attr_extras 3.1.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 52ef09869d3ebdb635964d77234b8bf806b85370
-  data.tar.gz: 3ae234b7c52e1e766cb1399d44c09f5cfc7ee82a
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZWFjODUyMWM5ZDQwYTllYzlkYWU4YjkwNzBkOWQ1YjY0NTE5MWY0ZQ==
+  data.tar.gz: !binary |-
+    NzI4N2YyZjcwN2ZkZDIzMmIyN2I2NmI3NDJjMGNlZTQyNjZkOGNmYw==
 SHA512:
-  metadata.gz: 926fdc5d339f40c481cfec0fbb0a20bb7c11ffcc3fe4206fde1c25e3d6183834e04c4bec247c3c89672f22f6d48a0adb1454c93a98b734b17029503c9fffdb98
-  data.tar.gz: d6040789a8f309c42a5fa15f46c7168ca0a65975d4a15989bd2b0ad723c8d0de9636b7101ca05e510dd869d9a94855c5e3740a2bee72d4e055fe33679a066eba
+  metadata.gz: !binary |-
+    NTUxMDVlN2I2NzI4NzY4MjBkMGM4OWQ0OGM5M2NjNGRkYzdiNzRiOWNiYzQ5
+    YTEyZTFhMjkxNjg3YTU2ZWJkMTgxNjU0OTU5NjcxNzY2YjYzODA0NTNlZmY4
+    MzYxZTc2ZTE5YzdiMjg1OTEzMmE1ODNmYzJjYmQ5OTkxMzZiODI=
+  data.tar.gz: !binary |-
+    YmRlYTAwYWQzMmJiODA2ZTk5YzEyMDVkNGVmY2JiODI5MGUxYTAxNWQzNDIx
+    MjAyZWM3OTUwOWMzN2Y0NDkxZjhkOGYwYmM0ZmNjM2JhMTg0MDQ1ZGM3NGQw
+    ZmE2YzM1MGE2ODU2YTExZGZmNGM5NmZhYzI3YzgwMTFjODNjMzQ=

data/lib/attr_extras.rb

@@ -66,17 +66,23 @@ module AttrExtras
       arg_names = names.last.is_a?(Array) ? names.pop : []
       arity = arg_names.length
 
-      names.each do |name|
-        define_method(name) do |*args|
-          provided_arity = args.length
-
-          if provided_arity != arity
-            raise ArgumentError, "wrong number of arguments (#{provided_arity} for #{arity})"
+      mod = Module.new do
+        define_method :method_missing do |name, *args|
+          if names.include?(name)
+            provided_arity = args.length
+
+            if provided_arity != arity
+              raise ArgumentError, "wrong number of arguments (#{provided_arity} for #{arity})"
+            end
+
+            raise "Implement a '#{name}(#{arg_names.join(", ")})' method"
+          else
+            super(name, *args)
           end
-
-          raise "Implement a '#{name}(#{arg_names.join(", ")})' method"
         end
       end
+
+      include mod
     end
   end
 end

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "3.1.0"
+  VERSION = "3.2.0"
 end

data/spec/attr_implement_spec.rb

@@ -23,4 +23,34 @@ describe Object, ".attr_implement" do
 
     lambda { example.foo }.must_raise ArgumentError
   end
+
+  it "does not raise if method is implemented in a subclass" do
+    klass = Class.new do
+      attr_implement :foo
+    end
+
+    subklass = Class.new(klass) do
+      def foo
+        "bar"
+      end
+    end
+
+    subklass.new.foo.must_equal "bar"
+  end
+
+  # E.g. Active Record defines column query methods like "admin?"
+  # higher up in the ancestor chain.
+  it "does not raise if method is implemented in a superclass" do
+    superklass = Class.new do
+      def foo
+        "bar"
+      end
+    end
+
+    klass = Class.new(superklass) do
+      attr_implement :foo
+    end
+
+    klass.new.foo.must_equal "bar"
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Henrik Nyh
@@ -10,20 +10,20 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-12 00:00:00.000000000 Z
+date: 2015-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -33,9 +33,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rvmrc"
-- ".travis.yml"
+- .gitignore
+- .rvmrc
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
@@ -67,12 +67,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []