attr_extras 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0749835eb5235d2f2171a3da61eb87953d574cb9
-  data.tar.gz: f52712ce7b9e9d15f0e0e1efe9208b13ce5931ab
+  metadata.gz: 17e3dfb363304609f6981fe839b36c318f9726ea
+  data.tar.gz: d32ee310679a5135dd5433e288b561451418a88f
 SHA512:
-  metadata.gz: 4bccfdba5b88e7944b199dcf07d214b33b082f22c1128df429cb8fd80f274fab86e21024ec43a4be7154391f95ca078584994ed29828fe8018d8ab9454be3dbd
-  data.tar.gz: 71b0501a29618a80d824ab1eb69b07753eb3f4ff324d103b2c35c02190172e2465bbee5810707193ab1cd2b503937fb1032fcdc455bb9e08a6f6ff982357e5a1
+  metadata.gz: c24ba0b62181e236814657c9e06fdff80263696d77f3d824b62eeec038e20b7ff0cd4979783d16aec71c884fd2f7711429c7983e3cdc7321b301c52e8f33e958
+  data.tar.gz: 7846ad4e0bd1808dccdec81857477a8e7372cf56378e6e1e95659fe4a19339ba2c4759f713fa18577aa4705b4a939fd165bf26cc83f3e122e4fe532b37c8b0c4

data/README.md

@@ -47,7 +47,7 @@ Defines both initializer and private readers.
 Defines both initializer and public readers.
 
 `method_object :fooable?, :foo`<br>
-Defines a `.fooable?` class method that delegates to an instance method.
+Defines a `.fooable?` class method that takes one argument (`:foo`) and delegates to an instance method that can access `foo` as a private reader.
 
 `attr_id_query :foo?, :bar?`<br>
 Defines query methods like `foo?`, which is true iff `foo_id` is truthy. Goes well with Active Record.
@@ -64,8 +64,7 @@ and the enforced questionmarks with `attr_id_query :foo?`, so you can search for
 
 ``` ruby
 class MyClass
-  attr_initialize :foo, :bar
-  attr_private :foo
+  pattr_initialize :foo, :bar
   attr_id_query :item?
   attr_query :oof?
 
@@ -84,6 +83,7 @@ x.foo    # NoMethodError: private method `foo' called.
 x.item?  # => true
 x.oof?   # => true
 
+
 class MyMethodObject
   method_object :fooable?,
     :foo
@@ -96,6 +96,7 @@ end
 MyMethodObject.fooable?(:some_value)     # => true
 MyMethodObject.fooable?(:another_value)  # => false
 
+
 class MyHashyObject
   attr_initialize :foo, [:bar, :baz]
   attr_reader :bar
@@ -104,14 +105,15 @@ end
 x = MyHashyObject.new("Foo!", bar: "Bar!", baz: "Baz!")
 x.bar  # => "Bar!"
 
+
 class MyValueObject
   attr_value :foo, :bar
 end
 
 x = MyValueObject.new(5, 10)
-x.foo # => 5
-x.bar # => 10
-x.foo = 20 # NoMethodError: undefined method `foo=''` 
+x.foo  # => 5
+x.bar  # => 10
+x.foo = 20  # NoMethodError: undefined method `foo=''`
 ```
 
 ## Why not use `Struct`?
@@ -125,7 +127,7 @@ Instead of `attr_private :foo`, you could do `private; attr_reader :foo`.
 
 Other than being more to type, declaring `attr_reader` after `private` will actually give you a warning (deserved or not) if you run Ruby with warnings turned on.
 
-If you don't want the dependency on `attr_extras`, you can get rid of the warnings with `attr_reader :foo; private :foo` or just define a regular private method.
+If you don't want the dependency on `attr_extras`, you can get rid of the warnings with `attr_reader :foo; private :foo`. Or just define a regular private method.
 
 
 ## Installation
@@ -142,6 +144,7 @@ Or install it yourself as:
 
     gem install attr_extras
 
+
 ## License
 
 Copyright (c) 2012 [Barsoom AB](http://barsoom.se)

data/lib/attr_extras.rb

@@ -44,14 +44,12 @@ module AttrExtras
 
     def pattr_initialize(*names)
       attr_initialize(*names)
-
-      flat_names = names.flatten.map { |x| x.to_s.sub(/!\z/, "") }
-      attr_private(*flat_names)
+      attr_private *attr_flat_names(names)
     end
 
     def attr_value(*names)
       attr_initialize(*names)
-      attr_reader(*names.flatten)
+      attr_reader *attr_flat_names(names)
     end
 
     def method_object(method_name, *names)
@@ -72,6 +70,10 @@ module AttrExtras
 
     private
 
+    def attr_flat_names(names)
+      names.flatten.map { |x| x.to_s.sub(/!\z/, "") }
+    end
+
     def attr_query_with_suffix(*names, suffix)
       names.each do |name|
         name = name.to_s

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "1.8.0"
+  VERSION = "1.8.1"
 end

data/spec/attr_extras_spec.rb

@@ -123,11 +123,12 @@ describe Object, ".attr_value" do
 
   it "works with hash ivars" do
     klass = Class.new do
-      attr_value :foo, [:bar, :baz]
+      attr_value :foo, [:bar, :baz!]
     end
 
-    example = klass.new("Foo", :bar => "Bar")
+    example = klass.new("Foo", :bar => "Bar", :baz => "Baz")
     example.bar.must_equal "Bar"
+    example.baz.must_equal "Baz"
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - Henrik Nyh