attr_extras 1.6.2 → 1.6.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: bee10ccc02153b1f71b7aed58cba2ec72b82518a
+  data.tar.gz: 5f546c46cbca537eb24cf497b3cfc917cb902f81
+SHA512:
+  metadata.gz: e68b64c856a4e8a08f99f47d67afcdb3630ea8cf3765533bc76744c7629fc16ac0bbfeae13f37047ebe72c1ed528bcb2431f3c3b0ea9fc0b18185718e413ae8c
+  data.tar.gz: 5c0f5a1879bc6e61611f96d130b2c6f0774660ecd664b07952546fdba6602b5a713c162a791f14d0d4d80185d5b61d0f7b65240f30c8eeddf3f5fc2578e515d2

data/README.md

@@ -2,7 +2,34 @@
 
 # attr\_extras
 
-Takes some boilerplate out of Ruby and complements `attr_accessor`, `attr_reader` and `attr_writer` nicely by providing:
+Takes some boilerplate out of Ruby, lowering the barrier to extracting small focused classes, without the downsides of using `Struct`.
+
+Instead of
+
+```
+class InvoiceBuilder
+  def initialize(invoice, employee)
+    @invoice, @employee = invoice, employee
+  end
+
+  private
+
+  attr_reader :invoice, :employee
+end
+```
+
+you can just do
+
+```
+class InvoiceBuilder
+  pattr_initialize :invoice, :employee
+end
+```
+
+This nicely complements Ruby's built-in `attr_accessor`, `attr_reader` and `attr_writer`.
+
+
+## Usage
 
 `attr_initialize :foo, :bar`<br>
 Defines an initializer that takes two arguments and assigns `@foo` and `@bar`.

data/lib/attr_extras.rb

@@ -3,13 +3,21 @@ require "attr_extras/version"
 module AttrExtras
   module ClassMethods
     def attr_initialize(*names)
+      min_arity = names.count { |n| not n.is_a?(Array) }
+      max_arity = names.length
+
       define_method(:initialize) do |*values|
-        unless values.length == names.length
-          raise ArgumentError, "wrong number of arguments (#{values.length} for #{names.length})"
+        provided_arity = values.length
+
+        unless (min_arity..max_arity).include?(provided_arity)
+          arity_range = [min_arity, max_arity].uniq.join("..")
+          raise ArgumentError, "wrong number of arguments (#{provided_arity} for #{arity_range})"
         end
 
         names.zip(values).each do |name_or_names, value|
           if name_or_names.is_a?(Array)
+            value ||= {}
+
             name_or_names.each do |key|
               instance_variable_set("@#{key}", value[key])
             end

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "1.6.2"
+  VERSION = "1.6.3"
 end

data/spec/attr_extras_spec.rb

@@ -2,63 +2,76 @@ require "minitest/autorun"
 require "minitest/pride"
 require "attr_extras"
 
-class Example
-  attr_initialize :foo, :bar
-  attr_private :foo, :bar
-end
-
-class PattrExample
-  pattr_initialize :foo, :bar
-end
-
-class QueryExample
-  attr_id_query :baz?, :boink?
-  attr_query :flurp?
-  attr_accessor :baz_id, :flurp
-end
-
-class MethodObjectExample
-  method_object :fooable?,
-    :foo
-
-  def fooable?
-    foo
+describe Object, ".method_object" do
+  let(:klass) do
+    Class.new do
+      method_object :fooable?,
+        :foo
+
+      def fooable?
+        foo
+      end
+    end
   end
-end
-
-class ExampleWithHash
-  pattr_initialize :foo, [:bar, :baz]
-end
 
-describe Object, ".method_object" do
   it "creates a class method that instantiates and runs that instance method" do
-    assert MethodObjectExample.fooable?(true)
-    refute MethodObjectExample.fooable?(false)
+    assert klass.fooable?(true)
+    refute klass.fooable?(false)
   end
 end
 
 describe Object, ".attr_initialize" do
+  let(:klass) do
+    Class.new do
+      attr_initialize :foo, :bar
+    end
+  end
+
   it "creates an initializer setting those instance variables" do
-    example = Example.new("Foo", "Bar")
+    example = klass.new("Foo", "Bar")
     example.instance_variable_get("@foo").must_equal "Foo"
     example.instance_variable_get("@bar").must_equal "Bar"
   end
 
   it "requires all arguments" do
-    lambda { Example.new("Foo") }.must_raise ArgumentError
+    lambda { klass.new("Foo") }.must_raise ArgumentError
   end
 
   it "can set ivars from a hash" do
-    example = ExampleWithHash.new("Foo", :bar => "Bar", :baz => "Baz")
+    klass = Class.new do
+      pattr_initialize :foo, [:bar, :baz]
+    end
+
+    example = klass.new("Foo", :bar => "Bar", :baz => "Baz")
     example.instance_variable_get("@foo").must_equal "Foo"
     example.instance_variable_get("@bar").must_equal "Bar"
     example.instance_variable_get("@baz").must_equal "Baz"
   end
+
+  it "treats hash values as optional" do
+    klass = Class.new do
+      pattr_initialize :foo, [:bar, :baz]
+    end
+
+    example = klass.new("Foo", :bar => "Bar")
+    example.instance_variable_get("@baz").must_equal nil
+
+    example = klass.new("Foo")
+    example.instance_variable_get("@bar").must_equal nil
+  end
 end
 
 describe Object, ".attr_private" do
+  let(:klass) do
+    Class.new do
+      attr_private :foo, :bar
+    end
+  end
+
   it "creates private readers" do
-    example = Example.new("Foo", "Bar")
+    example = klass.new
+    example.instance_variable_set("@foo", "Foo")
+    example.instance_variable_set("@bar", "Bar")
     example.send(:foo).must_equal "Foo"
     example.send(:bar).must_equal "Bar"
     lambda { example.foo }.must_raise NoMethodError
@@ -67,20 +80,34 @@ end
 
 describe Object, ".pattr_initialize" do
   it "creates both initializer and private readers" do
-    example = PattrExample.new("Foo", "Bar")
+    klass = Class.new do
+      pattr_initialize :foo, :bar
+    end
+
+    example = klass.new("Foo", "Bar")
     example.send(:foo).must_equal "Foo"
   end
 
   it "works with hash ivars" do
-    example = ExampleWithHash.new("Foo", :bar => "Bar")
+    klass = Class.new do
+      pattr_initialize :foo, [:bar, :baz]
+    end
+
+    example = klass.new("Foo", :bar => "Bar")
     example.send(:bar).must_equal "Bar"
   end
 end
 
 describe Object, ".attr_id_query" do
   it "creates id query methods" do
-    example = QueryExample.new
+    klass = Class.new do
+      attr_id_query :baz?, :boink?
+      attr_accessor :baz_id
+    end
+
+    example = klass.new
     refute example.baz?
+
     example.baz_id = 123
     assert example.baz?
   end
@@ -92,7 +119,12 @@ end
 
 describe Object, ".attr_query" do
   it "creates attribute query methods" do
-    example = QueryExample.new
+    klass = Class.new do
+      attr_query :flurp?
+      attr_accessor :flurp
+    end
+
+    example = klass.new
     refute example.flurp?
     example.flurp = "!"
     assert example.flurp?

metadata

@@ -1,27 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 1.6.2
-  prerelease: 
+  version: 1.6.3
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-30 00:00:00.000000000 Z
+date: 2014-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70165595375620 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70165595375620
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - henrik@nyh.se
@@ -42,33 +44,26 @@ files:
 homepage: https://github.com/barsoom/attr_extras
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4094106113878864252
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4094106113878864252
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 2.2.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Takes some boilerplate out of Ruby with methods like attr_initialize.
 test_files:
 - spec/attr_extras_spec.rb