attr_digest 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 194a36a3b7b75ec263c866870a33131d3ec4bd8e
-  data.tar.gz: b66ea6b6df414d50b3e41f1be2e5c96727c55a9d
+  metadata.gz: 63cdafa1a0c9fb93a2faf186e6cfc34a9cbb3a82
+  data.tar.gz: 92768dd263b1ef29f66b6634a79373164ed43534
 SHA512:
-  metadata.gz: 79332b159616c23e1d8e189a5d1b32585ca24b92fabb1fa5da3101bafbd5624966b096d3bd1027caf73d86ca0b103e87bc5e03e56c60a4197b3cc9bd9947f06d
-  data.tar.gz: a37ceccfbe10c4eba2ca5df9d54dc451d0e2837dd0d333bda11b53946a5aba4cee6a3ba27d89a82a09afadb5e8fcfa47f8bd92c86d9fbbe0352b9f35e2c4b235
+  metadata.gz: c9135190b059ebddd9bae632614f5c787675d0cb627679b081e25f387d99bbed91217606e280ad1a9863898fb249ce831085dd2fcc1d03487a6a9b7d0332c7f7
+  data.tar.gz: ce9daa1a773fc71b8c2a9741aa91cece52490e15ee7be7bf5edc5e026c48d44e452f6a127b8007fb6acf8dc686b9a9ba21ce7abb00566d1ee39b3c4cdb9d3ee3

data/CHANGELOG.md

@@ -1,8 +1,10 @@
-#Change Log
+# Change Log
+
+##v1.2.0
+- Updated ActiveSupport and ActiveRecord between 4.2.6 and v5.0.0.
 
 ##v1.1.0
 - Updated Argon2 dependency to v1.1.0.
-- Updated README.md to reflect dependency changes and compatibility.
 
 ##v1.0.0
 - Initial release.

data/README.md

@@ -19,7 +19,7 @@ This Gem uses the [Ruby Argon2 Gem](https://github.com/technion/ruby-argon2) whi
 To install add the following line to your `Gemfile`:
 
 ``` ruby
-gem 'attr_digest', '~> 1.1.0'
+gem 'attr_digest',
 ```
 
 And run `bundle install`.
@@ -27,8 +27,8 @@ And run `bundle install`.
 ## Dependencies
 
 Runtime:
-- activerecord (~> 4.2.2)
-- activesupport (~> 4.2.2)
+- activerecord (>= 4.2.6, ~> 5.0.0)
+- activesupport (>= 4.2.6, ~> 5.0.0)
 - argon2 (~> 1.1.0)
 
 Development/Test:
@@ -40,7 +40,7 @@ Development/Test:
 
 ## Compatibility
 
-Tested with Ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin15] against ActiveRecord 4.2.6 on Mac OS X El Capitan 10.11.4 (15E65).
+Tested with Ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15] against ActiveRecord 5.0.0 on Mac OS X El Capitan 10.11.5 (15F34).
 
 Argon2 requires Ruby 2.2 minimum and an OS platform that supports Ruby FFI Bindings, so unfortunately Windows is out.
 

data/lib/attr_digest/attr_digest.rb

@@ -66,7 +66,6 @@ module AttrDigest
     protected :protect_setter
     protected :define_authenticate_method
   end
-
 end
 
 ActiveRecord::Base.send :include, AttrDigest

data/lib/attr_digest/version.rb

@@ -1,14 +1,11 @@
 module AttrDigest
   module VERSION
     MAJOR = 1
-    MINOR = 1
+    MINOR = 2
     TINY  = 0
     PRE   = nil
-
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
-
     SUMMARY = "AttrDigest v#{STRING}"
-
     DESCRIPTION = "Provides functionality to store a hash digest of an attribute using Argon2"
   end
 end

metadata

@@ -1,43 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: attr_digest
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Jurgen Jocubeit
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-05 00:00:00.000000000 Z
+date: 2016-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.6
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.2
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.6
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.2
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.6
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.2
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.6
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.2
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: argon2
   requirement: !ruby/object:Gem::Requirement
@@ -135,12 +147,6 @@ files:
 - lib/attr_digest.rb
 - lib/attr_digest/attr_digest.rb
 - lib/attr_digest/version.rb
-- spec/factories/models.rb
-- spec/lib/attr_digest_spec.rb
-- spec/spec_helper.rb
-- spec/support/models.rb
-- spec/support/schema.rb
-- spec/tmp/test.sqlite3
 homepage: https://github.com/brightcommerce/attr_digest
 licenses:
 - MIT
@@ -162,9 +168,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: AttrDigest v1.1.0
+summary: AttrDigest v1.2.0
 test_files: []
-has_rdoc: 

data/spec/factories/models.rb

@@ -1,46 +0,0 @@
-FactoryGirl.define do
-  
-  factory :model_with_attr_digest do
-    username 'username'
-    password 'password'
-    password_confirmation 'password'
-    security_question 'question'
-    security_answer 'answer'
-    security_answer_confirmation 'answer'
-  end
-
-  factory :model_with_attr_digest_and_validations_option do
-    username 'username_no_validation'
-    password 'password'
-    password_confirmation 'password'
-    security_question 'question'
-    security_answer 'answer'
-  end
-
-  factory :model_with_attr_digest_and_protected_option do
-    username 'username_protect'
-    password 'password'
-    password_confirmation 'password'
-    security_question 'question'
-    security_answer 'answer'
-    security_answer_confirmation 'answer'
-  end
-
-  factory :model_with_attr_digest_and_case_sensitive_option do
-    username 'username_protect'
-    password 'password'
-    password_confirmation 'password'
-    security_question 'question'
-    security_answer 'answer'
-    security_answer_confirmation 'answer'
-  end
-
-  factory :model_with_attr_digest_and_confirmation_option do
-    username 'username_protect'
-    password 'password'
-    password_confirmation 'password'
-    security_question 'question'
-    security_answer 'answer'
-  end
-  
-end

data/spec/lib/attr_digest_spec.rb

@@ -1,209 +0,0 @@
-require 'spec_helper'
-
-describe ModelWithAttrDigest do
-  it 'responds to :security_answer' do
-    respond_to(:security_answer)
-  end
-  
-  it 'responds to :security_answer=' do
-    respond_to(:security_answer=)
-  end
-  
-  it 'responds to :security_answer_confirmation' do
-    respond_to(:security_answer_confirmation)
-  end
-  
-  it 'responds to :security_answer_confirmation=' do
-    respond_to(:security_answer_confirmation=)
-  end
-  
-  it 'responds to :authenticate_security_answer' do
-    respond_to(:authenticate_security_answer)
-  end
-
-  it 'confirms :security_answer' do
-    subject.security_answer = 'hello there'
-    subject.security_answer_confirmation = 'there hello'
-    subject.valid?
-    expect(subject.errors[:security_answer_confirmation]).to include("doesn't match Security answer")
-  end
-    
-  it 'does not confirm :security_answer if not given' do
-    subject.security_answer = nil
-    subject.security_answer_confirmation = 'there hello'
-    subject.valid?
-    expect(subject.errors[:security_answer_confirmation]).to be_blank
-  end
-
-  it 'requires :security_answer on create' do
-    expect(subject).to be_new_record
-    subject.security_answer = nil
-    subject.valid?
-    expect(subject.errors[:security_answer]).to include("can't be blank")
-  end
-  
-  it 'requires :security_answer_confirmation if :security_answer given' do
-    subject.security_answer = 'hello there'
-    subject.valid?
-    expect(subject.errors[:security_answer_confirmation]).to include("can't be blank")
-  end
-  
-  it 'does not require :security_answer_confirmation if :security_answer is not given' do
-    subject.security_answer = ''
-    subject.valid?
-    expect(subject.errors[:security_answer_confirmation]).to be_blank
-  end
-  
-  it 'requires :security_answer_digest on create' do
-    subject = FactoryGirl.build(:model_with_attr_digest)
-    expect(subject).to be_new_record
-    # change the security_answer_digest to verify the test
-    subject.security_answer_digest = ''
-    expect(lambda do
-      begin
-        subject.save!
-      rescue Exception => exception
-        expect(exception.message).to include("security_answer_digest missing on new record")
-        raise
-      end
-    end).to raise_error(RuntimeError)
-  end
-  
-  it 'does not require :security_answer_digest on update' do
-    subject = FactoryGirl.build(:model_with_attr_digest)
-    expect(subject).to be_new_record
-    subject.save!
-    # change the security_answer_digest to verify the test
-    subject.security_answer_digest = ''
-    subject.save!
-    subject.reload
-    expect(subject.security_answer_digest).to be_blank
-  end
-  
-  it 'allows to call :security_answer_digest directly if :protect_setter_for_digest is not given as option' do
-    lambda do
-      subject.security_answer_digest = 'hello'
-      expect(subject.security_answer_digest).to eq('hello')
-    end
-  end
-  
-  describe "#security_answer=" do
-    it 'sets the :security_answer and saves the digest' do
-      model = FactoryGirl.create(:model_with_attr_digest, security_answer: 'old answer', security_answer_confirmation: 'old answer')
-      expect(model.security_answer_digest).to_not be_blank
-      old_security_answer_digest = model.security_answer_digest
-      model.security_answer = 'new answer'
-      model.security_answer_confirmation = 'new answer'
-      expect(model.instance_variable_get(:@security_answer)).to eq('new answer')
-      model.save!
-      expect(model.security_answer_digest).to_not be_blank
-      expect(model.security_answer_digest).to_not eq(old_security_answer_digest)
-    end
-  end
-  
-  describe '#authenticate_security_answer' do
-    it 'returns true if :security_answer given matches the one stored' do
-      model = FactoryGirl.create(:model_with_attr_digest, security_answer: 'some answer', security_answer_confirmation: 'some answer')
-      expect(model.authenticate_security_answer('some answer')).to be(true)
-    end
-
-    it 'returns false if :security_answer given does not match the one stored' do
-      model = FactoryGirl.create(:model_with_attr_digest, security_answer: 'some answer', security_answer_confirmation: 'some answer')
-      expect(model.authenticate_security_answer('some other answer')).to be(false)
-    end
-  end
-
-end
-
-describe ModelWithAttrDigestAndValidationsOption do
-  it 'responds to :security_answer' do
-    respond_to(:security_answer)
-  end
-  
-  it 'responds to :security_answer=' do
-    respond_to(:security_answer=)
-  end
-  
-  it 'responds to :security_answer_confirmation' do
-    respond_to(:security_answer_confirmation)
-  end
-  
-  it 'responds to :security_answer_confirmation=' do
-    respond_to(:security_answer_confirmation=)
-  end
-  
-  it 'responds to :authenticate_security_answer' do
-    respond_to(:authenticate_security_answer)
-  end
-
-  it 'does not require :security_answer on create' do
-    expect(subject).to be_new_record
-    subject.security_answer = nil
-    subject.valid?
-    expect(subject.errors[:security_answer]).to be_blank
-  end
-
-  it 'does not require :security_answer_confirmation if :security_answer given' do
-    subject.security_answer = 'hello there'
-    subject.valid?
-    expect(subject.errors[:security_answer_confirmation]).to be_blank
-  end
-
-  it 'does not require :security_answer_confirmation if :security_answer is not given' do
-    subject.security_answer = ''
-    subject.valid?
-    expect(subject.errors[:security_answer_confirmation]).to be_blank
-  end
-
-  it 'does not require :security_answer_digest on create' do
-    subject = FactoryGirl.build(:model_with_attr_digest_and_validations_option)
-    expect(subject).to be_new_record
-    # change the security_answer_digest to verify the test
-    subject.security_answer_digest = ''
-    subject.save!
-  end
-
-  it 'does not require :security_answer_digest on update' do
-    subject = FactoryGirl.build(:model_with_attr_digest_and_validations_option)
-    expect(subject).to be_new_record
-    subject.save!
-    # change the :security_answer_digest to verify the test
-    subject.send(:security_answer_digest=, '')
-    subject.save!
-    subject.reload
-    expect(subject.security_answer_digest).to be_blank
-  end
-end
-
-describe ModelWithAttrDigestAndProtectedOption do
-  it 'does not allow to call to protected setter for :security_answer_digest' do
-    model = FactoryGirl.create(:model_with_attr_digest_and_protected_option, security_answer: 'Answer', security_answer_confirmation: 'Answer')
-    expect(lambda do
-      model.security_answer_digest = 'hello'
-    end).to raise_error(NoMethodError)
-  end
-end
-
-describe ModelWithAttrDigestAndCaseSensitiveOption do
-  it 'authenticates even if :security_answer is of different case' do
-    model = FactoryGirl.create(:model_with_attr_digest_and_case_sensitive_option, security_answer: 'Answer', security_answer_confirmation: 'Answer')
-    expect(model.authenticate_security_answer('answer')).to eq(true)
-  end
-end
-
-describe ModelWithAttrDigestAndConfirmationOption do
-  it 'does not respond to :security_answer_confirmation' do
-    respond_to(:security_answer_confirmation) == false
-  end
-  
-  it 'does not respond to :security_answer_confirmation=' do
-    respond_to(:security_answer_confirmation=) == false
-  end
-  
-  it 'allows to create and save without any confirmation on :security_answer' do
-    model = FactoryGirl.create(:model_with_attr_digest_and_confirmation_option, security_answer: 'Answer')
-    model.save!
-    expect(model.authenticate_security_answer('another answer')).to be(false)
-    expect(model.authenticate_security_answer('Answer')).to be(true)
-  end
-end

data/spec/spec_helper.rb

@@ -1,34 +0,0 @@
-begin
-  require 'simplecov'
-  SimpleCov.start
-  if ENV['CI']=='true'
-    require 'codecov'
-    SimpleCov.formatter = SimpleCov::Formatter::Codecov
-  end
-rescue LoadError
-end
-
-require 'active_record'
-
-ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: File.dirname(__FILE__) + "/tmp/test.sqlite3")
-
-puts "Using ActiveRecord #{ActiveRecord::VERSION::STRING}"
-
-load File.dirname(__FILE__) + '/support/schema.rb'
-
-require File.dirname(__FILE__) + '/../lib/attr_digest.rb'
-
-require 'support/models'
-
-require 'factory_girl'
-FactoryGirl.find_definitions
-
-require "rspec/expectations"
-
-RSpec.configure do |config|
-  config.before(:each) do
-    ModelWithAttrDigest.delete_all
-  end
-
-  config.order = 'random'
-end

data/spec/support/models.rb

@@ -1,47 +0,0 @@
-class ModelWithAttrDigest < ActiveRecord::Base
-  attr_digest :password
-  attr_digest :security_answer
-
-  validates :username, presence: true, uniqueness: { case_sensitive: false }
-  validates :security_question, presence: true
-end
-
-class ModelWithAttrDigestAndCaseSensitiveOption < ActiveRecord::Base
-  self.table_name = "model_with_attr_digests"
-  
-  attr_digest :password
-  attr_digest :security_answer, case_sensitive: false
-
-  validates :username, presence: true, uniqueness: { case_sensitive: false }
-  validates :security_question, presence: true
-end
-
-class ModelWithAttrDigestAndProtectedOption < ActiveRecord::Base
-  self.table_name = "model_with_attr_digests"
-  
-  attr_digest :password
-  attr_digest :security_answer, protected: true
-
-  validates :username, presence: true, uniqueness: { case_sensitive: false }
-  validates :security_question, presence: true
-end
-
-class ModelWithAttrDigestAndValidationsOption < ActiveRecord::Base
-  self.table_name = "model_with_attr_digests"
-  
-  attr_digest :password
-  attr_digest :security_answer, validations: false
-
-  validates :username, presence: true, uniqueness: { case_sensitive: false }
-  validates :security_question, presence: true
-end
-
-class ModelWithAttrDigestAndConfirmationOption < ActiveRecord::Base
-  self.table_name = "model_with_attr_digests"
-  
-  attr_digest :password
-  attr_digest :security_answer, confirmation: false
-
-  validates :username, presence: true, uniqueness: { case_sensitive: false }
-  validates :security_question, presence: true
-end

data/spec/support/schema.rb

@@ -1,17 +0,0 @@
-ActiveRecord::Schema.define do
-  
-  self.verbose = false
-
-  create_table :model_with_attr_digests, force: true do |t|
-    t.string :username,               null: false
-    t.string :password_digest,        null: false
-    t.string :security_question,      null: false
-    t.string :security_answer_digest, null: false
-    t.timestamps
-  end
-  
-  change_table :model_with_attr_digests do |t|
-    t.index :username, unique: true
-  end
-  
-end