attio-ruby 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '033186202207414f4872ff4843ee0f4983fbe4fb13cd413654f6240346349cde'
-  data.tar.gz: b5182d4744107a37af2e3326f017ecdbe9865b54323f9c0ca9168d3c2baf171e
+  metadata.gz: 55a5174c89fcc718a7152c4ab1027c5dd82766d6c35620e7dc3c8acc58b3f983
+  data.tar.gz: 205f0e84a49ba3e7f22d3a9d99a42586d6469977c84aea3163e16e9f80b7cd33
 SHA512:
-  metadata.gz: ecad0920b62fdd402335d459ab64b9a8ee2f5afcc881680760ba96d01a4abe515afd0981f6d79792e32f20d5deab90a5e092c1f51e19abe8fc497ecb60626557
-  data.tar.gz: b54ad915227b50620c70920d633358f829619949e8436487c7769a0bad137cf2529d52fe5c4803ffadd25abf34cb3ad11111baec7237ff7235a973d253aa556b
+  metadata.gz: ce8cb37b9adb959502703ff0e0bf04b96f757457494e9563f69dce4b6b104e534eaff0fc4badbf176fd4e5aa181dac867617261cf94a3e9cd5c66a7c64aa2052
+  data.tar.gz: 7318b994c5ba70fa0f57af7d2555711d6262c0a0fdec8aeef972ba77b79b7d4717a0c2ccaea6743bef1ee588f6412e40536a8ef4b7806e34dc26d5cb94c6b524

data/.rubocop.yml

@@ -84,7 +84,7 @@ Style/Documentation:
 
 # RSpec Configuration
 RSpec/ExampleLength:
-  Max: 30
+  Max: 45  # API mocking tests require comprehensive setup
   Exclude:
     - 'spec/integration/**/*'
 

data/CHANGELOG.md

@@ -5,6 +5,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.5] - 2025-08-11
+
+### Fixed
+- **Code Quality**: Comprehensive RuboCop compliance fixes
+  - Replaced all instance variables with `let` helpers in specs
+  - Fixed nested describe/context blocks exceeding depth limits
+  - Changed `before(:all)` to `before` to avoid state leakage
+  - Used proper RSpec matchers (`all` instead of iteration)
+  - Fixed context wording to follow RSpec conventions
+  - Used `described_class` instead of explicit class names
+  - Refactored long test examples for better readability
+  - Fixed indentation and formatting issues throughout
+
 ## [0.1.4] - 2025-08-08
 
 ### Added

data/examples/deals.rb

@@ -69,7 +69,7 @@ puts "Is lost? #{deal.lost?}"
 puts "\n=== Deal Pipeline Analysis ==="
 
 # List all deals and analyze by stage
-all_deals = Attio::Deal.list(params: { limit: 50 })
+all_deals = Attio::Deal.list(params: {limit: 50})
 stage_counts = Hash.new(0)
 
 all_deals.each do |d|
@@ -109,4 +109,4 @@ puts "\n=== Cleanup ==="
   puts "Deleted deal: #{d.name}"
 end
 
-puts "\nDone!"
+puts "\nDone!"

data/lib/attio/concerns/time_filterable.rb

@@ -24,7 +24,7 @@ module Attio
             else
               record[date_field]
             end
-            
+
             if date_value
               parsed_date = date_value.is_a?(String) ? Time.parse(date_value) : date_value
               period.includes?(parsed_date)
@@ -33,39 +33,39 @@ module Attio
             end
           end
         end
-        
+
         # Get records created in the last N days
         # @param days [Integer] Number of days to look back
         # @return [Array] Recently created records
         def recently_created(days = 7, **opts)
           in_period(Util::TimePeriod.last_days(days), date_field: :created_at, **opts)
         end
-        
+
         # Get records updated in the last N days
         # @param days [Integer] Number of days to look back
         # @return [Array] Recently updated records
         def recently_updated(days = 7, **opts)
           in_period(Util::TimePeriod.last_days(days), date_field: :updated_at, **opts)
         end
-        
+
         # Get records created this year
         # @return [Array] Records created in current year
         def created_this_year(**opts)
           in_period(Util::TimePeriod.current_year, date_field: :created_at, **opts)
         end
-        
+
         # Get records created this month
         # @return [Array] Records created in current month
         def created_this_month(**opts)
           in_period(Util::TimePeriod.current_month, date_field: :created_at, **opts)
         end
-        
+
         # Get records created year to date
         # @return [Array] Records created YTD
         def created_year_to_date(**opts)
           in_period(Util::TimePeriod.year_to_date, date_field: :created_at, **opts)
         end
-        
+
         # Get records created in a specific month
         # @param year [Integer] The year
         # @param month [Integer] The month (1-12)
@@ -73,7 +73,7 @@ module Attio
         def created_in_month(year, month, **opts)
           in_period(Util::TimePeriod.month(year, month), date_field: :created_at, **opts)
         end
-        
+
         # Get records created in a specific quarter
         # @param year [Integer] The year
         # @param quarter [Integer] The quarter (1-4)
@@ -81,21 +81,21 @@ module Attio
         def created_in_quarter(year, quarter, **opts)
           in_period(Util::TimePeriod.quarter(year, quarter), date_field: :created_at, **opts)
         end
-        
+
         # Get records created in a specific year
         # @param year [Integer] The year
         # @return [Array] Records created in that year
         def created_in_year(year, **opts)
           in_period(Util::TimePeriod.year(year), date_field: :created_at, **opts)
         end
-        
+
         # Get activity metrics for a period
         # @param period [Util::TimePeriod] The time period
         # @return [Hash] Metrics about records in the period
         def activity_metrics(period, **opts)
           created = in_period(period, date_field: :created_at, **opts)
           updated = in_period(period, date_field: :updated_at, **opts)
-          
+
           {
             period: period.label,
             created_count: created.size,
@@ -104,9 +104,9 @@ module Attio
           }
         end
       end
-      
+
       # Instance methods for time-based checks
-      
+
       # Check if this record was created in a specific period
       # @param period [Util::TimePeriod] The time period
       # @return [Boolean] True if created in the period
@@ -115,7 +115,7 @@ module Attio
         date = created_at.is_a?(String) ? Time.parse(created_at) : created_at
         period.includes?(date)
       end
-      
+
       # Check if this record was updated in a specific period
       # @param period [Util::TimePeriod] The time period
       # @return [Boolean] True if updated in the period
@@ -124,7 +124,7 @@ module Attio
         date = updated_at.is_a?(String) ? Time.parse(updated_at) : updated_at
         period.includes?(date)
       end
-      
+
       # Get the age of the record in days
       # @return [Integer] Days since creation
       def age_in_days
@@ -132,7 +132,7 @@ module Attio
         created = created_at.is_a?(String) ? Time.parse(created_at) : created_at
         ((Time.now - created) / (24 * 60 * 60)).round
       end
-      
+
       # Check if record is new (created recently)
       # @param days [Integer] Number of days to consider "new"
       # @return [Boolean] True if created within specified days
@@ -140,7 +140,7 @@ module Attio
         age = age_in_days
         age && age <= days
       end
-      
+
       # Check if record is old
       # @param days [Integer] Number of days to consider "old"
       # @return [Boolean] True if created more than specified days ago
@@ -150,4 +150,4 @@ module Attio
       end
     end
   end
-end
+end

data/lib/attio/internal/record.rb

@@ -341,7 +341,7 @@ module Attio
           if value_data.key?(:value) || value_data.key?("value")
             value_data[:value] || value_data["value"]
           elsif value_data.key?(:target_object) || value_data.key?("target_object") ||
-                value_data.key?(:referenced_actor_type) || value_data.key?("referenced_actor_type")
+              value_data.key?(:referenced_actor_type) || value_data.key?("referenced_actor_type")
             # Reference value - return the full reference object
             value_data
           elsif value_data.key?(:currency_value) || value_data.key?("currency_value")

data/lib/attio/resources/company.rb

@@ -176,7 +176,6 @@ module Attio
         super(values: values, **opts)
       end
 
-
       # Find companies by employee count range
       # @param min [Integer] Minimum employee count
       # @param max [Integer] Maximum employee count (optional)
@@ -196,9 +195,9 @@ module Attio
 
         list(**opts.merge(params: {filter: filter}))
       end
-      
+
       private
-      
+
       # Build filter for domain field
       def filter_by_domain(value)
         # Strip protocol if present
@@ -211,7 +210,7 @@ module Attio
           }
         }
       end
-      
+
       # Build filter for name field
       def filter_by_name(value)
         {

data/lib/attio/resources/deal.rb

@@ -32,53 +32,52 @@ module Attio
       # @param attributes [Hash] Deal attributes
       # @option attributes [String] :name Deal name (recommended)
       # @option attributes [Numeric] :value Deal value (recommended)
-      # @option attributes [String] :stage Deal stage (recommended) - defaults: "Lead", "In Progress", "Won 🎉", "Lost"
+      # @option attributes [String] :stage Deal stage (recommended) - configurable via Attio.configuration
       # @option attributes [String] :status Deal status (alias for stage)
       # @option attributes [String] :owner Owner email or workspace member (recommended)
       # @option attributes [Array<String>] :associated_people Email addresses of associated people
       # @option attributes [Array<String>] :associated_company Domains of associated companies
       # @option attributes [Hash] :values Raw values hash (for advanced use)
       def create(name:, value: nil, stage: nil, status: nil, owner: nil,
-                 associated_people: nil, associated_company: nil, values: {}, **opts)
+        associated_people: nil, associated_company: nil, values: {}, **opts)
         # Name is required and simple
         values[:name] = name if name && !values[:name]
-        
+
         # Add optional fields
         values[:value] = value if value && !values[:value]
-        
+
         # Handle stage vs status - API uses "stage" but we support both
         if (stage || status) && !values[:stage]
           values[:stage] = stage || status
         end
-        
-        
+
         # Handle owner - can be email address or workspace member reference
         if owner && !values[:owner]
           values[:owner] = owner
         end
-        
+
         # Handle associated people - convert email array to proper format
         if associated_people && !values[:associated_people]
           values[:associated_people] = associated_people.map do |email|
             {
               target_object: "people",
               email_addresses: [
-                { email_address: email }
+                {email_address: email}
               ]
             }
           end
         end
-        
+
         # Handle associated company - convert domain array to proper format
         if associated_company && !values[:associated_company]
           # associated_company can be array of domains or single domain
           domains = associated_company.is_a?(Array) ? associated_company : [associated_company]
           values[:associated_company] = {
             target_object: "companies",
-            domains: domains.map { |domain| { domain: domain } }
+            domains: domains.map { |domain| {domain: domain} }
           }
         end
-        
+
         super(values: values, **opts)
       end
 
@@ -87,15 +86,15 @@ module Attio
       # @return [Attio::ListObject] List of matching deals
       def in_stage(stage_names:, **opts)
         # If only one stage, use simple equality
-        if stage_names.length == 1
-          filter = { stage: stage_names.first }
+        filter = if stage_names.length == 1
+          {stage: stage_names.first}
         else
           # Multiple stages need $or operator
-          filter = {
-            "$or": stage_names.map { |stage| { stage: stage } }
+          {
+            "$or": stage_names.map { |stage| {stage: stage} }
           }
         end
-        
+
         list(**opts.merge(params: {filter: filter}))
       end
 
@@ -126,7 +125,7 @@ module Attio
         filters = []
         filters << {value: {"$gte": min}} if min
         filters << {value: {"$lte": max}} if max
-        
+
         filter = if filters.length == 1
           filters.first
         elsif filters.length > 1
@@ -134,7 +133,7 @@ module Attio
         else
           {}
         end
-        
+
         list(**opts.merge(params: {filter: filter}))
       end
 
@@ -144,14 +143,15 @@ module Attio
       # def closing_soon(days: 30, **opts)
       #   today = Date.today
       #   end_date = today + days
-      #   
+      #
       #   list(**opts.merge(params: {
       #     filter: {
       #       "$and": [
       #         {close_date: {"$gte": today.iso8601}},
       #         {close_date: {"$lte": end_date.iso8601}},
-      #         {stage: {"$ne": "Won 🎉"}},
-      #         {stage: {"$ne": "Lost"}}
+      #         # Exclude won and lost statuses
+      #         {"$not": {stage: {"$in": Attio.configuration.won_statuses}}},
+      #         {"$not": {stage: {"$in": Attio.configuration.lost_statuses}}}
       #       ]
       #     }
       #   }))
@@ -170,7 +170,7 @@ module Attio
           }
         }))
       end
-      
+
       # Get deals that closed in a specific time period
       # @param period [Util::TimePeriod] The time period
       # @return [Array<Attio::Deal>] List of deals closed in the period
@@ -180,7 +180,7 @@ module Attio
           closed_date && period.includes?(closed_date)
         end
       end
-      
+
       # Get deals that closed in a specific quarter
       # @param year [Integer] The year
       # @param quarter [Integer] The quarter (1-4)
@@ -189,7 +189,7 @@ module Attio
         period = Util::TimePeriod.quarter(year, quarter)
         closed_in_period(period, **opts)
       end
-      
+
       # Get metrics for any time period
       # @param period [Util::TimePeriod] The time period
       # @return [Hash] Metrics for the period
@@ -205,29 +205,33 @@ module Attio
             }
           }
         }
-        
+
         # Fetch won deals closed in the period
+        won_statuses = ::Attio.configuration.won_statuses
+        won_conditions = won_statuses.map { |status| {"stage" => status} }
         won_filter = {
           "$and" => [
-            { "stage" => "Won 🎉" },
+            ((won_conditions.size > 1) ? {"$or" => won_conditions} : won_conditions.first),
             date_filter
-          ]
+          ].compact
         }
-        won_response = list(**opts.merge(params: { filter: won_filter }))
-        
+        won_response = list(**opts.merge(params: {filter: won_filter}))
+
         # Fetch lost deals closed in the period
+        lost_statuses = ::Attio.configuration.lost_statuses
+        lost_conditions = lost_statuses.map { |status| {"stage" => status} }
         lost_filter = {
           "$and" => [
-            { "stage" => "Lost" },
+            ((lost_conditions.size > 1) ? {"$or" => lost_conditions} : lost_conditions.first),
             date_filter
-          ]
+          ].compact
         }
-        lost_response = list(**opts.merge(params: { filter: lost_filter }))
-        
+        lost_response = list(**opts.merge(params: {filter: lost_filter}))
+
         won_deals = won_response.data
         lost_deals = lost_response.data
         total_closed = won_deals.size + lost_deals.size
-        
+
         {
           period: period.label,
           won_count: won_deals.size,
@@ -235,54 +239,54 @@ module Attio
           lost_count: lost_deals.size,
           lost_amount: lost_deals.sum(&:amount),
           total_closed: total_closed,
-          win_rate: total_closed > 0 ? (won_deals.size.to_f / total_closed * 100).round(2) : 0.0
+          win_rate: (total_closed > 0) ? (won_deals.size.to_f / total_closed * 100).round(2) : 0.0
         }
       end
-      
+
       # Get current quarter metrics
       # @return [Hash] Metrics for the current quarter
       def current_quarter_metrics(**opts)
         metrics_for_period(Util::TimePeriod.current_quarter, **opts)
       end
-      
+
       # Get year-to-date metrics
       # @return [Hash] Metrics for year to date
       def year_to_date_metrics(**opts)
         metrics_for_period(Util::TimePeriod.year_to_date, **opts)
       end
-      
+
       # Get month-to-date metrics
       # @return [Hash] Metrics for month to date
       def month_to_date_metrics(**opts)
         metrics_for_period(Util::TimePeriod.month_to_date, **opts)
       end
-      
+
       # Get last 30 days metrics
       # @return [Hash] Metrics for last 30 days
       def last_30_days_metrics(**opts)
         metrics_for_period(Util::TimePeriod.last_30_days, **opts)
       end
-      
+
       # Get high-value deals above a threshold
       # @param threshold [Numeric] The minimum value threshold (defaults to 50,000)
       # @return [Array<Attio::Deal>] List of high-value deals
       def high_value(threshold = 50_000, **opts)
         all(**opts).select { |deal| deal.amount > threshold }
       end
-      
+
       # Get deals without owners
       # @return [Array<Attio::Deal>] List of unassigned deals
       def unassigned(**opts)
         all(**opts).select { |deal| deal.owner.nil? }
       end
-      
+
       # Get recently created deals
       # @param days [Integer] Number of days to look back (defaults to 7)
       # @return [Array<Attio::Deal>] List of recently created deals
       def recently_created(days = 7, **opts)
         created_in_period(Util::TimePeriod.last_days(days), **opts)
       end
-      
+
       # Get deals created in a specific period
       # @param period [Util::TimePeriod] The time period
       # @return [Array<Attio::Deal>] List of deals created in the period
@@ -292,12 +296,12 @@ module Attio
           created_at && period.includes?(created_at)
         end
       end
-      
+
       private
-      
+
       # Build filter for status field (maps to stage)
       def filter_by_status(value)
-        { stage: value }
+        {stage: value}
       end
     end
 
@@ -313,20 +317,20 @@ module Attio
       return 0.0 unless self[:value].is_a?(Hash)
       (self[:value]["currency_value"] || 0).to_f
     end
-    
+
     # Get the currency code
     # @return [String] The currency code (defaults to "USD")
     def currency
       return "USD" unless self[:value].is_a?(Hash)
       self[:value]["currency_code"] || "USD"
     end
-    
+
     # Get formatted amount for display
     # @return [String] The formatted currency amount
     def formatted_amount
       Util::CurrencyFormatter.format(amount, currency)
     end
-    
+
     # Get the raw deal value (for backward compatibility)
     # @deprecated Use {#amount} for monetary values or {#raw_value} for raw API response
     # @return [Object] The raw value from the API
@@ -334,7 +338,7 @@ module Attio
       warn "[DEPRECATION] `value` is deprecated. Use `amount` for monetary values or `raw_value` for the raw API response." unless ENV["ATTIO_SUPPRESS_DEPRECATION"]
       amount
     end
-    
+
     # Get the raw value data from the API
     # @return [Object] The raw value data
     def raw_value
@@ -346,11 +350,11 @@ module Attio
     def stage
       stage_data = self[:stage]
       return nil unless stage_data.is_a?(Hash)
-      
+
       # Attio always returns stage as a hash with nested status.title
       stage_data.dig("status", "title")
     end
-    
+
     # Alias for stage (for compatibility)
     # @return [String, nil] The deal stage
     alias_method :status, :stage
@@ -385,7 +389,7 @@ module Attio
     def update_stage(new_stage, **opts)
       self.class.update(id, values: {stage: new_stage}, **opts)
     end
-    
+
     # Alias for update_stage (for compatibility)
     # @param new_status [String] The new status/stage
     # @return [Attio::Deal] The updated deal
@@ -411,7 +415,7 @@ module Attio
     # @return [Attio::Company, nil] The company record if associated
     def company_record(**opts)
       return nil unless company
-      
+
       company_id = company.is_a?(Hash) ? company["target_record_id"] : company
       Company.retrieve(company_id, **opts) if company_id
     end
@@ -420,7 +424,7 @@ module Attio
     # @return [Attio::WorkspaceMember, nil] The owner record if assigned
     def owner_record(**opts)
       return nil unless owner
-      
+
       owner_id = if owner.is_a?(Hash)
         owner["referenced_actor_id"] || owner["target_record_id"]
       else
@@ -446,7 +450,7 @@ module Attio
     # @return [Time, nil] The timestamp when status changed
     def status_changed_at
       return nil unless self[:stage].is_a?(Hash)
-      
+
       # Attio returns active_from at the top level of the stage hash
       timestamp = self[:stage]["active_from"]
       timestamp ? Time.parse(timestamp) : nil
@@ -456,7 +460,7 @@ module Attio
     # @return [Boolean] True if the deal is open
     def open?
       return false unless current_status
-      
+
       all_open_statuses = Attio.configuration.open_statuses + Attio.configuration.in_progress_statuses
       all_open_statuses.include?(current_status)
     end
@@ -465,7 +469,7 @@ module Attio
     # @return [Boolean] True if the deal is won
     def won?
       return false unless current_status
-      
+
       Attio.configuration.won_statuses.include?(current_status)
     end
 
@@ -473,7 +477,7 @@ module Attio
     # @return [Boolean] True if the deal is lost
     def lost?
       return false unless current_status
-      
+
       Attio.configuration.lost_statuses.include?(current_status)
     end
 
@@ -487,7 +491,7 @@ module Attio
     # Get the timestamp when the deal was closed (won or lost)
     # @return [Time, nil] The timestamp when deal was closed, or nil if still open
     def closed_at
-      return nil unless (won? || lost?)
+      return nil unless won? || lost?
       status_changed_at
     end
 
@@ -497,32 +501,32 @@ module Attio
     #   return false unless close_date && open?
     #   Date.parse(close_date) < Date.today
     # end
-    
+
     # Check if this is an enterprise deal
     # @return [Boolean] True if amount > 100,000
     def enterprise?
       amount > 100_000
     end
-    
+
     # Check if this is a mid-market deal
     # @return [Boolean] True if amount is between 10,000 and 100,000
     def mid_market?
       amount.between?(10_000, 100_000)
     end
-    
+
     # Check if this is a small deal
     # @return [Boolean] True if amount < 10,000
     def small?
       amount < 10_000
     end
-    
+
     # Get the number of days the deal has been in current stage
     # @return [Integer] Number of days in current stage
     def days_in_stage
       return 0 unless status_changed_at
       ((Time.now - status_changed_at) / (24 * 60 * 60)).round
     end
-    
+
     # Check if the deal is stale (no activity for specified days)
     # @param days [Integer] Number of days to consider stale (defaults to 30)
     # @return [Boolean] True if deal is open and hasn't changed in specified days
@@ -530,25 +534,25 @@ module Attio
       return false if closed?
       days_in_stage > days
     end
-    
+
     # Check if the deal is closed (won or lost)
     # @return [Boolean] True if deal is won or lost
     def closed?
       won? || lost?
     end
-    
+
     # Get a simple summary of the deal
     # @return [String] Summary string with name, amount, and stage
     def summary
-      "#{name || 'Unnamed Deal'}: #{formatted_amount} (#{stage || 'No Stage'})"
+      "#{name || "Unnamed Deal"}: #{formatted_amount} (#{stage || "No Stage"})"
     end
-    
+
     # Convert to string for display
     # @return [String] The deal summary
     def to_s
       summary
     end
-    
+
     # Get deal size category
     # @return [Symbol] :enterprise, :mid_market, or :small
     def size_category
@@ -560,21 +564,21 @@ module Attio
         :small
       end
     end
-    
+
     # Check if deal needs attention (stale and not closed)
     # @param stale_days [Integer] Days to consider stale
     # @return [Boolean] True if deal needs attention
     def needs_attention?(stale_days = 30)
       !closed? && stale?(stale_days)
     end
-    
+
     # Get deal velocity (amount per day if closed)
     # @return [Float, nil] Amount per day or nil if not closed
     def velocity
-      return nil unless closed? && closed_at && self.created_at
-      
-      days_to_close = ((closed_at - self.created_at) / (24 * 60 * 60)).round
-      days_to_close > 0 ? (amount / days_to_close).round(2) : amount
+      return nil unless closed? && closed_at && created_at
+
+      days_to_close = ((closed_at - created_at) / (24 * 60 * 60)).round
+      (days_to_close > 0) ? (amount / days_to_close).round(2) : amount
     end
   end
 
@@ -582,4 +586,4 @@ module Attio
   # @example
   #   Attio::Deals.create(name: "New Deal", value: 10000)
   Deals = Deal
-end
+end

data/lib/attio/resources/meta.rb

@@ -26,7 +26,7 @@ module Attio
     # Build workspace object from flat attributes
     def workspace
       return nil unless self[:workspace_id]
-      
+
       {
         id: self[:workspace_id],
         name: self[:workspace_name],
@@ -34,22 +34,22 @@ module Attio
         logo_url: self[:workspace_logo_url]
       }.compact
     end
-    
+
     # Build token object from flat attributes
     def token
       return nil unless self[:client_id]
-      
+
       {
         id: self[:client_id],
         type: self[:token_type] || "Bearer",
         scope: self[:scope]
       }.compact
     end
-    
+
     # Build actor object from flat attributes
     def actor
       return nil unless self[:authorized_by_workspace_member_id]
-      
+
       {
         type: "workspace-member",
         id: self[:authorized_by_workspace_member_id]
@@ -138,7 +138,5 @@ module Attio
     def inspect
       "#<#{self.class.name}:#{object_id} workspace=#{workspace_slug.inspect} token=#{token_name.inspect}>"
     end
-
-    private
   end
 end

data/lib/attio/resources/object.rb

@@ -53,7 +53,7 @@ module Attio
       known_opts.each do |opt|
         opts[opt] = conditions.delete(opt) if conditions.key?(opt)
       end
-      
+
       # Currently only supports slug
       if conditions.key?(:slug)
         slug = conditions[:slug]
@@ -66,7 +66,7 @@ module Attio
         raise ArgumentError, "find_by only supports slug attribute for objects"
       end
     end
-    
+
     # Find by API slug (deprecated - use find_by(slug: ...) instead)
     def self.find_by_slug(slug, **opts)
       find_by(slug: slug, **opts)

data/lib/attio/resources/person.rb

@@ -251,7 +251,6 @@ module Attio
         super(values: values, **opts)
       end
 
-
       # Search people by query
       # @param query [String] Query to search for
       def search(query, **opts)
@@ -268,7 +267,7 @@ module Attio
       end
 
       private
-      
+
       # Build filter for email field
       def filter_by_email(value)
         {
@@ -279,7 +278,7 @@ module Attio
           }
         }
       end
-      
+
       # Build filter for name field (searches across first, last, and full name)
       def filter_by_name(value)
         {

data/lib/attio/resources/typed_record.rb

@@ -64,18 +64,18 @@ module Attio
       # Supports Rails-style hash syntax: find_by(name: "Test")
       def find_by(**conditions)
         raise ArgumentError, "find_by requires at least one condition" if conditions.empty?
-        
+
         # Extract any opts that aren't conditions (like api_key)
         opts = {}
         known_opts = [:api_key, :timeout, :idempotency_key]
         known_opts.each do |opt|
           opts[opt] = conditions.delete(opt) if conditions.key?(opt)
         end
-        
+
         # Build filter from conditions
         filters = []
         search_query = nil
-        
+
         conditions.each do |field, value|
           # Check if there's a special filter method for this field
           filter_method = "filter_by_#{field}"
@@ -92,7 +92,7 @@ module Attio
             filters << {field => value}
           end
         end
-        
+
         # If we have a search query, use search instead of filter
         if search_query
           search(search_query, **opts).first
@@ -105,7 +105,7 @@ module Attio
           else
             {}
           end
-          
+
           list(**opts.merge(params: {
             filter: final_filter
           })).first

data/lib/attio/resources/workspace_member.rb

@@ -111,7 +111,7 @@ module Attio
         known_opts.each do |opt|
           opts[opt] = conditions.delete(opt) if conditions.key?(opt)
         end
-        
+
         # Currently only supports email
         if conditions.key?(:email)
           email = conditions[:email]

data/lib/attio/util/currency_formatter.rb

@@ -42,10 +42,10 @@ module Attio
         "PEN" => "S/",
         "ARS" => "$"
       }.freeze
-      
+
       # Currencies that typically don't use decimal places
       NO_DECIMAL_CURRENCIES = %w[JPY KRW VND IDR CLP].freeze
-      
+
       class << self
         # Format an amount with the appropriate currency symbol
         # @param amount [Numeric] The amount to format
@@ -58,12 +58,12 @@ module Attio
         def format(amount, currency_code = "USD", options = {})
           currency_code = currency_code.to_s.upcase
           symbol = symbol_for(currency_code)
-          
+
           # Determine decimal places
           decimal_places = options[:decimal_places] || decimal_places_for(currency_code)
           thousands_sep = options[:thousands_separator] || ","
           decimal_sep = options[:decimal_separator] || "."
-          
+
           # Handle zero amounts
           if amount == 0
             if decimal_places > 0
@@ -72,11 +72,11 @@ module Attio
               return "#{symbol}0"
             end
           end
-          
+
           # Handle negative amounts
           negative = amount < 0
           abs_amount = amount.abs
-          
+
           # Format the amount
           if decimal_places == 0
             # No decimal places
@@ -86,14 +86,14 @@ module Attio
           else
             # With decimal places
             whole = abs_amount.to_i
-            decimal = ((abs_amount - whole) * (10 ** decimal_places)).round
+            decimal = ((abs_amount - whole) * (10**decimal_places)).round
             formatted_whole = format_with_separators(whole, thousands_sep)
             formatted_whole = "-#{formatted_whole}" if negative
             formatted_decimal = decimal.to_s.rjust(decimal_places, "0")
             "#{symbol}#{formatted_whole}#{decimal_sep}#{formatted_decimal}"
           end
         end
-        
+
         # Get the currency symbol for a given code
         # @param currency_code [String] The ISO 4217 currency code
         # @return [String] The currency symbol or code with space
@@ -101,7 +101,7 @@ module Attio
           currency_code = currency_code.to_s.upcase
           CURRENCY_SYMBOLS[currency_code] || "#{currency_code} "
         end
-        
+
         # Determine the number of decimal places for a currency
         # @param currency_code [String] The ISO 4217 currency code
         # @return [Integer] Number of decimal places
@@ -109,14 +109,14 @@ module Attio
           currency_code = currency_code.to_s.upcase
           NO_DECIMAL_CURRENCIES.include?(currency_code) ? 0 : 2
         end
-        
+
         # Check if a currency typically uses decimal places
         # @param currency_code [String] The ISO 4217 currency code
         # @return [Boolean] True if the currency uses decimals
         def uses_decimals?(currency_code)
           decimal_places_for(currency_code) > 0
         end
-        
+
         # Format just the numeric part without currency symbol
         # @param amount [Numeric] The amount to format
         # @param currency_code [String] The ISO 4217 currency code
@@ -127,9 +127,9 @@ module Attio
           symbol = symbol_for(currency_code)
           result.sub(/^#{Regexp.escape(symbol)}/, "")
         end
-        
+
         private
-        
+
         # Add thousands separators to a number
         # @param number [Integer] The number to format
         # @param separator [String] The separator character
@@ -140,4 +140,4 @@ module Attio
       end
     end
   end
-end
+end

data/lib/attio/util/time_period.rb

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
 
-require 'date'
+require "date"
 
 module Attio
   module Util
     # Utility class for time period calculations
     class TimePeriod
       attr_reader :start_date, :end_date
-      
+
       def initialize(start_date, end_date)
         @start_date = parse_date(start_date)
         @end_date = parse_date(end_date)
       end
-      
+
       private
-      
+
       def parse_date(date)
         case date
         when Date
@@ -25,23 +25,23 @@ module Attio
           date.to_date
         end
       end
-      
+
       public
-      
+
       # Named constructors for common periods
-      
+
       # Current year to date
       def self.year_to_date
         today = Date.today
         new(Date.new(today.year, 1, 1), today)
       end
-      
+
       # Current month to date
       def self.month_to_date
         today = Date.today
         new(Date.new(today.year, today.month, 1), today)
       end
-      
+
       # Current quarter to date
       def self.quarter_to_date
         today = Date.today
@@ -49,21 +49,21 @@ module Attio
         quarter_start = Date.new(today.year, (quarter - 1) * 3 + 1, 1)
         new(quarter_start, today)
       end
-      
+
       # Specific quarter
       def self.quarter(year, quarter_num)
-        raise ArgumentError, "Quarter must be between 1 and 4" unless (1..4).include?(quarter_num)
+        raise ArgumentError, "Quarter must be between 1 and 4" unless (1..4).cover?(quarter_num)
         quarter_start = Date.new(year, (quarter_num - 1) * 3 + 1, 1)
         quarter_end = (quarter_start >> 3) - 1
         new(quarter_start, quarter_end)
       end
-      
+
       # Current quarter (full quarter, not QTD)
       def self.current_quarter
         today = Date.today
         quarter(today.year, (today.month - 1) / 3 + 1)
       end
-      
+
       # Previous quarter
       def self.previous_quarter
         today = Date.today
@@ -74,21 +74,21 @@ module Attio
           quarter(today.year, current_q - 1)
         end
       end
-      
+
       # Specific month
       def self.month(year, month_num)
-        raise ArgumentError, "Month must be between 1 and 12" unless (1..12).include?(month_num)
+        raise ArgumentError, "Month must be between 1 and 12" unless (1..12).cover?(month_num)
         month_start = Date.new(year, month_num, 1)
         month_end = (month_start >> 1) - 1
         new(month_start, month_end)
       end
-      
+
       # Current month (full month, not MTD)
       def self.current_month
         today = Date.today
         month(today.year, today.month)
       end
-      
+
       # Previous month
       def self.previous_month
         today = Date.today
@@ -98,71 +98,71 @@ module Attio
           month(today.year, today.month - 1)
         end
       end
-      
+
       # Specific year
       def self.year(year_num)
         new(Date.new(year_num, 1, 1), Date.new(year_num, 12, 31))
       end
-      
+
       # Current year (full year, not YTD)
       def self.current_year
         year(Date.today.year)
       end
-      
+
       # Previous year
       def self.previous_year
         year(Date.today.year - 1)
       end
-      
+
       # Last N days (including today)
       def self.last_days(num_days)
         today = Date.today
         new(today - num_days + 1, today)
       end
-      
+
       # Last 7 days
       def self.last_week
         last_days(7)
       end
-      
+
       # Last 30 days
       def self.last_30_days
         last_days(30)
       end
-      
+
       # Last 90 days
       def self.last_90_days
         last_days(90)
       end
-      
+
       # Last 365 days
       def self.last_year_rolling
         last_days(365)
       end
-      
+
       # Custom range
       def self.between(start_date, end_date)
         new(start_date, end_date)
       end
-      
+
       # Instance methods
-      
+
       # Check if a date falls within this period
       def includes?(date)
         date = date.to_date
-        date >= @start_date && date <= @end_date
+        date.between?(@start_date, @end_date)
       end
-      
+
       # Get the date range
       def to_range
         @start_date..@end_date
       end
-      
+
       # Number of days in the period
       def days
         (@end_date - @start_date).to_i + 1
       end
-      
+
       # String representation
       def to_s
         if @start_date == @end_date
@@ -171,18 +171,18 @@ module Attio
           "#{@start_date} to #{@end_date}"
         end
       end
-      
+
       # Human-readable label
       def label
         today = Date.today
-        
+
         # Check for common patterns
         if @start_date == Date.new(today.year, 1, 1) && @end_date == today
           "Year to Date"
         elsif @start_date == Date.new(today.year, today.month, 1) && @end_date == today
           "Month to Date"
         elsif @start_date == Date.new(today.year, 1, 1) && @end_date == Date.new(today.year, 12, 31)
-          "#{today.year}"
+          today.year.to_s
         elsif @start_date.day == 1 && @end_date == (@start_date >> 1) - 1
           @start_date.strftime("%B %Y")
         elsif days == 7 && @end_date == today
@@ -195,19 +195,19 @@ module Attio
           # Check for quarters
           quarter = detect_quarter
           return quarter if quarter
-          
+
           to_s
         end
       end
-      
+
       private
-      
+
       def detect_quarter
         # Check if this is a complete quarter
         [1, 2, 3, 4].each do |q|
           quarter_start = Date.new(@start_date.year, (q - 1) * 3 + 1, 1)
           quarter_end = (quarter_start >> 3) - 1
-          
+
           if @start_date == quarter_start && @end_date == quarter_end
             return "Q#{q} #{@start_date.year}"
           end
@@ -216,4 +216,4 @@ module Attio
       end
     end
   end
-end
+end

data/lib/attio/version.rb

@@ -2,5 +2,5 @@
 
 module Attio
   # Current version of the Attio Ruby gem
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/lib/attio-ruby.rb

@@ -2,4 +2,4 @@
 
 # This file exists to match the gem name for auto-requiring
 # It simply requires the main attio module
-require_relative "attio"
+require_relative "attio"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attio-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Robert Beene
@@ -335,7 +335,6 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- attio-ruby.gemspec
 - docs/CODECOV_SETUP.md
 - examples/app_specific_typed_record.md
 - examples/basic_usage.rb

data/attio-ruby.gemspec

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "lib/attio/version"
-
-Gem::Specification.new do |spec|
-  spec.name = "attio-ruby"
-  spec.version = Attio::VERSION
-  spec.authors = ["Robert Beene"]
-  spec.email = ["robert@ismly.com"]
-
-  spec.summary = "Ruby client library for the Attio API"
-  spec.description = "A comprehensive Ruby client library for the Attio CRM API with OAuth support, type safety, and extensive test coverage"
-  spec.homepage = "https://github.com/rbeene/attio_ruby"
-  spec.license = "MIT"
-  spec.required_ruby_version = ">= 3.4.0"
-
-  spec.metadata["allowed_push_host"] = "https://rubygems.org"
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/rbeene/attio_ruby"
-  spec.metadata["changelog_uri"] = "https://github.com/rbeene/attio_ruby/blob/main/CHANGELOG.md"
-  spec.metadata["documentation_uri"] = "https://rubydoc.info/gems/attio-ruby"
-  spec.metadata["bug_tracker_uri"] = "https://github.com/rbeene/attio_ruby/issues"
-
-  # Specify which files should be added to the gem when it is released.
-  spec.files = Dir.chdir(__dir__) do
-    `git ls-files -z`.split("\x0").reject do |f|
-      (File.expand_path(f) == __FILE__) ||
-        f.start_with?(*%w[bin/ test/ spec/ features/ .git .github appveyor Gemfile])
-    end
-  end
-  spec.bindir = "exe"
-  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
-
-  # Runtime dependencies
-  spec.add_dependency "faraday", "~> 2.0"
-  spec.add_dependency "faraday-retry", "~> 2.0"
-  spec.add_dependency "ostruct", "~> 0.6"
-
-  # Development dependencies
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "rspec", "~> 3.12"
-  spec.add_development_dependency "webmock", "~> 3.18"
-  spec.add_development_dependency "simplecov", "~> 0.22"
-  spec.add_development_dependency "simplecov-cobertura", "~> 2.1"
-  spec.add_development_dependency "yard", "~> 0.9"
-  spec.add_development_dependency "redcarpet", "~> 3.6"
-  spec.add_development_dependency "rubocop", "~> 1.50"
-  spec.add_development_dependency "rubocop-rspec", "~> 2.20"
-  spec.add_development_dependency "rubocop-performance", "~> 1.17"
-  spec.add_development_dependency "standard", "~> 1.28"
-  spec.add_development_dependency "benchmark-ips", "~> 2.12"
-  spec.add_development_dependency "pry", "~> 0.14"
-  spec.add_development_dependency "pry-byebug", "~> 3.10"
-  spec.add_development_dependency "dotenv", "~> 2.8"
-  spec.add_development_dependency "timecop", "~> 0.9"
-  spec.add_development_dependency "bundle-audit", "~> 0.1"
-  spec.add_development_dependency "brakeman", "~> 6.0"
-  spec.metadata["rubygems_mfa_required"] = "true"
-end