attestor 1.0.0 → 2.0.0

data/spec/tests/validations/reporter_spec.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+
+require "support/policies"
+
+describe Attestor::Validations::Reporter do
+
+  let(:object)     { double }
+  let(:error)      { Attestor::InvalidError.new object, ["foo"] }
+  let(:report)     { Attestor::Report }
+  let(:test_class) { Class.new.send(:include, described_class) }
+
+  subject { test_class.new }
+
+  describe "#validate" do
+
+    let(:result) { subject.validate object }
+
+    context "when #validate! fails" do
+
+      before do
+        allow(subject).to receive(:validate!).with(object) { fail(error) }
+      end
+
+      it "returns an invalid report" do
+        expect(result).to be_kind_of report
+        expect(result.object).to eq object
+        expect(result.error).not_to be_nil
+        expect(result.messages).to eq error.messages
+      end
+
+    end # context
+
+    context "when #validate! passes" do
+
+      before { allow(subject).to receive(:validate!).with(object) }
+
+      it "returns a valid report" do
+        expect(result).to be_kind_of report
+        expect(result.object).to eq object
+        expect(result.error).to be_nil
+      end
+
+    end # context
+
+  end # describe #validate
+
+end # describe Attestor::Validations::Reporter

data/spec/tests/validations/validator_spec.rb

@@ -4,6 +4,7 @@ require "support/policies"
 
 describe Attestor::Validations::Validator do
 
+  let(:reporter_module) { Attestor::Validations::Reporter }
   subject { described_class.new "foo" }
 
   describe ".new" do
@@ -12,32 +13,6 @@ describe Attestor::Validations::Validator do
       expect(subject).to be_frozen
     end
 
-    it "accepts item option :except" do
-      expect { described_class.new "foo", except: :bar }.not_to raise_error
-    end
-
-    it "accepts array option :except" do
-      expect { described_class.new "foo", except: %w(bar) }.not_to raise_error
-    end
-
-    it "ignores repetitive :except items" do
-      expect(described_class.new "foo", except: %i(bar bar))
-        .to eq(described_class.new "foo", except: %i(bar))
-    end
-
-    it "accepts item option :only" do
-      expect { described_class.new "foo", only: :bar }.not_to raise_error
-    end
-
-    it "accepts array option :only" do
-      expect { described_class.new "foo", only: %w(bar) }.not_to raise_error
-    end
-
-    it "ignores repetitive :only items" do
-      expect(described_class.new "foo", only: %i(bar bar))
-        .to eq(described_class.new "foo", only: %i(bar))
-    end
-
   end # describe .new
 
   describe "#name" do
@@ -52,66 +27,65 @@ describe Attestor::Validations::Validator do
 
   end # describe .name
 
-  describe "#==" do
+  describe "#whitelist" do
 
-    subject { described_class.new :foo, except: [:foo], only: %i(bar) }
-
-    context "item with the same arguments" do
-
-      let(:other) { described_class.new :foo, except: %i(foo), only: %i(bar) }
-
-      it "returns true" do
-        expect(subject == other).to eq true
-        expect(subject).to eq other
-      end
-
-    end # context
-
-    context "item with another name" do
-
-      let(:other) { described_class.new :baz, except: %i(foo), only: %i(bar) }
-
-      it "returns false" do
-        expect(subject == other).to eq false
-        expect(subject).not_to eq other
-      end
+    it "returns an empty array by default" do
+      expect(subject.whitelist).to eq []
+    end
 
-    end # context
+    it "is initialized" do
+      subject = described_class.new("foo", only: :bar)
+      expect(subject.whitelist).to eq [:bar]
+    end
 
-    context "item with another blacklist" do
+    it "is symbolized" do
+      subject = described_class.new("foo", only: %w(bar baz))
+      expect(subject.whitelist).to eq [:bar, :baz]
+    end
 
-      let(:other) { described_class.new :foo, except: %i(baz), only: %i(bar) }
+    it "contains unique items" do
+      subject = described_class.new("foo", only: %i(bar bar))
+      expect(subject.whitelist).to eq [:bar]
+    end
 
-      it "returns false" do
-        expect(subject == other).to eq false
-        expect(subject).not_to eq other
-      end
+  end # describe .whitelist
 
-    end # context
+  describe "#blacklist" do
 
-    context "item with another whitelist" do
+    it "returns an empty array by default" do
+      expect(subject.blacklist).to eq []
+    end
 
-      let(:other) { described_class.new :foo, except: %i(foo), only: %i(baz) }
+    it "is initialized" do
+      subject = described_class.new("foo", except: :bar)
+      expect(subject.blacklist).to eq [:bar]
+    end
 
-      it "returns false" do
-        expect(subject == other).to eq false
-        expect(subject).not_to eq other
-      end
+    it "is symbolized" do
+      subject = described_class.new("foo", except: %w(bar baz))
+      expect(subject.blacklist).to eq [:bar, :baz]
+    end
 
-    end # context
+    it "contains unique items" do
+      subject = described_class.new("foo", except: %i(bar bar))
+      expect(subject.blacklist).to eq [:bar]
+    end
 
-    context "not an item" do
+  end # describe .blacklist
 
-      let(:other) { "baz" }
+  describe "#block" do
 
-      it "returns false" do
-        expect(subject == other).to eq false
-        expect(subject).not_to eq other
-      end
+    it "returns nil by default" do
+      expect(subject.block).to be_nil
+    end
 
-    end # context
+    it "is initialized" do
+      block = proc { :foo }
+      subject = described_class.new "foo", &block
+      expect(subject.block).to eq block
+    end
 
-  end # describe #==
+  end # describe .blacklist
 
   describe "#used_in_context?" do
 
@@ -156,10 +130,10 @@ describe Attestor::Validations::Validator do
 
   end # describe #name
 
-  describe "#validate" do
+  describe "#validate!" do
 
-    let(:object) { Class.new { private def foo; end }.new }
-    after        { subject.validate object }
+    let(:object) { Class.new { private; def foo; end }.new }
+    after        { subject.validate! object }
 
     context "when no block initialized" do
 
@@ -181,6 +155,14 @@ describe Attestor::Validations::Validator do
 
     end # context
 
+  end # describe #validate!
+
+  describe "#validate" do
+
+    it "is is imported from the Reporter" do
+      expect(described_class).to include reporter_module
+    end
+
   end # describe #validate
 
 end # describe Attestor::Validation

data/spec/tests/validations/validators_spec.rb

@@ -3,7 +3,9 @@
 describe Attestor::Validations::Validators do
 
   let(:validator_class) { Attestor::Validations::Validator }
-  let(:delegator_class) { Attestor::Validations::Delegator  }
+  let(:delegator_class) { Attestor::Validations::Delegator }
+  let(:reporter_module) { Attestor::Validations::Reporter  }
+  let(:invalid_error)   { Attestor::InvalidError           }
 
   describe ".new" do
 
@@ -61,18 +63,24 @@ describe Attestor::Validations::Validators do
 
     context "with a block" do
 
-      let(:result) { subject.add_validator { foo } }
+      let(:block)  { proc { foo } }
+      let(:result) { subject.add_validator(&block) }
 
       it "returns validators" do
         expect(result).to be_kind_of described_class
       end
 
-      it "adds validator (not a delegator)" do
+      it "adds a validator (not a delegator)" do
         item = result.first
         expect(item).to be_kind_of validator_class
         expect(item).not_to be_kind_of delegator_class
       end
 
+      it "assigns a block to the validator" do
+        item = result.first
+        expect(item.block).to eq block
+      end
+
     end # context
 
     context "with contexts" do
@@ -117,7 +125,8 @@ describe Attestor::Validations::Validators do
 
     context "with a block" do
 
-      let(:result) { subject.add_delegator { foo } }
+      let(:block)  { proc { foo } }
+      let(:result) { subject.add_delegator(&block) }
 
       it "returns validators" do
         expect(result).to be_kind_of described_class
@@ -128,6 +137,11 @@ describe Attestor::Validations::Validators do
         expect(item).to be_kind_of delegator_class
       end
 
+      it "assigns a block to the delegator" do
+        item = result.first
+        expect(item.block).to eq block
+      end
+
     end # context
 
     context "with contexts" do
@@ -165,4 +179,67 @@ describe Attestor::Validations::Validators do
 
   end # describe #set
 
+  describe "#validate!" do
+
+    let(:object) { double foo: nil, bar: nil }
+
+    subject do
+      described_class.new
+        .add_validator("foo")
+        .add_validator("bar")
+    end
+
+    context "when all validators passes" do
+
+      it "calls all validators" do
+        expect(object).to receive :foo
+        expect(object).to receive :bar
+        subject.validate! object
+      end
+
+      it "passes" do
+        expect { subject.validate! object }.not_to raise_error
+      end
+
+    end # context
+
+    context "when any validator fails" do
+
+      let(:messages) { %w(foo) }
+      before do
+        allow(object)
+          .to receive(:foo) { fail invalid_error.new(object, messages) }
+      end
+
+      it "calls all validators" do
+        expect(object).to receive :foo
+        expect(object).to receive :bar
+        subject.validate! object rescue nil
+      end
+
+      it "fails" do
+        expect { subject.validate! object }.to raise_error(invalid_error)
+      end
+
+      it "collects errors from validators" do
+        begin
+          subject.validate! object
+        rescue => error
+          expect(error.object).to   eq object
+          expect(error.messages).to eq messages
+        end
+      end
+
+    end # context
+
+  end # describe #validate!
+
+  describe "#validate" do
+
+    it "is is imported from the Reporter" do
+      expect(described_class).to include reporter_module
+    end
+
+  end # describe #validate
+
 end # describe Attestor::Validators

data/spec/tests/validations_spec.rb

@@ -31,18 +31,42 @@ describe Attestor::Validations do
 
   describe ".validate" do
 
-    context "without options" do
+    context "with a name" do
 
       before { test_class.validate :foo }
 
       it "registers a validator" do
-        expect(test_class.validators.map(&:name)).to eq [:foo]
-        expect(test_class.validators.first).not_to be_kind_of delegator_class
+        item = test_class.validators.first
+        expect(item).to be_kind_of validator_class
+        expect(item).not_to be_kind_of delegator_class
+      end
+
+      it "assigns the name to the validator" do
+        item = test_class.validators.first
+        expect(item.name).to eq :foo
+      end
+
+    end # context
+
+    context "with a block" do
+
+      let(:block) { proc { foo } }
+      before      { test_class.validate(&block) }
+
+      it "registers a validator" do
+        item = test_class.validators.first
+        expect(item).to be_kind_of validator_class
+        expect(item).not_to be_kind_of delegator_class
+      end
+
+      it "assigns the block to the validator" do
+        item = test_class.validators.first
+        expect(item.block).to eq block
       end
 
     end # context
 
-    context "with restrictions" do
+    context "with options" do
 
       before { test_class.validate :foo, only: %w(bar baz), except: "bar" }
 
@@ -58,18 +82,40 @@ describe Attestor::Validations do
 
   describe ".validates" do
 
-    context "without options" do
+    context "with a name" do
 
       before { test_class.validates :foo }
 
       it "registers a delegator" do
-        expect(test_class.validators.map(&:name)).to eq [:foo]
-        expect(test_class.validators.first).to be_kind_of delegator_class
+        item = test_class.validators.first
+        expect(item).to be_kind_of delegator_class
+      end
+
+      it "assigns the name to the delegator" do
+        item = test_class.validators.first
+        expect(item.name).to eq :foo
       end
 
     end # context
 
-    context "with restrictions" do
+    context "with a block" do
+
+      let(:block) { proc { foo } }
+      before      { test_class.validates(&block) }
+
+      it "registers a delegator" do
+        item = test_class.validators.first
+        expect(item).to be_kind_of delegator_class
+      end
+
+      it "assigns the block to the delegator" do
+        item = test_class.validators.first
+        expect(item.block).to eq block
+      end
+
+    end # context
+
+    context "with options" do
 
       before { test_class.validates :foo, only: %w(bar baz), except: "bar" }
 
@@ -87,7 +133,13 @@ describe Attestor::Validations do
 
     shared_examples "raising an error" do |name, options = {}|
 
-      let(:message) { message_class.new(name, subject, options) }
+      let(:message) { double }
+      before do
+        allow(message_class)
+          .to receive(:new)
+          .with(name, subject, options)
+          .and_return message
+      end
 
       it "raises an InvalidError" do
         expect { invalid }.to raise_error invalid_error
@@ -122,6 +174,42 @@ describe Attestor::Validations do
 
   end # invalid
 
+  describe "#validate!" do
+
+    before do
+      test_class.validate  :foo
+      test_class.validate  :bar, only: :all
+      test_class.validates :baz, only: :foo
+
+      allow(subject).to receive(:foo)
+      allow(subject).to receive(:bar)
+      allow(subject).to receive(:baz) { valid_policy }
+    end
+
+    context "without an argument" do
+
+      it "calls validators for :all context" do
+        expect(subject).to receive(:foo)
+        expect(subject).to receive(:bar)
+        expect(subject).not_to receive(:baz)
+        subject.validate!
+      end
+
+    end # context
+
+    context ":foo" do
+
+      it "calls validators for :foo context" do
+        expect(subject).to receive(:foo)
+        expect(subject).to receive(:baz)
+        expect(subject).not_to receive(:bar)
+        subject.validate! :foo
+      end
+
+    end # context
+
+  end # describe #validate!
+
   describe "#validate" do
 
     before do
@@ -156,6 +244,6 @@ describe Attestor::Validations do
 
     end # context
 
-  end # describe #validate
+  end # describe #validate!
 
 end # describe Attestor::Validations

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attestor
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Andrew Kozin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-28 00:00:00.000000000 Z
+date: 2015-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: extlib
@@ -80,9 +80,11 @@ files:
 - lib/attestor/policy/not.rb
 - lib/attestor/policy/or.rb
 - lib/attestor/policy/xor.rb
+- lib/attestor/report.rb
 - lib/attestor/validations.rb
 - lib/attestor/validations/delegator.rb
 - lib/attestor/validations/message.rb
+- lib/attestor/validations/reporter.rb
 - lib/attestor/validations/validator.rb
 - lib/attestor/validations/validators.rb
 - lib/attestor/version.rb
@@ -98,8 +100,10 @@ files:
 - spec/tests/policy/or_spec.rb
 - spec/tests/policy/xor_spec.rb
 - spec/tests/policy_spec.rb
+- spec/tests/report_spec.rb
 - spec/tests/validations/delegator_spec.rb
 - spec/tests/validations/message_spec.rb
+- spec/tests/validations/reporter_spec.rb
 - spec/tests/validations/validator_spec.rb
 - spec/tests/validations/validators_spec.rb
 - spec/tests/validations_spec.rb
@@ -123,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Validations for immutable Ruby objects
@@ -132,8 +136,10 @@ test_files:
 - spec/tests/policy_spec.rb
 - spec/tests/invalid_error_spec.rb
 - spec/tests/validations_spec.rb
+- spec/tests/report_spec.rb
 - spec/tests/validations/message_spec.rb
 - spec/tests/validations/validator_spec.rb
+- spec/tests/validations/reporter_spec.rb
 - spec/tests/validations/delegator_spec.rb
 - spec/tests/validations/validators_spec.rb
 - spec/tests/policy/or_spec.rb