attache 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc90b16475272e6baac6425b906f8fffca6f1249
-  data.tar.gz: 58122828ad77382848273daf0913e3c6de9782d4
+  metadata.gz: 1438a328d3cedfa04d52dcbe33d1b168be8ccd98
+  data.tar.gz: 0676c54d6050a8280247fa4e48ade32ec749edaf
 SHA512:
-  metadata.gz: 3441af14460f63af2df895148879f0a44858ae0e931c10612916cf96fb67e838f70adf5554b03b5f05b7bf3cf33a0d9535512d9bdb36aae38078bd7c4f0dbe67
-  data.tar.gz: fd96f3fcef7f3f5668c14077cb67aad90c7e8d2c818267f0268879265ee3aa808a51d5f5c53a45d36f38962b315ccdbb887b6699c64f31803b12230ebaab1290
+  metadata.gz: 25f7bdb0321d6850f7e42002fa54670654260f670023d3a119b587302f704efc303f2ef2c6ba8bcb852d77b7f35a66f11332b6fd2dc260940f94090ed25f523b
+  data.tar.gz: bea5d1625b2235168897f5978de5fb1dbb62a5a9ec65af10a1264e7204c5397939b0d5447129ca2fff3b72e79c09956f90298f533c6815788f108cf97a007a32

data/README.md

@@ -1,8 +1,18 @@
 # attache
 
+[![Gem Version](https://badge.fury.io/rb/attache.svg)](https://badge.fury.io/rb/attache)
 [![Build Status](https://travis-ci.org/choonkeat/attache.svg?branch=master)](https://travis-ci.org/choonkeat/attache)
 
-## Run
+## But why?
+
+If you're interested in the "why", checkout [my slides](http://www.slideshare.net/choonkeat/file-upload-2015) and [the blog post](http://blog.choonkeat.com/weblog/2015/10/file-uploads-2015.html).
+
+Your app can easily support
+- dynamic resize of images (no predefined styles in your app)
+- all file types since attache let apps [display non-image files as icons through `<img src...>`](https://github.com/choonkeat/attache/pull/28)
+- resumeable upload over unreliable (mobile) networks [using TUS protocol](https://github.com/choonkeat/attache/pull/10)
+
+## Run an instance
 
 #### Heroku
 
@@ -18,19 +28,6 @@ docker run -it -p 9292:5000 --rm attache/attache
 
 Also, see [Deploying Attache on Digital Ocean using Docker](https://github.com/choonkeat/attache/wiki/Deploying-Attache-on-Digital-Ocean-using-Docker)
 
-#### Source code
-
-You can checkout the source code and run it like a regular [a Procfile-based app](ddollar.github.io/foreman/)
-
-```
-git clone https://github.com/choonkeat/attache.git
-cd attache
-bundle install
-foreman start -c web=1 -p 9292
-```
-
-See [foreman](https://github.com/ddollar/foreman) for more details.
-
 #### RubyGem
 
 You can install the gem and then execute `attache` command
@@ -68,7 +65,20 @@ bundle exec attache start -c web=1 -p 9292
 
 NOTE: some config files will be written into your current directory (see RubyGems above)
 
-## Configure
+#### Source code
+
+You can checkout the source code and run it like a regular [a Procfile-based app](ddollar.github.io/foreman/)
+
+```
+git clone https://github.com/choonkeat/attache.git
+cd attache
+bundle install
+foreman start -c web=1 -p 9292
+```
+
+See [foreman](https://github.com/ddollar/foreman) for more details.
+
+## Configuration
 
 `LOCAL_DIR` is where your local disk cache will be. By default, attache will use a system assigned temporary directory which may not be the same everytime you run attache.
 
@@ -82,7 +92,7 @@ However if you prefer a more durable queue for reliable uploads, configuring `RE
 
 If for some reason you'd want the cloud storage delete to be synchronous, set `INLINE_JOB=1` instead.
 
-#### Cloud Storage Virtual Host
+#### Virtual Host Cloud Storage
 
 `attache` uses a different config (and backup files into a different cloud service) depending on the request hostname that it was accessed by.
 
@@ -102,9 +112,15 @@ heroku config:set VHOST=$(bundle exec rake attache:vhost)
 
 #### Virtual Host Authorization
 
-By default `attache` will accept uploads and delete requests from any client.
+By default `attache` will accept uploads and delete requests from any client. Set `SECRET_KEY` to ensure attache only receives upload (and delete commands) from your own app.
+
+To most app developers *using* attache in your rails app through a library like [attache-rails gem](https://github.com/choonkeat/attache-rails), how this work may not matter. But if you are developing attache itself or writing a client library for attache, then read on.
+
+#### Virtual Host Authorization (Developer)
 
-When `SECRET_KEY` is set, `attache` will require a valid `hmac` parameter in the upload request. Upload and Delete requests will be refused with `HTTP 401` error unless the `hmac` is correct. The additional parameters required for authorized request are:
+When `SECRET_KEY` is set, `attache` will require a valid `hmac` parameter in the upload request. Upload and Delete requests will be refused with `HTTP 401` error unless the `hmac` is correct.
+
+The additional parameters required for authorized request are:
 
 * `uuid` is a uuid string
 * `expiration` is a unix timestamp of a future time. the significance is, if the timestamp has passed, the upload will be regarded as invalid
@@ -116,8 +132,6 @@ i.e.
 hmac = OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha1'), SECRET_KEY, uuid + expiration)
 ```
 
-This will be transparent to you when using integration libraries like [attache_rails gem](https://github.com/choonkeat/attache_rails).
-
 ## APIs
 
 The attache server is a reference implementation of these interfaces. If you write your own server, [compatibility can be verified by running a test suite](https://github.com/choonkeat/attache_api#testing-against-an-attache-compatible-server).
@@ -126,7 +140,6 @@ The attache server is a reference implementation of these interfaces. If you wri
 
 Users will upload files directly into the `attache` server from their browser, bypassing the main app.
 
-
 > ```
 > PUT /upload?file=image123.jpg
 > ```
@@ -181,6 +194,8 @@ The `paths` value should be delimited by the newline character, aka `\n`. In the
 > paths=image1.jpg%0Aprefix2%2Fimage2.jpg%0Aimage3.jpg
 > ```
 
+This feature might be known as `promote` in other file upload solutions. `attache` allows client app to `backup` uploaded images to another bucket for longer term storage.
+
 Copying 1 or more files from the default remote storage to the backup remote storage (backup) can be done via a http `POST` request to `/backup`, with a `paths` parameter in the request body.
 
 The `paths` value should be delimited by the newline character, aka `\n`. In the example above, 3 files will be requested for backup: `image1.jpg`, `prefix2/image2.jpg`, and `image3.jpg`.

data/lib/attache/download.rb

@@ -48,7 +48,7 @@ class Attache::Download < Attache::Base
           nil
         end
 
-        unless file
+        unless file && file.try(:size).to_i > 0
           return [404, config.download_headers, []]
         end
 

data/lib/attache/version.rb

@@ -1,3 +1,3 @@
 module Attache
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/lib/attache/vhost.rb

@@ -44,11 +44,16 @@ class Attache::VHost
   end
 
   def storage_url(args)
-    remote_api.new({
+    object = remote_api.new({
       key: File.join(*remotedir, args[:relpath]),
-    }).url(Time.now + 600).tap do |url|
-      Attache.logger.info "storage_url: #{url}"
+    })
+    result = if object.respond_to?(:url)
+      object.url(Time.now + 600)
+    else
+      object.public_url
     end
+  ensure
+    Attache.logger.info "storage_url: #{result}"
   end
 
   def storage_get(args)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attache
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - choonkeat
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-01-18 00:00:00.000000000 Z
+date: 2016-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: paperclip
   requirement: !ruby/object:Gem::Requirement