atomic_lti 1.2.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7381dbf24886137688f92e773144dd5194746ad605b426d743221a7ba2ec25ba
-  data.tar.gz: ebc4d85849a13db6df43c0b6d906af6fe32b453fbbf3cf34934ff647a64d68c8
+  metadata.gz: f4e630de3811dceac9fa0db319f298f3d0f2c2511624466df133e398ab87ad4a
+  data.tar.gz: afa911b83546448c4a14e0ce27f8e4fb773e4b44c261362fe4e777f49a5fa023
 SHA512:
-  metadata.gz: 129f9b79ae60f4bb7a00db8199c83ee0348a6d2484280f895736e89e9d26cf3531fe9b557072cd07011234675ce658a8dfe6e1227e81442c2cdbcb2dccd4e685
-  data.tar.gz: 955d5ff4465790e5106d9b551fdcd8b52b8a93cd41c919b16ac1d2c6b31cfd97f2637b8bd64aa5b26cd702e54c90ecb578749c9bc6ce8486057cb163d5978027
+  metadata.gz: 4a6dd4c17f5b458c2c4adaa8cfd152ad047c906f09d5d6746b05fe13b5efd0f31841a2237e3d65ac9325a74dd26811768c6fabddc536c27e22a4394ce0e19a95
+  data.tar.gz: 1f64fb3ed49714598867763504f9609c9769cc34b2e292da18bc5f34bdc97ea081443b836034b56ed1f7054749991999d51ba9e04880171bf79c3d11c9f14253

data/app/lib/atomic_lti/authorization.rb

@@ -16,7 +16,7 @@ module AtomicLti
 
       platform = Platform.find_by(iss: iss)
 
-      raise AtomicLti::Exceptions::NoLTIPlatform(iss: iss, deployment_id: decoded_token.dig(0, "deployment_id")) if platform.nil?
+      raise AtomicLti::Exceptions::NoLTIPlatform.new(iss: iss, deployment_id: decoded_token.dig(0, "deployment_id")) if platform.nil?
 
       cache_key = "#{iss}_jwks"
 

data/app/lib/atomic_lti/lti.rb

@@ -16,6 +16,19 @@ module AtomicLti
         errors.push("LTI token is missing required field sub")
       end
 
+      if decoded_token["aud"].blank?
+        errors.push("LTI token is missing required field aud")
+      end
+
+      if decoded_token["aud"].is_a?(Array) && decoded_token["aud"].length > 1
+        # OpenID Connect spec specifies the AZP should exist and be an AUD
+        if decoded_token["azp"].blank?
+          errors.push("LTI token has multiple aud and is missing required field azp")
+        elsif decoded_token["aud"].exclude?(decoded_token["azp"])
+          errors.push("LTI token azp is not one of the aud's")
+        end
+      end
+
       if decoded_token[AtomicLti::Definitions::DEPLOYMENT_ID].blank?
         errors.push(
           "LTI token is missing required field #{AtomicLti::Definitions::DEPLOYMENT_ID}"
@@ -90,5 +103,17 @@ module AtomicLti
         false
       end
     end
+
+    def self.client_id(decoded_token)
+      if decoded_token["aud"]&.is_a?(Array)
+        if decoded_token["aud"].length > 1
+          decoded_token["azp"]
+        else
+          decoded_token["aud"][0]
+        end
+      else
+        decoded_token["aud"]
+      end
+    end
   end
-end
+end

data/app/lib/atomic_lti/services/line_items.rb

@@ -27,7 +27,7 @@ module AtomicLti
           tag: tag,
           startDateTime: start_date_time,
           endDateTime: end_date_time,
-        }
+        }.compact
         attrs["resourceLinkId"] = resource_link_id if resource_link_id
         if external_tool_url
           attrs[AtomicLti::Definitions::CANVAS_SUBMISSION_TYPE] = {

data/lib/atomic_lti/open_id_middleware.rb

@@ -159,7 +159,7 @@ module AtomicLti
     end
 
     def update_install(id_token:)
-      client_id = id_token["aud"]
+      client_id = AtomicLti::Lti.client_id(id_token)
       iss = id_token["iss"]
 
       if client_id.present? && iss.present?
@@ -202,7 +202,7 @@ module AtomicLti
     end
 
     def update_deployment(id_token:)
-      client_id = id_token["aud"]
+      client_id = AtomicLti::Lti.client_id(id_token)
       iss = id_token["iss"]
       deployment_id = id_token[AtomicLti::Definitions::DEPLOYMENT_ID]
       platform_guid = id_token.dig(AtomicLti::Definitions::TOOL_PLATFORM_CLAIM, "guid")
@@ -247,7 +247,7 @@ module AtomicLti
     def build_oidc_response(request, state, nonce, redirect_uri)
       platform = AtomicLti::Platform.find_by(iss: request.params["iss"])
       if !platform
-        raise AtomicLti::Exceptions::NoLTIPlatform(iss: request.params["iss"])
+        raise AtomicLti::Exceptions::NoLTIPlatform.new(iss: request.params["iss"])
       end
 
       uri = URI.parse(platform.oidc_url)

data/lib/atomic_lti/version.rb

@@ -1,3 +1,3 @@
 module AtomicLti
-  VERSION = '1.2.0'
+  VERSION = '1.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic_lti
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Matt Petro
@@ -10,36 +10,36 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-21 00:00:00.000000000 Z
+date: 2023-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.3
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.3
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: pg
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: '7.0'
 description: AtomicLti implements the LTI Advantage specification. This gem does contain
   source code specific to other Atomic Jolt products
 email: