atomic_cache 0.2.2.rc1 → 0.2.3.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb65136822683212f95725ed2a56753b369cabc3ff68335310755f465e997dc7
-  data.tar.gz: 891410bc30fcb78b0b8850913b7d3e2c70eff9d2063df3e76c233a3685a6c55e
+  metadata.gz: da4480539afcbe1c7c15e34dfbd77c7da40761853fc270bab1a0ad6d778b253e
+  data.tar.gz: c0deb89b6a828430252b6ae85d1727aa5282837b355013f661be6f100406125b
 SHA512:
-  metadata.gz: 13b9b39ea19ad6e157e6015a4e2670df741f9106d36b0f64931da60d651ecd61abd39c24183fb648498f3d4d54ab92684c389ced188650a61f6c2dcc7170748d
-  data.tar.gz: e33b8ded8491885eb96508e678ddb8bbc7f62f691c795fbcbaa9303c0a6e578f5666793c64ca1db8b0fbf98a0d9257f1eb68653c0f862d416bf3d6b65fa012b3
+  metadata.gz: 1aacd6f8ac2f420ac3b87e3d3031533f0cd3268cd6cb567a22e990c860274a6640800c4cfd4a88481b90af5c40ef60101d699a2a2df348fbe60e8e4639dd6901
+  data.tar.gz: c405dbd590e3f3f095a25ca1189687548cdf09380bba0b390060560b555730eade8528f897665d99d50a2ac0783ca00bd96e4029d852fbd79ffe14cd38daee0c

data/lib/atomic_cache/storage/dalli.rb

@@ -10,10 +10,6 @@ module AtomicCache
     class Dalli < Store
       extend Forwardable
 
-      ADD_SUCCESS = 'STORED'
-      ADD_UNSUCCESSFUL = 'NOT_STORED'
-      ADD_EXISTS = 'EXISTS'
-
       def_delegators :@dalli_client, :delete
 
       def initialize(dalli_client)
@@ -27,8 +23,7 @@ module AtomicCache
         # dalli expects time in seconds
         # https://github.com/petergoldstein/dalli/blob/b8f4afe165fb3e07294c36fb1c63901b0ed9ce10/lib/dalli/client.rb#L27
         # TODO: verify this unit is being treated correctly through the system
-        response = @dalli_client.add(key, new_value, ttl, opts)
-        response.start_with?(ADD_SUCCESS)
+        !!@dalli_client.add(key, new_value, ttl, opts)
       end
 
       def read(key, user_options={})
@@ -38,7 +33,7 @@ module AtomicCache
       def set(key, value, user_options={})
         ttl = user_options[:ttl]
         user_options.delete(:ttl)
-        @dalli_client.set(key, value, ttl, user_options)
+        !!@dalli_client.set(key, value, ttl, user_options)
       end
 
     end

data/lib/atomic_cache/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicCache
-  VERSION = "0.2.2.rc1"
+  VERSION = "0.2.3.rc1"
 end

data/spec/atomic_cache/storage/dalli_spec.rb

@@ -37,7 +37,7 @@ describe 'Dalli' do
 
   context '#add' do
     before(:each) do
-      allow(dalli_client).to receive(:add).and_return('NOT_STORED\r\n')
+      allow(dalli_client).to receive(:add).and_return(false)
     end
 
     it 'delegates to #add with the raw option set' do
@@ -47,22 +47,17 @@ describe 'Dalli' do
     end
 
     it 'returns true when the add is successful' do
-      expect(dalli_client).to receive(:add).and_return('STORED\r\n')
+      expect(dalli_client).to receive(:add).and_return(12339031748204560384)
       result = subject.add('key', 'value', 100)
       expect(result).to eq(true)
     end
 
     it 'returns false if the key already exists' do
-      expect(dalli_client).to receive(:add).and_return('EXISTS\r\n')
+      expect(dalli_client).to receive(:add).and_return(false)
       result = subject.add('key', 'value', 100)
       expect(result).to eq(false)
     end
 
-    it 'returns false if the add fails' do
-      expect(dalli_client).to receive(:add).and_return('NOT_STORED\r\n')
-      result = subject.add('key', 'value', 100)
-      expect(result).to eq(false)
-    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic_cache
 version: !ruby/object:Gem::Version
-  version: 0.2.2.rc1
+  version: 0.2.3.rc1
 platform: ruby
 authors:
 - Ibotta Developers