atomic_cache 0.2.0.rc1 → 0.2.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4534d927a8015f910a8f6a330f5a49ffc2e96931b968bdafe123c104f50ee159
-  data.tar.gz: c8b834855c70ae59b272efd57eb9f491db734b90280a3d20f14ba4b56fe26786
+  metadata.gz: d908f524b778436fea47a5a576f1f64003d6640ff734ce61aa711d4432fb2cac
+  data.tar.gz: 7fa480b5bd764c4f4b5e2d6a940e42fbccc4900bd892e8a6578d76389cafc09d
 SHA512:
-  metadata.gz: d1f49452ff1cf04f665112f39232749ec595bb6ac3a45f13ee178d52fe0e9581e594466f2936e542495f6dfda5b665617a77aebbd70e320b7a137d551fe1bf13
-  data.tar.gz: 113adcfe789cd195283c3bf2db1691c0724cf2b9e9fb5d1e3ac13bc93d401faac47b6206c54e8da045d666d27c913f617e931aa77e18b7f36c7a39b9cc2a41db
+  metadata.gz: 19a87c2ef28d260290edf004559611228cbf79d378814db31d6d1ffb24399b118bdff8c66d3049ae7c8f028039b5606b1abe80d72726406eae759c301639a4d4
+  data.tar.gz: e18ea892a4eb44e0fb851d0e5aae5aa81adf2443507e8dd4e2c9273342759db1d277f27a00444dd9e8b970783927481c60f1c67c08d1639af7f7139e09679be1

data/lib/atomic_cache/concerns/global_lmt_cache_concern.rb

@@ -100,7 +100,7 @@ module AtomicCache
     end
 
     def expire_cache(at=Time.now)
-      self.class.expire_cache(ns)
+      self.class.expire_cache(at)
     end
 
     def last_modified_time

data/lib/atomic_cache/key/keyspace.rb

@@ -20,11 +20,11 @@ module AtomicCache
     # @param separator [String] character or string to separate keyspace segments
     # @param timestamp_formatter [Proc] function to turn Time -> String
     def initialize(namespace:, root: nil, separator: nil, timestamp_formatter: nil)
+      @timestamp_formatter = timestamp_formatter || DefaultConfig.instance.timestamp_formatter
+      @separator = separator || DefaultConfig.instance.separator
       @namespace = []
       @namespace = normalize_segments(namespace) if namespace.present?
-      @separator = separator || DefaultConfig.instance.separator
-      @timestamp_formatter = timestamp_formatter || DefaultConfig.instance.timestamp_formatter
-      @root = root || namespace.last
+      @root = root || @namespace.last
     end
 
     # Create a new Keyspace, extending the namespace with the given segments and
@@ -70,7 +70,7 @@ module AtomicCache
     def normalize_segments(segments)
       if segments.is_a? Array
         segments.map { |seg| expand_segment(seg) }
-      elsif sgs.nil?
+      elsif segments.nil?
         []
       else
         [expand_segment(segments)]

data/lib/atomic_cache/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicCache
-  VERSION = "0.2.0.rc1"
+  VERSION = "0.2.0.rc2"
 end

data/spec/atomic_cache/concerns/global_lmt_cache_concern_spec.rb

@@ -82,6 +82,13 @@ describe 'AtomicCacheConcern' do
         expect(ns2_value).to eq('new-buz')
       end
     end
+
+    it 'works on the instance method' do
+      time = Time.local(2018, 1, 1, 15, 30, 0)
+      subject.new.expire_cache(time)
+      expect(key_storage.store).to have_key(:'foo1:lmt')
+      expect(key_storage.read(:'foo1:lmt')).to eq(time.to_i)
+    end
   end
 
   context '#cache_keyspace' do

data/spec/atomic_cache/key/keyspace_spec.rb

@@ -6,29 +6,48 @@ describe 'Keyspace' do
   subject { AtomicCache::Keyspace.new(namespace: ['foo', 'bar'], root: 'foo') }
 
   context '#initialize' do
-    it 'hashes non-primitive types' do
-      ids = [1,2,3]
-      ns1 = AtomicCache::Keyspace.new(namespace: ['foo', ids])
-      hash = ns1.send(:hexhash, ids)
-      expect(ns1.namespace).to eq(['foo', hash])
-    end
 
-    it 'leaves primitives alone' do
-      ns1 = AtomicCache::Keyspace.new(namespace: ['foo', :foo, 5])
-      expect(ns1.namespace).to eq(['foo', :foo, 5])
+    it 'sorts sortable values before hashing' do
+      ks1 = AtomicCache::Keyspace.new(namespace: ['foo', [1, 2, 3]])
+      ks2 = AtomicCache::Keyspace.new(namespace: ['foo', [3, 2, 1]])
+      expect(ks1.namespace).to eq(ks2.namespace)
     end
 
-    it 'sorts sortable values before hashing' do
-      ns1 = AtomicCache::Keyspace.new(namespace: ['foo', [1, 2, 3]])
-      ns2 = AtomicCache::Keyspace.new(namespace: ['foo', [3, 2, 1]])
-      expect(ns1.namespace).to eq(ns2.namespace)
+    context 'namespace' do
+      it 'accepts nil' do
+        ks = AtomicCache::Keyspace.new(namespace: nil)
+        expect(ks.namespace).to eq([])
+      end
+
+      it 'accepts single values' do
+        ks = AtomicCache::Keyspace.new(namespace: 'foo')
+        expect(ks.namespace).to eq(['foo'])
+      end
+
+      it 'hashes non-primitive types' do
+        ids = [1,2,3]
+        ks1 = AtomicCache::Keyspace.new(namespace: ['foo', ids])
+        hash = ks1.send(:hexhash, ids)
+        expect(ks1.namespace).to eq(['foo', hash])
+      end
+
+      it 'leaves primitives alone' do
+        ks1 = AtomicCache::Keyspace.new(namespace: ['foo', :foo, 5])
+        expect(ks1.namespace).to eq(['foo', :foo, 5])
+      end
+
+      it 'expands timestamps' do
+        formatter = Proc.new { |t| 'formatted' }
+        ks = AtomicCache::Keyspace.new(namespace: Time.new, timestamp_formatter: formatter)
+        expect(ks.namespace).to eq(['formatted'])
+      end
     end
   end
 
   context '#child' do
     it 'extends the keyspace' do
-      ns2 = subject.child([:buz, :baz])
-      expect(ns2.namespace).to eq(['foo', 'bar', :buz, :baz])
+      ks2 = subject.child([:buz, :baz])
+      expect(ks2.namespace).to eq(['foo', 'bar', :buz, :baz])
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic_cache
 version: !ruby/object:Gem::Version
-  version: 0.2.0.rc1
+  version: 0.2.0.rc2
 platform: ruby
 authors:
 - Ibotta Developers
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-28 00:00:00.000000000 Z
+date: 2018-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler