atomic-ruby 0.7.2 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df0115a62c1857c8f5c11cac42003d5ed1c91ec1c5b204d5b5cf093f25d5cab9
-  data.tar.gz: 67963d4c342b33e235a5cb320013388dc227d46311c80c1b19e029b4ff02bc1d
+  metadata.gz: ecc5a5a825a6636db5718458318ba2650c05edb9a5a1198947f82e94596a974e
+  data.tar.gz: 7a08fbdf2e3362e03450ccb5d2342055c8e50832afae4bc709c5e1c5e187f88b
 SHA512:
-  metadata.gz: e26adf803f4e798808a736eabdb86dc8d4074a71231aa2806e15f84ea5c8c6a7770cc268fb412733702fb0c540d1392e01265bf3571c3d143165f51776f72c19
-  data.tar.gz: d788e9e25c29f26050095050357ddb64b31a132bd1c9d9e13604945eec2382744a0b94e9f946d97eec6721c73fa16d83e574fc5e3e0644a3101c8b97b9b9b833
+  metadata.gz: f52cfbc19feaac870429dc893cbbf3541120e9beeaf20723d9f705b6a74835891473a299b682531d593e5adb1d2b3b75a0eed365b29e3490c1b921ea59aa4714
+  data.tar.gz: f797297e13eb693db8759e2bef195ed57288530dd05c8188b67dc1c9df1378476ed4e252b48385a2d951350e6e0f94f6b7aa3a2680d40885759d50fbdcdac1e9

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## [Unreleased]
 
+## [0.8.1] - 2025-11-01
+
+- Don't require `AtomicThreadPool#<<` to be given a shareable proc
+
+## [0.8.0] - 2025-11-01
+
+- Fix Ractor safety (requires Ruby 3.5+)
+- Make `ArgumentError` messages consistent
+- Implement write barriers for `Atom`
+
 ## [0.7.2] - 2025-10-26
 
 - Revert "Fix O(n) performance issue in `AtomicThreadPool#<<` by using linked list"

data/README.md

@@ -98,7 +98,18 @@ p latch.count #=> 0
 ```
 
 > [!NOTE]
-> `Atom`, `AtomicBoolean`, and `AtomicCountDownLatch` are also Ractor safe.
+> `Atom`, `AtomicBoolean`, and `AtomicCountDownLatch` are Ractor-safe in Ruby 3.5+.
+>
+> When storing procs in atoms, create them using `Ractor.shareable_proc`, as `Ractor.make_shareable`
+> cannot convert regular procs to shareable ones when the proc's context is not shareable.
+>
+> ```ruby
+> # This will raise an error in Ruby 3.5+ (proc created in non-shareable context)
+> atom = Atom.new(proc { puts "hello" })
+>
+> # Use this instead
+> atom = Atom.new(Ractor.shareable_proc { puts "hello" })
+> ```
 
 ## Benchmarks
 
@@ -210,9 +221,9 @@ puts "Atomic Ruby Atomic Bank Account:     #{results[2].real.round(6)} seconds"
 ```
 > bundle exec rake compile && bundle exec ruby examples/atom_benchmark.rb
 
-ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
+ruby version:            ruby 3.5.0dev (2025-10-31T18:08:15Z master 980e18496e) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.7.0
+atomic-ruby version:     0.8.0
 
 Balances:
 Synchronized Bank Account Balance:           975
@@ -220,9 +231,9 @@ Concurrent Ruby Atomic Bank Account Balance: 975
 Atomic Ruby Atomic Bank Account Balance:     975
 
 Benchmark Results:
-Synchronized Bank Account:           5.102692 seconds
-Concurrent Ruby Atomic Bank Account: 5.100103 seconds
-Atomic Ruby Atomic Bank Account:     5.096461 seconds
+Synchronized Bank Account:           5.105459 seconds
+Concurrent Ruby Atomic Bank Account: 5.101044 seconds
+Atomic Ruby Atomic Bank Account:     5.091892 seconds
 ```
 
 </details>
@@ -301,29 +312,29 @@ end
 ```
 > bundle exec rake compile && bundle exec ruby examples/atomic_boolean_benchmark.rb
 
-ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
+ruby version:            ruby 3.5.0dev (2025-10-31T18:08:15Z master 980e18496e) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.7.0
+atomic-ruby version:     0.8.0
 
 Warming up --------------------------------------
 Synchronized Boolean Toggle
-                        93.000 i/100ms
+                       154.000 i/100ms
 Concurrent Ruby Atomic Boolean Toggle
-                        79.000 i/100ms
+                       127.000 i/100ms
 Atomic Ruby Atomic Boolean Toggle
-                        87.000 i/100ms
+                       139.000 i/100ms
 Calculating -------------------------------------
 Synchronized Boolean Toggle
-                        889.613 (± 3.0%) i/s    (1.12 ms/i) -      4.464k in   5.022732s
+                          1.458k (± 7.3%) i/s  (685.85 μs/i) -      7.392k in   5.102733s
 Concurrent Ruby Atomic Boolean Toggle
-                        803.418 (± 2.5%) i/s    (1.24 ms/i) -      4.029k in   5.017952s
+                          1.129k (± 9.7%) i/s  (886.10 μs/i) -      5.588k in   5.001783s
 Atomic Ruby Atomic Boolean Toggle
-                         1.037k (± 3.1%) i/s  (964.07 μs/i) -      5.220k in   5.037558s
+                          1.476k (± 6.0%) i/s  (677.44 μs/i) -      7.367k in   5.017482s
 
 Comparison:
-Atomic Ruby Atomic Boolean Toggle:         1037.3 i/s
-Synchronized Boolean Toggle:                889.6 i/s - 1.17x  slower
-Concurrent Ruby Atomic Boolean Toggle:      803.4 i/s - 1.29x  slower
+Atomic Ruby Atomic Boolean Toggle:         1476.1 i/s
+Synchronized Boolean Toggle:               1458.1 i/s - same-ish: difference falls within error
+Concurrent Ruby Atomic Boolean Toggle:     1128.5 i/s - 1.31x  slower
 ```
 
 </details>
@@ -351,11 +362,11 @@ results = []
     end
 
     100.times do
-      pool << -> { sleep(0.2) }
+      pool << proc { sleep(0.2) }
     end
 
     100.times do
-      pool << -> { 1_000_000.times.map(&:itself).sum }
+      pool << proc { 1_000_000.times.map(&:itself).sum }
     end
 
     pool.shutdown
@@ -379,13 +390,13 @@ puts "Atomic Ruby Atomic Thread Pool: #{results[1].real.round(6)} seconds"
 ```
 > bundle exec rake compile && bundle exec ruby examples/atomic_thread_pool_benchmark.rb
 
-ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
+ruby version:            ruby 3.5.0dev (2025-10-31T18:08:15Z master 980e18496e) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.7.0
+atomic-ruby version:     0.8.1
 
 Benchmark Results:
-Concurrent Ruby Thread Pool:    5.30284 seconds
-Atomic Ruby Atomic Thread Pool: 5.019147 seconds
+Concurrent Ruby Thread Pool:    5.139026 seconds
+Atomic Ruby Atomic Thread Pool: 4.833597 seconds
 ```
 
 </details>

data/ext/atomic_ruby/atomic_ruby.c

@@ -31,20 +31,35 @@ static const rb_data_type_t atomic_ruby_atom_type = {
     .dsize = atomic_ruby_atom_memsize,
     .dcompact = atomic_ruby_atom_compact
   },
-  .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_FROZEN_SHAREABLE
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+  .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED | RUBY_TYPED_FROZEN_SHAREABLE
+#else
+  .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
+#endif
 };
 
 static VALUE rb_cAtom_allocate(VALUE klass) {
   atomic_ruby_atom_t *atomic_ruby_atom;
   VALUE obj = TypedData_Make_Struct(klass, atomic_ruby_atom_t, &atomic_ruby_atom_type, atomic_ruby_atom);
-  atomic_ruby_atom->value = Qnil;
+  RB_OBJ_WRITE(obj, &atomic_ruby_atom->value, Qnil);
   return obj;
 }
 
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+static void check_value_shareable(VALUE value) {
+  if (!rb_ractor_shareable_p(value)) {
+    rb_raise(rb_eArgError, "value must be a shareable object");
+  }
+}
+#endif
+
 static VALUE rb_cAtom_initialize(VALUE self, VALUE value) {
   atomic_ruby_atom_t *atomic_ruby_atom;
   TypedData_Get_Struct(self, atomic_ruby_atom_t, &atomic_ruby_atom_type, atomic_ruby_atom);
-  atomic_ruby_atom->value = value;
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+  check_value_shareable(value);
+#endif
+  RB_OBJ_WRITE(self, &atomic_ruby_atom->value, value);
   return self;
 }
 
@@ -62,13 +77,17 @@ static VALUE rb_cAtom_swap(VALUE self) {
   do {
     expected_old_value = atomic_ruby_atom->value;
     new_value = rb_yield(expected_old_value);
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+    check_value_shareable(new_value);
+#endif
   } while (RUBY_ATOMIC_VALUE_CAS(atomic_ruby_atom->value, expected_old_value, new_value) != expected_old_value);
+  RB_OBJ_WRITTEN(self, expected_old_value, new_value);
 
   return new_value;
 }
 
 RUBY_FUNC_EXPORTED void Init_atomic_ruby(void) {
-#ifdef HAVE_RB_EXT_RACTOR_SAFE
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
   rb_ext_ractor_safe(true);
 #endif
 
@@ -79,4 +98,10 @@ RUBY_FUNC_EXPORTED void Init_atomic_ruby(void) {
   rb_define_method(rb_cAtom, "_initialize", rb_cAtom_initialize, 1);
   rb_define_method(rb_cAtom, "_value", rb_cAtom_value, 0);
   rb_define_method(rb_cAtom, "_swap", rb_cAtom_swap, 0);
+
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+  rb_define_const(rb_mAtomicRuby, "RACTOR_SAFE", Qtrue);
+#else
+  rb_define_const(rb_mAtomicRuby, "RACTOR_SAFE", Qfalse);
+#endif
 }

data/ext/atomic_ruby/atomic_ruby.h

@@ -3,5 +3,11 @@
 
 #include "ruby.h"
 #include "ruby/atomic.h"
+#include "ruby/ractor.h"
+#include "ruby/version.h"
+
+#if RUBY_API_VERSION_CODE >= 30500
+#define ATOMIC_RUBY_RACTOR_SAFE 1
+#endif
 
 #endif /* ATOMIC_RUBY_ATOM_H */

data/lib/atomic-ruby/atom.rb

@@ -5,9 +5,9 @@ require "atomic_ruby/atomic_ruby"
 module AtomicRuby
   class Atom
     def initialize(value)
-      _initialize(value)
+      _initialize(make_shareable(value))
 
-      Ractor.make_shareable(self)
+      freeze if RACTOR_SAFE
     end
 
     def value
@@ -15,7 +15,19 @@ module AtomicRuby
     end
 
     def swap(&block)
-      _swap(&block)
+      _swap do |old_value|
+        make_shareable(block.call(old_value))
+      end
+    end
+
+    private
+
+    def make_shareable(value)
+      if RACTOR_SAFE
+        Ractor.make_shareable(value)
+      else
+        value
+      end
     end
   end
 end

data/lib/atomic-ruby/atomic_boolean.rb

@@ -6,12 +6,12 @@ module AtomicRuby
   class AtomicBoolean
     def initialize(boolean)
       unless boolean.is_a?(TrueClass) || boolean.is_a?(FalseClass)
-        raise ArgumentError, "boolean must be a TrueClass or FalseClass, got #{boolean.class}"
+        raise ArgumentError, "boolean must be a TrueClass or FalseClass"
       end
 
       @boolean = Atom.new(boolean)
 
-      Ractor.make_shareable(self)
+      Ractor.make_shareable(self) if RACTOR_SAFE
     end
 
     def value

data/lib/atomic-ruby/atomic_count_down_latch.rb

@@ -9,12 +9,12 @@ module AtomicRuby
 
     def initialize(count)
       unless count.is_a?(Integer) && count > 0
-        raise ArgumentError, "count must be a positive Integer, got #{count.class}"
+        raise ArgumentError, "count must be a positive Integer"
       end
 
       @count = Atom.new(count)
 
-      Ractor.make_shareable(self)
+      Ractor.make_shareable(self) if RACTOR_SAFE
     end
 
     def count
@@ -32,7 +32,7 @@ module AtomicRuby
         end
       end
       raise AlreadyCountedDownError, "already counted down to zero" if already_counted_down
-      
+
       new_count
     end
 

data/lib/atomic-ruby/atomic_thread_pool.rb

@@ -17,7 +17,8 @@ module AtomicRuby
       @size = size
       @name = name
 
-      @state = Atom.new(queue: [], shutdown: false)
+      @queue = Queue.new
+      @state = Atom.new(shutdown: false)
       @started_threads = Atom.new(0)
       @threads = []
 
@@ -26,11 +27,8 @@ module AtomicRuby
 
     def <<(work)
       state = @state.swap do |current_state|
-        if current_state[:shutdown]
-          current_state
-        else
-          current_state.merge(queue: [*current_state[:queue], work])
-        end
+        @queue.push(work) unless current_state[:shutdown]
+        current_state
       end
       raise EnqueuedWorkAfterShutdownError if state[:shutdown]
     end
@@ -40,7 +38,7 @@ module AtomicRuby
     end
 
     def queue_length
-      @state.value[:queue].length
+      @queue.size
     end
 
     def shutdown
@@ -55,7 +53,7 @@ module AtomicRuby
       end
       return if already_shutdown
 
-      Thread.pass until @state.value[:queue].empty?
+      Thread.pass until @queue.empty?
 
       @threads.each(&:join)
     end
@@ -76,15 +74,12 @@ module AtomicRuby
             should_shutdown = false
 
             @state.swap do |current_state|
-              if current_state[:shutdown] && current_state[:queue].empty?
+              if current_state[:shutdown] && @queue.empty?
                 should_shutdown = true
-                current_state
-              elsif current_state[:queue].empty?
-                current_state
               else
-                work = current_state[:queue].first
-                current_state.merge(queue: current_state[:queue].drop(1))
+                work = @queue.pop(timeout: 0)
               end
+              current_state
             end
 
             if should_shutdown

data/lib/atomic-ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicRuby
-  VERSION = "0.7.2"
+  VERSION = "0.8.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic-ruby
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.1
 platform: ruby
 authors:
 - Joshua Young
@@ -50,7 +50,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.2
+rubygems_version: 4.0.0.dev
 specification_version: 4
 summary: Atomic primitives for Ruby
 test_files: []