atomic-ruby 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed78c53bc97b5e75c87c0d41a6ca9c5ba86688acb0eafff182cdba2b45c1134b
-  data.tar.gz: 143b41531bde38087ce81761977d7b283ed066880641370e25543424cf163a41
+  metadata.gz: 9e35d6cd7774994256c00cbf310fa5511aaafac0c55e4b0919102f22b444961d
+  data.tar.gz: 763d472bdc50d97522f9a9f630f6d51f2db4832f9d507ca27d0f6dbae761ca54
 SHA512:
-  metadata.gz: 6ff9bf98c45ba8f404fbab1908befbb2a703d3067cf0739c7265996e7c7840a7bc8c8ffe5a6cbfe8608960679f3e6ba716f773e790c333420fe35f5b251355ec
-  data.tar.gz: df712bfcc529dc67e3017204da3670a7502e438a4706befcfa7c595f37c6d8024ed33f35d061fa7beaa4cd2680fe263b319747177aa59a978888fbf2ee621cdb
+  metadata.gz: a39511160e42082e08f9d435a29ffe658325d0e93fa10818a6f60b5f54882bf698ce2d2dcd655a6cbde19bea9cd7ebc2ede86fd8ff5e70e95bb94750400a7f36
+  data.tar.gz: 89800c8d9fe359a497be8a71c463e3d22ef1585752d3320c85aeae0051634b41f70c78ace27502b452231b088de4a8e359ac7ab5be8ffa71836cdf564c9c2240

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## [Unreleased]
 
+## [0.8.0] - 2025-11-01
+
+- Fix Ractor safety (requires Ruby 3.5+)
+- Make `ArgumentError` messages consistent
+- Implement write barriers for `Atom`
+
+## [0.7.2] - 2025-10-26
+
+- Revert "Fix O(n) performance issue in `AtomicThreadPool#<<` by using linked list"
+
 ## [0.7.1] - 2025-10-26
 
 - Fix O(n) performance issue in `AtomicThreadPool#<<` by using linked list

data/README.md

@@ -98,7 +98,19 @@ p latch.count #=> 0
 ```
 
 > [!NOTE]
-> `Atom`, `AtomicBoolean`, and `AtomicCountDownLatch` are also Ractor safe.
+> `Atom`, `AtomicBoolean`, and `AtomicCountDownLatch` are Ractor-safe in Ruby 3.5+.
+>
+> When storing procs in atoms (including queueing them with `AtomicThreadPool#<<`), create them
+> using `Ractor.shareable_proc`, as `Ractor.make_shareable` cannot convert regular procs to
+> shareable ones when the proc's context is not shareable.
+>
+> ```ruby
+> # This will raise an error in Ruby 3.5+ (proc created in non-shareable context)
+> atom = Atom.new(proc { puts "hello" })
+>
+> # Use this instead
+> atom = Atom.new(Ractor.shareable_proc { puts "hello" })
+> ```
 
 ## Benchmarks
 
@@ -210,9 +222,9 @@ puts "Atomic Ruby Atomic Bank Account:     #{results[2].real.round(6)} seconds"
 ```
 > bundle exec rake compile && bundle exec ruby examples/atom_benchmark.rb
 
-ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
+ruby version:            ruby 3.5.0dev (2025-10-31T18:08:15Z master 980e18496e) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.7.0
+atomic-ruby version:     0.8.0
 
 Balances:
 Synchronized Bank Account Balance:           975
@@ -220,9 +232,9 @@ Concurrent Ruby Atomic Bank Account Balance: 975
 Atomic Ruby Atomic Bank Account Balance:     975
 
 Benchmark Results:
-Synchronized Bank Account:           5.102692 seconds
-Concurrent Ruby Atomic Bank Account: 5.100103 seconds
-Atomic Ruby Atomic Bank Account:     5.096461 seconds
+Synchronized Bank Account:           5.105459 seconds
+Concurrent Ruby Atomic Bank Account: 5.101044 seconds
+Atomic Ruby Atomic Bank Account:     5.091892 seconds
 ```
 
 </details>
@@ -301,29 +313,29 @@ end
 ```
 > bundle exec rake compile && bundle exec ruby examples/atomic_boolean_benchmark.rb
 
-ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
+ruby version:            ruby 3.5.0dev (2025-10-31T18:08:15Z master 980e18496e) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.7.0
+atomic-ruby version:     0.8.0
 
 Warming up --------------------------------------
 Synchronized Boolean Toggle
-                        93.000 i/100ms
+                       154.000 i/100ms
 Concurrent Ruby Atomic Boolean Toggle
-                        79.000 i/100ms
+                       127.000 i/100ms
 Atomic Ruby Atomic Boolean Toggle
-                        87.000 i/100ms
+                       139.000 i/100ms
 Calculating -------------------------------------
 Synchronized Boolean Toggle
-                        889.613 (± 3.0%) i/s    (1.12 ms/i) -      4.464k in   5.022732s
+                          1.458k (± 7.3%) i/s  (685.85 μs/i) -      7.392k in   5.102733s
 Concurrent Ruby Atomic Boolean Toggle
-                        803.418 (± 2.5%) i/s    (1.24 ms/i) -      4.029k in   5.017952s
+                          1.129k (± 9.7%) i/s  (886.10 μs/i) -      5.588k in   5.001783s
 Atomic Ruby Atomic Boolean Toggle
-                         1.037k (± 3.1%) i/s  (964.07 μs/i) -      5.220k in   5.037558s
+                          1.476k (± 6.0%) i/s  (677.44 μs/i) -      7.367k in   5.017482s
 
 Comparison:
-Atomic Ruby Atomic Boolean Toggle:         1037.3 i/s
-Synchronized Boolean Toggle:                889.6 i/s - 1.17x  slower
-Concurrent Ruby Atomic Boolean Toggle:      803.4 i/s - 1.29x  slower
+Atomic Ruby Atomic Boolean Toggle:         1476.1 i/s
+Synchronized Boolean Toggle:               1458.1 i/s - same-ish: difference falls within error
+Concurrent Ruby Atomic Boolean Toggle:     1128.5 i/s - 1.31x  slower
 ```
 
 </details>
@@ -341,6 +353,14 @@ require "benchmark"
 require "concurrent-ruby"
 require_relative "../lib/atomic-ruby"
 
+def shareable_proc(&block)
+  if AtomicRuby::RACTOR_SAFE
+    Ractor.shareable_proc(&block)
+  else
+    block
+  end
+end
+
 results = []
 
 2.times do |idx|
@@ -351,11 +371,11 @@ results = []
     end
 
     100.times do
-      pool << -> { sleep(0.2) }
+      pool << shareable_proc { sleep(0.2) }
     end
 
     100.times do
-      pool << -> { 1_000_000.times.map(&:itself).sum }
+      pool << shareable_proc { 1_000_000.times.map(&:itself).sum }
     end
 
     pool.shutdown
@@ -379,13 +399,13 @@ puts "Atomic Ruby Atomic Thread Pool: #{results[1].real.round(6)} seconds"
 ```
 > bundle exec rake compile && bundle exec ruby examples/atomic_thread_pool_benchmark.rb
 
-ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
+ruby version:            ruby 3.5.0dev (2025-10-31T18:08:15Z master 980e18496e) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.7.0
+atomic-ruby version:     0.8.0
 
 Benchmark Results:
-Concurrent Ruby Thread Pool:    4.802586 seconds
-Atomic Ruby Atomic Thread Pool: 4.466127 seconds
+Concurrent Ruby Thread Pool:    5.13772 seconds
+Atomic Ruby Atomic Thread Pool: 4.893086 seconds
 ```
 
 </details>

data/ext/atomic_ruby/atomic_ruby.c

@@ -31,20 +31,35 @@ static const rb_data_type_t atomic_ruby_atom_type = {
     .dsize = atomic_ruby_atom_memsize,
     .dcompact = atomic_ruby_atom_compact
   },
-  .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_FROZEN_SHAREABLE
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+  .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED | RUBY_TYPED_FROZEN_SHAREABLE
+#else
+  .flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
+#endif
 };
 
 static VALUE rb_cAtom_allocate(VALUE klass) {
   atomic_ruby_atom_t *atomic_ruby_atom;
   VALUE obj = TypedData_Make_Struct(klass, atomic_ruby_atom_t, &atomic_ruby_atom_type, atomic_ruby_atom);
-  atomic_ruby_atom->value = Qnil;
+  RB_OBJ_WRITE(obj, &atomic_ruby_atom->value, Qnil);
   return obj;
 }
 
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+static void check_value_shareable(VALUE value) {
+  if (!rb_ractor_shareable_p(value)) {
+    rb_raise(rb_eArgError, "value must be a shareable object");
+  }
+}
+#endif
+
 static VALUE rb_cAtom_initialize(VALUE self, VALUE value) {
   atomic_ruby_atom_t *atomic_ruby_atom;
   TypedData_Get_Struct(self, atomic_ruby_atom_t, &atomic_ruby_atom_type, atomic_ruby_atom);
-  atomic_ruby_atom->value = value;
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+  check_value_shareable(value);
+#endif
+  RB_OBJ_WRITE(self, &atomic_ruby_atom->value, value);
   return self;
 }
 
@@ -62,13 +77,17 @@ static VALUE rb_cAtom_swap(VALUE self) {
   do {
     expected_old_value = atomic_ruby_atom->value;
     new_value = rb_yield(expected_old_value);
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+    check_value_shareable(new_value);
+#endif
   } while (RUBY_ATOMIC_VALUE_CAS(atomic_ruby_atom->value, expected_old_value, new_value) != expected_old_value);
+  RB_OBJ_WRITTEN(self, expected_old_value, new_value);
 
   return new_value;
 }
 
 RUBY_FUNC_EXPORTED void Init_atomic_ruby(void) {
-#ifdef HAVE_RB_EXT_RACTOR_SAFE
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
   rb_ext_ractor_safe(true);
 #endif
 
@@ -79,4 +98,10 @@ RUBY_FUNC_EXPORTED void Init_atomic_ruby(void) {
   rb_define_method(rb_cAtom, "_initialize", rb_cAtom_initialize, 1);
   rb_define_method(rb_cAtom, "_value", rb_cAtom_value, 0);
   rb_define_method(rb_cAtom, "_swap", rb_cAtom_swap, 0);
+
+#ifdef ATOMIC_RUBY_RACTOR_SAFE
+  rb_define_const(rb_mAtomicRuby, "RACTOR_SAFE", Qtrue);
+#else
+  rb_define_const(rb_mAtomicRuby, "RACTOR_SAFE", Qfalse);
+#endif
 }

data/ext/atomic_ruby/atomic_ruby.h

@@ -3,5 +3,11 @@
 
 #include "ruby.h"
 #include "ruby/atomic.h"
+#include "ruby/ractor.h"
+#include "ruby/version.h"
+
+#if RUBY_API_VERSION_CODE >= 30500
+#define ATOMIC_RUBY_RACTOR_SAFE 1
+#endif
 
 #endif /* ATOMIC_RUBY_ATOM_H */

data/lib/atomic-ruby/atom.rb

@@ -5,9 +5,9 @@ require "atomic_ruby/atomic_ruby"
 module AtomicRuby
   class Atom
     def initialize(value)
-      _initialize(value)
+      _initialize(make_shareable(value))
 
-      Ractor.make_shareable(self)
+      freeze if RACTOR_SAFE
     end
 
     def value
@@ -15,7 +15,19 @@ module AtomicRuby
     end
 
     def swap(&block)
-      _swap(&block)
+      _swap do |old_value|
+        make_shareable(block.call(old_value))
+      end
+    end
+
+    private
+
+    def make_shareable(value)
+      if RACTOR_SAFE
+        Ractor.make_shareable(value)
+      else
+        value
+      end
     end
   end
 end

data/lib/atomic-ruby/atomic_boolean.rb

@@ -6,12 +6,12 @@ module AtomicRuby
   class AtomicBoolean
     def initialize(boolean)
       unless boolean.is_a?(TrueClass) || boolean.is_a?(FalseClass)
-        raise ArgumentError, "boolean must be a TrueClass or FalseClass, got #{boolean.class}"
+        raise ArgumentError, "boolean must be a TrueClass or FalseClass"
       end
 
       @boolean = Atom.new(boolean)
 
-      Ractor.make_shareable(self)
+      Ractor.make_shareable(self) if RACTOR_SAFE
     end
 
     def value

data/lib/atomic-ruby/atomic_count_down_latch.rb

@@ -9,12 +9,12 @@ module AtomicRuby
 
     def initialize(count)
       unless count.is_a?(Integer) && count > 0
-        raise ArgumentError, "count must be a positive Integer, got #{count.class}"
+        raise ArgumentError, "count must be a positive Integer"
       end
 
       @count = Atom.new(count)
 
-      Ractor.make_shareable(self)
+      Ractor.make_shareable(self) if RACTOR_SAFE
     end
 
     def count
@@ -32,7 +32,7 @@ module AtomicRuby
         end
       end
       raise AlreadyCountedDownError, "already counted down to zero" if already_counted_down
-      
+
       new_count
     end
 

data/lib/atomic-ruby/atomic_thread_pool.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "atom"
-require_relative "linked_list"
 
 module AtomicRuby
   class AtomicThreadPool
@@ -18,7 +17,7 @@ module AtomicRuby
       @size = size
       @name = name
 
-      @state = Atom.new(queue: LinkedList.new, shutdown: false)
+      @state = Atom.new(queue: [], shutdown: false)
       @started_threads = Atom.new(0)
       @threads = []
 
@@ -30,7 +29,7 @@ module AtomicRuby
         if current_state[:shutdown]
           current_state
         else
-          current_state.merge(queue: current_state[:queue].prepend(work))
+          current_state.merge(queue: [*current_state[:queue], work])
         end
       end
       raise EnqueuedWorkAfterShutdownError if state[:shutdown]
@@ -84,7 +83,7 @@ module AtomicRuby
                 current_state
               else
                 work = current_state[:queue].first
-                current_state.merge(queue: current_state[:queue].rest)
+                current_state.merge(queue: current_state[:queue].drop(1))
               end
             end
 

data/lib/atomic-ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicRuby
-  VERSION = "0.7.1"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic-ruby
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Joshua Young
@@ -29,7 +29,6 @@ files:
 - lib/atomic-ruby/atomic_boolean.rb
 - lib/atomic-ruby/atomic_count_down_latch.rb
 - lib/atomic-ruby/atomic_thread_pool.rb
-- lib/atomic-ruby/linked_list.rb
 - lib/atomic-ruby/version.rb
 homepage: https://github.com/joshuay03/atomic-ruby
 licenses:
@@ -51,7 +50,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.2
+rubygems_version: 4.0.0.dev
 specification_version: 4
 summary: Atomic primitives for Ruby
 test_files: []

data/lib/atomic-ruby/linked_list.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module AtomicRuby
-  class LinkedList
-    Node = Data.define(:value, :next_node)
-
-    def initialize(head = nil)
-      @head = head
-    end
-
-    def prepend(value)
-      self.class.new(Node.new(value, @head))
-    end
-
-    def first
-      @head&.value
-    end
-
-    def rest
-      self.class.new(@head&.next_node)
-    end
-
-    def empty?
-      @head.nil?
-    end
-
-    def length
-      count = 0
-      current = @head
-      while current
-        count += 1
-        current = current.next_node
-      end
-      count
-    end
-  end
-end