atomic-ruby 0.6.6 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71ab1390a71e724460d0331491b033a45d4dd1fb19308d62ffdcbf68bf68b149
-  data.tar.gz: e19d576cd3ad1756ea5b429b6d57ab5e34402b3cf19674c597abc80a9f4b5f36
+  metadata.gz: ed78c53bc97b5e75c87c0d41a6ca9c5ba86688acb0eafff182cdba2b45c1134b
+  data.tar.gz: 143b41531bde38087ce81761977d7b283ed066880641370e25543424cf163a41
 SHA512:
-  metadata.gz: b0db49db3fde19a7a6c7fe3adc58f999943b09e2074b88a79489ad6103712c2c4c2abf88a0d73ab1c7fe9e51dffeaa24c18c5d5519738d71d5fe8d7512855a5e
-  data.tar.gz: f2d93730a210f1886d83c9971be5fa73acd8fa754c727008fd355899dc9cb2dfe90bb1fb7791663e2457f37b2adc74078a71f8f812c0f105132bcc7f68994468
+  metadata.gz: 6ff9bf98c45ba8f404fbab1908befbb2a703d3067cf0739c7265996e7c7840a7bc8c8ffe5a6cbfe8608960679f3e6ba716f773e790c333420fe35f5b251355ec
+  data.tar.gz: df712bfcc529dc67e3017204da3670a7502e438a4706befcfa7c595f37c6d8024ed33f35d061fa7beaa4cd2680fe263b319747177aa59a978888fbf2ee621cdb

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [0.7.1] - 2025-10-26
+
+- Fix O(n) performance issue in `AtomicThreadPool#<<` by using linked list
+
+## [0.7.0] - 2025-10-20
+
+- Improve thread safety, performance, and error handling across atomic classes
+
 ## [0.6.6] - 2025-10-16
 
 - Fix individual file requires

data/README.md

@@ -212,7 +212,7 @@ puts "Atomic Ruby Atomic Bank Account:     #{results[2].real.round(6)} seconds"
 
 ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.6.4
+atomic-ruby version:     0.7.0
 
 Balances:
 Synchronized Bank Account Balance:           975
@@ -220,9 +220,9 @@ Concurrent Ruby Atomic Bank Account Balance: 975
 Atomic Ruby Atomic Bank Account Balance:     975
 
 Benchmark Results:
-Synchronized Bank Account:           5.110797 seconds
-Concurrent Ruby Atomic Bank Account: 5.118082 seconds
-Atomic Ruby Atomic Bank Account:     5.087287 seconds
+Synchronized Bank Account:           5.102692 seconds
+Concurrent Ruby Atomic Bank Account: 5.100103 seconds
+Atomic Ruby Atomic Bank Account:     5.096461 seconds
 ```
 
 </details>
@@ -303,27 +303,27 @@ end
 
 ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.6.4
+atomic-ruby version:     0.7.0
 
 Warming up --------------------------------------
 Synchronized Boolean Toggle
-                       103.000 i/100ms
+                        93.000 i/100ms
 Concurrent Ruby Atomic Boolean Toggle
-                        84.000 i/100ms
+                        79.000 i/100ms
 Atomic Ruby Atomic Boolean Toggle
-                       115.000 i/100ms
+                        87.000 i/100ms
 Calculating -------------------------------------
 Synchronized Boolean Toggle
-                          1.052k (± 3.9%) i/s  (950.20 μs/i) -      5.356k in   5.097149s
+                        889.613 (± 3.0%) i/s    (1.12 ms/i) -      4.464k in   5.022732s
 Concurrent Ruby Atomic Boolean Toggle
-                        872.073 (± 3.2%) i/s    (1.15 ms/i) -      4.368k in   5.013857s
+                        803.418 (± 2.5%) i/s    (1.24 ms/i) -      4.029k in   5.017952s
 Atomic Ruby Atomic Boolean Toggle
-                          1.214k (± 1.5%) i/s  (823.94 μs/i) -      6.095k in   5.023014s
+                         1.037k (± 3.1%) i/s  (964.07 μs/i) -      5.220k in   5.037558s
 
 Comparison:
-Atomic Ruby Atomic Boolean Toggle:     1213.7 i/s
-Synchronized Boolean Toggle:     1052.4 i/s - 1.15x  slower
-Concurrent Ruby Atomic Boolean Toggle:      872.1 i/s - 1.39x  slower
+Atomic Ruby Atomic Boolean Toggle:         1037.3 i/s
+Synchronized Boolean Toggle:                889.6 i/s - 1.17x  slower
+Concurrent Ruby Atomic Boolean Toggle:      803.4 i/s - 1.29x  slower
 ```
 
 </details>
@@ -381,11 +381,11 @@ puts "Atomic Ruby Atomic Thread Pool: #{results[1].real.round(6)} seconds"
 
 ruby version:            ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +YJIT +PRISM [arm64-darwin25]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.6.4
+atomic-ruby version:     0.7.0
 
 Benchmark Results:
-Concurrent Ruby Thread Pool:    4.768847 seconds
-Atomic Ruby Atomic Thread Pool: 4.401936 seconds
+Concurrent Ruby Thread Pool:    4.802586 seconds
+Atomic Ruby Atomic Thread Pool: 4.466127 seconds
 ```
 
 </details>

data/lib/atomic-ruby/atomic_boolean.rb

@@ -4,14 +4,12 @@ require_relative "atom"
 
 module AtomicRuby
   class AtomicBoolean
-    class InvalidBooleanError < StandardError; end
-
-    def initialize(value)
-      unless value.is_a?(TrueClass) || value.is_a?(FalseClass)
-        raise InvalidBooleanError, "expected boolean to be a `TrueClass` or `FalseClass`, got #{value.class}"
+    def initialize(boolean)
+      unless boolean.is_a?(TrueClass) || boolean.is_a?(FalseClass)
+        raise ArgumentError, "boolean must be a TrueClass or FalseClass, got #{boolean.class}"
       end
 
-      @boolean = Atom.new(value)
+      @boolean = Atom.new(boolean)
 
       Ractor.make_shareable(self)
     end

data/lib/atomic-ruby/atomic_count_down_latch.rb

@@ -4,12 +4,12 @@ require_relative "atom"
 
 module AtomicRuby
   class AtomicCountDownLatch
-    class InvalidCountError < StandardError; end
-    class AlreadyCountedDownError < StandardError; end
+    class Error < StandardError; end
+    class AlreadyCountedDownError < Error; end
 
     def initialize(count)
-      unless count.is_a?(Integer)
-        raise InvalidCountError, "expected count to be an `Integer`, got #{count.class}"
+      unless count.is_a?(Integer) && count > 0
+        raise ArgumentError, "count must be a positive Integer, got #{count.class}"
       end
 
       @count = Atom.new(count)
@@ -22,11 +22,18 @@ module AtomicRuby
     end
 
     def count_down
-      unless @count.value > 0
-        raise AlreadyCountedDownError, "count has already reached zero"
+      already_counted_down = false
+      new_count = @count.swap do |current_count|
+        if current_count == 0
+          already_counted_down = true
+          current_count
+        else
+          current_count - 1
+        end
       end
-
-      @count.swap { |current_value| current_value - 1 }
+      raise AlreadyCountedDownError, "already counted down to zero" if already_counted_down
+      
+      new_count
     end
 
     def wait

data/lib/atomic-ruby/atomic_thread_pool.rb

@@ -1,35 +1,39 @@
 # frozen_string_literal: true
 
 require_relative "atom"
-require_relative "atomic_boolean"
+require_relative "linked_list"
 
 module AtomicRuby
   class AtomicThreadPool
-    class UnsupportedWorkTypeError < StandardError; end
-    class InvalidWorkQueueingError < StandardError; end
+    class Error < StandardError; end
+
+    class EnqueuedWorkAfterShutdownError < Error
+      def message = "cannot queue work after shutdown"
+    end
 
     def initialize(size:, name: nil)
+      raise ArgumentError, "size must be a positive Integer" unless size.is_a?(Integer) && size > 0
+      raise ArgumentError, "name must be a String" unless name.nil? || name.is_a?(String)
+
       @size = size
       @name = name
-      @queue = Atom.new([])
-      @threads = []
+
+      @state = Atom.new(queue: LinkedList.new, shutdown: false)
       @started_threads = Atom.new(0)
-      @stopping = AtomicBoolean.new(false)
+      @threads = []
 
       start
     end
 
     def <<(work)
-      unless work.is_a?(Proc) || work == :stop
-        raise UnsupportedWorkTypeError, "expected work to be a `Proc`, got #{work.class}"
-      end
-
-      if @stopping.true?
-        raise InvalidWorkQueueingError, "cannot queue work during or after pool shutdown"
+      state = @state.swap do |current_state|
+        if current_state[:shutdown]
+          current_state
+        else
+          current_state.merge(queue: current_state[:queue].prepend(work))
+        end
       end
-
-      @queue.swap { |current_queue| current_queue += [work] }
-      true
+      raise EnqueuedWorkAfterShutdownError if state[:shutdown]
     end
 
     def length
@@ -37,20 +41,31 @@ module AtomicRuby
     end
 
     def queue_length
-      @queue.value.length
+      @state.value[:queue].length
     end
 
     def shutdown
-      self << :stop
+      already_shutdown = false
+      @state.swap do |current_state|
+        if current_state[:shutdown]
+          already_shutdown = true
+          current_state
+        else
+          current_state.merge(shutdown: true)
+        end
+      end
+      return if already_shutdown
+
+      Thread.pass until @state.value[:queue].empty?
+
       @threads.each(&:join)
-      true
     end
 
     private
 
     def start
-      @threads = @size.times.map do |num|
-        Thread.new(num) do |idx|
+      @size.times do |num|
+        @threads << Thread.new(num) do |idx|
           thread_name = String.new("AtomicThreadPool thread #{idx}")
           thread_name << " for #{@name}" if @name
           Thread.current.name = thread_name
@@ -59,9 +74,23 @@ module AtomicRuby
 
           loop do
             work = nil
-            @queue.swap { |current_queue| work = current_queue.last; current_queue[0..-2] }
-            case work
-            when Proc
+            should_shutdown = false
+
+            @state.swap do |current_state|
+              if current_state[:shutdown] && current_state[:queue].empty?
+                should_shutdown = true
+                current_state
+              elsif current_state[:queue].empty?
+                current_state
+              else
+                work = current_state[:queue].first
+                current_state.merge(queue: current_state[:queue].rest)
+              end
+            end
+
+            if should_shutdown
+              break
+            elsif work
               begin
                 work.call
               rescue => err
@@ -69,18 +98,13 @@ module AtomicRuby
                 puts "#{err.class}: #{err.message}"
                 puts err.backtrace.join("\n")
               end
-            when :stop
-              @stopping.make_true
-            when NilClass
-              if @stopping.true?
-                break
-              else
-                Thread.pass
-              end
+            else
+              Thread.pass
             end
           end
         end
       end
+      @threads.freeze
 
       Thread.pass until @started_threads.value == @size
     end

data/lib/atomic-ruby/linked_list.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module AtomicRuby
+  class LinkedList
+    Node = Data.define(:value, :next_node)
+
+    def initialize(head = nil)
+      @head = head
+    end
+
+    def prepend(value)
+      self.class.new(Node.new(value, @head))
+    end
+
+    def first
+      @head&.value
+    end
+
+    def rest
+      self.class.new(@head&.next_node)
+    end
+
+    def empty?
+      @head.nil?
+    end
+
+    def length
+      count = 0
+      current = @head
+      while current
+        count += 1
+        current = current.next_node
+      end
+      count
+    end
+  end
+end

data/lib/atomic-ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicRuby
-  VERSION = "0.6.6"
+  VERSION = "0.7.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic-ruby
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.7.1
 platform: ruby
 authors:
 - Joshua Young
@@ -29,6 +29,7 @@ files:
 - lib/atomic-ruby/atomic_boolean.rb
 - lib/atomic-ruby/atomic_count_down_latch.rb
 - lib/atomic-ruby/atomic_thread_pool.rb
+- lib/atomic-ruby/linked_list.rb
 - lib/atomic-ruby/version.rb
 homepage: https://github.com/joshuay03/atomic-ruby
 licenses:
@@ -50,7 +51,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.7.2
 specification_version: 4
 summary: Atomic primitives for Ruby
 test_files: []