atomic-ruby 0.6.6 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71ab1390a71e724460d0331491b033a45d4dd1fb19308d62ffdcbf68bf68b149
-  data.tar.gz: e19d576cd3ad1756ea5b429b6d57ab5e34402b3cf19674c597abc80a9f4b5f36
+  metadata.gz: 673339dcf17f8da8f0f34326cb31a5a1514b820b4c31229f0022290f50c0a7fe
+  data.tar.gz: 289ebbf398e1f2a9bc2b58623680525c02b57056789a589c329f51977b46c250
 SHA512:
-  metadata.gz: b0db49db3fde19a7a6c7fe3adc58f999943b09e2074b88a79489ad6103712c2c4c2abf88a0d73ab1c7fe9e51dffeaa24c18c5d5519738d71d5fe8d7512855a5e
-  data.tar.gz: f2d93730a210f1886d83c9971be5fa73acd8fa754c727008fd355899dc9cb2dfe90bb1fb7791663e2457f37b2adc74078a71f8f812c0f105132bcc7f68994468
+  metadata.gz: 5d495876e6706f589bbe91dcea4ad2ba71ab525b32ad897cdd6762de2a3451de91874c7446d8a439323e316d6b13f9748f19f304871a435916deb40e2f9239f6
+  data.tar.gz: be35ad1d840b4ea84eecf942087571a7f78b44bb04b3365f18491fed64fc2b5d3fb2182a614a05ad66b55e723c39680d7aa19810aa57bcd24a0166971bd1761c

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.7.0] - 2025-10-20
+
+- Improve thread safety, performance, and error handling across atomic classes
+
 ## [0.6.6] - 2025-10-16
 
 - Fix individual file requires

data/lib/atomic-ruby/atomic_boolean.rb

@@ -4,14 +4,12 @@ require_relative "atom"
 
 module AtomicRuby
   class AtomicBoolean
-    class InvalidBooleanError < StandardError; end
-
-    def initialize(value)
-      unless value.is_a?(TrueClass) || value.is_a?(FalseClass)
-        raise InvalidBooleanError, "expected boolean to be a `TrueClass` or `FalseClass`, got #{value.class}"
+    def initialize(boolean)
+      unless boolean.is_a?(TrueClass) || boolean.is_a?(FalseClass)
+        raise ArgumentError, "boolean must be a TrueClass or FalseClass, got #{boolean.class}"
       end
 
-      @boolean = Atom.new(value)
+      @boolean = Atom.new(boolean)
 
       Ractor.make_shareable(self)
     end

data/lib/atomic-ruby/atomic_count_down_latch.rb

@@ -4,12 +4,12 @@ require_relative "atom"
 
 module AtomicRuby
   class AtomicCountDownLatch
-    class InvalidCountError < StandardError; end
-    class AlreadyCountedDownError < StandardError; end
+    class Error < StandardError; end
+    class AlreadyCountedDownError < Error; end
 
     def initialize(count)
-      unless count.is_a?(Integer)
-        raise InvalidCountError, "expected count to be an `Integer`, got #{count.class}"
+      unless count.is_a?(Integer) && count > 0
+        raise ArgumentError, "count must be a positive Integer, got #{count.class}"
       end
 
       @count = Atom.new(count)
@@ -22,11 +22,18 @@ module AtomicRuby
     end
 
     def count_down
-      unless @count.value > 0
-        raise AlreadyCountedDownError, "count has already reached zero"
+      already_counted_down = false
+      new_count = @count.swap do |current_count|
+        if current_count == 0
+          already_counted_down = true
+          current_count
+        else
+          current_count - 1
+        end
       end
-
-      @count.swap { |current_value| current_value - 1 }
+      raise AlreadyCountedDownError, "already counted down to zero" if already_counted_down
+      
+      new_count
     end
 
     def wait

data/lib/atomic-ruby/atomic_thread_pool.rb

@@ -1,35 +1,38 @@
 # frozen_string_literal: true
 
 require_relative "atom"
-require_relative "atomic_boolean"
 
 module AtomicRuby
   class AtomicThreadPool
-    class UnsupportedWorkTypeError < StandardError; end
-    class InvalidWorkQueueingError < StandardError; end
+    class Error < StandardError; end
+
+    class EnqueuedWorkAfterShutdownError < Error
+      def message = "cannot queue work after shutdown"
+    end
 
     def initialize(size:, name: nil)
+      raise ArgumentError, "size must be a positive Integer" unless size.is_a?(Integer) && size > 0
+      raise ArgumentError, "name must be a String" unless name.nil? || name.is_a?(String)
+
       @size = size
       @name = name
-      @queue = Atom.new([])
-      @threads = []
+
+      @state = Atom.new(queue: [], shutdown: false)
       @started_threads = Atom.new(0)
-      @stopping = AtomicBoolean.new(false)
+      @threads = []
 
       start
     end
 
     def <<(work)
-      unless work.is_a?(Proc) || work == :stop
-        raise UnsupportedWorkTypeError, "expected work to be a `Proc`, got #{work.class}"
-      end
-
-      if @stopping.true?
-        raise InvalidWorkQueueingError, "cannot queue work during or after pool shutdown"
+      state = @state.swap do |current_state|
+        if current_state[:shutdown]
+          current_state
+        else
+          current_state.merge(queue: [*current_state[:queue], work])
+        end
       end
-
-      @queue.swap { |current_queue| current_queue += [work] }
-      true
+      raise EnqueuedWorkAfterShutdownError if state[:shutdown]
     end
 
     def length
@@ -37,20 +40,31 @@ module AtomicRuby
     end
 
     def queue_length
-      @queue.value.length
+      @state.value[:queue].length
     end
 
     def shutdown
-      self << :stop
+      already_shutdown = false
+      @state.swap do |current_state|
+        if current_state[:shutdown]
+          already_shutdown = true
+          current_state
+        else
+          current_state.merge(shutdown: true)
+        end
+      end
+      return if already_shutdown
+
+      Thread.pass until @state.value[:queue].empty?
+
       @threads.each(&:join)
-      true
     end
 
     private
 
     def start
-      @threads = @size.times.map do |num|
-        Thread.new(num) do |idx|
+      @size.times do |num|
+        @threads << Thread.new(num) do |idx|
           thread_name = String.new("AtomicThreadPool thread #{idx}")
           thread_name << " for #{@name}" if @name
           Thread.current.name = thread_name
@@ -59,9 +73,23 @@ module AtomicRuby
 
           loop do
             work = nil
-            @queue.swap { |current_queue| work = current_queue.last; current_queue[0..-2] }
-            case work
-            when Proc
+            should_shutdown = false
+
+            @state.swap do |current_state|
+              if current_state[:shutdown] && current_state[:queue].empty?
+                should_shutdown = true
+                current_state
+              elsif current_state[:queue].empty?
+                current_state
+              else
+                work = current_state[:queue].first
+                current_state.merge(queue: current_state[:queue].drop(1))
+              end
+            end
+
+            if should_shutdown
+              break
+            elsif work
               begin
                 work.call
               rescue => err
@@ -69,18 +97,13 @@ module AtomicRuby
                 puts "#{err.class}: #{err.message}"
                 puts err.backtrace.join("\n")
               end
-            when :stop
-              @stopping.make_true
-            when NilClass
-              if @stopping.true?
-                break
-              else
-                Thread.pass
-              end
+            else
+              Thread.pass
             end
           end
         end
       end
+      @threads.freeze
 
       Thread.pass until @started_threads.value == @size
     end

data/lib/atomic-ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicRuby
-  VERSION = "0.6.6"
+  VERSION = "0.7.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic-ruby
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.7.0
 platform: ruby
 authors:
 - Joshua Young
@@ -50,7 +50,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.7.2
 specification_version: 4
 summary: Atomic primitives for Ruby
 test_files: []