atomic-ruby 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc55b63bd9de85a395232f89184e97aa80e08e8e082981f2b17012fd1b56b5c0
-  data.tar.gz: 25cffc0cbb45f1d145d3b99380decc91a39ef82415833781bed40ba2583286a8
+  metadata.gz: 7e47f4b67bd3d4dcaecbd560ed61b8dc4c86c24882b52279a5d0e92fd6de666a
+  data.tar.gz: 2fb299af89ccc871b7c8b3d6ef18f15924e98b90ad196143c0ea9fa3cac76419
 SHA512:
-  metadata.gz: 1420ff50010eec4386301619d4866c1e96aec8f91936e464b2ed56276607fd6dfaf88d0cc5582ee255c06a15928a2b1390f1a2e18ceb443ee0d74fa190a36ee9
-  data.tar.gz: 80ceb6dd2348ea38bbd8b63223fc7ab27a6d36026d0e028fc0aef60dd9f92885b29adb5fa997b551b54c9aadbaca24fdd71a4f7b1d94337f3a3887955c108a5b
+  metadata.gz: fb201628eedea540bea2a8436daf0bb9f9db3cf2f0cd1caa5d27a54af840b992474cf4e08496a52c16f963ab311cd14f3796977f6777140c648e38cd283a6679
+  data.tar.gz: fe346ae21ffa67e8ed82048a1b79fe2eada3f101e2b812112eef689139f924e01b420b6e0d56f37ca2c795e597bd86631e79f8d93fa5d32f50a77ef7eb1f9734

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.3.2] - 2025-06-14
+
+- Fix `AtomicThreadPool#<<` shutdown check race condition
+
 ## [0.3.1] - 2025-06-08
 
 - Fix current queue being mutated in `AtomicThreadPool#<<`

data/README.md

@@ -169,6 +169,7 @@ results = []
   results << result
 end
 
+puts "\n"
 puts "ruby version:            #{RUBY_DESCRIPTION}"
 puts "concurrent-ruby version: #{Concurrent::VERSION}"
 puts "atomic-ruby version:     #{AtomicRuby::VERSION}"
@@ -189,7 +190,7 @@ puts "Atomic Ruby Atomic Bank Account:     #{results[2].real.round(6)} seconds"
 
 ruby version:            ruby 3.4.4 (2025-05-14 revision a38531fd3f) +YJIT +PRISM [arm64-darwin24]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.3.0
+atomic-ruby version:     0.3.2
 
 Balances:
 Synchronized Bank Account Balance:           975
@@ -197,9 +198,9 @@ Concurrent Ruby Atomic Bank Account Balance: 975
 Atomic Ruby Atomic Bank Account Balance:     975
 
 Benchmark Results:
-Synchronized Bank Account:           5.125638 seconds
-Concurrent Ruby Atomic Bank Account: 5.114936 seconds
-Atomic Ruby Atomic Bank Account:     5.108171 seconds
+Synchronized Bank Account:           5.130792 seconds
+Concurrent Ruby Atomic Bank Account: 5.121400 seconds
+Atomic Ruby Atomic Bank Account:     5.119191 seconds
 ```
 
 </details>
@@ -215,6 +216,23 @@ require "benchmark/ips"
 require "concurrent-ruby"
 require_relative "../lib/atomic-ruby"
 
+module Benchmark
+  module IPS
+    class Job
+      class StreamReport
+        def start_warming
+          @out.puts "\n"
+          @out.puts "ruby version:            #{RUBY_DESCRIPTION}"
+          @out.puts "concurrent-ruby version: #{Concurrent::VERSION}"
+          @out.puts "atomic-ruby version:     #{AtomicRuby::VERSION}"
+          @out.puts "\n"
+          @out.puts "Warming up --------------------------------------"
+        end
+      end
+    end
+  end
+end
+
 Benchmark.ips do |x|
   x.report("Synchronized Boolean Toggle") do
     boolean = false
@@ -261,26 +279,29 @@ end
 ```
 > bundle exec rake compile && bundle exec ruby examples/atomic_boolean_benchmark.rb
 
-ruby 3.4.4 (2025-05-14 revision a38531fd3f) +YJIT +PRISM [arm64-darwin24]
+ruby version:            ruby 3.4.4 (2025-05-14 revision a38531fd3f) +YJIT +PRISM [arm64-darwin24]
+concurrent-ruby version: 1.3.5
+atomic-ruby version:     0.3.2
+
 Warming up --------------------------------------
 Synchronized Boolean Toggle
-                        83.000 i/100ms
+                        87.000 i/100ms
 Concurrent Ruby Atomic Boolean Toggle
-                        58.000 i/100ms
+                        81.000 i/100ms
 Atomic Ruby Atomic Boolean Toggle
-                        88.000 i/100ms
+                        92.000 i/100ms
 Calculating -------------------------------------
 Synchronized Boolean Toggle
-                        775.552 (± 6.2%) i/s    (1.29 ms/i) -      3.901k in   5.051649s
+                        969.205 (± 5.8%) i/s    (1.03 ms/i) -      4.872k in   5.043520s
 Concurrent Ruby Atomic Boolean Toggle
-                        741.655 (± 3.5%) i/s    (1.35 ms/i) -      3.712k in   5.011183s
+                        885.546 (± 5.2%) i/s    (1.13 ms/i) -      4.455k in   5.044282s
 Atomic Ruby Atomic Boolean Toggle
-                        881.916 (± 2.8%) i/s    (1.13 ms/i) -      4.488k in   5.092910s
+                         1.154k (± 5.3%) i/s  (866.65 μs/i) -      5.796k in   5.037272s
 
 Comparison:
-Atomic Ruby Atomic Boolean Toggle:      881.9 i/s
-Synchronized Boolean Toggle:            775.6 i/s - 1.14x  slower
-Concurrent Ruby Atomic Boolean Toggle:  741.7 i/s - 1.19x  slower
+Atomic Ruby Atomic Boolean Toggle:     1153.9 i/s
+Synchronized Boolean Toggle:            969.2 i/s - 1.19x  slower
+Concurrent Ruby Atomic Boolean Toggle:  885.5 i/s - 1.30x  slower
 ```
 
 </details>
@@ -315,17 +336,15 @@ results = []
       pool << -> { 1_000_000.times.map(&:itself).sum }
     end
 
-    # concurrent-ruby does not wait for threads to die on shutdown
-    threads = if idx == 0
-      pool.instance_variable_get(:@pool).map { |worker| worker.instance_variable_get(:@thread) }
-    end
     pool.shutdown
-    threads&.each(&:join)
+    # concurrent-ruby's #shutdown does not wait for threads to terminate
+    pool.wait_for_termination if idx == 0
   end
 
   results << result
 end
 
+puts "\n"
 puts "ruby version:            #{RUBY_DESCRIPTION}"
 puts "concurrent-ruby version: #{Concurrent::VERSION}"
 puts "atomic-ruby version:     #{AtomicRuby::VERSION}"
@@ -340,11 +359,11 @@ puts "Atomic Ruby Atomic Thread Pool: #{results[1].real.round(6)} seconds"
 
 ruby version:            ruby 3.4.4 (2025-05-14 revision a38531fd3f) +YJIT +PRISM [arm64-darwin24]
 concurrent-ruby version: 1.3.5
-atomic-ruby version:     0.3.0
+atomic-ruby version:     0.3.2
 
 Benchmark Results:
-Concurrent Ruby Thread Pool:    5.136456 seconds
-Atomic Ruby Atomic Thread Pool: 4.700981 seconds
+Concurrent Ruby Thread Pool:    5.032940 seconds
+Atomic Ruby Atomic Thread Pool: 4.508259 seconds
 ```
 
 </details>

data/lib/atomic-ruby/atomic_thread_pool.rb

@@ -23,11 +23,13 @@ module AtomicRuby
         raise UnsupportedWorkTypeError, "expected work to be a `Proc`, got #{work.class}"
       end
 
-      if @stopping.true?
-        raise InvalidWorkQueueingError, "cannot queue work during or after pool shutdown"
-      end
+      @queue.swap do |current_queue|
+        if @stopping.true?
+          raise InvalidWorkQueueingError, "cannot queue work during or after pool shutdown"
+        end
 
-      @queue.swap { |current_queue| current_queue += [work] }
+        current_queue += [work]
+      end
       true
     end
 
@@ -80,7 +82,7 @@ module AtomicRuby
         end
       end
 
-      sleep(0.001) until @started_threads.value == @size
+      Thread.pass until @started_threads.value == @size
     end
   end
 end

data/lib/atomic-ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicRuby
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic-ruby
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Joshua Young
@@ -50,7 +50,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.7.0.dev
 specification_version: 4
 summary: Atomic primitives for Ruby
 test_files: []