asynchronic 2.0.1 → 4.0.0

data/lib/asynchronic/version.rb

@@ -1,3 +1,3 @@
 module Asynchronic
-  VERSION = '2.0.1'
+  VERSION = '4.0.0'
 end

data/lib/asynchronic/worker.rb

@@ -1,24 +1,21 @@
 class Asynchronic::Worker
 
-  attr_reader :queue
-  attr_reader :queue_name
-  attr_reader :env
-  attr_reader :listener
+  attr_reader :queue, :queue_name, :environment, :listener
 
-  def initialize(queue_name, env)
+  def initialize(queue_name, environment)
     @queue_name = queue_name
-    @queue = env.queue_engine[queue_name]
-    @env = env
-    @listener = env.queue_engine.listener
+    @queue = environment.queue_engine[queue_name]
+    @environment = environment
+    @listener = environment.queue_engine.listener
   end
 
   def start
     Asynchronic.logger.info('Asynchronic') { "Starting worker of #{queue_name} (#{Process.pid})" }
 
     Signal.trap('QUIT') { stop }
-    
+
     listener.listen(queue) do |pid|
-      env.load_process(pid).execute
+      environment.load_process(pid).execute
     end
   end
 

data/spec/data_store/data_store_examples.rb

@@ -1,5 +1,11 @@
 module DataStoreExamples
-  
+
+  extend Minitest::Spec::DSL
+
+  after do
+    data_store.clear
+  end
+
   it 'Get/Set value' do
     data_store[:key] = 123
     data_store[:key].must_equal 123
@@ -32,8 +38,8 @@ module DataStoreExamples
     data_store.delete_cascade Asynchronic::DataStore::Key[:key_1]
 
     data_store.keys.sort.must_equal [
-      Asynchronic::DataStore::Key[:key_2], 
-      Asynchronic::DataStore::Key[:key_2][:key_2_1], 
+      Asynchronic::DataStore::Key[:key_2],
+      Asynchronic::DataStore::Key[:key_2][:key_2_1],
       Asynchronic::DataStore::Key[:key_2][:key_2_2]
     ]
   end
@@ -110,18 +116,20 @@ module DataStoreExamples
 
   it 'Synchronization' do
     sum = 0
-    threads = 1.upto(100).map do |i|
+
+    threads = 10.times.map do
       Thread.new do
-        data_store.synchronize('xxx') do
+        data_store.synchronize('lock_key') do
           temp = sum
-          sleep 0
+          sleep 0.01
           sum = temp + 1
         end
       end
     end
+
     threads.each(&:join)
-      
-    sum.must_equal 100
+
+    sum.must_equal threads.count
   end
-  
+
 end

data/spec/data_store/in_memory_spec.rb

@@ -1,6 +1,4 @@
 require 'minitest_helper'
-require_relative './data_store_examples'
-require_relative './lazy_value_examples'
 
 describe Asynchronic::DataStore::InMemory do
 

data/spec/data_store/key_spec.rb

@@ -56,5 +56,5 @@ describe Asynchronic::DataStore::Key do
     key.remove_last.must_equal 'foo|bar'
     key.remove_last(2).must_equal 'foo'
   end
-  
+
 end

data/spec/data_store/lazy_value_examples.rb

@@ -1,5 +1,7 @@
 module LazyValueExamples
 
+  extend Minitest::Spec::DSL
+
   def lazy_value(key)
     Asynchronic::DataStore::LazyValue.new data_store, key
   end
@@ -7,26 +9,25 @@ module LazyValueExamples
   it 'Get' do
     value = lazy_value :key
     value.must_be_nil
-    
-    data_store[:key] =  1
+
+    data_store[:key] = 1
     value.must_equal 1
   end
 
   it 'Reload' do
     value = lazy_value :key
 
-    data_store[:key] =  1
+    data_store[:key] = 1
     value.must_equal 1
 
-    data_store[:key] =  2
+    data_store[:key] = 2
     value.must_equal 1
     value.reload.must_equal 2
   end
 
   it 'Transparent proxy' do
     value = lazy_value :key
-    data_store[:key] =  1
-    value.must_be_instance_of Fixnum
+    data_store[:key] = 1
     value.must_equal 1
   end
 

data/spec/data_store/redis_spec.rb

@@ -1,17 +1,15 @@
 require 'minitest_helper'
-require_relative './data_store_examples'
-require_relative './lazy_value_examples'
 
 describe Asynchronic::DataStore::Redis do
 
   let(:data_store) { Asynchronic::DataStore::Redis.new :asynchronic_test }
 
-  after do
-    data_store.clear
-  end
-
   include DataStoreExamples
 
+  describe 'LazyValue' do
+    include LazyValueExamples
+  end
+
   it 'Safe deserialization' do
     SampleClass = Class.new
 
@@ -24,8 +22,4 @@ describe Asynchronic::DataStore::Redis do
     data_store[:instance].must_be_instance_of String
   end
 
-  describe 'LazyValue' do
-    include LazyValueExamples
-  end
-
 end

data/spec/expectations.rb

@@ -15,10 +15,10 @@ module MiniTest::Assertions
   def assert_be_initialized(process)
     process.must_be :pending?
     process.wont_be :finalized?
-    
+
     process.processes.must_be_empty
     process.error.must_be_nil
-    
+
     process.created_at.must_be_instance_of Time
     process.queued_at.must_be_nil
     process.started_at.must_be_nil

data/spec/facade_spec.rb

@@ -6,7 +6,7 @@ describe Asynchronic, 'Facade' do
     Asynchronic.environment.data_store.clear
     Asynchronic.environment.queue_engine.clear
   end
-  
+
   it 'Default queue' do
     Asynchronic.default_queue.must_equal :asynchronic_test
   end
@@ -40,7 +40,7 @@ describe Asynchronic, 'Facade' do
   end
 
   it 'List processes' do
-    ids = 3.times.map do 
+    ids = 3.times.map do
       process = Asynchronic.environment.create_process SequentialJob
       process.id
     end
@@ -51,7 +51,7 @@ describe Asynchronic, 'Facade' do
 
   it 'Enqueue' do
     id = BasicJob.enqueue input: 100
-    
+
     Asynchronic.environment.tap do |env|
       process = env.load_process id
       process.type.must_equal BasicJob
@@ -69,11 +69,11 @@ describe Asynchronic, 'Facade' do
   end
 
   it 'Keep alive timeout' do
-    Asynchronic.keep_alive_timeout.must_equal 0.1
+    Asynchronic.keep_alive_timeout.must_equal 1
   end
 
   it 'Connection name' do
-    Asynchronic.connection_name.must_equal "HOST=#{Socket.gethostname},PID=#{::Process.pid}"
+    Asynchronic.connection_name.must_match /^HOST=#{Socket.gethostname},PID=#{::Process.pid}/
   end
 
 end

data/spec/jobs.rb

@@ -9,8 +9,8 @@ class SequentialJob < Asynchronic::Job
 
   def call
     async Step1, input: params[:input]
-    
-    async Step2, dependency: Step1, 
+
+    async Step2, dependency: Step1,
                  input: params[:input]
 
     nil
@@ -32,7 +32,7 @@ end
 
 
 class GraphJob < Asynchronic::Job
-  
+
   def call
     async Sum, input: params[:input]
 
@@ -113,13 +113,13 @@ class AliasJob < Asynchronic::Job
   def call
     async Write, alias: :word_1,
                  text: 'Take'
-    
-    async Write, alias: :word_2, 
-                 text: 'it', 
+
+    async Write, alias: :word_2,
+                 text: 'it',
                  prefix: result(:word_1)
-    
-    async Write, alias: :word_3, 
-                 text: 'easy', 
+
+    async Write, alias: :word_3,
+                 text: 'easy',
                  prefix: result(:word_2)
 
     result :word_3
@@ -200,7 +200,7 @@ end
 class WithRetriesJob < Asynchronic::Job
   def call
     @counter = 0
-    retry_when [RuntimeError] do
+    retry_when [RuntimeError], 0.1 do
       @counter += 1
       raise 'Counter < 3' if @counter < 3
       @counter
@@ -326,7 +326,7 @@ class NestedJobWithErrorInChildJob < Asynchronic::Job
 end
 
 
-class AbortQueuedAfertErrorJob < Asynchronic::Job
+class AbortQueuedAfterErrorJob < Asynchronic::Job
   def call
     async Child_1
     async Child_2
@@ -402,4 +402,4 @@ class BeforeFinalizeExceptionOnAbortedJob < Asynchronic::Job
   def before_finalize
     raise 'Before finalize error'
   end
-end
+end

data/spec/minitest_helper.rb

@@ -3,14 +3,17 @@ require 'asynchronic'
 require 'minitest/autorun'
 require 'minitest/colorin'
 require 'minitest/great_expectations'
+require 'minitest/stub_any_instance'
 require 'jobs'
 require 'expectations'
 require 'timeout'
 require 'pry-nav'
 
-class Module
-  include Minitest::Spec::DSL
-end
+require_relative 'data_store/data_store_examples'
+require_relative 'data_store/lazy_value_examples'
+require_relative 'process/life_cycle_examples'
+require_relative 'queue_engine/queue_engine_examples'
+require_relative 'worker/worker_examples'
 
 Asynchronic.logger.level = Logger::FATAL
 
@@ -19,13 +22,4 @@ class Minitest::Spec
     Asynchronic.restore_default_configuration
     Asynchronic.default_queue = :asynchronic_test
   end
-end
-
-module Asynchronic::DataStore::Helper
-  def dump
-    puts 'DataStore:'
-    each do |k,v|
-      puts "#{k}: #{v}"
-    end
-  end
 end

data/spec/process/life_cycle_examples.rb

@@ -1,12 +1,15 @@
 module LifeCycleExamples
-  
-  let(:env) { Asynchronic::Environment.new queue_engine, data_store }
+
+  extend Minitest::Spec::DSL
+
+  let(:env) { Asynchronic::Environment.new queue_engine, data_store, notifier }
 
   let(:queue) { env.default_queue }
 
   after do
     data_store.clear
     queue_engine.clear
+    notifier.unsubscribe_all
   end
 
   def create(type, params={})
@@ -17,10 +20,46 @@ module LifeCycleExamples
 
   def execute(queue)
     process = env.load_process(queue.pop)
+
+    events = []
+    status_changed_id = notifier.subscribe(process.id, :status_changed) { |status| events << status }
+
+    is_finalized = false
+    finalized_id = notifier.subscribe(process.id, :finalized) { is_finalized = true }
+
     process.execute
+
     process.must_have_connection_name
     process.wont_be :dead?
+
     process.send(:connected?).must_be_true
+
+    env.queue_engine.stub(:active_connections, ->() { raise 'Forced error' }) do
+      process.send(:connected?).must_be_true
+    end
+
+    with_retries do
+      events.last.must_equal process.status
+      process.finalized?.must_equal is_finalized
+    end
+
+    notifier.unsubscribe status_changed_id
+    notifier.unsubscribe finalized_id
+
+    status = process.status
+    process.abort_if_dead
+    process.status.must_equal status
+  end
+
+  def with_retries(&block)
+    Timeout.timeout(3) do
+      begin
+        block.call
+      rescue Minitest::Assertion
+        sleep 0.001
+        retry
+      end
+    end
   end
 
   it 'Basic' do
@@ -101,7 +140,7 @@ module LifeCycleExamples
     process[GraphJob::Total].must_be_pending
     process[GraphJob::Total].must_have_params '10%' => nil, '20%' => nil
     queue.must_enqueued process[GraphJob::Sum]
-    
+
     execute queue
 
     process.must_be_waiting
@@ -257,7 +296,7 @@ module LifeCycleExamples
     process[:word_3].result.must_equal 'Take it easy'
     queue.must_be_empty
   end
-  
+
   it 'Custom queue' do
     process = create CustomQueueJob, input: 'hello'
 
@@ -271,7 +310,7 @@ module LifeCycleExamples
 
     process.must_be_queued
     process.processes.must_be_empty
-    
+
     env.queue(:queue_1).must_enqueued process
     env.queue(:queue_2).must_be_empty
     env.queue(:queue_3).must_be_empty
@@ -281,7 +320,7 @@ module LifeCycleExamples
     process.must_be_waiting
     process[CustomQueueJob::Reverse].must_be_queued
     process[CustomQueueJob::Reverse].must_have_params input: 'hello'
-    
+
     env.queue(:queue_1).must_be_empty
     env.queue(:queue_2).must_enqueued process[CustomQueueJob::Reverse]
     env.queue(:queue_3).must_be_empty
@@ -292,7 +331,7 @@ module LifeCycleExamples
     process.result.must_equal 'olleh'
     process[CustomQueueJob::Reverse].must_be_completed
     process[CustomQueueJob::Reverse].result.must_equal 'olleh'
-    
+
     env.queue(:queue_1).must_be_empty
     env.queue(:queue_2).must_be_empty
     env.queue(:queue_3).must_be_empty
@@ -448,7 +487,7 @@ module LifeCycleExamples
 
   it 'Data' do
     process = create DataJob, input: 1
-  
+
     process.enqueue
     execute queue
 
@@ -460,7 +499,7 @@ module LifeCycleExamples
   it 'Nested job with error in child' do
     process = create NestedJobWithErrorInChildJob
 
-    process.enqueue 
+    process.enqueue
 
     Timeout.timeout(1) do
       until process.status == :aborted
@@ -474,87 +513,88 @@ module LifeCycleExamples
   it 'Nested job with error in parent' do
     process = create NestedJobWithErrorInParentJob
 
-    process.enqueue 
+    process.enqueue
 
     execute queue
- 
+
     process.real_error.must_equal "Error in parent"
   end
 
-  it 'Abort queued afert error' do
-    process = create AbortQueuedAfertErrorJob
+  it 'Abort queued After error' do
+    process = create AbortQueuedAfterErrorJob
 
-    process.enqueue 
+    process.enqueue
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :waiting,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :queued
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :waiting,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :queued,
+                                   'AbortQueuedAfterErrorJob::Child_2' => :queued,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :queued,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :queued
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :waiting,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :waiting,
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :waiting,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :waiting,
                                    'Child_1_1'                         => :queued,
                                    'Child_1_2'                         => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :queued
+                                   'AbortQueuedAfterErrorJob::Child_2' => :queued,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :queued,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :queued
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :waiting,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :waiting,
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :waiting,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :waiting,
                                    'Child_1_1'                         => :queued,
                                    'Child_1_2'                         => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :completed,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :queued
+                                   'AbortQueuedAfterErrorJob::Child_2' => :completed,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :queued,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :queued
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :waiting,
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :waiting,
                                    'Child_1_1'                         => :queued,
                                    'Child_1_2'                         => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :completed,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :queued
+                                   'AbortQueuedAfterErrorJob::Child_2' => :completed,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :queued
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :waiting,
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :waiting,
                                    'Child_1_1'                         => :queued,
                                    'Child_1_2'                         => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :completed,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :aborted
+                                   'AbortQueuedAfterErrorJob::Child_2' => :completed,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :aborted
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :aborted,
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :aborted,
                                    'Child_1_1'                         => :aborted,
                                    'Child_1_2'                         => :queued,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :completed,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :aborted
+                                   'AbortQueuedAfterErrorJob::Child_2' => :completed,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :aborted
 
     execute queue
 
-    process.full_status.must_equal 'AbortQueuedAfertErrorJob'          => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_1' => :aborted,
+    process.full_status.must_equal 'AbortQueuedAfterErrorJob'          => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_1' => :aborted,
                                    'Child_1_1'                         => :aborted,
                                    'Child_1_2'                         => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_2' => :completed,
-                                   'AbortQueuedAfertErrorJob::Child_3' => :aborted,
-                                   'AbortQueuedAfertErrorJob::Child_4' => :aborted
+                                   'AbortQueuedAfterErrorJob::Child_2' => :completed,
+                                   'AbortQueuedAfterErrorJob::Child_3' => :aborted,
+                                   'AbortQueuedAfterErrorJob::Child_4' => :aborted
 
     process.real_error.must_equal 'Forced error'
+    process.processes[0].processes[1].error.message.must_equal Asynchronic::Process::AUTOMATIC_ABORTED_ERROR_MESSAGE
   end
 
   it 'Manual abort' do
@@ -564,27 +604,27 @@ module LifeCycleExamples
 
     execute queue
 
-    process.full_status.must_equal 'NestedJob'         => :waiting, 
+    process.full_status.must_equal 'NestedJob'         => :waiting,
                                    'NestedJob::Level1' => :queued
 
     execute queue
 
-    process.full_status.must_equal 'NestedJob'                 => :waiting, 
-                                   'NestedJob::Level1'         => :waiting, 
+    process.full_status.must_equal 'NestedJob'                 => :waiting,
+                                   'NestedJob::Level1'         => :waiting,
                                    'NestedJob::Level1::Level2' => :queued
 
     process.cancel!
 
     process.real_error.must_equal Asynchronic::Process::CANCELED_ERROR_MESSAGE
 
-    process.full_status.must_equal 'NestedJob'                 => :aborted, 
-                                   'NestedJob::Level1'         => :waiting, 
+    process.full_status.must_equal 'NestedJob'                 => :aborted,
+                                   'NestedJob::Level1'         => :waiting,
                                    'NestedJob::Level1::Level2' => :queued
 
     execute queue
 
-    process.full_status.must_equal 'NestedJob'                 => :aborted, 
-                                   'NestedJob::Level1'         => :aborted, 
+    process.full_status.must_equal 'NestedJob'                 => :aborted,
+                                   'NestedJob::Level1'         => :aborted,
                                    'NestedJob::Level1::Level2' => :aborted
   end
 
@@ -612,41 +652,49 @@ module LifeCycleExamples
     process_1 = create AliasJob
     process_1.enqueue
     4.times { execute queue }
-    
+
     process_2 = create AliasJob
     process_2.enqueue
     execute queue
 
+    process_3 = create BasicJob
+
     pid_1 = process_1.id
     pid_2 = process_2.id
+    pid_3 = process_3.id
 
     process_1.must_be_completed
     process_2.must_be_waiting
+    process_3.must_be_pending
 
     data_store.keys.select { |k| k.start_with? pid_1 }.count.must_equal 53
     data_store.keys.select { |k| k.start_with? pid_2 }.count.must_equal 38
+    data_store.keys.select { |k| k.start_with? pid_3 }.count.must_equal 7
 
     gc = Asynchronic::GarbageCollector.new env, 0.001
-    
-    gc.add_condition('Completed', &:completed?)
+
+    gc.add_condition('Finalized', &:finalized?)
     gc.add_condition('Waiting', &:waiting?)
     gc.add_condition('Exception') { raise 'Invalid condition' }
 
-    gc.conditions_names.must_equal ['Completed', 'Waiting', 'Exception']
+    gc.conditions_names.must_equal ['Finalized', 'Waiting', 'Exception']
 
     gc.remove_condition 'Waiting'
-    
-    gc.conditions_names.must_equal ['Completed', 'Exception']
+
+    gc.conditions_names.must_equal ['Finalized', 'Exception']
 
     Thread.new do
       sleep 0.01
       gc.stop
     end
 
-    gc.start
+    Asynchronic::Process.stub_any_instance(:dead?, -> { id == pid_3 }) do
+      gc.start
+    end
 
     data_store.keys.select { |k| k.start_with? pid_1 }.count.must_equal 0
     data_store.keys.select { |k| k.start_with? pid_2 }.count.must_equal 38
+    data_store.keys.select { |k| k.start_with? pid_3 }.count.must_equal 0
   end
 
   it 'Before finalize hook when completed' do
@@ -717,5 +765,4 @@ module LifeCycleExamples
     queue.must_be_empty
   end
 
-
 end