async_methods 1.0.2 → 1.0.3

data/VERSION

@@ -1 +1 @@
-1.0.2
+1.0.3

data/async_methods.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{async_methods}
-  s.version = "1.0.2"
+  s.version = "1.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brian Durand"]
-  s.date = %q{2011-01-19}
+  s.date = %q{2011-01-24}
   s.description = %q{Gem that adds asynchronous method calls for all methods on every object to aid in throughput on I/O bound processes. This is intended to improve throughput on I/O bound processes like making several HTTP calls in row.}
   s.email = %q{brian@embellishedvisions.com}
   s.extra_rdoc_files = [

data/lib/async_methods/async_methods.rb

@@ -14,7 +14,12 @@ module AsyncMethods
       method = method.to_s
       if method[0, 6] == 'async_'
         method = method.to_s
-        return Proxy.new(self, method[6 , method.length], args, &block)
+        called_method = method[6 , method.length]
+        if Thread.critical
+          return send(called_method, *args, &block)
+        else
+          return Proxy.new(self, called_method, args, &block)
+        end
       else
         # Keep track of the current missing method calls to keep out of an infinite loop
         stack = Thread.current[:async_method_missing_methods] ||= []
@@ -23,6 +28,10 @@ module AsyncMethods
         begin
           stack.push(sig)
           return method_missing_without_async(method, *args, &block)
+        rescue Exception => e
+          # Strip this method from the stack trace as it adds confusion
+          e.backtrace.reject!{|line| line.include?(__FILE__)}
+          raise e
         ensure
           stack.pop
         end
@@ -46,7 +55,7 @@ module AsyncMethods
     end
     
     def eql? (sig)
-      sig.kind_of(MethodSignature) and sig.object == @object and sig.method == @method
+      sig.kind_of(MethodSignature) && sig.object == @object && sig.method == @method
     end
     
   end
@@ -54,22 +63,24 @@ module AsyncMethods
   # The proxy object does all the heavy lifting.
   class Proxy
     # These methods we don't want to override. All other existing methods will be redefined.
-    PROTECTED_METHODS = %w(initialize __proxy_result__ __proxy_loaded__ method_missing __send__ object_id)
+    PROTECTED_METHODS = %w(initialize method_missing __proxy_result__ __proxy_loaded__ __send__ __id__ object_id)
+    
+    # Override already defined methods on Object to proxy them to the result object
+    instance_methods.each do |m|
+      undef_method(m) unless PROTECTED_METHODS.include?(m.to_s)
+    end
     
     def initialize (obj, method, args = [], &block)
-      # Override already defined methods on Object to proxy them to the result object
-      methods.each do |m|
-        eval "def self.#{m} (*args, &block); __proxy_result__.send(:#{m}, *args, &block); end" unless PROTECTED_METHODS.include?(m.to_s)
-      end
-      
+      @proxy_result = nil
+      @proxy_exception = nil
       @thread = Thread.new do
         begin
-          if obj and method
+          if obj && method
             @proxy_result = obj.send(method, *args, &block)
           else
             @proxy_result = block.call
           end
-        rescue Object => e
+        rescue Exception => e
           @proxy_exception = e
         end
       end

data/spec/async_method_spec.rb

@@ -24,6 +24,16 @@ describe AsyncMethods::InstanceMethods do
     proxy.__proxy_loaded__.should == true
   end
   
+  it "should remove itself from stacktraces thrown in method_missing" do
+    begin
+      "object".call_a_missing_method_that_does_not_exist
+      raise "should not get here"
+    rescue => e
+      async_source_file = File.expand_path("../../lib/async_methods/async_methods.rb", __FILE__)
+      File.exist?(async_source_file).should == true
+      e.backtrace.join("\n").should_not include(async_source_file)
+    end
+  end
 end
 
 describe AsyncMethods::Proxy do
@@ -99,4 +109,15 @@ describe AsyncMethods::Proxy do
     object.async_real_method_called.should == true
   end
   
+  it "should not open a new thread if Thread.critical is true" do
+    begin
+      Thread.critical = true
+      Thread.should_not_receive(:new)
+      proxy = "xxx".async_to_s
+      proxy.should == "xxx"
+    ensure
+      Thread.critical = false
+    end
+  end
+  
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: async_methods
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: 
   segments: 
   - 1
   - 0
-  - 2
-  version: 1.0.2
+  - 3
+  version: 1.0.3
 platform: ruby
 authors: 
 - Brian Durand
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-19 00:00:00 -06:00
+date: 2011-01-24 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency