async_experiments 0.0.1 → 0.1.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async_experiments
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Elliot Crosby-McCullough
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-17 00:00:00.000000000 Z
+date: 2016-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashdiff
@@ -136,7 +136,8 @@ files:
 - lib/async_experiments/experiment_control.rb
 - lib/async_experiments/experiment_error_worker.rb
 - lib/async_experiments/experiment_result.rb
-- lib/async_experiments/experiment_result_worker.rb
+- lib/async_experiments/experiment_result_candidate_worker.rb
+- lib/async_experiments/experiment_result_control_worker.rb
 - lib/async_experiments/util.rb
 - lib/async_experiments/version.rb
 - spec/async_experiments_spec.rb
@@ -144,8 +145,9 @@ files:
 - spec/examples.txt
 - spec/experiment_control_spec.rb
 - spec/experiment_error_worker_spec.rb
+- spec/experiment_result_candidate_worker_spec.rb
+- spec/experiment_result_control_worker_spec.rb
 - spec/experiment_result_spec.rb
-- spec/experiment_result_worker_spec.rb
 - spec/spec_helper.rb
 - spec/util_spec.rb
 homepage: http://github.com/alphagov/async_experiments
@@ -174,9 +176,10 @@ specification_version: 4
 summary: An asynchronous experiment framework.
 test_files:
 - spec/experiment_result_spec.rb
+- spec/experiment_result_candidate_worker_spec.rb
 - spec/spec_helper.rb
+- spec/experiment_result_control_worker_spec.rb
 - spec/experiment_error_worker_spec.rb
-- spec/experiment_result_worker_spec.rb
 - spec/async_experiments_spec.rb
 - spec/util_spec.rb
 - spec/experiment_control_spec.rb

data/lib/async_experiments/experiment_result_worker.rb

@@ -1,36 +0,0 @@
-require "async_experiments/experiment_result"
-
-module AsyncExperiments
-  class ExperimentResultWorker
-    include Sidekiq::Worker
-
-    sidekiq_options queue: :experiments
-
-    LOCK_TIMEOUT = 60
-
-    def perform(name, id, run_output, duration, type)
-      type = type.to_sym
-
-      Sidekiq.redis do |redis|
-        this_branch = ExperimentResult.new(name, id, type, redis, statsd, run_output, duration)
-
-        if this_branch.control?
-          candidate = ExperimentResult.new(name, id, :candidate, redis, statsd)
-          if candidate.available?
-            this_branch.process_run_output(candidate)
-          else
-            self.class.perform_in(5, name, id, run_output, duration, type)
-          end
-        elsif this_branch.candidate?
-          this_branch.store_run_output
-        end
-      end
-    end
-
-  private
-
-    def statsd
-      AsyncExperiments.statsd
-    end
-  end
-end

data/spec/experiment_result_worker_spec.rb

@@ -1,106 +0,0 @@
-require "spec_helper"
-require "async_experiments"
-require "async_experiments/experiment_result"
-require "async_experiments/experiment_result_worker"
-
-RSpec.describe AsyncExperiments::ExperimentResultWorker do
-  let(:name) { "some_experiment" }
-  let(:id) { SecureRandom.uuid }
-
-  let(:statsd) { double(:statsd) }
-  let(:redis) { double(:redis) }
-  let(:redis_key) { double(:redis_key) }
-
-  let(:control_output) { "control output" }
-  let(:control_duration) { 10.0 }
-
-  let(:candidate_output) { "candidate output" }
-  let(:candidate_duration) { 5.0 }
-
-  let(:control) {
-    double(:control,
-      control?: true,
-      candidate?: false,
-      key: redis_key,
-    )
-  }
-  let(:candidate) {
-    double(:candidate,
-      candidate?: true,
-      control?: false,
-      key: redis_key,
-    )
-  }
-
-  subject { described_class.new }
-
-  before do
-    allow(Sidekiq).to receive(:redis).and_yield(redis)
-    AsyncExperiments.statsd = statsd
-  end
-
-  it "uses the 'experiments' queue" do
-    Sidekiq::Testing.fake! do
-      described_class.perform_async
-
-      expect(described_class.jobs.size).to eq(1)
-    end
-  end
-
-  context "if we're the candidate" do
-    let(:type) { "candidate" }
-
-    it "stores the run output and duration" do
-      expect(AsyncExperiments::ExperimentResult).to receive(:new)
-        .with(name, id, type.to_sym, redis, statsd, candidate_output, candidate_duration)
-        .and_return(candidate)
-
-      expect(candidate).to receive(:store_run_output)
-
-      subject.perform(name, id, candidate_output, candidate_duration, type)
-    end
-  end
-
-  context "if we're the control" do
-    let(:type) { "control" }
-
-    before do
-      expect(AsyncExperiments::ExperimentResult).to receive(:new)
-        .with(name, id, :control, redis, statsd, control_output, control_duration)
-        .and_return(control)
-
-      expect(AsyncExperiments::ExperimentResult).to receive(:new)
-        .with(name, id, :candidate, redis, statsd)
-        .and_return(candidate)
-    end
-
-    context "and the candidate is available" do
-      before do
-        allow(candidate).to receive(:available?).and_return(true)
-      end
-
-      it "processes the run output with the candidate" do
-        expect(control).to receive(:process_run_output).with(candidate)
-        subject.perform(name, id, control_output, control_duration, type)
-      end
-    end
-
-    context "but the candidate is unavailable" do
-      before do
-        allow(candidate).to receive(:available?).and_return(false)
-        allow(described_class).to receive(:perform_in)
-      end
-
-      it "does not process the run output" do
-        expect(control).not_to receive(:process_run_output)
-        subject.perform(name, id, control_output, control_duration, type)
-      end
-
-      it "schedules the job to run again later" do
-        args = [name, id, control_output, control_duration]
-        expect(described_class).to receive(:perform_in).with(5, *args, type.to_sym)
-        subject.perform(*args, type)
-      end
-    end
-  end
-end