async_block 0.2.4 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecd9d7e535b3cc5a1c3202a298246dd4d3ac610cd5fde6af8123590608f92692
-  data.tar.gz: cdb1f518b1c333d5b93cdca58e83c46efcb709a3d59b4d0b04899460deee1123
+  metadata.gz: 18e0e1824a1ab945b463420a2e016fdbe18f6d43495ca65709f4a52c74f0e745
+  data.tar.gz: b60005b7644181beb5758ad9414439901dfa93ce58b860095a065b59c98eb06b
 SHA512:
-  metadata.gz: 511fa72a1d25adefa23f78ea983a98610715ec72e2ad22af09248a122fbd85244ad1e51dea1fa83d943626ff5c929a4cb8ecb1e39374d1d094025e864d0a9274
-  data.tar.gz: c21922bbab72a2ad274f846b703e17834a52d95438e858abcfa685b03b3f281a5f4a7f1b4b7ee61cc89a590df34324d742e21f6d4ce7b93a34b4e86e70c370ca
+  metadata.gz: 1ca350e098475197eba58efabd2e995a99e113c9b74504f78756e998cf38b8442af317b77ac9c93e519ce5e98c6a02e6e5dc549c6846ac1b487ffce6cdbd0d51
+  data.tar.gz: 62c2ce631bda1ab60f14b1fd832ddda2742730699669061ca8d634b4cec297f7114dd4c5ffc552b37d3f1af925577ab661f68255a10373babaf517b5254979e2

data/lib/async_block/async_wrapper_job.rb

@@ -1,25 +1,14 @@
 # frozen_string_literal: true
 
 require_relative 'block_source_service'
+require_relative 'custom_active_job'
 
 module AsyncBlock
   # Job to dynamically run a block of code
-  class AsyncWrapperJob < ActiveJob::Base
-    class CodeBlockError < StandardError; end
+  class AsyncWrapperJob < CustomActiveJob
     queue_as :async_wrapper_job
 
-    retry_on StandardError, wait: :exponentially_longer, attempts: 3 do |job, error|
-      # send_error_message(job, error)
-      error_message = "Stopped retrying #{job.class} (JID #{job.job_id})
-        with #{job.arguments.join(', ')} due to
-        '#{error.class} - #{error.message}'.
-        This job was retried for #{job.executions} times.".squish
-      on_error(error_message)
-    end
-
-    def perform(source, on_error_source)
-      initialize_on_error(on_error_source)
-      # Converts source code to callable block
+    def perform(source)
       block = source_to_block(source)
       execute_block!(block)
     end
@@ -27,24 +16,12 @@ module AsyncBlock
     private
 
     def source_to_block(source)
+      # Converts source code to callable block
       SourceToBlock.new(source).convert
     end
 
     def execute_block!(block)
       block.call
     end
-
-    def initialize_on_error(on_error_source)
-      # Puts :on_error method in instance
-      source_to_block(on_error_source).call
-    end
-
-    # def send_error_message(job, error)
-    #   error_message = "Stopped retrying #{job.class} (JID #{job.job_id})
-    #     with #{job.arguments.join(', ')} due to
-    #     '#{error.class} - #{error.message}'.
-    #     This job was retried for #{job.executions} times.".squish
-    #   on_error(error_message)
-    # end
   end
 end

data/lib/async_block/custom_active_job.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module AsyncBlock
+  # Custom active job inherited from ActiveJob to enable error logging and retries
+  class CustomActiveJob < ActiveJob::Base
+    before_perform do |job|
+      context = { arguments: job.arguments.to_json }
+      if Module.const_defined?(:Sentry)
+        Sentry.configure_scope do |scope|
+          scope.set_context('context', context)
+        end
+      end
+      Honeybadger.context(context) if Module.const_defined?(:Honeybadger)
+    end
+
+    retry_on StandardError, wait: :exponentially_longer, attempts: 3 do |job, error|
+      message = "Stopped retrying #{job.class} (JID #{job.job_id})
+        with #{job.arguments.join(', ')} due to
+        '#{error.class} - #{error.message}'.
+        This job was retried for #{job.executions} times.".squish
+      Sentry.capture_message(message) if Module.const_defined?(:Sentry)
+      Honeybadger.notify(message) if Module.const_defined?(:Honeybadger)
+    end
+  end
+end

data/lib/async_block/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AsyncBlock
-  VERSION = '0.2.4'
+  VERSION = '0.2.6'
 end

data/lib/async_block.rb

@@ -10,18 +10,13 @@ require_relative 'async_block/async_wrapper_job'
 module AsyncBlock
   class Error < StandardError; end
 
-  def self.perform(queue: nil, delay: nil, on_error: nil, &block)
+  def self.perform(queue: nil, delay: nil, &block)
     source = BlockToSource.new(block).convert
-    on_error_source = BlockToSource.new(on_error || default_on_error).convert
     queue ||= DEFAULT_QUEUE_NAME
     if delay.instance_of?(ActiveSupport::Duration)
-      AsyncWrapperJob.set(wait: delay, queue: queue.to_sym).perform_later(source, on_error_source)
+      AsyncWrapperJob.set(wait: delay, queue: queue.to_sym).perform_later(source)
     else
-      AsyncWrapperJob.set(queue: queue.to_sym).perform_later(source, on_error_source)
+      AsyncWrapperJob.set(queue: queue.to_sym).perform_later(source)
     end
   end
-
-  def self.default_on_error(error_message)
-    puts('AsyncBlockError', error_message)
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async_block
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.6
 platform: ruby
 authors:
 - Adittya Dey
@@ -51,6 +51,7 @@ files:
 - lib/async_block/async_wrapper_job.rb
 - lib/async_block/block_source_service.rb
 - lib/async_block/constants.rb
+- lib/async_block/custom_active_job.rb
 - lib/async_block/version.rb
 - sig/async_block.rbs
 homepage: https://github.com/Velocity-Engineering/async-block