async 2.13.0 → 2.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe1866e547e6705255fdce380d3e5532964d0b74c009579f481f3c3fb8086b6c
-  data.tar.gz: 5d3ac4bbbb8579cbcc85944c447dcea2e6b4b2408af9ad3829eace9934067199
+  metadata.gz: ffbf235f3425b766c8eedfcdb2b03f86569e43ab1cdda3bd44f74c1b25f516b7
+  data.tar.gz: 1d71883b2151b5eb0f23daf27221ac091d352809a0ef1f687f282696cd22ae79
 SHA512:
-  metadata.gz: e208dc1b43979431fe3bf36acdcbebb97306bf32ec8471ea9081763d737865e47486dc798d5704ed829b27b16385f48425c4af687eda169f94e36f1c32c8ec86
-  data.tar.gz: d961dafc64289d00b1e99b3245577d5e549365d415e6628cba39af4a5b0d58fc15da468d880fa1796c97351ff83ba2814d073ebbab18aaeaef6a3eb50be26efb
+  metadata.gz: a00499f9ea43ffee3e6a5cf65dee14f67c5dcd167cb68e1b5da7c11bcef51c06da9c8c2d7a0606f72e5802520f7b9837f128d8425ade3de75111ca16a4cc9c10
+  data.tar.gz: f65b60522c85e07a17fdc345944c06e7447095682afea0bd2b7dcbf462deeeb7dcb6053e82eefc96cc259b10d6b0849803b8f22356feb10a21666a5ab134f6d6

data/lib/async/task.rb

@@ -13,6 +13,8 @@ require 'console/event/failure'
 require_relative 'node'
 require_relative 'condition'
 
+Fiber.attr_accessor :async_task
+
 module Async
 	# Raised when a task is explicitly stopped.
 	class Stop < Exception
@@ -186,6 +188,15 @@ module Async
 				
 				schedule do
 					@block.call(self, *arguments)
+				rescue => error
+					# I'm not completely happy with this overhead, but the alternative is to not log anything which makes debugging extremely difficult. Maybe we can introduce a debug wrapper which adds extra logging.
+					if @finished.nil?
+						Console::Event::Failure.for(error).emit("Task may have ended with unhandled exception.", severity: :warn)
+					# else
+					# 	Console::Event::Failure.for(error).emit(self, severity: :debug)
+					end
+					
+					raise
 				end
 			else
 				raise RuntimeError, "Task already running!"
@@ -316,13 +327,13 @@ module Async
 		# @returns [Task]
 		# @raises[RuntimeError] If task was not {set!} for the current fiber.
 		def self.current
-			Thread.current[:async_task] or raise RuntimeError, "No async task available!"
+			Fiber.current.async_task or raise RuntimeError, "No async task available!"
 		end
 		
 		# Check if there is a task defined for the current fiber.
 		# @returns [Interface(:async) | Nil]
 		def self.current?
-			Thread.current[:async_task]
+			Fiber.current.async_task
 		end
 		
 		# @returns [Boolean] Whether this task is the currently executing task.
@@ -354,21 +365,10 @@ module Async
 			@status = :completed
 		end
 		
-		# This is a very tricky aspect of tasks to get right. I've modelled it after `Thread` but it's slightly different in that the exception can propagate back up through the reactor. If the user writes code which raises an exception, that exception should always be visible, i.e. cause a failure. If it's not visible, such code fails silently and can be very difficult to debug.
-		def failed!(exception = false, propagate = true)
+		# State transition into the failed state.
+		def failed!(exception = false)
 			@result = exception
 			@status = :failed
-			
-			if exception
-				if propagate
-					raise exception
-				elsif @finished.nil?
-					# If no one has called wait, we log this as a warning:
-					Console::Event::Failure.for(exception).emit(self, "Task may have ended with unhandled exception.", severity: :warn)
-				else
-					Console::Event::Failure.for(exception).emit(self, severity: :debug)
-				end
-			end
 		end
 		
 		def stopped!
@@ -399,30 +399,26 @@ module Async
 		
 		def schedule(&block)
 			@fiber = Fiber.new(annotation: self.annotation) do
-				set!
-				
 				begin
 					completed!(yield)
-					# Console.debug(self) {"Task was completed with #{@children.size} children!"}
 				rescue Stop
 					stopped!
 				rescue StandardError => error
-					failed!(error, false)
+					failed!(error)
 				rescue Exception => exception
-					failed!(exception, true)
+					failed!(exception)
+					
+					# This is a critical failure, we should stop the reactor:
+					raise
 				ensure
 					# Console.info(self) {"Task ensure $! = #{$!} with #{@children&.size.inspect} children!"}
 					finish!
 				end
 			end
 			
+			@fiber.async_task = self
+			
 			self.root.resume(@fiber)
 		end
-		
-		# Set the current fiber's `:async_task` to this task.
-		def set!
-			# This is actually fiber-local:
-			Thread.current[:async_task] = self
-		end
 	end
 end

data/lib/async/version.rb

@@ -4,5 +4,5 @@
 # Copyright, 2017-2024, by Samuel Williams.
 
 module Async
-	VERSION = "2.13.0"
+	VERSION = "2.14.1"
 end

data/readme.md

@@ -19,20 +19,17 @@ Async is a composable asynchronous I/O framework for Ruby based on [io-event](ht
 
 Please see the [project documentation](https://socketry.github.io/async/) for more details.
 
-  - [Getting Started](https://socketry.github.io/async/guides/getting-started/index) - This guide shows how to add
-    async to your project and run code asynchronously.
+  - [Getting Started](https://socketry.github.io/async/guides/getting-started/index) - This guide shows how to add async to your project and run code asynchronously.
 
-  - [Asynchronous Tasks](https://socketry.github.io/async/guides/asynchronous-tasks/index) - This guide explains how
-    asynchronous tasks work and how to use them.
+  - [Asynchronous Tasks](https://socketry.github.io/async/guides/asynchronous-tasks/index) - This guide explains how asynchronous tasks work and how to use them.
 
-  - [Event Loop](https://socketry.github.io/async/guides/event-loop/index) - This guide gives an overview of how the
-    event loop is implemented.
+  - [Event Loop](https://socketry.github.io/async/guides/event-loop/index) - This guide gives an overview of how the event loop is implemented.
 
-  - [Compatibility](https://socketry.github.io/async/guides/compatibility/index) - This guide gives an overview of the
-    compatibility of Async with Ruby and other frameworks.
+  - [Compatibility](https://socketry.github.io/async/guides/compatibility/index) - This guide gives an overview of the compatibility of Async with Ruby and other frameworks.
 
-  - [Best Practices](https://socketry.github.io/async/guides/best-practices/index) - This guide gives an overview of
-    best practices for using Async.
+  - [Best Practices](https://socketry.github.io/async/guides/best-practices/index) - This guide gives an overview of best practices for using Async.
+
+  - [Debugging](https://socketry.github.io/async/guides/debugging/index) - This guide explains how to debug issues with programs that use Async.
 
 ## Contributing
 

data.tar.gz.sig

@@ -1,3 +1,2 @@
-`y�ROr��ٵOaO�f`�~����l���_Y�~�A�)�.v���2o'�oiVQ���~�M�u��K���~�{Vu�t�˼�͛�6*�!����?2�3.��
-�uk�
���Y@u$E��GB��2��M�!E&ٳ���n7�ʀv��P�@5��pw�3���8��m{h���j�W���LkJ����5�}n_ �j �����(��ALq�⥉��E1�4�k?��2>�U���M�[�E����Mj��8��)�^?	]�����{
|9��S�A�=�\��
-���`�G���VhL�&�_����_�gǁ6��[�E:���nk�p����-Y���xD��gG�f�&�)��!�[5N1��Ο��Cc�l�ӕ
+�(��6�d��Gl!剟��ץ�4��5��w�s�Ib��<^&5��5��@g�{\�rR_���O���o�e ĉ�F�s�RL6A*��LΆ��Ԏz5v-N�ZF�_\k�<H"`�D�*�[�P���sE`x�X��4�`v->�f`�ge�~?\�m�`�QB�&��y��uk ]^�=t�B}=�ԯ�\����ib�;�.2>����T�Y������&=����o��8�㱑�x�:����s��c�/^k��˷c?LqQ�ߤ�+�b���9L�E�p�CWx_���?z����hK�Y��I@;5�D�7t�lE��x�S����
�!~ ᤪϪԆ��K�`-�f`��
+�6�&s�9s�m�S�K�;U�o8��@

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.14.1
 platform: ruby
 authors:
 - Samuel Williams
@@ -62,7 +62,7 @@ cert_chain:
   Q2K9NVun/S785AP05vKkXZEFYxqG6EW012U4oLcFl5MySFajYXRYbuUpH6AY+HP8
   voD0MPg1DssDLKwXyt1eKD/+Fq0bFWhwVM/1XiAXL7lyYUyOq24KHgQ2Csg=
   -----END CERTIFICATE-----
-date: 2024-07-12 00:00:00.000000000 Z
+date: 2024-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: console
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: A concurrency framework for Ruby.