async 1.28.7 → 1.28.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b128ca85a69e6f07c87da25bc6c138a1198141cb01b02200ede0a677313a98dc
-  data.tar.gz: d9b0bae05938d165d08e6812fe9c08a8908cbae4826945a69b70b62cfee81059
+  metadata.gz: 0bfd6d656f9d5f891985de61ab428bafe452148e85cdc9d3ff43deec90e17f5e
+  data.tar.gz: 4c402e7fb08a04356ae96672598e5c196774bdc0c95462d6f32620796977cd64
 SHA512:
-  metadata.gz: 5a600ab32546c19049ba04a6ada9637db0e8c128d70e259a994da70a6e00e4fdc70a4a7de91e2149ded2cb1738d8f07a2cb8cdab79d06927cbd78d895e1d3bf9
-  data.tar.gz: 2a90f534c8d0ff01b2bff0a23fea131b24affae3a1c239f3d7bde17beadfb7ba462528d0de2f23b54cf1d564fd3622dd8a24462a7328690234ba3a3286692d9d
+  metadata.gz: 96b328f71cd892be4d9ecb677911054dad649b2e1115d5c6a92aa6c616295e66c969d964b3127797c9209f38cdb44962e364e4d8a0462e14d5da13bf51b1c4a5
+  data.tar.gz: 919265a3a3c5a8a1e512548860fb8a37641016c0a25f7322330f2560f651a1991144c632ef12c8e87410810f8fe2e42df67a9a5a7c98965e37f414ad515baddb

data/lib/async/node.rb

@@ -24,6 +24,7 @@ module Async
 	# A double linked list.
 	class List
 		def initialize
+			# The list behaves like a list node, so @tail points to the next item (the first one) and head points to the previous item (the last one). This may be slightly confusing but it makes the interface more natural.
 			@head = nil
 			@tail = nil
 			@size = 0
@@ -36,21 +37,21 @@ module Async
 		
 		# Inserts an item at the end of the list.
 		def insert(item)
-			unless @head
-				@head = item
+			unless @tail
 				@tail = item
+				@head = item
 				
 				# Consistency:
 				item.head = nil
 				item.tail = nil
 			else
-				@tail.tail = item
-				item.head = @tail
+				@head.tail = item
+				item.head = @head
 				
 				# Consistency:
 				item.tail = nil
 				
-				@tail = item
+				@head = item
 			end
 			
 			@size += 1
@@ -59,14 +60,14 @@ module Async
 		end
 		
 		def delete(item)
-			if @head.equal?(item)
-				@head = @head.tail
+			if @tail.equal?(item)
+				@tail = @tail.tail
 			else
 				item.head.tail = item.tail
 			end
 			
-			if @tail.equal?(item)
-				@tail = @tail.head
+			if @head.equal?(item)
+				@head = @head.head
 			else
 				item.tail.head = item.head
 			end
@@ -79,15 +80,17 @@ module Async
 			return self
 		end
 		
-		def each
+		def each(&block)
 			return to_enum unless block_given?
 			
-			item = @head
-			while item
-				# We store the tail pointer so we can remove the current item from the linked list:
-				tail = item.tail
-				yield item
-				item = tail
+			current = self
+			while node = current.tail
+				yield node
+				
+				# If the node has deleted itself or any subsequent node, it will no longer be the next node, so don't use it for continued traversal:
+				if current.tail.equal?(node)
+					current = node
+				end
 			end
 		end
 		
@@ -100,19 +103,19 @@ module Async
 		end
 		
 		def first
-			@head
+			@tail
 		end
 		
 		def last
-			@tail
+			@head
 		end
 		
 		def empty?
-			@head.nil?
+			@tail.nil?
 		end
 		
 		def nil?
-			@head.nil?
+			@tail.nil?
 		end
 	end
 	
@@ -276,6 +279,8 @@ module Async
 						if child.finished?
 							delete_child(child)
 						else
+							# In theory we don't need to do this... because we are throwing away the list. However, if you don't correctly update the list when moving the child to the parent, it foobars the enumeration, and subsequent nodes will be skipped, or in the worst case you might start enumerating the parents nodes.
+							delete_child(child)
 							parent.add_child(child)
 						end
 					end

data/lib/async/reactor.rb

@@ -347,7 +347,7 @@ module Async
 			timer = @timers.after(timeout) do
 				if fiber.alive?
 					error = exception.new("execution expired")
-					fiber.resume error
+					fiber.resume(error)
 				end
 			end
 			

data/lib/async/version.rb

@@ -21,5 +21,5 @@
 # THE SOFTWARE.
 
 module Async
-	VERSION = "1.28.7"
+	VERSION = "1.28.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async
 version: !ruby/object:Gem::Version
-  version: 1.28.7
+  version: 1.28.8
 platform: ruby
 authors:
 - Samuel Williams
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-09 00:00:00.000000000 Z
+date: 2021-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: console