async-redis 0.4.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d1cabed5b3d53ceb51ba113cffb2ace9bab46a1eacefc159531fc24723598c29
-  data.tar.gz: 566ea90f81848a6c78bb468e351e0c61ddbd01c82d76f9855dbed69ef0016cfc
+  metadata.gz: 7796495846ed0704472b1daea7b68b6ef8eaab48b7fa7f70699603eb3b88f834
+  data.tar.gz: cfbe584b55ddf465e4a013512003971df7c51ef8fe118b3843f1113d08bee7c4
 SHA512:
-  metadata.gz: d2cd6cddf7bf21fc8b71b86ed6739bf9799378a264f27ccb867181e90d298f0357569070080737106674808b738e17b317ef1fb5c1a23c00f47cc2bde86324dd
-  data.tar.gz: 32cbe030112f49d1fd498804b4756c1108fc3d985bafdcb249507d23b1c4e17372925d0a05e52e55bf67a110bada60f863ca838135f2bdb0d48afc4cccdb02fd
+  metadata.gz: 54523c3cb2c25376f46ce385c4bd2eb3a575993979810e4017b6e057de55811fb6d8c87d081f6677644307d967df5497415b8b155618def43d6eb7692c310ea1
+  data.tar.gz: 2525dd0c0cd9eb602253513091ad68fe83350061ed1753fb70c28f9ac5dc75a627234837a2c5a2dc3fb5d7aa8d7331218f833d050c95d6329204c2663d9fa161

data/lib/async/redis.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # 
 # Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -20,3 +22,4 @@
 
 require_relative 'redis/version'
 require_relative 'redis/client'
+require_relative 'redis/sentinels'

data/lib/async/redis/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # 
 # Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -18,7 +20,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.
 
-require_relative 'pool'
 require_relative 'context/pipeline'
 require_relative 'context/transaction'
 require_relative 'context/subscribe'
@@ -27,6 +28,7 @@ require_relative 'protocol/resp2'
 
 require 'async/io'
 require 'async/io/stream'
+require 'async/pool/controller'
 
 require 'protocol/redis/methods'
 
@@ -35,8 +37,8 @@ module Async
 		# Legacy.
 		ServerError = ::Protocol::Redis::ServerError
 		
-		def self.local_endpoint
-			Async::IO::Endpoint.tcp('localhost', 6379)
+		def self.local_endpoint(port: 6379)
+			Async::IO::Endpoint.tcp('localhost', port)
 		end
 		
 		class Client
@@ -54,8 +56,8 @@ module Async
 			
 			# @return [client] if no block provided.
 			# @yield [client, task] yield the client in an async task.
-			def self.open(*args, &block)
-				client = self.new(*args)
+			def self.open(*arguments, &block)
+				client = self.new(*arguments)
 				
 				return client unless block_given?
 				
@@ -72,10 +74,6 @@ module Async
 				@pool.close
 			end
 			
-			def publish(channel, message)
-				call('PUBLISH', channel, message)
-			end
-			
 			def subscribe(*channels)
 				context = Context::Subscribe.new(@pool, channels)
 				
@@ -88,18 +86,6 @@ module Async
 				end
 			end
 			
-			def multi(&block)
-				context = Context::Multi.new(@pool)
-				
-				return context unless block_given?
-				
-				begin
-					yield context
-				ensure
-					context.close
-				end
-			end
-			
 			def transaction(&block)
 				context = Context::Transaction.new(@pool)
 				
@@ -111,12 +97,14 @@ module Async
 					context.close
 				end
 			end
-
+			
+			alias multi transaction
+			
 			def pipeline(&block)
 				context = Context::Pipeline.new(@pool)
-
+				
 				return context unless block_given?
-
+				
 				begin
 					yield context
 				ensure
@@ -139,8 +127,8 @@ module Async
 			
 			protected
 			
-			def connect(connection_limit: nil)
-				Pool.new(connection_limit) do
+			def connect(**options)
+				Async::Pool::Controller.wrap(**options) do
 					peer = @endpoint.connect
 					
 					peer.setsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY, 1)

data/lib/async/redis/context/generic.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # Copyright, 2018, by Huba Nagy.
 # 
@@ -25,7 +27,7 @@ module Async
 	module Redis
 		module Context
 			class Generic
-				def initialize(pool, *args)
+				def initialize(pool, *arguments)
 					@pool = pool
 					@connection = pool.acquire
 				end
@@ -37,8 +39,8 @@ module Async
 					end
 				end
 				
-				def write_request(command, *args)
-					@connection.write_request([command, *args])
+				def write_request(command, *arguments)
+					@connection.write_request([command, *arguments])
 				end
 				
 				def read_response
@@ -47,8 +49,8 @@ module Async
 					return @connection.read_response
 				end
 				
-				def call(command, *args)
-					write_request(command, *args)
+				def call(command, *arguments)
+					write_request(command, *arguments)
 					
 					return read_response
 				end

data/lib/async/redis/context/pipeline.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2019, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # Copyright, 2019, by Huba Nagy.
 # 
@@ -36,8 +38,8 @@ module Async
 					end
 					
 					# This method just accumulates the commands and their params.
-					def call(command, *args)
-						@pipeline.call(command, *args)
+					def call(command, *arguments)
+						@pipeline.call(command, *arguments)
 						
 						@pipeline.flush(1)
 						
@@ -72,8 +74,8 @@ module Async
 				end
 				
 				# This method just accumulates the commands and their params.
-				def call(command, *args)
-					write_request(command, *args)
+				def call(command, *arguments)
+					write_request(command, *arguments)
 					
 					return nil
 				end

data/lib/async/redis/context/subscribe.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # Copyright, 2018, by Huba Nagy.
 # 
@@ -33,6 +35,13 @@ module Async
 					subscribe(channels)
 				end
 				
+				def close
+					# There is no way to reset subscription state. On Redis v6+ you can use RESET, but this is not supported in <= v6.
+					@connection&.close
+					
+					super
+				end
+				
 				def listen
 					return @connection.read_response
 				end
@@ -65,7 +74,7 @@ module Async
 						return response
 					else
 						@channels.subtract(channels)
-						return call 'UNSUBSCRIBE', *channels
+						return call('UNSUBSCRIBE', *channels)
 					end
 				end
 			end

data/lib/async/redis/context/transaction.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # Copyright, 2018, by Huba Nagy.
 # 
@@ -25,7 +27,7 @@ module Async
 	module Redis
 		module Context
 			class Transaction < Pipeline
-				def initialize(pool, *args)
+				def initialize(pool, *arguments)
 					super(pool)
 				end
 				

data/lib/async/redis/key.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # 
 # Permission is hereby granted, free of charge, to any person obtaining a copy

data/lib/async/redis/protocol/resp2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # 
 # Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -25,9 +27,17 @@ module Async
 		module Protocol
 			module RESP2
 				class Connection < ::Protocol::Redis::Connection
-					def connected?
+					def concurrency
+						1
+					end
+					
+					def viable?
 						@stream.connected?
 					end
+					
+					def reusable?
+						!@stream.closed?
+					end
 				end
 				
 				def self.client(stream)

data/lib/async/redis/sentinels.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+module Async
+	module Redis
+		class SentinelsClient < Client
+			def initialize(master_name, sentinels, role = :master, protocol = Protocol::RESP2, **options)
+				@master_name = master_name
+				@sentinel_endpoints = sentinels.map do |sentinel|
+					Async::IO::Endpoint.tcp(sentinel[:host], sentinel[:port])
+				end
+				@role = role
+
+				@protocol = protocol
+				@pool = connect(**options)
+			end
+
+			private
+
+			# Override the parent method. The only difference is that this one needs
+			# to resolve the master/slave address.
+			def connect(**options)
+				Async::Pool::Controller.wrap(**options) do
+					endpoint = resolve_address
+					peer = endpoint.connect
+					stream = IO::Stream.new(peer)
+
+					@protocol.client(stream)
+				end
+			end
+
+			def resolve_address
+				address = case @role
+									when :master then resolve_master
+									when :slave then resolve_slave
+									else raise ArgumentError, "Unknown instance role #{@role}"
+									end
+
+				address or raise RuntimeError, "Unable to fetch #{@role} via Sentinel."
+			end
+
+			def resolve_master
+				@sentinel_endpoints.each do |sentinel_endpoint|
+					client = Client.new(sentinel_endpoint)
+
+					begin
+						address = client.call('sentinel', 'get-master-addr-by-name', @master_name)
+					rescue Errno::ECONNREFUSED
+						next
+					end
+
+					return Async::IO::Endpoint.tcp(address[0], address[1]) if address
+				end
+
+				nil
+			end
+
+			def resolve_slave
+				@sentinel_endpoints.each do |sentinel_endpoint|
+					client = Client.new(sentinel_endpoint)
+
+					begin
+						reply = client.call('sentinel', 'slaves', @master_name)
+					rescue Errno::ECONNREFUSED
+						next
+					end
+
+					slaves = available_slaves(reply)
+					next if slaves.empty?
+
+					slave = select_slave(slaves)
+					return Async::IO::Endpoint.tcp(slave['ip'], slave['port'])
+				end
+
+				nil
+			end
+
+			def available_slaves(slaves_cmd_reply)
+				# The reply is an array with the format: [field1, value1, field2,
+				# value2, etc.].
+				# When a slave is marked as down by the sentinel, the "flags" field
+				# (comma-separated array) contains the "s_down" value.
+				slaves_cmd_reply.map { |s| s.each_slice(2).to_h }
+						            .reject { |s| s.fetch('flags').split(',').include?('s_down') }
+			end
+
+			def select_slave(available_slaves)
+				available_slaves.sample
+			end
+		end
+	end
+end

data/lib/async/redis/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
 # 
 # Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -20,6 +22,6 @@
 
 module Async
 	module Redis
-		VERSION = "0.4.1"
+		VERSION = "0.5.2"
 	end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: async-redis
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Samuel Williams
 - Huba Nagy
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-09 00:00:00.000000000 Z
+date: 2020-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async
@@ -39,20 +39,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
+- !ruby/object:Gem::Dependency
+  name: async-pool
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: protocol-redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: async-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -68,7 +82,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: redis
+  name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -82,7 +96,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: benchmark-ips
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -110,7 +124,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: hiredis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -124,21 +138,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -152,35 +166,25 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: hiredis
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: 
+        version: '3.6'
+description:
 email:
-- samuel.williams@oriontransfer.co.nz
-- 12huba@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".editorconfig"
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
-- Gemfile
-- README.md
-- Rakefile
-- async-redis.gemspec
 - lib/async/redis.rb
 - lib/async/redis/client.rb
 - lib/async/redis/context/generic.rb
@@ -188,13 +192,14 @@ files:
 - lib/async/redis/context/subscribe.rb
 - lib/async/redis/context/transaction.rb
 - lib/async/redis/key.rb
-- lib/async/redis/pool.rb
 - lib/async/redis/protocol/resp2.rb
+- lib/async/redis/sentinels.rb
 - lib/async/redis/version.rb
 homepage: https://github.com/socketry/async-redis
-licenses: []
+licenses:
+- MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -209,8 +214,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: A Redis client library.
 test_files: []

data/.editorconfig

@@ -1,6 +0,0 @@
-root = true
-
-[*]
-indent_style = tab
-indent_size = 2
-

data/.gitignore

@@ -1,13 +0,0 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
-
-# rspec failure tracking
-.rspec_status
-.covered.db

data/.rspec

@@ -1,3 +0,0 @@
---format documentation
---warnings
---require spec_helper

data/.travis.yml

@@ -1,23 +0,0 @@
-language: ruby
-dist: xenial
-cache: bundler
-
-services:
-  - redis-server
-
-matrix:
-  include:
-    - rvm: 2.3
-    - rvm: 2.4
-    - rvm: 2.5
-    - rvm: 2.6
-    - rvm: 2.6
-      env: COVERAGE=BriefSummary,Coveralls
-    - rvm: ruby-head
-    - rvm: truffleruby
-    - rvm: jruby-head
-      env: JRUBY_OPTS="--debug -X+O"
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: truffleruby
-    - rvm: jruby-head

data/Gemfile

@@ -1,10 +0,0 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in async-io.gemspec
-gemspec
-
-# gem "protocol-redis", path: "../protocol-redis"
-
-group :development do
-	gem 'pry'
-end

data/README.md

@@ -1,125 +0,0 @@
-# Async::Redis
-
-An asynchronous client for Redis including TLS. Support for streaming requests and responses. Built on top of [async] and [async-io].
-
-[![Build Status](https://secure.travis-ci.org/socketry/async-redis.svg)](https://travis-ci.org/socketry/async-redis)
-[![Code Climate](https://codeclimate.com/github/socketry/async-redis.svg)](https://codeclimate.com/github/socketry/async-redis)
-[![Coverage Status](https://coveralls.io/repos/socketry/async-redis/badge.svg)](https://coveralls.io/r/socketry/async-redis)
-
-[async]: https://github.com/socketry/async
-[async-io]: https://github.com/socketry/async-io
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'async-redis'
-```
-
-And then execute:
-
-	$ bundle
-
-Or install it yourself as:
-
-	$ gem install async-redis
-
-## Usage
-
-### Basic Local Connection
-
-```ruby
-require 'async/redis'
-
-endpoint = Async::Redis.local_endpoint
-client = Async::Redis::Client.new(endpoint)
-
-Async do
-	pp client.info
-ensure
-	client.close
-end
-```
-
-### Variables
-
-```ruby
-require 'async'
-require 'async/redis'
-
-endpoint = Async::Redis.local_endpoint
-client = Async::Redis::Client.new(endpoint)
-
-Async do
-	client.set('X', 10)
-	pp client.get('X')
-ensure
-	client.close
-end
-```
-
-### Subscriptions
-
-```ruby
-require 'async'
-require 'async/redis'
-
-endpoint = Async::Redis.local_endpoint
-client = Async::Redis::Client.new(endpoint)
-
-Async do |task|
-	condition = Async::Condition.new
-	
-	publisher = task.async do
-		condition.wait
-		
-		client.publish 'status.frontend', 'good'
-	end
-	
-	subscriber = task.async do
-		client.subscribe 'status.frontend' do |context|
-			condition.signal # We are waiting for messages.
-			
-			type, name, message = context.listen
-			
-			pp type, name, message
-		end
-	end
-ensure
-	client.close
-end
-```
-
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
-
-## License
-
-Released under the MIT license.
-
-Copyright, 2018, by [Samuel G. D. Williams](http://www.codeotaku.com/samuel-williams).  
-Copyright, 2018, by Huba Z. Nagy.  
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.

data/Rakefile

@@ -1,18 +0,0 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:test)
-
-task :default => :test
-
-task :client do
-	require 'irb'
-	require 'async/redis/client'
-	
-	endpoint = Async::Redis.local_endpoint
-	client = Async::Redis::Client.new(endpoint)
-	
-	Async do
-		binding.irb
-	end
-end

data/async-redis.gemspec

@@ -1,38 +0,0 @@
-
-require_relative 'lib/async/redis/version'
-
-Gem::Specification.new do |spec|
-	spec.name          = "async-redis"
-	spec.version       = Async::Redis::VERSION
-	spec.authors       = ["Samuel Williams", "Huba Nagy"]
-	spec.email         = ["samuel.williams@oriontransfer.co.nz", "12huba@gmail.com"]
-
-	spec.summary       = "A Redis client library."
-	spec.homepage      = "https://github.com/socketry/async-redis"
-
-	spec.files         = `git ls-files -z`.split("\x0").reject do |f|
-		f.match(%r{^(test|spec|features)/})
-	end
-	
-	spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-	spec.require_paths = ["lib"]
-	
-	spec.add_dependency("async", "~> 1.8")
-	spec.add_dependency("async-io", "~> 1.10")
-	
-	spec.add_dependency("protocol-redis", "~> 0.2.0")
-	
-	spec.add_development_dependency "async-rspec", "~> 1.1"
-	spec.add_development_dependency "redis"
-	spec.add_development_dependency "benchmark-ips"
-
-	spec.add_development_dependency "covered"
-	spec.add_development_dependency "bundler"
-	spec.add_development_dependency "rspec", "~> 3.6"
-	spec.add_development_dependency "rake"
-
-	# Dependencies with C extensions
-	if defined?(RUBY_ENGINE) && RUBY_ENGINE == "ruby"
-		spec.add_development_dependency "hiredis"
-	end
-end

data/lib/async/redis/pool.rb

@@ -1,135 +0,0 @@
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
-
-require 'async/notification'
-
-module Async
-	module Redis
-		# It might make sense to add support for pipelining https://redis.io/topics/pipelining
-		# We should be able to wrap the protocol so that write_request and read_response happen in lockstep.
-		# The only problem would be blocking operations. It might also be confusing if order of operations affects commands.
-		class Pool
-			def initialize(limit = nil, &block)
-				@resources = []
-				@available = Async::Notification.new
-				
-				@limit = limit
-				@active = 0
-				
-				@constructor = block
-			end
-			
-			attr :resources
-			
-			def empty?
-				@resources.empty?
-			end
-			
-			def acquire
-				resource = wait_for_resource
-				
-				return resource unless block_given?
-				
-				begin
-					yield resource
-				ensure
-					release(resource)
-				end
-			end
-			
-			# Make the resource resources and let waiting tasks know that there is something resources.
-			def release(resource)
-				# A resource that is not good should also not be reusable.
-				unless resource.closed?
-					reuse(resource)
-				else
-					retire(resource)
-				end
-			end
-			
-			def close
-				@resources.each(&:close)
-				@resources.clear
-				
-				@active = 0
-			end
-			
-			def to_s
-				"\#<#{self.class} resources=#{resources.size} limit=#{@limit}>"
-			end
-			
-			protected
-			
-			def reuse(resource)
-				Async.logger.debug(self) {"Reuse #{resource}"}
-				
-				@resources << resource
-				
-				@available.signal
-			end
-			
-			def retire(resource)
-				Async.logger.debug(self) {"Retire #{resource}"}
-				
-				@active -= 1
-				
-				resource.close
-				
-				@available.signal
-			end
-			
-			def wait_for_resource
-				# If we fail to create a resource (below), we will end up waiting for one to become resources.
-				until resource = available_resource
-					@available.wait
-				end
-				
-				Async.logger.debug(self) {"Wait for resource #{resource}"}
-				
-				return resource
-			end
-			
-			def create
-				# This might return nil, which means creating the resource failed.
-				return @constructor.call
-			end
-			
-			def available_resource
-				while resource = @resources.pop
-					if resource.connected?
-						return resource
-					else
-						retire(resource)
-					end
-				end
-				
-				if !@limit or @active < @limit
-					Async.logger.debug(self) {"No resources resources, allocating new one..."}
-					
-					@active += 1
-					
-					return create
-				end
-				
-				return nil
-			end
-		end
-	end
-end