async-io 1.27.5 → 1.27.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2aa645f59a002756ee40be3c903917fb8010d91d61f1984a863481cab364644c
-  data.tar.gz: 8e4fc966f387cb76a7635923d4f3803a2cd91354ddf63fc4618431c97c1c89e9
+  metadata.gz: 8e0bff7f13a902bd5ef577d7a36d067f482c4d02001dfe1111ef83cb549187fd
+  data.tar.gz: 80aa5c4aaf1da1f1fe9df08779f9be5e03168b4ba42a3a8e83b19c3b4b5205f2
 SHA512:
-  metadata.gz: 297100087ebdf7a49a147b3b29f7e1b1c9cceffcf8c2a68857bb12cf10dfde34e83e5f18c53a1060f2833bb630b17ba72f5532bbd3453e953d5362c30d4eaf2c
-  data.tar.gz: 0dfb45ca2d1134185511c44a91bf2c02e8ded1cb7e31fc10cb71ac2de93444aa45a5dd44a5edb94f224a1b2800c1d63818ae23803a0607137de5a810486fa878
+  metadata.gz: 9a6cd691bc26134513232ae20b4d7c38c7807fe697360537a690fd504099b825e546c6be4cd7fbb50d50164f55d46a02a0a5986a1ee97b64673342442886cf84
+  data.tar.gz: cf04dd4be38376c52b76c88233b5de97b58e7dc4ce14cac2a9d68824dc5489db3e192fb0d29bb8101d15a2172ffce66be51e9914a8b22b65807cd17a8cb4f583

data/Gemfile

@@ -8,6 +8,8 @@ gemspec
 group :development do
 	gem 'pry'
 	gem 'guard-rspec'
+	
+	gem 'bake-bundler'
 end
 
 group :test do

data/lib/async/io/generic.rb

@@ -29,7 +29,7 @@ module Async
 		BLOCK_SIZE = ENV.fetch('ASYNC_IO_BLOCK_SIZE', 1024*64).to_i
 		
 		# The maximum read size when appending to IO buffers. Defaults to 8MB.
-		MAXIMUM_READ_SIZE = ENV.fetch('ASYNC_IO_MAXIMUM_READ_SIZE', BLOCK_SIZE * 128 * 8).to_i
+		MAXIMUM_READ_SIZE = ENV.fetch('ASYNC_IO_MAXIMUM_READ_SIZE', BLOCK_SIZE * 128).to_i
 		
 		# Convert a Ruby ::IO object to a wrapped instance:
 		def self.try_convert(io, &block)

data/lib/async/io/stream.rb

@@ -48,6 +48,7 @@ module Async
 				
 				@deferred = deferred
 				@pending = 0
+				
 				@writing = Async::Semaphore.new(1)
 				
 				# We don't want Ruby to do any IO buffering.
@@ -154,7 +155,6 @@ module Async
 					if @pending == 1
 						task.yield
 						drain_write_buffer unless @write_buffer.empty?
-						@pending = 0
 					end
 				else
 					drain_write_buffer unless @write_buffer.empty?
@@ -245,18 +245,29 @@ module Async
 			
 			def drain_write_buffer
 				@writing.acquire do
-					Async.logger.debug(self) do
+					Async.logger.debug(self) do |buffer|
 						if @pending > 0
-							"Draining #{@pending} writes (#{@write_buffer.bytesize} bytes)..."
+							buffer.puts "Draining #{@pending} writes (#{@write_buffer.bytesize} bytes)..."
 						else
-							"Draining immediate write (#{@write_buffer.bytesize} bytes)..."
+							buffer.puts "Draining immediate write (#{@write_buffer.bytesize} bytes)..."
 						end
+						
+						# buffer.puts "@write_buffer = #{@write_buffer.inspect}"
+						# buffer.puts "@drain_buffer = #{@drain_buffer.inspect}"
 					end
 					
+					# Flip the write buffer and drain buffer:
 					@write_buffer, @drain_buffer = @drain_buffer, @write_buffer
 					
-					@io.write(@drain_buffer)
-					@drain_buffer.clear
+					# The write buffer no longer contains pending writes:
+					@pending = 0
+					
+					begin
+						@io.write(@drain_buffer)
+					ensure
+						# If the write operation fails, we still need to clear this buffer, and the data is essentially lost.
+						@drain_buffer.clear
+					end
 				end
 			end
 			
@@ -281,6 +292,7 @@ module Async
 					if chunk = @io.read_nonblock(size, @input_buffer, exception: false)
 						@read_buffer << chunk
 						# Async.logger.debug(self, name: "read") {@read_buffer.inspect}
+						
 						return true
 					end
 				end

data/lib/async/io/version.rb

@@ -22,6 +22,6 @@
 
 module Async
 	module IO
-		VERSION = "1.27.5"
+		VERSION = "1.27.6"
 	end
 end

data/spec/async/io/stream_spec.rb

@@ -77,6 +77,25 @@ RSpec.describe Async::IO::Stream do
 					expect(buffer).to be == (buffer[0] * buffer_size)
 				end
 			end
+			
+			it "handles write failures" do
+				subject.close
+				
+				task = reactor.async do
+					output.write("Hello World")
+					output.flush(deferred: true)
+				end
+				
+				expect do
+					task.wait
+				end.to raise_error(Errno::EPIPE)
+				
+				write_buffer = output.instance_variable_get(:@write_buffer)
+				drain_buffer = output.instance_variable_get(:@drain_buffer)
+				
+				expect(write_buffer).to be_empty
+				expect(drain_buffer).to be_empty
+			end
 		end
 		
 		describe '#close_read' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async-io
 version: !ruby/object:Gem::Version
-  version: 1.27.5
+  version: 1.27.6
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-21 00:00:00.000000000 Z
+date: 2020-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async
@@ -122,7 +122,6 @@ files:
 - ".yardopts"
 - Gemfile
 - README.md
-- Rakefile
 - async-io.gemspec
 - examples/allocations/byteslice.rb
 - examples/allocations/memory.rb
@@ -212,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Provides support for asynchonous TCP, UDP, UNIX and SSL sockets.

data/Rakefile

@@ -1,8 +0,0 @@
-# frozen_string_literal: true
-
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:test)
-
-task :default => :test