async-io 1.16.4 → 1.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 964165da2ad0d5d46442afadfd7afda4d3ddc675cacaafdd73c3a411cee3d4b7
-  data.tar.gz: caece9fc620704475055cdc5df52748b2610c8880af5a4dd803161f16e4df9ef
+  metadata.gz: f254eacfde68b66e406ec00807db18c540f32d899fe4ceece03e39fc0c4df3dd
+  data.tar.gz: e4409d3946bfd916032afd983765f87a344e73afed3c7e83afc947bc5b2459f6
 SHA512:
-  metadata.gz: 4a0b330d6eec4f7354e1fd3d0aeba0ebb3711905bb47a0353ab8fc683261bb923508ad21eae9822ac8acc80a853877dbdeee0f11865240bb965e6dea724a87b1
-  data.tar.gz: efa6e3c135f4030bb8adafc298de93134bc9cad5ea6a58657657903bbce75b3c62904667c98c49ebb982dc7ac8977a368e8d55fad98a8b6a2f40ccf4136d7823
+  metadata.gz: 39642ae9d92dcf5772cb3df0d067df6acb355a3132efcb60deb535b516a2f47b6ffeb635a521b78eb67e0e34c9bf881f938a5bdc2d5c5f15f652c81245543cba
+  data.tar.gz: 25c54aab50b73e02abba62201c6b3750bea851ba36a6fe81074148bebcc60364f09397882f0fdb759cccba1c60a79e544995b82610f9287f3d7a33eb9e6a0507

data/.editorconfig

@@ -2,4 +2,5 @@ root = true
 
 [*]
 indent_style = tab
-indent_size = 4
+indent_size = 2
+

data/.travis.yml

@@ -13,11 +13,13 @@ matrix:
     - rvm: 2.4
     - rvm: 2.5
     - rvm: 2.6
+    - rvm: truffleruby
     - rvm: jruby-head
       env: JRUBY_OPTS="--debug -X+O"
     - rvm: ruby-head
     - rvm: rbx-3
   allow_failures:
     - rvm: ruby-head
+    - rvm: truffleruby
     - rvm: jruby-head
     - rvm: rbx-3

data/lib/async/io/socket.rb

@@ -41,6 +41,37 @@ module Async
 				# This might be thrown by recv_nonblock.
 				return false
 			end
+			
+			# Best effort to set *_NODELAY if it makes sense. Swallows errors where possible.
+			def sync=(value)
+				super
+				
+				case self.protocol
+				when 0, Socket::IPPROTO_TCP
+					self.setsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY, value ? 1 : 0)
+				else
+					warn "Unsure how to sync=#{value} for #{self.protocol}!"
+				end
+			rescue Errno::EINVAL
+				# On Darwin, sometimes occurs when the connection is not yet fully formed. Empirically, TCP_NODELAY is enabled despite this result.
+			end
+			
+			def sync
+				case self.protocol
+				when Socket::IPPROTO_TCP
+					self.getsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY).bool
+				else
+					true
+				end && super
+			end
+			
+			def type
+				self.local_address.socktype
+			end
+			
+			def protocol
+				self.local_address.protocol
+			end
 		end
 		
 		class BasicSocket < Generic
@@ -52,10 +83,6 @@ module Async
 			wrap_blocking_method :sendmsg, :sendmsg_nonblock
 			wrap_blocking_method :send, :sendmsg_nonblock, invert: false
 			
-			def type
-				self.local_address.socktype
-			end
-			
 			include Peer
 		end
 		
@@ -134,7 +161,6 @@ module Async
 				task.annotate "connecting to #{remote_address.inspect}"
 				
 				wrapper = build(remote_address.afamily, remote_address.socktype, remote_address.protocol, **options) do |socket|
-					
 					if reuse_port
 						socket.setsockopt(::Socket::SOL_SOCKET, ::Socket::SO_REUSEADDR, 1)
 					end
@@ -142,7 +168,7 @@ module Async
 					if local_address
 						socket.bind(local_address.to_sockaddr)
 					end
-
+					
 					self.new(socket, task.reactor)
 				end
 				

data/lib/async/io/version.rb

@@ -20,6 +20,6 @@
 
 module Async
 	module IO
-		VERSION = "1.16.4"
+		VERSION = "1.17.1"
 	end
 end

data/spec/async/io/generic_spec.rb

@@ -25,9 +25,11 @@ require_relative 'generic_examples'
 RSpec.describe Async::IO::Generic do
 	include_context Async::RSpec::Reactor
 	
+	CONSOLE_METHODS = [:beep, :cooked, :cooked!, :cursor, :cursor=, :echo=, :echo?,:getch, :getpass, :goto, :iflush, :ioflush, :noecho, :oflush,:pressed?, :raw, :raw!, :winsize, :winsize=]
+	
 	it_should_behave_like Async::IO::Generic, [
 		:bytes, :chars, :codepoints, :each, :each_byte, :each_char, :each_codepoint, :each_line, :getbyte, :getc, :gets, :lineno, :lineno=, :lines, :print, :printf, :putc, :puts, :readbyte, :readchar, :readline, :readlines, :ungetbyte, :ungetc
-	]
+	] + CONSOLE_METHODS
 	
 	let(:pipe) {IO.pipe}
 	let(:input) {Async::IO::Generic.new(pipe.first)}

data/spec/async/io/socket_spec.rb

@@ -71,6 +71,19 @@ RSpec.describe Async::IO::Socket do
 		end
 	end
 	
+	describe '#sync' do
+		it "should set TCP_NODELAY" do
+			address = Async::IO::Address.tcp('127.0.0.1', 0)
+			
+			socket = Async::IO::Socket.wrap(::Socket::AF_INET, ::Socket::SOCK_STREAM, ::Socket::IPPROTO_TCP)
+			
+			socket.sync = true
+			expect(socket.getsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY).bool).to be true
+			
+			socket.close
+		end
+	end
+	
 	describe '.pair' do
 		subject{described_class.pair(:UNIX, :STREAM, 0)}
 		

data/spec/spec_helper.rb

@@ -19,6 +19,11 @@ end
 require "bundler/setup"
 require "async/io"
 
+if RUBY_ENGINE == "truffleruby"
+	warn "Workarounds for TruffleRuby enabled..."
+	require_relative 'truffle'
+end
+
 # Shared rspec helpers:
 require "async/rspec"
 

data/spec/truffle.rb

@@ -0,0 +1,58 @@
+
+require 'socket'
+
+class IO
+	def write_nonblock(data, exception: true)
+		ensure_open_and_writable
+
+		data = String data
+		return 0 if data.empty?
+
+		@ibuffer.unseek!(self) unless @sync
+
+		self.nonblock = true
+
+		begin
+			Truffle::POSIX.write_string_nonblock(self, data)
+		rescue Errno::EAGAIN
+			if exception
+				raise EAGAINWaitWritable
+			else
+				return :wait_writable
+			end
+		end
+	end
+end
+
+class IO::BidirectionalPipe
+	def write_nonblock(*args, **options)
+		@write.write_nonblock(*args, **options)
+	end
+end
+
+class Socket
+	def connect_nonblock(sockaddr, exception: true)
+		fcntl(Fcntl::F_SETFL, Fcntl::O_NONBLOCK)
+
+		if sockaddr.is_a?(Addrinfo)
+			sockaddr = sockaddr.to_sockaddr
+		end
+
+		status = Truffle::Socket::Foreign.connect(descriptor, sockaddr)
+
+		# There should be a better way to do this than raising an exception!?
+		if Errno.errno == Errno::EISCONN::Errno
+			raise Errno::EISCONN
+		end
+
+		if status < 0
+			if exception
+				Truffle::Socket::Error.write_nonblock('connect(2)')
+			else
+				:wait_writable
+			end
+		else
+			0
+		end
+	end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async-io
 version: !ruby/object:Gem::Version
-  version: 1.16.4
+  version: 1.17.1
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-07 00:00:00.000000000 Z
+date: 2018-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async
@@ -152,6 +152,7 @@ files:
 - spec/async/io/wrap/http_rb_spec.rb
 - spec/async/io/wrap/tcp_spec.rb
 - spec/spec_helper.rb
+- spec/truffle.rb
 homepage: https://github.com/socketry/async-io
 licenses: []
 metadata: {}
@@ -171,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Provides support for asynchonous TCP, UDP, UNIX and SSL sockets.
@@ -201,3 +202,4 @@ test_files:
 - spec/async/io/wrap/http_rb_spec.rb
 - spec/async/io/wrap/tcp_spec.rb
 - spec/spec_helper.rb
+- spec/truffle.rb