async-htty 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f033a6514d7f18ec5f7c94b4f547ef2fa00e025eedce18d004387dde4baae5bb
-  data.tar.gz: 6d6a4cf76032a9e403c3f38f0ed4a46d1f6af61dd61ca3b712c68c93eabea6f8
+  metadata.gz: 9d7783c87883c9c45dd3d05a11b2060fea115b7a1b5a2435bcb3ebe3a2f0bb06
+  data.tar.gz: 235ff150ef9cf4966538b2899a2471df665544606d8599345f62f863772d6632
 SHA512:
-  metadata.gz: 1f027635ab2786cae7850b213eba3c37e3ac9762409d746a0d54e83d6a9366963d598843f7ccedbd729298c877181062dce7c28f20154c91a6a944cdea2430c3
-  data.tar.gz: b3bfefe4d878d7a404ffc3f3d66798f9acd5e6e17b03743849f58a281dde09a3d63c1fc85bb7918f4b8ff6a340c4335e2ddaaf1d20e882d1f270c6f953ba3f82
+  metadata.gz: af3056573867c1b572c48a713c28a07cfa7d33d363d1a5c94ef555faee4dfae35e8aeb482ed5d14cd70c11cdcf5bc78d6a5e1296c9f3b61eb4ad958f674b3166
+  data.tar.gz: 97bf7592db90bc2df78b28e39f04ea14d53ea725443e56693c3f5daf5661e2b8ce018b6e2fb5692991619a0d5dc0fc676f291131e3291931c23f1b02c71d2b55

data/lib/async/htty/protocol/htty/server.rb

@@ -12,9 +12,10 @@ module Async
 				class Server < ::Async::HTTP::Protocol::HTTP2::Server
 					def receive_goaway(frame)
 						super
-
-						unless self.framer.nil?
+						
+						if framer = self.framer
 							self.send_goaway
+							framer.flush
 						end
 					end
 				end

data/lib/async/htty/protocol/htty.rb

@@ -13,7 +13,11 @@ module Async
 		module Protocol
 			module HTTY
 				def self.client(stream, settings: ::Async::HTTP::Protocol::HTTP2::CLIENT_SETTINGS)
-					stream = ::Protocol::HTTY::Stream.open(stream, bootstrap: :read)
+					mode = stream.read_bootstrap
+					
+					unless mode == ::Protocol::HTTY::Stream::RAW_MODE
+						raise ::Protocol::HTTY::ProtocolError, "Expected HTTY bootstrap mode #{::Protocol::HTTY::Stream::RAW_MODE.inspect}, got #{mode.inspect}"
+					end
 					
 					client = ::Async::HTTP::Protocol::HTTP2::Client.new(stream)
 					client.send_connection_preface(settings)
@@ -23,7 +27,7 @@ module Async
 				end
 				
 				def self.server(stream, settings: ::Async::HTTP::Protocol::HTTP2::SERVER_SETTINGS)
-					stream = ::Protocol::HTTY::Stream.open(stream, bootstrap: :write)
+					stream.write_bootstrap
 					
 					server = Server.new(stream)
 					server.read_connection_preface(settings)

data/lib/async/htty/server.rb

@@ -45,7 +45,7 @@ module Async
 				original_output = output.dup
 				original_error = error.dup
 				
-				stream = ::IO::Stream::Duplex(original_input, original_output)
+				stream = ::Protocol::HTTY::Stream.new(original_input, original_output)
 				input.reopen(File::NULL)
 				output.reopen(File::NULL)
 				error.reopen(File::NULL)

data/lib/async/htty/version.rb

@@ -5,6 +5,6 @@
 
 module Async
 	module HTTY
-		VERSION = "0.2.1"
+		VERSION = "0.3.0"
 	end
 end

data/readme.md

@@ -14,6 +14,11 @@ Please see the [project documentation](https://socketry.github.io/async-htty/) f
 
 Please see the [project releases](https://socketry.github.io/async-htty/releases/index) for all releases.
 
+### v0.3.0
+
+  - Pass explicit terminal input and output endpoints into `Protocol::HTTY::Stream`, avoiding buffered duplex reads across the HTTY HTTP/2 transport.
+  - Expect the HTTY protocol adapter to receive a prepared `Protocol::HTTY::Stream` instance before performing bootstrap and HTTP/2 setup.
+
 ### v0.2.1
 
   - Send a server-side GOAWAY when the HTTY client closes an HTTP/2 session, allowing terminal clients to detach cleanly.

data/releases.md

@@ -1,5 +1,10 @@
 # Releases
 
+## v0.3.0
+
+  - Pass explicit terminal input and output endpoints into `Protocol::HTTY::Stream`, avoiding buffered duplex reads across the HTTY HTTP/2 transport.
+  - Expect the HTTY protocol adapter to receive a prepared `Protocol::HTTY::Stream` instance before performing bootstrap and HTTP/2 setup.
+
 ## v0.2.1
 
   - Send a server-side GOAWAY when the HTTY client closes an HTTP/2 session, allowing terminal clients to detach cleanly.

data/test/async/htty/protocol/htty.rb

@@ -65,11 +65,11 @@ describe Async::HTTY::Protocol::HTTY do
 	end
 	
 	def client_stream(pipes)
-		IO::Stream::Duplex(pipes[:client_input], pipes[:client_output])
+		Protocol::HTTY::Stream.new(pipes[:client_input], pipes[:client_output])
 	end
 	
 	def server_stream(pipes)
-		IO::Stream::Duplex(pipes[:server_input], pipes[:server_output])
+		Protocol::HTTY::Stream.new(pipes[:server_input], pipes[:server_output])
 	end
 	
 	def spawn_fixture(name)
@@ -123,7 +123,8 @@ describe Async::HTTY::Protocol::HTTY do
 		payload = (0x00..0xff).to_a.pack("C*")
 		
 		with_fixture("echo_body.rb") do |stream|
-			Protocol::HTTY::Stream.new(stream).read_bootstrap
+			stream = Protocol::HTTY::Stream.new(stream.input, stream.output)
+			stream.read_bootstrap
 			
 			framer = Protocol::HTTP2::Framer.new(stream)
 			client = EchoClient.new(framer)
@@ -174,7 +175,8 @@ describe Async::HTTY::Protocol::HTTY do
 				server_finished.signal
 			end
 			
-			stream = Protocol::HTTY::Stream.open(client_stream(pipes), bootstrap: :read)
+			stream = client_stream(pipes)
+			stream.read_bootstrap
 			framer = Protocol::HTTP2::Framer.new(stream)
 			client = Protocol::HTTP2::Client.new(framer)
 			client.send_connection_preface

data/test/async/htty/server.rb

@@ -88,8 +88,8 @@ describe Async::HTTY::Server do
 		
 		protocol.define_singleton_method(:server) do |stream|
 			reopened_to_null = [input.reopened_to_null?, output.reopened_to_null?, error.reopened_to_null?]
-			duplex_input = stream.io.input
-			duplex_output = stream.io.output
+			duplex_input = stream.input
+			duplex_output = stream.output
 			
 			stream.write("response", flush: true)
 			

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-htty
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Samuel Williams
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.3'
 executables: []
 extensions: []
 extra_rdoc_files: []