async-htty 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9d30babccdd7bf9fe410add7bb9dd2a6f7dafaa4d642bb377bf431f2aea4818
-  data.tar.gz: 8cd9da81dce5256dd99c9724491f07c94217fda9efd604f468c67b61a1b4f379
+  metadata.gz: 9d7783c87883c9c45dd3d05a11b2060fea115b7a1b5a2435bcb3ebe3a2f0bb06
+  data.tar.gz: 235ff150ef9cf4966538b2899a2471df665544606d8599345f62f863772d6632
 SHA512:
-  metadata.gz: b9a43f93f8c0a6a73e3114ea24ff950fcce09d49bd06752ca121e720ea8f566d220b41ee000514819bd1b537551e7ef74b0e191f3c6709e73a44083b0278e667
-  data.tar.gz: 0d9d94b0125c871ee18a5f95c98e45249e84b2397ef751f9c4b56b9b3175842b438630a998fd063fe0f848f75570c6a9f94b66ddc7044cdd99451173ff6c387d
+  metadata.gz: af3056573867c1b572c48a713c28a07cfa7d33d363d1a5c94ef555faee4dfae35e8aeb482ed5d14cd70c11cdcf5bc78d6a5e1296c9f3b61eb4ad958f674b3166
+  data.tar.gz: 97bf7592db90bc2df78b28e39f04ea14d53ea725443e56693c3f5daf5661e2b8ce018b6e2fb5692991619a0d5dc0fc676f291131e3291931c23f1b02c71d2b55

checksums.yaml.gz.sig

@@ -1,2 +1,2 @@
-�;�$�qǂ���jS-G��ɤЪ$�"&|�rH� ���X�^�6�A�#�
\:��"�g�.g
ݦ���8�>���%�U����шOyH����B����k�I�Q�N��������p�tds2��^BN���r�pS%��Ib>Q�P.(%�_%ܩʽ�X+��,�x'9�B:[&���n���9�&*�f��׆�Qo�P�]�����Ͳ����	m�Φ�*R|�<<���͐hn�23�?�
���
�
-ع��ԩ_E@�����l��3�%#ɖ*�Բ�0�%q��1�HI�MRӛ�/�
+����2+����X�r�g���oi�F��THj)��+�����S�JʾT�N�3�F��n�#�5�#�J#���N4�Y�q��E�ĸz����=E��[l�Ac���t��CBU>$�)�R�M�_ppF��b �;L�ѩ�<��
+H,^SO{�&8h�9 <����`q� ��(�n6j��ˡY��,���y���ƥ��V��yQ���Zaj��"тE�J�{Q�����i-Ʋ�>�gC%*у�=j�7�! �)i��N
���P�D|
qf
;������Ο|��!e�5C:���V�~,p���Jl����=�+�oj�/Ϝ9#�wd��0Lo�ڋH����'���$pJ�.ƨŢ��@X���㽂�#������|�

data/lib/async/htty/protocol/htty/server.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+# Released under the MIT License.
+# Copyright, 2026, by Samuel Williams.
+
+require "async/http/protocol/http2/server"
+
+module Async
+	module HTTY
+		module Protocol
+			module HTTY
+				class Server < ::Async::HTTP::Protocol::HTTP2::Server
+					def receive_goaway(frame)
+						super
+						
+						if framer = self.framer
+							self.send_goaway
+							framer.flush
+						end
+					end
+				end
+			end
+		end
+	end
+end

data/lib/async/htty/protocol/htty.rb

@@ -6,13 +6,18 @@
 require "protocol/htty"
 
 require "async/http/protocol/http2"
+require_relative "htty/server"
 
 module Async
 	module HTTY
 		module Protocol
 			module HTTY
 				def self.client(stream, settings: ::Async::HTTP::Protocol::HTTP2::CLIENT_SETTINGS)
-					stream = ::Protocol::HTTY::Stream.open(stream, bootstrap: :read)
+					mode = stream.read_bootstrap
+					
+					unless mode == ::Protocol::HTTY::Stream::RAW_MODE
+						raise ::Protocol::HTTY::ProtocolError, "Expected HTTY bootstrap mode #{::Protocol::HTTY::Stream::RAW_MODE.inspect}, got #{mode.inspect}"
+					end
 					
 					client = ::Async::HTTP::Protocol::HTTP2::Client.new(stream)
 					client.send_connection_preface(settings)
@@ -22,9 +27,9 @@ module Async
 				end
 				
 				def self.server(stream, settings: ::Async::HTTP::Protocol::HTTP2::SERVER_SETTINGS)
-					stream = ::Protocol::HTTY::Stream.open(stream, bootstrap: :write)
+					stream.write_bootstrap
 					
-					server = ::Async::HTTP::Protocol::HTTP2::Server.new(stream)
+					server = Server.new(stream)
 					server.read_connection_preface(settings)
 					server.start_connection
 					

data/lib/async/htty/server.rb

@@ -45,7 +45,7 @@ module Async
 				original_output = output.dup
 				original_error = error.dup
 				
-				stream = ::IO::Stream::Duplex(original_input, original_output)
+				stream = ::Protocol::HTTY::Stream.new(original_input, original_output)
 				input.reopen(File::NULL)
 				output.reopen(File::NULL)
 				error.reopen(File::NULL)

data/lib/async/htty/version.rb

@@ -5,6 +5,6 @@
 
 module Async
 	module HTTY
-		VERSION = "0.2.0"
+		VERSION = "0.3.0"
 	end
 end

data/readme.md

@@ -14,6 +14,16 @@ Please see the [project documentation](https://socketry.github.io/async-htty/) f
 
 Please see the [project releases](https://socketry.github.io/async-htty/releases/index) for all releases.
 
+### v0.3.0
+
+  - Pass explicit terminal input and output endpoints into `Protocol::HTTY::Stream`, avoiding buffered duplex reads across the HTTY HTTP/2 transport.
+  - Expect the HTTY protocol adapter to receive a prepared `Protocol::HTTY::Stream` instance before performing bootstrap and HTTP/2 setup.
+
+### v0.2.1
+
+  - Send a server-side GOAWAY when the HTTY client closes an HTTP/2 session, allowing terminal clients to detach cleanly.
+  - Add PTY coverage for binary request/response bodies across the full byte range.
+
 ### v0.2.0
 
   - Reopen `stdin`, `stdout`, and `stderr` to null devices to prevent output from interfering with HTTY's byte stream.

data/releases.md

@@ -1,5 +1,15 @@
 # Releases
 
+## v0.3.0
+
+  - Pass explicit terminal input and output endpoints into `Protocol::HTTY::Stream`, avoiding buffered duplex reads across the HTTY HTTP/2 transport.
+  - Expect the HTTY protocol adapter to receive a prepared `Protocol::HTTY::Stream` instance before performing bootstrap and HTTP/2 setup.
+
+## v0.2.1
+
+  - Send a server-side GOAWAY when the HTTY client closes an HTTP/2 session, allowing terminal clients to detach cleanly.
+  - Add PTY coverage for binary request/response bodies across the full byte range.
+
 ## v0.2.0
 
   - Reopen `stdin`, `stdout`, and `stderr` to null devices to prevent output from interfering with HTTY's byte stream.

data/test/async/htty/protocol/htty.rb

@@ -4,12 +4,48 @@
 # Copyright, 2026, by Samuel Williams.
 
 require "async"
+require "protocol/http/body/writable"
 require "protocol/http/request"
 require "protocol/http/response"
 require "protocol/http2"
+require "protocol/http2/client"
+require "protocol/http2/stream"
+require "rbconfig"
 require "async/htty"
 
+require "async/htty/pty_stream"
+
+class EchoResponseStream < Protocol::HTTP2::Stream
+	attr :response_headers
+	attr :body
+	
+	def initialize(...)
+		super
+		@response_headers = []
+		@body = +"".b
+	end
+	
+	def process_headers(frame)
+		@response_headers = super
+	end
+	
+	def process_data(frame)
+		data = super
+		@body << data.b if data
+		return data
+	end
+end
+
+class EchoClient < Protocol::HTTP2::Client
+	def create_stream(id = next_stream_id)
+		EchoResponseStream.create(self, id)
+	end
+end
+
 describe Async::HTTY::Protocol::HTTY do
+	let(:root) {File.expand_path("../../../..", __dir__)}
+	let(:ruby_load_path) {File.join(root, "lib")}
+	
 	def make_pipes
 		server_input, client_output = IO.pipe
 		client_input, server_output = IO.pipe
@@ -29,11 +65,34 @@ describe Async::HTTY::Protocol::HTTY do
 	end
 	
 	def client_stream(pipes)
-		IO::Stream::Duplex(pipes[:client_input], pipes[:client_output])
+		Protocol::HTTY::Stream.new(pipes[:client_input], pipes[:client_output])
 	end
 	
 	def server_stream(pipes)
-		IO::Stream::Duplex(pipes[:server_input], pipes[:server_output])
+		Protocol::HTTY::Stream.new(pipes[:server_input], pipes[:server_output])
+	end
+	
+	def spawn_fixture(name)
+		environment = {
+			"HTTY" => "1",
+			"RUBYLIB" => [ruby_load_path, ENV["RUBYLIB"]].compact.join(":"),
+		}
+		executable = File.join(root, "fixtures", "async", "htty", "executables", name)
+		
+		PTY.spawn(environment, RbConfig.ruby, executable)
+	end
+	
+	def with_fixture(name)
+		input, output, pid = spawn_fixture(name)
+		input.binmode
+		output.binmode
+		
+		stream = Async::HTTY::PTYStream.new(input, output)
+		
+		yield stream
+	ensure
+		stream&.close
+		Process.wait(pid) rescue nil
 	end
 	
 	it "can carry an HTTP/2 request over HTTY bootstrap and raw transport" do
@@ -60,6 +119,97 @@ describe Async::HTTY::Protocol::HTTY do
 		end
 	end
 	
+	it "round trips all byte values over a real PTY" do
+		payload = (0x00..0xff).to_a.pack("C*")
+		
+		with_fixture("echo_body.rb") do |stream|
+			stream = Protocol::HTTY::Stream.new(stream.input, stream.output)
+			stream.read_bootstrap
+			
+			framer = Protocol::HTTP2::Framer.new(stream)
+			client = EchoClient.new(framer)
+			client.send_connection_preface
+			
+			request = client.create_stream
+			request.send_headers(
+				[
+					[":method", "POST"],
+					[":path", "/echo"],
+					[":scheme", "http"],
+					[":authority", "htty.local"],
+					["content-length", payload.bytesize.to_s],
+					["content-type", "application/octet-stream"],
+				]
+			)
+			request.send_data(payload)
+			request.send_data(nil)
+			
+			until request.closed?
+				client.read_frame
+			end
+			
+			expect(request.response_headers.to_h[":status"]).to be == "200"
+			expect(request.body).to be == payload
+		ensure
+			client&.send_goaway
+			client&.close
+		end
+	end
+	
+	it "returns from accept when the client sends GOAWAY while a response body is active" do
+		pipes = make_pipes
+		body = Protocol::HTTP::Body::Writable.new
+		
+		Sync do |task|
+			request_started = Async::Notification.new
+			server_finished = Async::Notification.new
+			
+			server = Async::HTTY::Server.for do |request|
+				request_started.signal
+				Protocol::HTTP::Response[200, {}, body]
+			end
+			
+			server_task = task.async do
+				server.accept(server_stream(pipes))
+			ensure
+				server_finished.signal
+			end
+			
+			stream = client_stream(pipes)
+			stream.read_bootstrap
+			framer = Protocol::HTTP2::Framer.new(stream)
+			client = Protocol::HTTP2::Client.new(framer)
+			client.send_connection_preface
+			
+			request = client.create_stream
+			request.send_headers(
+				[[":method", "GET"], [":path", "/"], [":scheme", "http"], [":authority", "htty.local"]],
+				Protocol::HTTP2::END_STREAM
+			)
+			
+			request_started.wait
+			client.send_goaway
+			
+			task.with_timeout(1) do
+				server_finished.wait
+			end
+			
+			frame = task.with_timeout(1) do
+				loop do
+					frame = framer.read_frame(client.local_settings.maximum_frame_size)
+					break frame if frame.is_a?(Protocol::HTTP2::GoawayFrame)
+				end
+			end
+			
+			expect(frame).to be(:is_a?, Protocol::HTTP2::GoawayFrame)
+		ensure
+			body.close
+			client&.close
+			server_task&.stop
+			close_pipes(pipes)
+		end
+	end
+	
 	it "ignores terminal noise before the HTTY bootstrap" do
 		pipes = make_pipes
 		

data/test/async/htty/server.rb

@@ -88,8 +88,8 @@ describe Async::HTTY::Server do
 		
 		protocol.define_singleton_method(:server) do |stream|
 			reopened_to_null = [input.reopened_to_null?, output.reopened_to_null?, error.reopened_to_null?]
-			duplex_input = stream.io.input
-			duplex_output = stream.io.output
+			duplex_input = stream.input
+			duplex_output = stream.output
 			
 			stream.write("response", flush: true)
 			

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-htty
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Samuel Williams
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.3'
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -105,6 +105,7 @@ files:
 - lib/async/htty/error.rb
 - lib/async/htty/protocol.rb
 - lib/async/htty/protocol/htty.rb
+- lib/async/htty/protocol/htty/server.rb
 - lib/async/htty/server.rb
 - lib/async/htty/version.rb
 - license.md