async-http 0.98.0 → 0.99.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e917b21ce0a19c8ebf43041264757a1e880fc53fb80bd2f14837debfbd759e6
-  data.tar.gz: de5e2c5a9eedfbd1542c6e4edb78007636214c424574ac46d02869af4a8e6bd1
+  metadata.gz: 0b6ac145066c1d834e5466282d944564e313852717edd28359de26515a85ead6
+  data.tar.gz: 1b242251b92b8885392569c591fc0581ea94eba1751f4d2cf8f0c5279c07336e
 SHA512:
-  metadata.gz: 8c3bbc279a98b45968656445bbfa512652edf2d08550a1a21bf619e84368f0fb26f68bcc406b7c335152c4abe29cf3b8e1f6c500ff7dbf1e84af006be261b464
-  data.tar.gz: 14bf4bb97b0a58c977e856896e6c13f8812634cf88b3e03b0e80e4da0b734896256c4fb27ebcfcd4cf0cd11c4c73fe40ba60578e78abcf358a5323feb1271ff5
+  metadata.gz: 690e9bc0fd0080b7dd98119fdf8876c3f04bd84d4045b727cbdd82735159d314c6852a56a7967949939fe5b7a2182318ef7ec405ffa2d44ce4383c814952abba
+  data.tar.gz: 2e72385b497dbb1e37bb1a9237f32c963baa886cb6efe35171f78e16a940c74f22f0305f0e5892fdf1a84ade8045194c58da722dcef40213eb2acb30157eb80e

data/lib/async/http/client.rb

@@ -9,6 +9,7 @@ require "io/endpoint"
 require "async/pool/controller"
 
 require "protocol/http/body/completable"
+require "protocol/http/error"
 require "protocol/http/methods"
 
 require_relative "protocol"
@@ -126,7 +127,7 @@ module Async
 					else
 						raise
 					end
-				rescue SocketError, IOError, EOFError, Errno::ECONNRESET, Errno::EPIPE
+				rescue ::Protocol::HTTP::RemoteError, SocketError, IOError, EOFError, Errno::ECONNRESET, Errno::EPIPE
 					if connection
 						@pool.release(connection)
 						connection = nil

data/lib/async/http/protocol/http1/connection.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2018-2025, by Samuel Williams.
+# Copyright, 2018-2026, by Samuel Williams.
 
 require_relative "request"
 require_relative "response"
@@ -67,7 +67,24 @@ module Async
 					
 					# Can we use this connection to make requests?
 					def viable?
-						self.idle? && @stream&.readable?
+						unless self.idle?
+							return false
+						end
+						
+						unless @stream
+							return false
+						end
+						
+						# `nil` indicates that the connection has no data, but is still alive. An empty string means the connection is closed, while a non-empty string indicates application data on a idle HTTP/1 connection, both are failure cases.
+						if @stream.peek_partial(1)
+							return false
+						end
+						
+						return @stream.readable?
+					rescue => error
+						Console.debug(self, "Connection viability probe failed!", exception: error)
+						
+						return false
 					end
 					
 					# @returns [Boolean] Whether the connection can be reused for another request.

data/lib/async/http/protocol/http1/server.rb

@@ -10,6 +10,7 @@
 require_relative "connection"
 require_relative "finishable"
 
+require "async/promise"
 require "console/event/failure"
 
 module Async
@@ -22,14 +23,14 @@ module Async
 					def initialize(...)
 						super
 						
-						@ready = Async::Notification.new
+						@ready = Async::Promise.new
 					end
 					
 					# Called when the connection is closed, signalling any waiting tasks.
 					def closed(error = nil)
 						super
 						
-						@ready.signal
+						@ready.resolve(nil)
 					end
 					
 					# Write a failure response with the given status code.

data/lib/async/http/protocol/http2/response.rb

@@ -6,6 +6,8 @@
 require_relative "../response"
 require_relative "stream"
 
+require "async/promise"
+
 module Async
 	module HTTP
 		module Protocol
@@ -20,8 +22,7 @@ module Async
 							
 							@response = Response.new(self)
 							
-							@notification = Async::Notification.new
-							@exception = nil
+							@ready = Async::Promise.new
 						end
 						
 						attr :response
@@ -88,7 +89,7 @@ module Async
 								send_reset_stream(::Protocol::HTTP2::Error::PROTOCOL_ERROR)
 							end
 							
-							self.notify!
+							@ready.resolve(nil)
 							
 							return headers
 						end
@@ -106,22 +107,15 @@ module Async
 							@response.request.send_interim_response(status, headers)
 						end
 						
-						# Notify anyone waiting on the response headers to be received (or failure).
-						def notify!
-							if notification = @notification
-								@notification = nil
-								notification.signal
-							end
-						end
-						
 						# Wait for the headers to be received or for stream reset.
 						def wait
-							# If you call wait after the headers were already received, it should return immediately:
-							@notification&.wait
-							
-							if @exception
-								raise @exception
+							@ready.wait
+						rescue ::Protocol::HTTP2::StreamError => error
+							if error.code == ::Protocol::HTTP2::Error::INTERNAL_ERROR
+								raise ::Protocol::HTTP::RemoteError, error.message
 							end
+							
+							raise
 						end
 						
 						# Called when the stream is closed.
@@ -133,9 +127,11 @@ module Async
 								@response = nil
 							end
 							
-							@exception = error
-							
-							self.notify!
+							if error
+								@ready.reject(error)
+							else
+								@ready.resolve(nil)
+							end
 						end
 					end
 					

data/lib/async/http/protocol/http2/server.rb

@@ -6,6 +6,7 @@
 require_relative "connection"
 require_relative "request"
 
+require "async/barrier"
 require "protocol/http2/server"
 
 module Async
@@ -41,11 +42,7 @@ module Async
 					
 					# Close the server connection and stop accepting requests.
 					def close(error = nil)
-						if @requests
-							# Stop the request loop:
-							@requests.enqueue(nil)
-							@requests = nil
-						end
+						@requests.close
 						
 						super
 					end
@@ -55,9 +52,10 @@ module Async
 					# 	@parameter request [Request] The incoming HTTP/2 request.
 					def each(task: Task.current)
 						task.annotate("Reading #{version} requests for #{self.class}.")
+						barrier = Async::Barrier.new(parent: task)
 						
 						# It's possible the connection has died before we get here...
-						@requests&.async do |task, request|
+						@requests.async(parent: barrier) do |task, request|
 							task.annotate("Incoming request: #{request.method} #{request.path.inspect}.")
 							
 							response = nil
@@ -79,7 +77,9 @@ module Async
 							end
 						end
 						
-						# Maybe we should add some synchronisation here - i.e. only exit once all requests are finished.
+						barrier.wait
+					ensure
+						barrier&.stop
 					end
 				end
 			end

data/lib/async/http/version.rb

@@ -7,6 +7,6 @@
 module Async
 	# @namespace
 	module HTTP
-		VERSION = "0.98.0"
+		VERSION = "0.99.0"
 	end
 end

data/readme.md

@@ -16,6 +16,14 @@ Please see the [project documentation](https://socketry.github.io/async-http/) f
 
 Please see the [project releases](https://socketry.github.io/async-http/releases/index) for all releases.
 
+### v0.99.0
+
+  - Retry safe requests when a remote HTTP/2 endpoint resets the stream with `INTERNAL_ERROR` before returning a response.
+
+### v0.98.1
+
+  - Probe idle HTTP/1 connections before reuse, avoiding requests on connections already closed by the peer.
+
 ### v0.98.0
 
   - Rewind request bodies before retrying requests.
@@ -51,14 +59,6 @@ Please see the [project releases](https://socketry.github.io/async-http/releases
 
   - Propagate all errors from background reader to active streams so that they are closed correctly (e.g. errors are not missed).
 
-### v0.92.2
-
-  - Better handling of trailers. If invalid trailers are received, the connection (HTTP/1) or stream (HTTP/2) is reset.
-
-### v0.92.0
-
-  - **Breaking**: Remove `Async::HTTP::Reference`. Use `Protocol::URL::Reference` directly instead.
-
 ## See Also
 
   - [benchmark-http](https://github.com/socketry/benchmark-http) — A benchmarking tool to report on web server concurrency.

data/releases.md

@@ -1,5 +1,13 @@
 # Releases
 
+## v0.99.0
+
+  - Retry safe requests when a remote HTTP/2 endpoint resets the stream with `INTERNAL_ERROR` before returning a response.
+
+## v0.98.1
+
+  - Probe idle HTTP/1 connections before reuse, avoiding requests on connections already closed by the peer.
+
 ## v0.98.0
 
   - Rewind request bodies before retrying requests.

data.tar.gz.sig

@@ -1,3 +1,2 @@
-��m�9�l��Y�/�;=�>L�w1a�-$Pu�[�`�͒U���Zm��Uv���~�o
���$z�Fɯ�����j�n
-B��D�j�S��.���<�.�l5� �-^8#��
�e3�s�Ȩ���mK
~���=`
-���m
��Ƚ���%��/-OM�!�)M�
+��
+�8�0X��d�wk�T��
p}q��賗�NqѪ�}��2�hwӀ�%z�өT��`	�L��O_�4/A�荋 ��q��x�L�s�x�NQ'<�V�����\�_t��7���d\^�Y�0rXFʤR���4��=��xÝQX���G�2݁+,����rY����ِJB����( ��0bQ�-���&��O���WrfS���l.�_��'ĺ�mL���&���%W<���?>��d��e6* ��}9JB����3��P�����-�jk�%�"���d�-/�����>`��r׫2]z�F�t���A@�mz���j��D��Y

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-http
 version: !ruby/object:Gem::Version
-  version: 0.98.0
+  version: 0.99.0
 platform: ruby
 authors:
 - Samuel Williams
@@ -110,28 +110,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: protocol-http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.64'
+        version: '0.66'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.64'
+        version: '0.66'
 - !ruby/object:Gem::Dependency
   name: protocol-http1
   requirement: !ruby/object:Gem::Requirement