async-http 0.34.2 → 0.34.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 29e346514b130a63e1de8fc367ff5f85ae00469e3c9e7b41790a78381efa5a41
-  data.tar.gz: 43b4568e84df9e1c2f836dece89bb569cbf777fe5bcf81f82850b1e36c8f4a0a
+  metadata.gz: 2286b4231db339b1475ba7c3cc4dadab0238bfefda06e29698b8a137c43969c1
+  data.tar.gz: cc8610973b007b112ef52735aa4b8553f7e4ccdbc44929c2dbecbce8c8beeef1
 SHA512:
-  metadata.gz: 37a89c1db15f3228c5d2cf45ae1c31e83d2532e1157fa5cb9eb61c79ccb6a008d1b21c4e6672ff6dc55fdcbd9138251c9be1df2ef6da73c50ec2ca6904c59643
-  data.tar.gz: 6d2a879574d21d1c7025a1e45458cc5350c9e0fb9b6d6ee08935fa6ca517b6af3343aefd946cd6be37687c665592e5eca0ae91cac71ba87f903403ea3f109746
+  metadata.gz: aaec72d53ef0f56a5220d6e7efbf027264bb926081723231ad6062ce2946099efe01cb80dae1b943faeff4fbbe6293591b97d7d2b27cd9711007037c1825ee7c
+  data.tar.gz: 95b4545de1b8a9e365c62803cbfbf11d712c21eb0b63c9e310c32eb7ace1b9f49dfed6041f4fe5e37efcc33742a70b6ca90ca06333df534588ef0316637a9dbf

data/lib/async/http/client.rb

@@ -28,11 +28,11 @@ require_relative 'middleware'
 module Async
 	module HTTP
 		class Client
-			def initialize(endpoint, protocol = nil, authority = nil, retries: 3, **options)
+			def initialize(endpoint, protocol = endpoint.protocol, authority = endpoint.hostname, retries: 3, **options)
 				@endpoint = endpoint
 				
-				@protocol = protocol || endpoint.protocol
-				@authority = authority || endpoint.hostname
+				@protocol = protocol
+				@authority = authority
 				
 				@retries = retries
 				@pool = connect(**options)

data/lib/async/http/protocol/http2/response.rb

@@ -92,12 +92,23 @@ module Async
 					end
 					
 					def send_request(request)
-						headers = Headers::Merged.new({
-							SCHEME => HTTPS,
-							METHOD => request.method,
-							PATH => request.path,
-							AUTHORITY => request.authority,
-						}, request.headers)
+						# https://http2.github.io/http2-spec/#rfc.section.8.1.2.3
+						# All HTTP/2 requests MUST include exactly one valid value for the :method, :scheme, and :path pseudo-header fields, unless it is a CONNECT request (Section 8.3). An HTTP request that omits mandatory pseudo-header fields is malformed (Section 8.1.2.6).
+						pseudo_headers = [
+							[SCHEME, HTTPS],
+							[METHOD, request.method],
+							[PATH, request.path],
+						]
+						
+						# To ensure that the HTTP/1.1 request line can be reproduced accurately, this pseudo-header field MUST be omitted when translating from an HTTP/1.1 request that has a request target in origin or asterisk form (see [RFC7230], Section 5.3). Clients that generate HTTP/2 requests directly SHOULD use the :authority pseudo-header field instead of the Host header field. 
+						if authority = request.authority
+							pseudo_headers << [AUTHORITY, authority]
+						end
+						
+						headers = Headers::Merged.new(
+							pseudo_headers,
+							request.headers
+						)
 						
 						if request.body.nil?
 							@stream.send_headers(nil, headers, ::HTTP::Protocol::HTTP2::END_STREAM)

data/lib/async/http/version.rb

@@ -20,6 +20,6 @@
 
 module Async
 	module HTTP
-		VERSION = "0.34.2"
+		VERSION = "0.34.3"
 	end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async-http
 version: !ruby/object:Gem::Version
-  version: 0.34.2
+  version: 0.34.3
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-19 00:00:00.000000000 Z
+date: 2018-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async