async-http-faraday 0.21.0 → 0.22.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61ec5bb845598b4ed1282944e5ecce5ed41fd0abcac72c4bcdaedcf40b707e89
-  data.tar.gz: b16fe2a762a49b3cc20cc5c8f7e674d764ef81f1ab1cd8f95fa41f11e5bc057e
+  metadata.gz: 7d9bc8db7f390b5eab35d03ad3748aebcf800ebbfbf63c47e06345e9bf0ccc7b
+  data.tar.gz: eb25b8a2a39b8d62b36dc5f5a80c33576c10496bd63d4e4629e612801704df54
 SHA512:
-  metadata.gz: 330032d445badaf1eace0bf580012c573b24a83128c3cb7bd6b479d8710b65558450d892000cbf21aacda704428d28e63dba834f7456c5bc53b7c473f6cd511b
-  data.tar.gz: 584dd4a49d4af9d088a386f8a6130f199396ba6b93ee79af3a9fc15a6ebfcf66f0cddc7d95cfabb1d9d9acc18291e2128b0e003845e7c6241ec1fc7cc3ba2d2a
+  metadata.gz: 9f08eb5f9fd6726f3af04de66b4cb55120e8019ba9171ca171f5c5cb20e768813b95ef0035d297b6281de6c783fd29c7ce74ee0939cea5565ed46e715d827339
+  data.tar.gz: c0fd6948d709475a6746f3e3edcba70ca2e71c3dbc1f5b3dfc97097b4ff98cf7d0a2036ae1fdb8f9a815e924f2ed0e808af19b09c63ef10e5f6609171696ef9e

data/lib/async/http/faraday/adapter.rb

@@ -9,6 +9,7 @@
 # Copyright, 2023, by Flavio Fernandes.
 # Copyright, 2024, by Jacob Frautschi.
 # Copyright, 2025, by Nikolaos Anastopoulos.
+# Copyright, 2025, by Pedro Fayolle.
 
 require "faraday"
 require "faraday/adapter"
@@ -32,11 +33,16 @@ module Async
 				#
 				# @parameter body [Interface(:read)] The input body to wrap.
 				# @parameter block_size [Integer] The size of the blocks to read from the body.
-				def initialize(body, block_size: 4096)
+				# @parameter length [Integer | Nil] The length of the body, if known.
+				def initialize(body, length = nil, block_size: 4096)
 					@body = body
+					@length = length
 					@block_size = block_size
 				end
 				
+				# @attribute [Integer | Nil] The total length of the body, or `nil` if the length is unknown.
+				attr :length
+				
 				# Close the body if possible.
 				def close(error = nil)
 					@body.close if @body.respond_to?(:close)
@@ -111,7 +117,7 @@ module Async
 					SocketError
 				].freeze
 				
-				# Create a Farady compatible adapter.
+				# Create a Faraday compatible adapter.
 				# 
 				# @parameter timeout [Integer] The timeout for requests.
 				# @parameter options [Hash] Additional options to pass to the underlying Async::HTTP::Client.
@@ -168,22 +174,27 @@ module Async
 				
 				def perform_request(env)
 					with_client(env) do |endpoint, client|
+						if headers = env.request_headers
+							headers = ::Protocol::HTTP::Headers[headers]
+							
+							# Use content-length to inform body length if given, but remove the header since it will be
+							# set for us later anyway, and not doing so could result in a duplicate content-length headers
+							# if capitalization differs
+							content_length = headers.delete("content-length")&.to_i
+						end
+						
 						if body = env.body
 							# We need to ensure the body is wrapped in a Readable object so that it can be read in chunks:
 							# Faraday's body only responds to `#read`.
 							if body.is_a?(::Protocol::HTTP::Body::Readable)
 								# Good to go
 							elsif body.respond_to?(:read)
-								body = BodyReadWrapper.new(body)
+								body = BodyReadWrapper.new(body, content_length)
 							else
 								body = ::Protocol::HTTP::Body::Buffered.wrap(body)
 							end
 						end
 						
-						if headers = env.request_headers
-							headers = ::Protocol::HTTP::Headers[headers]
-						end
-						
 						method = env.method.to_s.upcase
 						
 						request = ::Protocol::HTTP::Request.new(endpoint.scheme, endpoint.authority, method, endpoint.path, nil, headers, body)

data/lib/async/http/faraday/clients.rb

@@ -177,10 +177,10 @@ module Async
 				# This will close all clients associated with all threads.
 				def close
 					Thread.list.each do |thread|
-						if clients = thread[@key]
-							clients.close
+						if clients = thread.thread_variable_get(@key)
+							thread.thread_variable_set(@key, nil)
 							
-							thread[@key] = nil
+							clients.close
 						end
 					end
 				end

data/lib/async/http/faraday/version.rb

@@ -6,7 +6,7 @@
 module Async
 	module HTTP
 		module Faraday
-			VERSION = "0.21.0"
+			VERSION = "0.22.1"
 		end
 	end
 end

data/license.md

@@ -10,6 +10,7 @@ Copyright, 2023, by Genki Takiuchi.
 Copyright, 2023, by Flavio Fernandes.  
 Copyright, 2024, by Jacob Frautschi.  
 Copyright, 2025, by Nikolaos Anastopoulos.  
+Copyright, 2025, by Pedro Fayolle.  
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/readme.md

@@ -17,6 +17,10 @@ Please see the [project documentation](https://socketry.github.io/async-http-far
 
 Please see the [project releases](https://socketry.github.io/async-http-faraday/releases/index) for all releases.
 
+### v0.22.1
+
+  - Fix memory leak in `Async::HTTP::Faraday::PerThreadPersistentClients` by ensuring that the `close` method is called on all clients when the adapter is closed.
+
 ### v0.21.0
 
   - [Improved support for `timeout` and `read_timeout`.](https://socketry.github.io/async-http-faraday/releases/index#improved-support-for-timeout-and-read_timeout.)

data/releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## v0.22.1
+
+  - Fix memory leak in `Async::HTTP::Faraday::PerThreadPersistentClients` by ensuring that the `close` method is called on all clients when the adapter is closed.
+
 ## v0.21.0
 
 ### Improved support for `timeout` and `read_timeout`.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-http-faraday
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.22.1
 platform: ruby
 authors:
 - Samuel Williams
@@ -14,6 +14,7 @@ authors:
 - Denis Talakevich
 - Flavio Fernandes
 - Jacob Frautschi
+- Pedro Fayolle
 bindir: bin
 cert_chain:
 - |
@@ -45,7 +46,7 @@ cert_chain:
   Q2K9NVun/S785AP05vKkXZEFYxqG6EW012U4oLcFl5MySFajYXRYbuUpH6AY+HP8
   voD0MPg1DssDLKwXyt1eKD/+Fq0bFWhwVM/1XiAXL7lyYUyOq24KHgQ2Csg=
   -----END CERTIFICATE-----
-date: 2025-02-15 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async-http
@@ -103,14 +104,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Provides an adaptor between async-http and faraday.
 test_files: []