async-container 0.35.1 → 0.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 293edf1aac3945b8751879fe8b8180e7fb9bcc769f5b1bea315687f19d33ea11
-  data.tar.gz: 60699b17d30ce273a236b0728246a10fb7bb47691d3f2b3827a0bc08c51fa097
+  metadata.gz: 62299eb75e389a8fcf1f7b179cdbc7803a0ecebc4fe41fb6e1f1023b702b5573
+  data.tar.gz: d13e79527be255c01311c07979eaed4ca6c22d18c36b51a2ea2644617975562c
 SHA512:
-  metadata.gz: 2febcb62a2cdce3e43e92fa0d39a943bb92ade5ef0af9401810853fdb27bca98805a75d029926bbf61de0a130da293169fc9533d091d74cd11c0d01f0ee5c296
-  data.tar.gz: 909529d757ada40f2501f96455df4f4ecad4a739365b52ef35ef77ae449c9b6869351a73cb28e0c335ef0793fed2c35656a9e6218e1b79da73fec5d4a8b09e9c
+  metadata.gz: d819e162498afd6c99125e525145fe981ceccb6d6bed77da0d01ea586f91052a24666bcd37676d66662d52637db0827536d61669e4ffee816de57d32ba621a56
+  data.tar.gz: a01f2d1a4e22ac3152392bbbdc42475ab333d1cc4605d3fb20711f495e889a2fd91de77d1bdfed580267d5d49d932b74f1b491a584551bd79b55a4cf285b474e

data/lib/async/container/controller.rb

@@ -12,6 +12,18 @@ require_relative "policy"
 
 module Async
 	module Container
+		# The default graceful stop policy for controllers.
+		GRACEFUL_STOP = ENV.fetch("ASYNC_CONTAINER_GRACEFUL_STOP", "true").then do |value|
+			case value
+			when "true"
+				true # Default timeout for graceful termination.
+			when "false"
+				false # Immediately kill the processes.
+			else
+				value.to_f
+			end
+		end
+		
 		# Manages the life-cycle of one or more containers in order to support a persistent system.
 		# e.g. a web server, job server or some other long running system.
 		class Controller
@@ -23,7 +35,7 @@ module Async
 			
 			# Initialize the controller.
 			# @parameter notify [Notify::Client] A client used for process readiness notifications.
-			def initialize(notify: Notify.open!, container_class: Container, graceful_stop: true)
+			def initialize(notify: Notify.open!, container_class: Container, graceful_stop: GRACEFUL_STOP)
 				@notify = notify
 				@container_class = container_class
 				@graceful_stop = graceful_stop

data/lib/async/container/forked.rb

@@ -101,23 +101,25 @@ module Async
 				def self.fork(**options)
 					# $stderr.puts fork: caller
 					self.new(**options) do |process|
-						::Process.fork do
-							# We use `Thread.current.raise(...)` so that exceptions are filtered through `Thread.handle_interrupt` correctly.
-							Signal.trap(:INT){::Thread.current.raise(Interrupt)}
-							Signal.trap(:TERM){::Thread.current.raise(Interrupt)}  # Same as SIGINT.
-							Signal.trap(:HUP){::Thread.current.raise(Restart)}
-							
-							# This could be a configuration option:
-							::Thread.handle_interrupt(SignalException => :immediate) do
-								yield Instance.for(process)
-							rescue Interrupt
-								# Graceful exit.
-							rescue Exception => error
-								Console.error(self, error)
+						::Thread.new do
+							::Process.fork do
+								# We use `Thread.current.raise(...)` so that exceptions are filtered through `Thread.handle_interrupt` correctly.
+								Signal.trap(:INT){::Thread.current.raise(Interrupt)}
+								Signal.trap(:TERM){::Thread.current.raise(Interrupt)}  # Same as SIGINT.
+								Signal.trap(:HUP){::Thread.current.raise(Restart)}
 								
-								exit!(1)
+								# This could be a configuration option:
+								::Thread.handle_interrupt(SignalException => :immediate) do
+									yield Instance.for(process)
+								rescue Interrupt
+									# Graceful exit.
+								rescue Exception => error
+									Console.error(self, error)
+									
+									exit!(1)
+								end
 							end
-						end
+						end.value
 					end
 				end
 				

data/lib/async/container/group.rb

@@ -10,19 +10,7 @@ require_relative "error"
 
 module Async
 	module Container
-		# The default timeout for terminating processes, before escalating to killing.
-		GRACEFUL_TIMEOUT = ENV.fetch("ASYNC_CONTAINER_GRACEFUL_TIMEOUT", "true").then do |value|
-			case value
-			when "true"
-				true # Default timeout for graceful termination.
-			when "false"
-				false # Immediately kill the processes.
-			else
-				value.to_f
-			end
-		end
-		
-		# The default timeout for graceful termination.
+		# The default timeout for graceful termination, used when the `graceful` argument is true.
 		DEFAULT_GRACEFUL_TIMEOUT = 10.0
 		
 		# Manages a group of running processes.
@@ -163,7 +151,7 @@ module Async
 			# If `graceful` is false, skip the SIGINT phase and go directly to SIGKILL.
 			#
 			# @parameter graceful [Boolean | Numeric] Whether to send SIGINT first or skip directly to SIGKILL.
-			def stop(graceful = GRACEFUL_TIMEOUT)
+			def stop(graceful = true)
 				Console.debug(self, "Stopping all processes...", graceful: graceful)
 				
 				# If a timeout is specified, interrupt the children first:

data/lib/async/container/version.rb

@@ -5,6 +5,6 @@
 
 module Async
 	module Container
-		VERSION = "0.35.1"
+		VERSION = "0.37.0"
 	end
 end

data/readme.md

@@ -28,6 +28,14 @@ Please see the [project documentation](https://socketry.github.io/async-containe
 
 Please see the [project releases](https://socketry.github.io/async-container/releases/index) for all releases.
 
+### v0.37.0
+
+  - Rename `ASYNC_CONTAINER_GRACEFUL_TIMEOUT` to `ASYNC_CONTAINER_GRACEFUL_STOP` and apply it at the controller level as `GRACEFUL_STOP`. `Group#stop` now only applies the shutdown policy it is given.
+
+### v0.36.0
+
+  - Forked containers now fork child processes from a short-lived thread, reducing inherited scheduler and parent stack state in children.
+
 ### v0.35.1
 
   - **Fixed**: `Hybrid` container now stops on interrupt instead of restarting indefinitely.
@@ -60,15 +68,6 @@ Please see the [project releases](https://socketry.github.io/async-container/rel
 
   - Add `Policy#make_statistics` to allow policies to customize statistics initialization.
 
-### v0.32.1
-
-  - Expose `Async::Container::Controller` `#notify`, `#container_class`, and `#graceful_stop` for testing.
-
-### v0.32.0
-
-  - Minor **breaking** changes to `Async::Container::Policy` interface.
-  - Expose `Async::Container::Statistics::Rate#window`.
-
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -1,5 +1,13 @@
 # Releases
 
+## v0.37.0
+
+  - Rename `ASYNC_CONTAINER_GRACEFUL_TIMEOUT` to `ASYNC_CONTAINER_GRACEFUL_STOP` and apply it at the controller level as `GRACEFUL_STOP`. `Group#stop` now only applies the shutdown policy it is given.
+
+## v0.36.0
+
+  - Forked containers now fork child processes from a short-lived thread, reducing inherited scheduler and parent stack state in children.
+
 ## v0.35.1
 
   - **Fixed**: `Hybrid` container now stops on interrupt instead of restarting indefinitely.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-container
 version: !ruby/object:Gem::Version
-  version: 0.35.1
+  version: 0.37.0
 platform: ruby
 authors:
 - Samuel Williams