async-container 0.34.4 → 0.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45d1096677e99abf4e408324f81089d3a09dffe06faec9802505f0982a286c9c
-  data.tar.gz: 9297103dfdd8c2181881a7cc6639afcc4d16ea3acfcd4f6074429c6a06c229f5
+  metadata.gz: 047d770adce55a53f648a828ac9e1b4694598d8815d06c271cb293b31829ac90
+  data.tar.gz: d54a1bda7d25bd2d33b72c62ea0722a8c82a3a68045b1cae529ed149d37e5ea8
 SHA512:
-  metadata.gz: c1e6e6c690ab46402878c54a91565decb35a5cfbb6f10b49e393949fafe2cba33da780bbdbb9a2b01dd9ad80487a16e83c7188667f22ee6e8c8696008a0e8ce2
-  data.tar.gz: fce543a64ebb908baa70bd0c5912b92b1395e3a99fc257cc3280cd3527f23215001e1aebfa50946f6fd956011f981b84e92a8ced7d4079e063fa9be542d1e8c6
+  metadata.gz: 5175d784347c33381f3014ce30845448890b6074ddb606861877fb23937a1afcdf0d776dd70d5f700498de4b09e59560936b78f59d0b3b2f2bf9b96d132efa24
+  data.tar.gz: c5e130f7dd4723935e9ae95f3aebb63dcea17aba57c2a995a5bb5ac4085973e63b5c1bf3dfb79d9ea79dd20b3a017be9b7f38937babe4f09ac7c6135f44f7300

data/lib/async/container/forked.rb

@@ -80,13 +80,15 @@ module Async
 					# This method replaces the child process with the new executable, thus this method never returns.
 					#
 					# @parameter arguments [Array] The arguments to pass to the new process.
-					# @parameter ready [Boolean] If true, informs the parent process that the child is ready. Otherwise, the child process will need to use a notification protocol to inform the parent process that it is ready.
+					# @parameter ready [Boolean] If true, informs the parent process that the child is ready before exec. The notification pipe will still be passed to the exec'd process to prevent premature termination.
 					# @parameter options [Hash] Additional options to pass to {::Process.exec}.
 					def exec(*arguments, ready: true, **options)
+						# Always set up the notification pipe to be inherited by the exec'd process.
+						# This prevents the pipe from closing, which would trigger hang prevention and SIGKILL.
+						self.before_spawn(arguments, options)
+						
 						if ready
 							self.ready!(status: "(exec)")
-						else
-							self.before_spawn(arguments, options)
 						end
 						
 						::Process.exec(*arguments, **options)

data/lib/async/container/generic.rb

@@ -115,6 +115,11 @@ module Async
 				@group.wait
 			end
 			
+			# Gracefully interrupt all child instances.
+			def interrupt
+				@group.interrupt
+			end
+			
 			# Returns true if all children instances have the specified status flag set.
 			# e.g. `:ready`.
 			# This state is updated by the process readiness protocol mechanism. See {Notify::Client} for more details.

data/lib/async/container/hybrid.rb

@@ -31,14 +31,15 @@ module Async
 						container.wait_until_ready
 						instance.ready!
 						
-						container.wait
-					rescue Async::Container::Terminate
-						# Stop it immediately:
-						container.stop(false)
-						raise
+						begin
+							container.wait
+						rescue Interrupt
+							# Gracefully interrupt child threads; parent process handles escalation.
+							container.interrupt
+							retry
+						end
 					ensure
-						# Stop it gracefully (also code path for Interrupt):
-						container.stop
+						container.stop(false)
 					end
 				end
 				

data/lib/async/container/threaded.rb

@@ -91,10 +91,11 @@ module Async
 					# Execute a child process using {::Process.spawn}. In order to simulate {::Process.exec}, an {Exit} instance is raised to propagage exit status.
 					# This creates the illusion that this method does not return (normally).
 					def exec(*arguments, ready: true, **options)
+						# Always set up the notification pipe to be inherited by the spawned process.
+						self.before_spawn(arguments, options)
+						
 						if ready
 							self.ready!(status: "(spawn)")
-						else
-							self.before_spawn(arguments, options)
 						end
 						
 						begin

data/lib/async/container/version.rb

@@ -5,6 +5,6 @@
 
 module Async
 	module Container
-		VERSION = "0.34.4"
+		VERSION = "0.35.0"
 	end
 end

data/readme.md

@@ -28,6 +28,14 @@ Please see the [project documentation](https://socketry.github.io/async-containe
 
 Please see the [project releases](https://socketry.github.io/async-container/releases/index) for all releases.
 
+### v0.35.0
+
+  - **Fixed**: `Hybrid` now interrupts inner threaded children during graceful shutdown and force-stops remaining children on exit.
+
+### v0.34.5
+
+  - **Fixed**: `instance.exec` with `ready: true` no longer causes premature termination. The notification pipe is now always passed to the exec'd process.
+
 ### v0.34.4
 
   - Add missing `bake` and `context` files to the release.
@@ -63,15 +71,6 @@ Please see the [project releases](https://socketry.github.io/async-container/rel
   - Add `Async::Container::Statistics::Rate` for tracking failure and restart rates over sliding time windows.
   - Fix restart counter to only increment when actually restarting (check `@running` flag).
 
-### v0.30.0
-
-  - `SIGTERM` is now graceful, the same as `SIGINT`, for better compatibility with Kubernetes and systemd.
-  - `ASYNC_CONTAINER_INTERRUPT_TIMEOUT` and `ASYNC_CONTAINER_TERMINATE_TIMEOUT` are removed and replaced by `ASYNC_CONTAINER_GRACEFUL_TIMEOUT`.
-
-### v0.29.0
-
-  - Introduce `Client#healthy!` for sending health check messages.
-
 ## Contributing
 
 We welcome contributions to this project.
@@ -82,6 +81,22 @@ We welcome contributions to this project.
 4.  Push to the branch (`git push origin my-new-feature`).
 5.  Create new Pull Request.
 
+### Running Tests
+
+To run the test suite:
+
+``` shell
+bundle exec sus
+```
+
+### Making Releases
+
+To make a new release:
+
+``` shell
+bundle exec bake gem:release:patch # or minor or major
+```
+
 ### Developer Certificate of Origin
 
 In order to protect users of this project, we require all contributors to comply with the [Developer Certificate of Origin](https://developercertificate.org/). This ensures that all contributions are properly licensed and attributed.

data/releases.md

@@ -1,5 +1,13 @@
 # Releases
 
+## v0.35.0
+
+  - **Fixed**: `Hybrid` now interrupts inner threaded children during graceful shutdown and force-stops remaining children on exit.
+
+## v0.34.5
+
+  - **Fixed**: `instance.exec` with `ready: true` no longer causes premature termination. The notification pipe is now always passed to the exec'd process.
+
 ## v0.34.4
 
   - Add missing `bake` and `context` files to the release.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-container
 version: !ruby/object:Gem::Version
-  version: 0.34.4
+  version: 0.35.0
 platform: ruby
 authors:
 - Samuel Williams
@@ -113,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Abstract container-based parallelism using threads and processes where appropriate.
 test_files: []