async-container 0.34.0 → 0.34.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0502d4a235533958f93fd6b4791479f056e42761394741af2427bfe027055bc
-  data.tar.gz: f4c07612adf5e21c1a7b5e86b0be8410e284f9606dad0daa5a4a3da9a94c7237
+  metadata.gz: 1c5506e1e43a28f8d2e9d47e49342821762eaab865a12de832a0517a6675f4de
+  data.tar.gz: b36a0515e6621c9cbc26aa749a7b181977d8fc331e2f17fd339004eac812048b
 SHA512:
-  metadata.gz: 1a29ea78a23485e75e30a6e552bc8dcb18b3361844a8346e57eceec6d0db473747240f3c7818c1d6e6ceeb2cf59ac46d0115c11f13a1fded65dcfbfaef2d0d87
-  data.tar.gz: 26bbb632a633a15f18a32bd76ada51524e9671123e5d45f17721fb0a5eda22aa88d851f3b32c27272dfcf52279a2729fca909ba980839557ee50abab7426a3e7
+  metadata.gz: 467d2c01e371653e65b545f0bf8ffcfc41d0551188c62ea2268988b58df5cf33a1221d50dd217046121cfdd793cecf42d92318c0d15016e03691b1add86a6574
+  data.tar.gz: 5c3b36fc6d4aa9dcc25408d183e9d3fdd47cd68a58f8e27f13f4ce259226167d3712c176c27eebda9654f7e467fb630dc86ef700ed2e8d7f468418d9857c021e

data/lib/async/container/controller.rb

@@ -111,7 +111,7 @@ module Async
 					self.restart
 				end
 				
-				Console.info(self, "Controller started...")
+				Console.info(self, "Controller started.")
 			end
 			
 			# Stop the container if it's running.

data/lib/async/container/generic.rb

@@ -170,8 +170,6 @@ module Async
 			rescue => error
 				Console.error(self, "Error while stopping container!", exception: error)
 				raise
-			ensure
-				@stopping = false
 			end
 			
 			protected def health_check_failed(child, age_clock, health_check_timeout)

data/lib/async/container/group.rb

@@ -35,9 +35,6 @@ module Async
 				
 				# The running fibers, indexed by IO:
 				@running = {}
-				
-				# This queue allows us to wait for processes to complete, without spawning new processes as a result.
-				@queue = nil
 			end
 			
 			# @returns [String] A human-readable representation of the group.
@@ -73,16 +70,11 @@ module Async
 			
 			# Sleep for at most the specified duration until some state change occurs.
 			def sleep(duration)
-				self.resume
-				self.suspend
-				
 				self.wait_for_children(duration)
 			end
 			
 			# Begin any outstanding queued processes and wait for them indefinitely.
 			def wait
-				self.resume
-				
 				with_health_checks do |duration|
 					self.wait_for_children(duration)
 				end
@@ -239,7 +231,10 @@ module Async
 					# Maybe consider using a proper event loop here:
 					if ready = self.select(duration)
 						ready.each do |io|
-							@running[io].resume
+							if fiber = @running[io]
+								# This method can be re-entered. While resuming a fiber, a policy hook may be invoked, which may invoke operations on the container. In that case, select may be called again on the same set of waiting fibers. On returning, those fibers may have already completed and removed themselves from @running, so we need to check for that.
+								fiber.resume
+							end
 						end
 					end
 				end
@@ -253,28 +248,6 @@ module Async
 					return readable
 				end
 			end
-			
-			def yield
-				if @queue
-					fiber = Fiber.current
-					
-					@queue << fiber
-					Fiber.yield
-				end
-			end
-			
-			def suspend
-				@queue ||= []
-			end
-			
-			def resume
-				if @queue
-					queue = @queue
-					@queue = nil
-					
-					queue.each(&:resume)
-				end
-			end
 		end
 	end
 end

data/lib/async/container/version.rb

@@ -5,6 +5,6 @@
 
 module Async
 	module Container
-		VERSION = "0.34.0"
+		VERSION = "0.34.2"
 	end
 end

data/readme.md

@@ -28,6 +28,10 @@ Please see the [project documentation](https://socketry.github.io/async-containe
 
 Please see the [project releases](https://socketry.github.io/async-container/releases/index) for all releases.
 
+### v0.34.2
+
+  - Once a container is stopped, it stays stopped.
+
 ### v0.34.0
 
   - Add `Async::Container::Generic#stopping?` so that policies can more accurately track the state of the container.
@@ -69,10 +73,6 @@ Please see the [project releases](https://socketry.github.io/async-container/rel
 
   - Make the child handling more robust in the face of exceptions.
 
-### v0.27.4
-
-  - Fix race condition where `wait_for` could modify `@running` while it was being iterated over (`each_value`) during health checks.
-
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## v0.34.2
+
+  - Once a container is stopped, it stays stopped.
+
 ## v0.34.0
 
   - Add `Async::Container::Generic#stopping?` so that policies can more accurately track the state of the container.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: async-container
 version: !ruby/object:Gem::Version
-  version: 0.34.0
+  version: 0.34.2
 platform: ruby
 authors:
 - Samuel Williams