asset_cloud 2.7.1 → 2.7.3

data/spec/validations_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
-require 'spec_helper'
+
+require "spec_helper"
 
 class ValidatedAsset < AssetCloud::Asset
   validate :no_cats
@@ -7,8 +8,8 @@ class ValidatedAsset < AssetCloud::Asset
   private
 
   def no_cats
-    add_error('no cats allowed!') if value =~ /cat/i
-    add_warning('bad dog!', 'wet dog smell!') if value =~ /dog/i
+    add_error("no cats allowed!") if value =~ /cat/i
+    add_warning("bad dog!", "wet dog smell!") if value =~ /dog/i
   end
 end
 
@@ -18,24 +19,24 @@ end
 
 describe ValidatedAsset do
   before(:each) do
-    @cloud = BasicCloud.new(File.dirname(__FILE__) + '/files', 'http://assets/')
-    @cat = @cloud.build('dog_pound/fido', 'cat')
-    @dog = @cloud.build('dog_pound/fido', 'dog')
+    @cloud = BasicCloud.new(File.dirname(__FILE__) + "/files", "http://assets/")
+    @cat = @cloud.build("dog_pound/fido", "cat")
+    @dog = @cloud.build("dog_pound/fido", "dog")
   end
 
   describe "#store" do
     it "should not store the asset unless validations pass" do
-      expect(@cloud).to(receive(:write).with('dog_pound/fido', 'dog').and_return(true))
+      expect(@cloud).to(receive(:write).with("dog_pound/fido", "dog").and_return(true))
 
       @cat.store
       expect(@cat.store).to(eq(false))
-      expect(@cat.errors).to(eq(['no cats allowed!']))
+      expect(@cat.errors).to(eq(["no cats allowed!"]))
       expect(@dog.store).to(eq(true))
     end
 
     it "should store asset with warnings and save them in the warnings array" do
       expect(@dog.store).to(eq(true))
-      expect(@dog.warnings).to(eq(['bad dog!', 'wet dog smell!']))
+      expect(@dog.warnings).to(eq(["bad dog!", "wet dog smell!"]))
       expect(@cat.store).to(eq(false))
       expect(@cat.warnings).to(eq([]))
     end
@@ -54,10 +55,10 @@ describe ValidatedAsset do
   describe "#valid?" do
     it "should clear errors, run validations, and return validity" do
       @cat.store
-      expect(@cat.errors).to(eq(['no cats allowed!']))
+      expect(@cat.errors).to(eq(["no cats allowed!"]))
       expect(@cat.valid?).to(eq(false))
-      expect(@cat.errors).to(eq(['no cats allowed!']))
-      @cat.value = 'disguised feline'
+      expect(@cat.errors).to(eq(["no cats allowed!"]))
+      @cat.value = "disguised feline"
       expect(@cat.valid?).to(eq(true))
       expect(@cat.errors).to(be_empty)
     end

data/spec/versioned_memory_bucket_spec.rb

@@ -1,36 +1,37 @@
 # frozen_string_literal: true
-require 'spec_helper'
+
+require "spec_helper"
 
 class VersionedMemoryCloud < AssetCloud::Base
   bucket :memory, AssetCloud::VersionedMemoryBucket
 end
 
 describe AssetCloud::VersionedMemoryBucket do
-  directory = File.dirname(__FILE__) + '/files'
+  directory = File.dirname(__FILE__) + "/files"
 
   before do
-    @fs = VersionedMemoryCloud.new(directory, 'http://assets/files')
-    %w{one two three}.each do |content|
+    @fs = VersionedMemoryCloud.new(directory, "http://assets/files")
+    ["one", "two", "three"].each do |content|
       @fs.write("memory/foo", content)
     end
   end
 
-  describe '#versioned?' do
+  describe "#versioned?" do
     it "should return true" do
       expect(@fs.buckets[:memory].versioned?).to(eq(true))
     end
   end
 
-  describe '#read_version' do
+  describe "#read_version" do
     it "should return the appropriate data when given a key and version" do
-      expect(@fs.read_version('memory/foo', 1)).to(eq('one'))
-      expect(@fs.read_version('memory/foo', 3)).to(eq('three'))
+      expect(@fs.read_version("memory/foo", 1)).to(eq("one"))
+      expect(@fs.read_version("memory/foo", 3)).to(eq("three"))
     end
   end
 
-  describe '#versions' do
+  describe "#versions" do
     it "should return a list of available version identifiers for the given key" do
-      expect(@fs.versions('memory/foo')).to(eq([1, 2, 3]))
+      expect(@fs.versions("memory/foo")).to(eq([1, 2, 3]))
     end
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.7.3
 platform: ruby
 authors:
 - Shopify
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-23 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -25,7 +24,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +38,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +52,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +66,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -100,12 +99,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/probots.yml"
+- ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
+- ".github/workflows/cla.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".rubocop_todo.yml"
+- ".ruby-version"
 - Gemfile
+- Gemfile.lock
 - History.md
 - LICENSE
 - README.rdoc
@@ -157,7 +158,6 @@ homepage: http://github.com/Shopify/asset_cloud
 licenses: []
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -165,37 +165,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: An abstraction layer around arbitrary and diverse asset stores.
-test_files:
-- spec/active_record_bucket_spec.rb
-- spec/asset_cloud/metadata_spec.rb
-- spec/asset_extension_spec.rb
-- spec/asset_spec.rb
-- spec/base_spec.rb
-- spec/blackhole_bucket_spec.rb
-- spec/bucket_chain_spec.rb
-- spec/bucket_spec.rb
-- spec/callbacks_spec.rb
-- spec/file_system_spec.rb
-- spec/files/products/key.txt
-- spec/files/versioned_stuff/foo
-- spec/find_free_key_spec.rb
-- spec/gcs_bucket_remote_spec.rb
-- spec/gcs_bucket_spec.rb
-- spec/memory_bucket_spec.rb
-- spec/mock_s3_interface.rb
-- spec/remote_s3_bucket_spec.rb
-- spec/s3_bucket_spec.rb
-- spec/spec_helper.rb
-- spec/validations_spec.rb
-- spec/versioned_memory_bucket_spec.rb
+test_files: []

data/.github/probots.yml

@@ -1,2 +0,0 @@
-enabled:
-  - cla

data/.rubocop_todo.yml

@@ -1,326 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2020-05-22 10:33:52 -0400 using RuboCop version 0.82.0.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'lib/asset_cloud/asset_extension.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'lib/asset_cloud/callbacks.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
-Layout/EmptyLinesAroundClassBody:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-    - 'lib/asset_cloud/buckets/versioned_memory_bucket.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
-  Exclude:
-    - 'lib/asset_cloud/asset.rb'
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-    - 'lib/asset_cloud/free_key_locator.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 187
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/RescueEnsureAlignment:
-  Exclude:
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Layout/SpaceAfterComma:
-  Exclude:
-    - 'lib/asset_cloud/asset.rb'
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/memory_bucket.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/bucket.rb'
-    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/memory_bucket.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
-# SupportedStylesForExponentOperator: space, no_space
-Layout/SpaceAroundOperators:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideHashLiteralBraces:
-  Exclude:
-    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
-
-# Offense count: 9
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'lib/asset_cloud/asset.rb'
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/s3_bucket.rb'
-
-# Offense count: 2
-Lint/DuplicateMethods:
-  Exclude:
-    - 'lib/asset_cloud/asset.rb'
-
-# Offense count: 1
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-
-# Offense count: 1
-# Configuration parameters: AllowComments.
-Lint/SuppressedException:
-  Exclude:
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'lib/asset_cloud/buckets/memory_bucket.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/blackhole_bucket.rb'
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/invalid_bucket.rb'
-
-# Offense count: 6
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-    - 'spec/gcs_bucket_spec.rb'
-
-# Offense count: 1
-Naming/ConstantName:
-  Exclude:
-    - 'lib/asset_cloud/buckets/invalid_bucket.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/asset_cloud/asset.rb'
-    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerBackticks.
-# SupportedStyles: backticks, percent_x, mixed
-Style/CommandLiteral:
-  Exclude:
-    - 'asset_cloud.gemspec'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
-  Exclude:
-    - 'lib/asset_cloud/asset_extension.rb'
-    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
-
-# Offense count: 17
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreMacros, IgnoredMethods, IgnoredPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
-# SupportedStyles: require_parentheses, omit_parentheses
-Style/MethodCallWithArgsParentheses:
-  Exclude:
-    - 'Gemfile'
-    - 'Rakefile'
-    - 'asset_cloud.gemspec'
-    - 'lib/asset_cloud.rb'
-    - 'lib/asset_cloud/asset.rb'
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-    - 'lib/asset_cloud/metadata.rb'
-
-# Offense count: 2
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'spec/callbacks_spec.rb'
-
-# Offense count: 2
-Style/MissingRespondToMissing:
-  Exclude:
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'spec/callbacks_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/bucket.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/s3_bucket.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: short, verbose
-Style/PreferredHashMethods:
-  Exclude:
-    - 'lib/asset_cloud/buckets/memory_bucket.rb'
-    - 'lib/asset_cloud/buckets/versioned_memory_bucket.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/RedundantBegin:
-  Exclude:
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-    - 'lib/asset_cloud/buckets/gcs_bucket.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Style/RedundantPercentQ:
-  Exclude:
-    - 'asset_cloud.gemspec'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AllowMultipleReturnValues.
-Style/RedundantReturn:
-  Exclude:
-    - 'lib/asset_cloud/buckets/bucket_chain.rb'
-    - 'lib/asset_cloud/buckets/gcs_bucket.rb'
-    - 'lib/asset_cloud/buckets/s3_bucket.rb'
-
-# Offense count: 14
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/asset_cloud/asset.rb'
-    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
-    - 'lib/asset_cloud/callbacks.rb'
-    - 'lib/asset_cloud/metadata.rb'
-    - 'lib/asset_cloud/validations.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
-    - 'lib/asset_cloud/buckets/s3_bucket.rb'
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'lib/asset_cloud/base.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowIfMethodIsEmpty.
-Style/SingleLineMethods:
-  Exclude:
-    - 'lib/asset_cloud/asset_extension.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: use_perl_names, use_english_names
-Style/SpecialGlobalVars:
-  Exclude:
-    - 'asset_cloud.gemspec'