asset_cloud 2.7.1 → 2.7.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (50) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/ci.yml +20 -5
  3. data/.github/workflows/cla.yml +22 -0
  4. data/.rubocop.yml +3 -1
  5. data/Gemfile +5 -3
  6. data/History.md +4 -0
  7. data/Rakefile +18 -16
  8. data/asset_cloud.gemspec +19 -18
  9. data/dev.yml +1 -1
  10. data/lib/asset_cloud/asset.rb +17 -13
  11. data/lib/asset_cloud/asset_extension.rb +27 -15
  12. data/lib/asset_cloud/base.rb +77 -72
  13. data/lib/asset_cloud/bucket.rb +5 -2
  14. data/lib/asset_cloud/buckets/active_record_bucket.rb +16 -14
  15. data/lib/asset_cloud/buckets/blackhole_bucket.rb +2 -0
  16. data/lib/asset_cloud/buckets/bucket_chain.rb +38 -31
  17. data/lib/asset_cloud/buckets/file_system_bucket.rb +14 -15
  18. data/lib/asset_cloud/buckets/gcs_bucket.rb +6 -8
  19. data/lib/asset_cloud/buckets/invalid_bucket.rb +9 -6
  20. data/lib/asset_cloud/buckets/memory_bucket.rb +7 -4
  21. data/lib/asset_cloud/buckets/s3_bucket.rb +11 -8
  22. data/lib/asset_cloud/buckets/versioned_memory_bucket.rb +4 -2
  23. data/lib/asset_cloud/callbacks.rb +7 -3
  24. data/lib/asset_cloud/free_key_locator.rb +6 -6
  25. data/lib/asset_cloud/metadata.rb +11 -7
  26. data/lib/asset_cloud/validations.rb +9 -5
  27. data/lib/asset_cloud.rb +23 -21
  28. data/spec/active_record_bucket_spec.rb +27 -26
  29. data/spec/asset_cloud/metadata_spec.rb +4 -2
  30. data/spec/asset_extension_spec.rb +17 -16
  31. data/spec/asset_spec.rb +27 -21
  32. data/spec/base_spec.rb +93 -92
  33. data/spec/blackhole_bucket_spec.rb +12 -11
  34. data/spec/bucket_chain_spec.rb +61 -56
  35. data/spec/bucket_spec.rb +6 -5
  36. data/spec/callbacks_spec.rb +41 -39
  37. data/spec/file_system_spec.rb +25 -24
  38. data/spec/find_free_key_spec.rb +16 -17
  39. data/spec/gcs_bucket_remote_spec.rb +23 -22
  40. data/spec/gcs_bucket_spec.rb +48 -60
  41. data/spec/memory_bucket_spec.rb +12 -11
  42. data/spec/mock_s3_interface.rb +17 -6
  43. data/spec/remote_s3_bucket_spec.rb +31 -28
  44. data/spec/s3_bucket_spec.rb +19 -17
  45. data/spec/spec_helper.rb +8 -7
  46. data/spec/validations_spec.rb +13 -12
  47. data/spec/versioned_memory_bucket_spec.rb +11 -10
  48. metadata +9 -32
  49. data/.github/probots.yml +0 -2
  50. data/.rubocop_todo.yml +0 -326
data/.rubocop_todo.yml DELETED
@@ -1,326 +0,0 @@
1
- # This configuration was generated by
2
- # `rubocop --auto-gen-config`
3
- # on 2020-05-22 10:33:52 -0400 using RuboCop version 0.82.0.
4
- # The point is for the user to remove these configuration records
5
- # one by one as the offenses are removed from the code base.
6
- # Note that changes in the inspected code, or installation of new
7
- # versions of RuboCop, may require this file to be generated again.
8
-
9
- # Offense count: 7
10
- # Cop supports --auto-correct.
11
- # Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
12
- Layout/EmptyLineBetweenDefs:
13
- Exclude:
14
- - 'lib/asset_cloud/asset_extension.rb'
15
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
16
-
17
- # Offense count: 1
18
- # Cop supports --auto-correct.
19
- # Configuration parameters: EnforcedStyle.
20
- # SupportedStyles: empty_lines, no_empty_lines
21
- Layout/EmptyLinesAroundBlockBody:
22
- Exclude:
23
- - 'lib/asset_cloud/callbacks.rb'
24
-
25
- # Offense count: 4
26
- # Cop supports --auto-correct.
27
- # Configuration parameters: EnforcedStyle.
28
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
29
- Layout/EmptyLinesAroundClassBody:
30
- Exclude:
31
- - 'lib/asset_cloud/base.rb'
32
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
33
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
34
- - 'lib/asset_cloud/buckets/versioned_memory_bucket.rb'
35
-
36
- # Offense count: 6
37
- # Cop supports --auto-correct.
38
- # Configuration parameters: EnforcedStyle.
39
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
40
- Layout/EmptyLinesAroundModuleBody:
41
- Exclude:
42
- - 'lib/asset_cloud/asset.rb'
43
- - 'lib/asset_cloud/base.rb'
44
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
45
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
46
- - 'lib/asset_cloud/free_key_locator.rb'
47
-
48
- # Offense count: 2
49
- # Cop supports --auto-correct.
50
- # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
51
- Layout/ExtraSpacing:
52
- Exclude:
53
- - 'lib/asset_cloud/base.rb'
54
-
55
- # Offense count: 9
56
- # Cop supports --auto-correct.
57
- # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
58
- # URISchemes: http, https
59
- Layout/LineLength:
60
- Max: 187
61
-
62
- # Offense count: 1
63
- # Cop supports --auto-correct.
64
- Layout/RescueEnsureAlignment:
65
- Exclude:
66
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
67
-
68
- # Offense count: 5
69
- # Cop supports --auto-correct.
70
- Layout/SpaceAfterComma:
71
- Exclude:
72
- - 'lib/asset_cloud/asset.rb'
73
- - 'lib/asset_cloud/base.rb'
74
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
75
- - 'lib/asset_cloud/buckets/memory_bucket.rb'
76
-
77
- # Offense count: 7
78
- # Cop supports --auto-correct.
79
- # Configuration parameters: EnforcedStyle.
80
- # SupportedStyles: space, no_space
81
- Layout/SpaceAroundEqualsInParameterDefault:
82
- Exclude:
83
- - 'lib/asset_cloud/base.rb'
84
- - 'lib/asset_cloud/bucket.rb'
85
- - 'lib/asset_cloud/buckets/active_record_bucket.rb'
86
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
87
- - 'lib/asset_cloud/buckets/memory_bucket.rb'
88
-
89
- # Offense count: 3
90
- # Cop supports --auto-correct.
91
- # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
92
- # SupportedStylesForExponentOperator: space, no_space
93
- Layout/SpaceAroundOperators:
94
- Exclude:
95
- - 'lib/asset_cloud/base.rb'
96
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
97
-
98
- # Offense count: 22
99
- # Cop supports --auto-correct.
100
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
101
- # SupportedStyles: space, no_space
102
- # SupportedStylesForEmptyBraces: space, no_space
103
- Layout/SpaceInsideBlockBraces:
104
- Exclude:
105
- - 'lib/asset_cloud/base.rb'
106
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
107
-
108
- # Offense count: 2
109
- # Cop supports --auto-correct.
110
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
111
- # SupportedStyles: space, no_space, compact
112
- # SupportedStylesForEmptyBraces: space, no_space
113
- Layout/SpaceInsideHashLiteralBraces:
114
- Exclude:
115
- - 'lib/asset_cloud/buckets/active_record_bucket.rb'
116
-
117
- # Offense count: 9
118
- # Configuration parameters: AllowSafeAssignment.
119
- Lint/AssignmentInCondition:
120
- Exclude:
121
- - 'lib/asset_cloud/asset.rb'
122
- - 'lib/asset_cloud/base.rb'
123
- - 'lib/asset_cloud/buckets/active_record_bucket.rb'
124
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
125
- - 'lib/asset_cloud/buckets/s3_bucket.rb'
126
-
127
- # Offense count: 2
128
- Lint/DuplicateMethods:
129
- Exclude:
130
- - 'lib/asset_cloud/asset.rb'
131
-
132
- # Offense count: 1
133
- Lint/IneffectiveAccessModifier:
134
- Exclude:
135
- - 'lib/asset_cloud/base.rb'
136
-
137
- # Offense count: 1
138
- # Configuration parameters: AllowComments.
139
- Lint/SuppressedException:
140
- Exclude:
141
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
142
-
143
- # Offense count: 1
144
- # Cop supports --auto-correct.
145
- # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
146
- Lint/UnusedBlockArgument:
147
- Exclude:
148
- - 'lib/asset_cloud/buckets/memory_bucket.rb'
149
-
150
- # Offense count: 9
151
- # Cop supports --auto-correct.
152
- # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
153
- Lint/UnusedMethodArgument:
154
- Exclude:
155
- - 'lib/asset_cloud/base.rb'
156
- - 'lib/asset_cloud/buckets/blackhole_bucket.rb'
157
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
158
- - 'lib/asset_cloud/buckets/invalid_bucket.rb'
159
-
160
- # Offense count: 6
161
- Lint/UselessAssignment:
162
- Exclude:
163
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
164
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
165
- - 'spec/gcs_bucket_spec.rb'
166
-
167
- # Offense count: 1
168
- Naming/ConstantName:
169
- Exclude:
170
- - 'lib/asset_cloud/buckets/invalid_bucket.rb'
171
-
172
- # Offense count: 2
173
- # Cop supports --auto-correct.
174
- # Configuration parameters: EnforcedStyle.
175
- # SupportedStyles: always, conditionals
176
- Style/AndOr:
177
- Exclude:
178
- - 'lib/asset_cloud/asset.rb'
179
- - 'lib/asset_cloud/buckets/active_record_bucket.rb'
180
-
181
- # Offense count: 1
182
- # Cop supports --auto-correct.
183
- # Configuration parameters: EnforcedStyle, AllowInnerBackticks.
184
- # SupportedStyles: backticks, percent_x, mixed
185
- Style/CommandLiteral:
186
- Exclude:
187
- - 'asset_cloud.gemspec'
188
-
189
- # Offense count: 1
190
- # Cop supports --auto-correct.
191
- # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
192
- # SupportedStyles: assign_to_condition, assign_inside_condition
193
- Style/ConditionalAssignment:
194
- Exclude:
195
- - 'lib/asset_cloud/base.rb'
196
-
197
- # Offense count: 22
198
- # Cop supports --auto-correct.
199
- # Configuration parameters: EnforcedStyle.
200
- # SupportedStyles: always, always_true, never
201
- Style/FrozenStringLiteralComment:
202
- Enabled: false
203
-
204
- # Offense count: 3
205
- # Cop supports --auto-correct.
206
- # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
207
- # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
208
- Style/HashSyntax:
209
- Exclude:
210
- - 'lib/asset_cloud/asset_extension.rb'
211
- - 'lib/asset_cloud/buckets/active_record_bucket.rb'
212
-
213
- # Offense count: 17
214
- # Cop supports --auto-correct.
215
- # Configuration parameters: IgnoreMacros, IgnoredMethods, IgnoredPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
216
- # SupportedStyles: require_parentheses, omit_parentheses
217
- Style/MethodCallWithArgsParentheses:
218
- Exclude:
219
- - 'Gemfile'
220
- - 'Rakefile'
221
- - 'asset_cloud.gemspec'
222
- - 'lib/asset_cloud.rb'
223
- - 'lib/asset_cloud/asset.rb'
224
- - 'lib/asset_cloud/base.rb'
225
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
226
- - 'lib/asset_cloud/metadata.rb'
227
-
228
- # Offense count: 2
229
- Style/MethodMissingSuper:
230
- Exclude:
231
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
232
- - 'spec/callbacks_spec.rb'
233
-
234
- # Offense count: 2
235
- Style/MissingRespondToMissing:
236
- Exclude:
237
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
238
- - 'spec/callbacks_spec.rb'
239
-
240
- # Offense count: 2
241
- # Cop supports --auto-correct.
242
- Style/ParallelAssignment:
243
- Exclude:
244
- - 'lib/asset_cloud/base.rb'
245
- - 'lib/asset_cloud/bucket.rb'
246
-
247
- # Offense count: 2
248
- # Cop supports --auto-correct.
249
- Style/PerlBackrefs:
250
- Exclude:
251
- - 'lib/asset_cloud/base.rb'
252
- - 'lib/asset_cloud/buckets/s3_bucket.rb'
253
-
254
- # Offense count: 3
255
- # Cop supports --auto-correct.
256
- # Configuration parameters: EnforcedStyle.
257
- # SupportedStyles: short, verbose
258
- Style/PreferredHashMethods:
259
- Exclude:
260
- - 'lib/asset_cloud/buckets/memory_bucket.rb'
261
- - 'lib/asset_cloud/buckets/versioned_memory_bucket.rb'
262
-
263
- # Offense count: 2
264
- # Cop supports --auto-correct.
265
- Style/RedundantBegin:
266
- Exclude:
267
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
268
- - 'lib/asset_cloud/buckets/gcs_bucket.rb'
269
-
270
- # Offense count: 5
271
- # Cop supports --auto-correct.
272
- Style/RedundantPercentQ:
273
- Exclude:
274
- - 'asset_cloud.gemspec'
275
-
276
- # Offense count: 3
277
- # Cop supports --auto-correct.
278
- # Configuration parameters: AllowMultipleReturnValues.
279
- Style/RedundantReturn:
280
- Exclude:
281
- - 'lib/asset_cloud/buckets/bucket_chain.rb'
282
- - 'lib/asset_cloud/buckets/gcs_bucket.rb'
283
- - 'lib/asset_cloud/buckets/s3_bucket.rb'
284
-
285
- # Offense count: 14
286
- # Cop supports --auto-correct.
287
- Style/RedundantSelf:
288
- Exclude:
289
- - 'lib/asset_cloud/asset.rb'
290
- - 'lib/asset_cloud/buckets/active_record_bucket.rb'
291
- - 'lib/asset_cloud/callbacks.rb'
292
- - 'lib/asset_cloud/metadata.rb'
293
- - 'lib/asset_cloud/validations.rb'
294
-
295
- # Offense count: 4
296
- # Cop supports --auto-correct.
297
- # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
298
- # SupportedStyles: slashes, percent_r, mixed
299
- Style/RegexpLiteral:
300
- Exclude:
301
- - 'lib/asset_cloud/base.rb'
302
- - 'lib/asset_cloud/buckets/file_system_bucket.rb'
303
- - 'lib/asset_cloud/buckets/s3_bucket.rb'
304
-
305
- # Offense count: 10
306
- # Cop supports --auto-correct.
307
- # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
308
- # AllowedMethods: present?, blank?, presence, try, try!
309
- Style/SafeNavigation:
310
- Exclude:
311
- - 'lib/asset_cloud/base.rb'
312
-
313
- # Offense count: 2
314
- # Cop supports --auto-correct.
315
- # Configuration parameters: AllowIfMethodIsEmpty.
316
- Style/SingleLineMethods:
317
- Exclude:
318
- - 'lib/asset_cloud/asset_extension.rb'
319
-
320
- # Offense count: 1
321
- # Cop supports --auto-correct.
322
- # Configuration parameters: EnforcedStyle.
323
- # SupportedStyles: use_perl_names, use_english_names
324
- Style/SpecialGlobalVars:
325
- Exclude:
326
- - 'asset_cloud.gemspec'