asset_cloud 2.7.0 → 2.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8573a0d845bd6022d3540cbb6e28027637bea815896060a6637ed70402fb0614
-  data.tar.gz: df5f502bd556e2414ee896327ba18c54ce679faa2a2ebcf5b50a630803454719
+  metadata.gz: 5b202062a28470fab35e4aadafe3600f7944d2cb075d0076274acfd72dd93a6e
+  data.tar.gz: ad42d5f81dbe67cfde24248c3f8f8b2cb5d9bd1694be44d98546f234c8ef703b
 SHA512:
-  metadata.gz: 7302dd7d0e4e4ca392b344c530d3ebd3e610c25e5e6aa45658582944e2333ca66371e511e911f93e38f471815fb184a7d2c52d38dadfdda172a33ff7ff90e6ec
-  data.tar.gz: 91a7fcfaf2dddbb1b855d6b25cadd563c414e09a625ceafdaaecf68faf07d4b89a6e80b89ab9cd2f264098f3ab9f1f387cf08f8ec8bcde19b67179045989bf40
+  metadata.gz: c22411e548811567b511d54b55b79591835721aefd3a34b89ab504871473a477eddbb0903e7c30292c2fefa0e7c51b54b0a94e8ae3081961b40bfb8a69287de4
+  data.tar.gz: 822630e44304e0e2507d01a9e162898bd0c053ade3eabe785c625e407216c7a54166087c270f5166c63261cc98757664c201a6472cb474034b5c7a3af389679f

data/.github/workflows/ci.yml

@@ -0,0 +1,27 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    name: Ruby ${{ matrix.ruby }}
+    strategy:
+      matrix:
+        ruby: ["2.5", "2.6", "2.7"]
+    steps:
+
+    - name: Check out code
+      uses: actions/checkout@v3
+
+    - name: Set up Ruby ${{ matrix.ruby }}
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+
+    - name: RuboCop
+      run: bundle exec rubocop || true # until we fix offenses due to outdated config
+
+    - name: Tests
+      run: bundle exec rspec

data/History.md

@@ -1,5 +1,9 @@
 # Asset Cloud Version History
 
+## Version 2.7.1, 2022-03-18
+
+* Fix incorrect invocation of callbacks defined in external classes (https://github.com/Shopify/asset_cloud/issues/71)
+
 ## Version 2.7.0, 2020-07-15
 
 * Add `Asset#write!` which raises on validation failure (https://github.com/Shopify/asset_cloud/pull/67)

data/README.rdoc

@@ -34,13 +34,12 @@ With GCS Remote test:
 
 Releasing is handled by Shopify's internal Shipit server.
 
-After merging a change, a separate PR should be opened to update `History.md` and bump the version
-(following [Semantic Versioning](https://semver.org/))
+After merging a change, a separate PR should be opened to update +History.md+ and bump the version
+(following {Semantic Versioning}[https://semver.org]).
 
 When merged, the new release will be automatically tagged and deployed to rubygems.org.
 
-Note that the automatic process does not create a new [release](https://github.com/Shopify/asset_cloud/releases) on
-GitHub.
+Note that the automatic process does not create a new {release}[https://github.com/Shopify/asset_cloud/releases] on GitHub.
 
 == Copyright
 

data/asset_cloud.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "2.7.0"
+  s.version = "2.7.1"
 
   s.authors = %w(Shopify)
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}

data/lib/asset_cloud/callbacks.rb

@@ -59,15 +59,15 @@ module AssetCloud
 
     def execute_callbacks(symbol, args)
       callbacks_for(symbol).each do |callback|
-
+        
         result = case callback
         when Symbol
           send(callback, *args)
         when Proc, Method
           callback.call(self, *args)
         else
-          if callback.respond_to?(method)
-            callback.send(method, self, *args)
+          if callback.respond_to?(symbol)
+            callback.send(symbol, self, *args)
           else
             raise StandardError, "Callbacks must be a symbol denoting the method to call, a string to be evaluated, a block to be invoked, or an object responding to the callback method."
           end

data/spec/callbacks_spec.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 require 'spec_helper'
 
+
+class AfterStoreCallback
+  def self.after_store(*args); end
+end
+
 class CallbackAsset < AssetCloud::Asset
   before_store :callback_before_store
   before_delete :callback_before_delete
@@ -9,6 +14,8 @@ class CallbackAsset < AssetCloud::Asset
   after_validate :add_spice
   validate :valid_value
 
+  after_store ::AfterStoreCallback
+
   private
 
   def callback_before_delete(*args); end
@@ -143,4 +150,15 @@ describe CallbackAsset do
 
     expect(@asset.delete).to(eq(nil))
   end
+
+  it "should invoke after_store callback defined in separate class" do
+    local_fs = BasicCloud.new(File.dirname(__FILE__) + '/files', 'http://assets/')
+    local_fs.write('callback_assets/foo', 'bar')
+    local_asset = local_fs.asset_at('callback_assets/foo')
+    
+    expect(local_asset).to(receive(:callback_before_store).and_return(true))
+    expect(::AfterStoreCallback).to(receive(:after_store))
+    
+    expect(local_asset.store).to(eq(true))
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.7.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-16 00:00:00.000000000 Z
+date: 2022-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -101,10 +101,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/probots.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - Gemfile
 - History.md
 - LICENSE
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.20
 signing_key: 
 specification_version: 4
 summary: An abstraction layer around arbitrary and diverse asset stores.

data/.travis.yml

@@ -1,12 +0,0 @@
-language: ruby
-before_install:
-  - gem install bundler
-rvm:
-  - '2.5'
-  - '2.6'
-  - '2.7'
-
-matrix:
-  exclude:
-    rvm: '2.7'
-    gemfile: gemfiles/Gemfile.activerecord52