asset_cloud 2.6.1 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5f21ffc94cb1b9d60698ca150060999dfc3c2e01f347698bb8f0c8e108bf460
-  data.tar.gz: a7d8bddbdbc14473c7eb7d0f8c4d50a4e8db12e72dbb320df3f97025ad08cd90
+  metadata.gz: 8573a0d845bd6022d3540cbb6e28027637bea815896060a6637ed70402fb0614
+  data.tar.gz: df5f502bd556e2414ee896327ba18c54ce679faa2a2ebcf5b50a630803454719
 SHA512:
-  metadata.gz: '08454bc3fc53e14b98b69d1a6feee2d57505d26cc61f7b43e52174300704e441faaea4a2710da524ab7136197d5c396de6f53110d66edb4b0a1d89d7cb1339cb'
-  data.tar.gz: 9802fca3c1bcc63a72b3effeca88044df1d1022854a5be72f9da865fb1acea768c57160896ea9930c0eece74c8301120c19fc09c2f1df8867ab530bca5b91a33
+  metadata.gz: 7302dd7d0e4e4ca392b344c530d3ebd3e610c25e5e6aa45658582944e2333ca66371e511e911f93e38f471815fb184a7d2c52d38dadfdda172a33ff7ff90e6ec
+  data.tar.gz: 91a7fcfaf2dddbb1b855d6b25cadd563c414e09a625ceafdaaecf68faf07d4b89a6e80b89ab9cd2f264098f3ab9f1f387cf08f8ec8bcde19b67179045989bf40

data/History.md

@@ -1,5 +1,9 @@
 # Asset Cloud Version History
 
+## Version 2.7.0, 2020-07-15
+
+* Add `Asset#write!` which raises on validation failure (https://github.com/Shopify/asset_cloud/pull/67)
+
 ## Version 2.6.0, 2020-05-22
 
 * Add checksum to metadata (https://github.com/Shopify/asset_cloud/pull/57)

data/README.rdoc

@@ -9,7 +9,7 @@ An abstraction layer around arbitrary and diverse asset stores.
 +value_hash+ is intended as a *private* hash/checksum, not exposed to end users. Its underlying algorithm is private, and
 could change over time so should not be relied on by clients.
 
-+checksum+ is intended as a *public* hash/checksum, exposed to end users. Its underlying algorithms is documented (e.g. MD5)
++checksum+ is intended as a *public* hash/checksum, exposed to end users. Its underlying algorithm is documented (e.g. MD5)
 and is not expected to change.
 
 == Installation
@@ -30,6 +30,18 @@ With GCS Remote test:
 
     GCS_PROJECT_ID="<project_id>" GCS_KEY_FILEPATH="<path_to_key>" GCS_BUCKET="<bucket_name>" bundle exec rake spec
 
+== Releasing
+
+Releasing is handled by Shopify's internal Shipit server.
+
+After merging a change, a separate PR should be opened to update `History.md` and bump the version
+(following [Semantic Versioning](https://semver.org/))
+
+When merged, the new release will be automatically tagged and deployed to rubygems.org.
+
+Note that the automatic process does not create a new [release](https://github.com/Shopify/asset_cloud/releases) on
+GitHub.
+
 == Copyright
 
 Copyright (c) 2008-2014 Tobias Lütke & Shopify, Inc. Released under the MIT license (see LICENSE for details).

data/asset_cloud.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "2.6.1"
+  s.version = "2.7.0"
 
   s.authors = %w(Shopify)
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}

data/lib/asset_cloud/base.rb

@@ -151,6 +151,12 @@ module AssetCloud
       bucket_for(key).write(key, value)
     end
 
+    def write!(key, value)
+      asset = self[key]
+      asset.value = value
+      asset.store!
+    end
+
     def read(key)
       logger.info { "  [#{self.class.name}] Reading from #{key}" } if logger
 

data/spec/base_spec.rb

@@ -7,11 +7,18 @@ end
 class LiquidAsset < AssetCloud::Asset
 end
 
+class BrokenBucket < AssetCloud::Bucket
+  def write(*)
+    false
+  end
+end
+
 class BasicCloud < AssetCloud::Base
   bucket :special, AssetCloud::MemoryBucket, asset_class: SpecialAsset
   bucket :conditional, AssetCloud::MemoryBucket, asset_class: proc { |key|
     LiquidAsset if key.ends_with?('.liquid')
   }
+  bucket :broken, BrokenBucket, asset_class: AssetCloud::Asset
 end
 
 describe BasicCloud do
@@ -192,6 +199,20 @@ describe BasicCloud do
     end
   end
 
+  describe "write!" do
+    it "should write through the Asset object (and thus run any callbacks on the asset)" do
+      special_asset = double(:special_asset)
+      expect(special_asset).to(receive(:value=).with('fancy fancy!'))
+      expect(special_asset).to(receive(:store!))
+      expect(SpecialAsset).to(receive(:at).and_return(special_asset))
+      @fs.write!('special/fancy.txt', 'fancy fancy!')
+    end
+
+    it "should raise AssetNotSaved when write fails" do
+      expect { @fs.write!('broken/file.txt', 'n/a') }.to(raise_error(AssetCloud::AssetNotSaved))
+    end
+  end
+
   describe "MATCH_BUCKET" do
     it "should match following stuff " do
       'products/key.txt' =~ AssetCloud::Base::MATCH_BUCKET

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 2.6.1
+  version: 2.7.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-26 00:00:00.000000000 Z
+date: 2020-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport