asset_cloud 2.5.3 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa8b974322c07bc208a54567997c8b49d4cec0c08519458ac4e205cb84f375d1
-  data.tar.gz: 7fa58473c81bed77e11b855e4d153e49fbebd07e53af888f976f6b3dae18fd41
+  metadata.gz: 134ba5f46359569f492531369197e78de71f48eabc0efef27c60b9f2a9b2a4fd
+  data.tar.gz: 28edd6a34bfb58f3fe796c697a0c58855a65f117c489a4d427711b88386b2df0
 SHA512:
-  metadata.gz: 8fcec64888039982e1e435d39c8ec50684aeb661eeeebcbbc7471499cb8b5a9ec0d29bc543eeec394fd3f7682064ac9daa1131b671c7f63210803db0bb8dcb00
-  data.tar.gz: c8625f3b8ce74509bb3c54b941c37f016d8bcb0adde0bd4851709f70b1d1deda80565313cc6f2d8255202965f8e686f1116383ee4133264a29afe656ce7f7063
+  metadata.gz: 161578c01372d753f3fe15558bc0f2b446e2cdbab75272c48c72bb3ce3e0a94c67616544b712efafc74eac6a7e0e18f69367712e5a37e87a769723177479c0c8
+  data.tar.gz: a65784b410afe987d821589a631cf16e4b78795b6e07cebf6b6a4252c5631dc35eaca8a1da8ea2cbe4bf37d3308965bd5ed3a6dafe0c57de37a49489d8e11d4d

data/.rubocop.yml

@@ -0,0 +1,3 @@
+inherit_gem:
+  rubocop-shopify: rubocop.yml
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,326 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-05-22 10:33:52 -0400 using RuboCop version 0.82.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'lib/asset_cloud/asset_extension.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'lib/asset_cloud/callbacks.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
+Layout/EmptyLinesAroundClassBody:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+    - 'lib/asset_cloud/buckets/versioned_memory_bucket.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
+Layout/EmptyLinesAroundModuleBody:
+  Exclude:
+    - 'lib/asset_cloud/asset.rb'
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+    - 'lib/asset_cloud/free_key_locator.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 187
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/RescueEnsureAlignment:
+  Exclude:
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Layout/SpaceAfterComma:
+  Exclude:
+    - 'lib/asset_cloud/asset.rb'
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/memory_bucket.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, no_space
+Layout/SpaceAroundEqualsInParameterDefault:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/bucket.rb'
+    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/memory_bucket.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
+Layout/SpaceAroundOperators:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+
+# Offense count: 22
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideBlockBraces:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
+
+# Offense count: 9
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/asset_cloud/asset.rb'
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/s3_bucket.rb'
+
+# Offense count: 2
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/asset_cloud/asset.rb'
+
+# Offense count: 1
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
+  Exclude:
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/asset_cloud/buckets/memory_bucket.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/blackhole_bucket.rb'
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/invalid_bucket.rb'
+
+# Offense count: 6
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+    - 'spec/gcs_bucket_spec.rb'
+
+# Offense count: 1
+Naming/ConstantName:
+  Exclude:
+    - 'lib/asset_cloud/buckets/invalid_bucket.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, conditionals
+Style/AndOr:
+  Exclude:
+    - 'lib/asset_cloud/asset.rb'
+    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerBackticks.
+# SupportedStyles: backticks, percent_x, mixed
+Style/CommandLiteral:
+  Exclude:
+    - 'asset_cloud.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+
+# Offense count: 22
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'lib/asset_cloud/asset_extension.rb'
+    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
+
+# Offense count: 17
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreMacros, IgnoredMethods, IgnoredPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
+# SupportedStyles: require_parentheses, omit_parentheses
+Style/MethodCallWithArgsParentheses:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'asset_cloud.gemspec'
+    - 'lib/asset_cloud.rb'
+    - 'lib/asset_cloud/asset.rb'
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+    - 'lib/asset_cloud/metadata.rb'
+
+# Offense count: 2
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'spec/callbacks_spec.rb'
+
+# Offense count: 2
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'spec/callbacks_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/ParallelAssignment:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/bucket.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/s3_bucket.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: short, verbose
+Style/PreferredHashMethods:
+  Exclude:
+    - 'lib/asset_cloud/buckets/memory_bucket.rb'
+    - 'lib/asset_cloud/buckets/versioned_memory_bucket.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+    - 'lib/asset_cloud/buckets/gcs_bucket.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/RedundantPercentQ:
+  Exclude:
+    - 'asset_cloud.gemspec'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'lib/asset_cloud/buckets/bucket_chain.rb'
+    - 'lib/asset_cloud/buckets/gcs_bucket.rb'
+    - 'lib/asset_cloud/buckets/s3_bucket.rb'
+
+# Offense count: 14
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+    - 'lib/asset_cloud/asset.rb'
+    - 'lib/asset_cloud/buckets/active_record_bucket.rb'
+    - 'lib/asset_cloud/callbacks.rb'
+    - 'lib/asset_cloud/metadata.rb'
+    - 'lib/asset_cloud/validations.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+    - 'lib/asset_cloud/buckets/file_system_bucket.rb'
+    - 'lib/asset_cloud/buckets/s3_bucket.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/asset_cloud/base.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowIfMethodIsEmpty.
+Style/SingleLineMethods:
+  Exclude:
+    - 'lib/asset_cloud/asset_extension.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  Exclude:
+    - 'asset_cloud.gemspec'

data/History.md

@@ -1,5 +1,11 @@
 # Asset Cloud Version History
 
+## Version 2.6.0, 2020-05-22
+
+* Add checksum to metadata (https://github.com/Shopify/asset_cloud/pull/57)
+
+**Note:** There are versions between 2.2.2 and 2.6.0 not covered by the History.
+
 ## Version 2.2.2, 2016-02-11
 
 * Allow asset_class to be a proc which determines the class to use within a bucket (https://github.com/Shopify/asset_cloud/pull/15)

data/README.rdoc

@@ -4,6 +4,14 @@
 
 An abstraction layer around arbitrary and diverse asset stores.
 
+== Value Hash vs Checksum
+
++value_hash+ is intended as a *private* hash/checksum, not exposed to end users. Its underlying algorithm is private, and
+could change over time so should not be relied on by clients.
+
++checksum+ is intended as a *public* hash/checksum, exposed to end users. Its underlying algorithms is documented (e.g. MD5)
+and is not expected to change.
+
 == Installation
 
 === as a Gem

data/Rakefile

@@ -5,9 +5,10 @@ require 'rake'
 require 'rake/testtask'
 require 'rdoc/task'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
-desc 'Default: run unit tests.'
-task :default => [:spec]
+desc 'Default: run unit tests and style checks.'
+task default: [:spec, :rubocop]
 
 desc "Run all spec examples"
 RSpec::Core::RakeTask.new do |t|
@@ -23,3 +24,5 @@ Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('README')
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
+
+RuboCop::RakeTask.new

data/asset_cloud.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "2.5.3"
+  s.version = "2.6.0"
 
   s.authors = %w(Shopify)
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}
@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'mocha'
   s.add_development_dependency 'pry'
   s.add_development_dependency 'pry-byebug'
+  s.add_development_dependency 'rubocop-shopify'
 end

data/lib/asset_cloud/asset.rb

@@ -89,6 +89,10 @@ module AssetCloud
       metadata.value_hash
     end
 
+    def checksum
+      metadata.checksum
+    end
+
     def delete
       if new_asset?
         false

data/lib/asset_cloud/metadata.rb

@@ -1,6 +1,6 @@
 module AssetCloud
   class Metadata
-    attr_accessor :exist, :size, :created_at, :updated_at, :value_hash
+    attr_accessor :exist, :size, :created_at, :updated_at, :value_hash, :checksum
 
     def new?
       !self.exist
@@ -10,9 +10,16 @@ module AssetCloud
       self.exist
     end
 
-    def initialize(exist, size = nil, created_at = nil, updated_at = nil, value_hash = nil)
-      self.exist, self.size, self.created_at, self.updated_at, self.value_hash = exist, size, created_at, updated_at, value_hash
+    # rubocop:disable Metrics/ParameterLists
+    def initialize(exist, size = nil, created_at = nil, updated_at = nil, value_hash = nil, checksum = nil)
+      self.exist = exist
+      self.size = size
+      self.created_at = created_at
+      self.updated_at = updated_at
+      self.value_hash = value_hash
+      self.checksum = checksum
     end
+    # rubocop:enable Metrics/ParameterLists
 
     def self.existing
       self.new(true)

data/spec/active_record_bucket_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 MockRecords = Object.new
@@ -5,7 +6,9 @@ MockRecords = Object.new
 class MockActiveRecordBucket < AssetCloud::ActiveRecordBucket
   self.key_attribute = 'name'
   self.value_attribute = 'body'
+
   protected
+
   def records
     MockRecords
   end
@@ -19,49 +22,49 @@ describe AssetCloud::ActiveRecordBucket do
   directory = File.dirname(__FILE__) + '/files'
 
   before do
-    @cloud = RecordCloud.new(directory , 'http://assets/files' )
+    @cloud = RecordCloud.new(directory, 'http://assets/files')
     @bucket = @cloud.buckets[:stuff]
   end
 
   describe '#ls' do
     before do
-      MockRecords.should_receive(:connection).and_return(@mock_connection = double("connection"))
-      @mock_connection.should_receive(:quote_column_name).with('name').and_return("`name`")
-      (@mock_record = double("record")).should_receive(:name).and_return('stuff/a1')
+      expect(MockRecords).to(receive(:connection).and_return(@mock_connection = double("connection")))
+      expect(@mock_connection).to(receive(:quote_column_name).with('name').and_return("`name`"))
+      expect(@mock_record = double("record")).to(receive(:name).and_return('stuff/a1'))
     end
 
     it "should return a list of assets which start with the given prefix" do
-      MockRecords.should_receive(:all).with(:conditions => ["`name` LIKE ?", "stuff/a%"]).and_return([@mock_record])
+      expect(MockRecords).to(receive(:all).with(conditions: ["`name` LIKE ?", "stuff/a%"]).and_return([@mock_record]))
 
-      @bucket.ls('stuff/a').size.should == 1
+      expect(@bucket.ls('stuff/a').size).to(eq(1))
     end
 
     it "should return a list of all assets when a prefix is not given" do
-      MockRecords.should_receive(:all).with(:conditions => ["`name` LIKE ?", "stuff%"]).and_return([@mock_record])
+      expect(MockRecords).to(receive(:all).with(conditions: ["`name` LIKE ?", "stuff%"]).and_return([@mock_record]))
 
-      @bucket.ls.size.should == 1
+      expect(@bucket.ls.size).to(eq(1))
     end
   end
 
   describe '#read' do
     it "should return the value of a key when it exists" do
-      (@mock_record = double("record")).should_receive(:body).and_return('foo')
-      MockRecords.should_receive(:first).with(:conditions => {'name' => 'stuff/a1'}).and_return(@mock_record)
+      expect(@mock_record = double("record")).to(receive(:body).and_return('foo'))
+      expect(MockRecords).to(receive(:first).with(conditions: { 'name' => 'stuff/a1' }).and_return(@mock_record))
 
       @bucket.read('stuff/a1')
     end
     it "should raise AssetNotFoundError when nothing is there" do
-      MockRecords.should_receive(:first).with(:conditions => {'name' => 'stuff/a1'}).and_return(nil)
+      expect(MockRecords).to(receive(:first).with(conditions: { 'name' => 'stuff/a1' }).and_return(nil))
 
-      lambda {@bucket.read('stuff/a1')}.should raise_error(AssetCloud::AssetNotFoundError)
+      expect { @bucket.read('stuff/a1') }.to(raise_error(AssetCloud::AssetNotFoundError))
     end
   end
 
   describe '#write' do
     it "should write to the DB" do
-      (@mock_record = double("record")).should_receive(:body=).with('foo').and_return('foo')
-      @mock_record.should_receive(:save!).and_return(true)
-      MockRecords.should_receive(:find_or_initialize_by_name).with('stuff/a1').and_return(@mock_record)
+      expect(@mock_record = double("record")).to(receive(:body=).with('foo').and_return('foo'))
+      expect(@mock_record).to(receive(:save!).and_return(true))
+      expect(MockRecords).to(receive(:find_or_initialize_by_name).with('stuff/a1').and_return(@mock_record))
 
       @bucket.write('stuff/a1', 'foo')
     end
@@ -69,8 +72,8 @@ describe AssetCloud::ActiveRecordBucket do
 
   describe '#delete' do
     it "should destroy records" do
-      (@mock_record = double("record")).should_receive(:destroy).and_return(true)
-      MockRecords.should_receive(:first).with(:conditions => {'name' => 'stuff/a1'}).and_return(@mock_record)
+      expect(@mock_record = double("record")).to(receive(:destroy).and_return(true))
+      expect(MockRecords).to(receive(:first).with(conditions: { 'name' => 'stuff/a1' }).and_return(@mock_record))
 
       @bucket.delete('stuff/a1')
     end
@@ -78,18 +81,15 @@ describe AssetCloud::ActiveRecordBucket do
 
   describe '#stat' do
     it "should return appropriate metadata" do
-      (@mock_record = double("record")).should_receive(:created_at).and_return(1982)
-      @mock_record.should_receive(:updated_at).and_return(2002)
-      @mock_record.should_receive(:body).and_return('foo')
-      MockRecords.should_receive(:first).with(:conditions => {'name' => 'stuff/a1'}).and_return(@mock_record)
+      expect(@mock_record = double("record")).to(receive(:created_at).and_return(1982))
+      expect(@mock_record).to(receive(:updated_at).and_return(2002))
+      expect(@mock_record).to(receive(:body).and_return('foo'))
+      expect(MockRecords).to(receive(:first).with(conditions: { 'name' => 'stuff/a1' }).and_return(@mock_record))
 
       metadata = @bucket.stat('stuff/a1')
-      metadata.created_at.should == 1982
-      metadata.updated_at.should == 2002
-      metadata.size.should == 3
+      expect(metadata.created_at).to(eq(1982))
+      expect(metadata.updated_at).to(eq(2002))
+      expect(metadata.size).to(eq(3))
     end
   end
-
-
-
 end