asset_cloud 2.2.9 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e767cf7119375ff7308f312b510f99cd89705e1d44ae556e89853bc8f55f2dd
-  data.tar.gz: 285705891684bc782af8326be994698a9282a4abf19d24df0759cc9a53461752
+  metadata.gz: 9915f9ae949c5a943ba524a2816df249c3e6ab3cc295786fc0cbbad6dd1690c4
+  data.tar.gz: e0b47f11c95a23903c702ed9f1c8b41fdb4115a459ae83937448902efb22ff56
 SHA512:
-  metadata.gz: b10838d5eb09a7efcb7a09ecbdc0ac63e879b233e6208a28aefde0faa811f53464eafb944aaf46bc8f71de3115cdade371bcd8516ad09e18162b8bfe2e383eb7
-  data.tar.gz: 738c8e086da574cfe5200b19da555a765cf482c8df341eb6168ee3864f08a42a211844f340177fda5aa34573473552d764063e7df6510a11ae0b2d66c8aa5cfe
+  metadata.gz: dd7caa8ab93936dfa3dc2a8823eaa3d8e6de5fc53a1c81928946595dbac5a67e67f2d925385494e30dcbfca18a16b3de805d2e6aab0ae32effa1b8abe063efdf
+  data.tar.gz: 59a74007e74f62b823d902414f6275ad26974f55fa0fb75f15a5bdef09ec104dee5ad2a673d5c8a6cb73fe94527ffce07783cd0ce3598721b66a0d8086672d9f

data/asset_cloud.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "2.2.9"
+  s.version = "2.3.0"
 
   s.authors = %w(Shopify)
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}

data/lib/asset_cloud/asset.rb

@@ -34,7 +34,13 @@ module AssetCloud
     end
 
     def <=>(other)
-      cloud.object_id <=> other.cloud.object_id && key <=> other.key
+      return 1 unless other.is_a?(Asset)
+      compare_cloud = cloud.object_id <=> other.cloud.object_id
+      if compare_cloud == 0
+        key <=> other.key
+      else
+        compare_cloud
+      end
     end
 
     def new_asset?

data/spec/asset_spec.rb

@@ -173,5 +173,43 @@ describe "Asset" do
     end
   end
 
+  describe "comparable" do
+    before do
+      @key = "products/key.txt"
+      @asset = AssetCloud::Asset.new(@cloud, @key)
+    end
+
+    context "comparing to instance of Asset class" do
+      it "is equal if cloud and key of both assets are equal" do
+        other_asset = AssetCloud::Asset.new(@cloud, @key)
+
+        expect(@asset == other_asset).to eq(true)
+      end
+
+      it "is not equal if cloud of both assets are not equal" do
+        other_cloud = double('Cloud2', :asset_extension_classes_for_bucket => [], :object_id => 999)
+        other_asset = AssetCloud::Asset.new(other_cloud, @key)
+
+        expect(@asset == other_asset).to eq(false)
+      end
 
+      it "is not equal if key of both assets are not equal" do
+        other_key = "products/other_key.txt"
+        other_asset = AssetCloud::Asset.new(@cloud, other_key)
+
+        expect(@asset == other_asset).to eq(false)
+      end
+    end
+
+    context "comparing to instance of non-Asset class" do
+      it "is not equal to a non-Asset object" do
+        AssetCloud::Asset.new(@cloud, "products/foo, bar.txt", "data")
+
+        expect(@asset == "some_string").to eq(false)
+        expect(@asset == :some_symbol).to eq(false)
+        expect(@asset == []).to eq(false)
+        expect(@asset == nil).to eq(false)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 2.2.9
+  version: 2.3.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-15 00:00:00.000000000 Z
+date: 2020-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport