assembly-utils 1.4.5 → 1.4.6

data/lib/assembly-utils/version.rb

@@ -2,7 +2,7 @@
 module Assembly
   # Main Utils class
   class Utils
-    # Project version number    
-    VERSION = "1.4.5"
+    # Project version number
+    VERSION = '1.4.6'
   end
 end

data/spec/spec_helper.rb

@@ -1,18 +1,15 @@
-TEST_PID='druid:dd999dd9999'
-TEST_PID_FILENAME=TEST_PID.gsub(':','_')
-TEST_APO_OBJECT='druid:qv648vd4392'   # this is a real APO object in dor-dev that must exist for the tests to pass
+TEST_PID = 'druid:dd999dd9999'
+TEST_PID_FILENAME = TEST_PID.tr(':', '_')
+TEST_APO_OBJECT = 'druid:qv648vd4392' # this is a real APO object in dor-dev that must exist for the tests to pass
 PATH = File.expand_path(File.dirname(__FILE__))
-TEST_OUTPUT_DIR=File.join(PATH,'test_data','output')
-ENV['ROBOT_ENVIRONMENT']='development'
+TEST_OUTPUT_DIR = File.join(PATH, 'test_data', 'output')
+ENV['ROBOT_ENVIRONMENT'] = 'development'
 
 require 'rspec'
-
 require "#{PATH}/../config/boot"
 require "#{PATH}/../config/connect_to_dor"
 
-
 RSpec.configure do |config|
-
 end
 
 def remove_files(dir)
@@ -26,6 +23,3 @@ end
 def delete_test_object
   Dor::Config.fedora.client["objects/#{TEST_PID}"].delete
 end
-
-
-

data/spec/utils_spec.rb

@@ -2,57 +2,57 @@ require 'spec_helper'
 
 describe Assembly::Utils do
 
-  it "should compute the correct staging path given a druid" do
-    path=Assembly::Utils.get_staging_path('aa000aa0001')
+  it 'should compute the correct staging path given a druid' do
+    path = Assembly::Utils.get_staging_path('aa000aa0001')
     expect(path).to eq('aa/000/aa/0001')
   end
 
-  it "should compute the correct staging path given a druid and a pre-pend path" do
-    path=Assembly::Utils.get_staging_path('aa000aa0001','/tmp')
+  it 'should compute the correct staging path given a druid and a pre-pend path' do
+    path = Assembly::Utils.get_staging_path('aa000aa0001', '/tmp')
     expect(path).to eq('/tmp/aa/000/aa/0001')
   end
 
-  it "should symbolize hash keys correctly" do
-    result=Assembly::Utils.symbolize_keys({'foo'=>'bar','ppuff'=>'doofus'})
-    expect(result).to eq({:foo=>'bar',:ppuff=>'doofus'})
+  it 'should symbolize hash keys correctly' do
+    result = Assembly::Utils.symbolize_keys({'foo' => 'bar', 'ppuff' => 'doofus'})
+    expect(result).to eq({:foo => 'bar', :ppuff => 'doofus'})
   end
 
-  it "should symbolize hash values correctly" do
-    result=Assembly::Utils.values_to_symbols!({'foo'=>'bar','ppuff'=>'doofus'})
-    expect(result).to eq({'foo'=>:bar,'ppuff'=>:doofus})
+  it 'should symbolize hash values correctly' do
+    result = Assembly::Utils.values_to_symbols!({'foo' => 'bar', 'ppuff' => 'doofus'})
+    expect(result).to eq({'foo' => :bar, 'ppuff' => :doofus})
   end
 
-  it "should return a blank string if a file is not found to read in" do
-    bogus_filename='crap/dude'
+  it 'should return a blank string if a file is not found to read in' do
+    bogus_filename = 'crap/dude'
     expect(Assembly::Utils.read_file(bogus_filename)).to eq('')
   end
 
-  it "should return a string with the file content if the file is found" do
-    progress_filename='spec/test_data/test_log.yaml'
+  it 'should return a string with the file content if the file is found' do
+    progress_filename = 'spec/test_data/test_log.yaml'
     expect(Assembly::Utils.read_file(progress_filename)).to match(/:pid: druid:bg598tg6338/)
   end
 
-  it "should read in a list of completed druids from a progress log file" do
-    progress_filename='spec/test_data/test_log.yaml'
-    druids=Assembly::Utils.get_druids_from_log(progress_filename)
-    expect(druids).to eq(['druid:bc006dj2846','druid:bg598tg6338'])
+  it 'should read in a list of completed druids from a progress log file' do
+    progress_filename = 'spec/test_data/test_log.yaml'
+    druids = Assembly::Utils.get_druids_from_log(progress_filename)
+    expect(druids).to eq(['druid:bc006dj2846', 'druid:bg598tg6338'])
   end
 
-  it "should read in a list of failed druids from a progress log file" do
-    progress_filename='spec/test_data/test_log.yaml'
-    druids=Assembly::Utils.get_druids_from_log(progress_filename,false)
+  it 'should read in a list of failed druids from a progress log file' do
+    progress_filename = 'spec/test_data/test_log.yaml'
+    druids = Assembly::Utils.get_druids_from_log(progress_filename, false)
     expect(druids).to eq(['druid:bh634sp8073'])
   end
 
-  it "should read in a YAML configuration file and turn it into a hash" do
-    config_filename='spec/test_data/local_dev_revs.yaml'
-    config=Assembly::Utils.load_config(config_filename)
+  it 'should read in a YAML configuration file and turn it into a hash' do
+    config_filename = 'spec/test_data/local_dev_revs.yaml'
+    config = Assembly::Utils.load_config(config_filename)
     expect(config['progress_log_file']).to eq('tmp/progress_revs.yaml')
   end
 
   ###################################################################################
   # NOTE: All the tests below depend on being able to connect successfully to DOR Dev
-  describe "dor-only-tests" do
+  describe 'dor-only-tests' do
 
     before(:all) do
       delete_test_object rescue nil
@@ -64,53 +64,53 @@ describe Assembly::Utils do
       delete_test_object
     end
 
-    it "should find druids by source ID", :type =>'integration' do
+    it 'should find druids by source ID', :type => 'integration' do
       expect(Dor::SearchService).to receive(:query_by_id).with('testing-assembly-utils-gem').and_return TEST_PID
-      druids=Assembly::Utils.get_druids_by_sourceid(['testing-assembly-utils-gem'])
+      druids = Assembly::Utils.get_druids_by_sourceid(['testing-assembly-utils-gem'])
       expect(druids).to eq([TEST_PID])
     end
 
-    it "should replace the datastream of an object", :type =>'integration' do
-      new_content="<xml><tag>stuff</tag></xml>"
-      datastream="test"
-      druids=[TEST_PID]
-      Assembly::Utils.replace_datastreams(druids,datastream,new_content)
+    it 'should replace the datastream of an object', :type => 'integration' do
+      new_content = '<xml><tag>stuff</tag></xml>'
+      datastream = 'test'
+      druids = [TEST_PID]
+      Assembly::Utils.replace_datastreams(druids, datastream, new_content)
       obj = Dor::Item.find(TEST_PID)
       expect(obj.datastreams[datastream].content).to match(/<tag>stuff<\/tag>/)
     end
 
-    it "should search and replace the datastream of an object", :type =>'integration' do
-      find_content="stuff"
-      replace_content="new"
-      datastream="test"
-      druids=[TEST_PID]
-      Assembly::Utils.update_datastreams(druids,datastream,find_content,replace_content)
+    it 'should search and replace the datastream of an object', :type => 'integration' do
+      find_content = 'stuff'
+      replace_content = 'new'
+      datastream = 'test'
+      druids = [TEST_PID]
+      Assembly::Utils.update_datastreams(druids, datastream, find_content, replace_content)
       obj = Dor::Item.find(TEST_PID)
       expect(obj.datastreams[datastream].content).to match(/<tag>new<\/tag>/)
     end
 
-    it "should export a PID to FOXML", :type =>'integration' do
-      expect(File.exists?(File.join(TEST_OUTPUT_DIR,"#{TEST_PID_FILENAME}.foxml.xml"))).to be false
-      Dir.mkdir(TEST_OUTPUT_DIR) unless Dir.exists?(TEST_OUTPUT_DIR)
-      Assembly::Utils.export_objects(TEST_PID,TEST_OUTPUT_DIR)
-      expect(File.exists?(File.join(TEST_OUTPUT_DIR,"#{TEST_PID_FILENAME}.foxml.xml"))).to be true
+    it 'should export a PID to FOXML', :type => 'integration' do
+      expect(File.exist?(File.join(TEST_OUTPUT_DIR, "#{TEST_PID_FILENAME}.foxml.xml"))).to be false
+      Dir.mkdir(TEST_OUTPUT_DIR) unless Dir.exist?(TEST_OUTPUT_DIR)
+      Assembly::Utils.export_objects(TEST_PID, TEST_OUTPUT_DIR)
+      expect(File.exist?(File.join(TEST_OUTPUT_DIR, "#{TEST_PID_FILENAME}.foxml.xml"))).to be true
     end
 
-    it "should return nil when the workflow state is not found in an object", :type =>'integration' do
-      expect(Assembly::Utils.get_workflow_status(TEST_PID,'assemblyWF','jp2-create')).to be_nil
+    it 'should return nil when the workflow state is not found in an object', :type => 'integration' do
+      expect(Assembly::Utils.get_workflow_status(TEST_PID, 'assemblyWF', 'jp2-create')).to be_nil
     end
 
-    it "should indicate if the specified workflow is defined in an APO object", :type =>'integration' do
-      expect(Assembly::Utils.apo_workflow_defined?(TEST_APO_OBJECT,'accessionWF')).to be true
-      expect(Assembly::Utils.apo_workflow_defined?(TEST_APO_OBJECT,'accessioning')).to be true
+    it 'should indicate if the specified workflow is defined in an APO object', :type => 'integration' do
+      expect(Assembly::Utils.apo_workflow_defined?(TEST_APO_OBJECT, 'accessionWF')).to be true
+      expect(Assembly::Utils.apo_workflow_defined?(TEST_APO_OBJECT, 'accessioning')).to be true
     end
 
-    it "should indicate if the specified workflow is not defined in an APO object", :type =>'integration' do
-      expect(Assembly::Utils.apo_workflow_defined?(TEST_APO_OBJECT,'crapsticks')).to be false
+    it 'should indicate if the specified workflow is not defined in an APO object', :type => 'integration' do
+      expect(Assembly::Utils.apo_workflow_defined?(TEST_APO_OBJECT, 'crapsticks')).to be false
     end
 
-    it "should indicate if the specified object is not an APO", :type =>'integration' do
-      expect{Assembly::Utils.apo_workflow_defined?(TEST_PID,'crapsticks')}.to raise_error
+    it 'should indicate if the specified object is not an APO', :type => 'integration' do
+      expect{Assembly::Utils.apo_workflow_defined?(TEST_PID, 'crapsticks')}.to raise_error
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: assembly-utils
 version: !ruby/object:Gem::Version
-  version: 1.4.5
+  version: 1.4.6
 platform: ruby
 authors:
 - Peter Mangiafico
@@ -9,174 +9,160 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-05 00:00:00.000000000 Z
+date: 2016-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: csv-mapper
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fastercsv
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: druid-tools
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.6
 - !ruby/object:Gem::Dependency
   name: dor-services
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.19'
+        version: '5.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.19'
+        version: '5.3'
 - !ruby/object:Gem::Dependency
   name: dor-workflow-service
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activeresource
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: addressable
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 2.3.5
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 2.3.5
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Contains classes to manipulate DOR objects for assembly and accessioning
@@ -188,9 +174,12 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .rvmrc.example
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".rvmrc.example"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -218,17 +207,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: assembly-utils
-rubygems_version: 2.4.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Ruby gem of methods usesful for assembly and accessioning.