assembly-objectfile 1.10.3 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0060fb5fbd2271cc712b63d2d1ff8752c7ab11346f7ee0a43f41fcc48288d805
-  data.tar.gz: 1759dd3e2e5c8ab86333957f30b27468296b53b0f4c7e1607f08e09b4f77da9c
+  metadata.gz: 8c85bb6c05fe0d46e9b2f37e90710043efce16322c5d58e0b0a9578fd21ece77
+  data.tar.gz: c7e3ac5e3f0a0aa2124f8ce3d6587de2d02923c733ee94b1c299ae171101f5a5
 SHA512:
-  metadata.gz: a6fa4a4f685bfd3f1c95284b07f8531b1bcdb6330d54b578ad5fefb7e394dd04431bb666930902204b06b44fedeefb9dca0fa9e69939775d27b40df2d41d434a
-  data.tar.gz: ccd72959056a26a186c32247100a86ffc7596ce3ef960800ada4f7c6677da13548b4e54dd5614c015555676d25264e5850d809fab3da7a968312af071654a984
+  metadata.gz: fbad307e9a103af61b4a6b05b35bb6b98953774a2c9bd32cb1404f1a9ff6e3404fe78cfc48f9061bfffaa23c3610f2a6f19df5e08975a20c6ee387073cc1010d
+  data.tar.gz: 717e174ccf88a94880f4a832b2d281b351774299fb1273a96b4a1bb942e360cd20b0ba3ac68b7ad4f113e3bd3c78652c7670efcf7bcf8f9bcf068972ba5cd42d

data/.circleci/config.yml

@@ -0,0 +1,14 @@
+version: 2.1
+orbs:
+  ruby-rails: sul-dlss/ruby-rails@3.0.1
+workflows:
+  build:
+    jobs:
+      - ruby-rails/lint-gem:
+          name: lint
+      - ruby-rails/test-gem:
+          name: test
+          before-test:
+            - run:
+                name: Install exiftool
+                command: curl -L http://cpanmin.us | perl - --sudo Image::ExifTool

data/.github/pull_request_template.md

@@ -1,12 +1,10 @@
-## Why was this change made?
+## Why was this change made? 🤔
 
 
 
-## How was this change tested?
+## How was this change tested? 🤨
 
-
-
-## Which documentation and/or configurations were updated?
+⚡ ⚠ If this change has cross service impact, ***run [integration tests](https://github.com/sul-dlss/infrastructure-integration-test) that do file accessioning*** (e.g. create_preassembly_image_spec) and/or test in [stage|qa] environment, in addition to specs. ⚡
 
 
 

data/.rubocop.yml

@@ -2,20 +2,12 @@ inherit_from: .rubocop_todo.yml
 require: rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.5
-
-RSpec/ContextWording:
-  Enabled: false # too dogmatic
-
-RSpec/ExampleLength:
-  Max: 25
-
-# we like 'expect(x).to receive' better than 'have_received'
-RSpec/MessageSpies:
-  Enabled: false
-
-RSpec/NestedGroups:
-  Max: 4 # default: 3
+  TargetRubyVersion: 3.0
+  DisplayCopNames: true
+  Exclude:
+    - 'Gemfile.lock'
+    - '**/*.md'
+    - 'vendor/**/*' # avoid running rubocop on cached bundler
 
 Metrics/BlockLength:
   Exclude:
@@ -135,3 +127,83 @@ Style/RedundantArgument: # (new in 1.4)
 
 Style/SwapValues: # (new in 1.1)
   Enabled: true
+
+Gemspec/RequireMFA: # new in 1.23
+  Enabled: true
+Layout/LineEndStringConcatenationIndentation: # new in 1.18
+  Enabled: true
+Lint/AmbiguousOperatorPrecedence: # new in 1.21
+  Enabled: true
+Lint/AmbiguousRange: # new in 1.19
+  Enabled: true
+Lint/EmptyInPattern: # new in 1.16
+  Enabled: true
+Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+  Enabled: true
+Lint/RequireRelativeSelfPath: # new in 1.22
+  Enabled: true
+Lint/UselessRuby2Keywords: # new in 1.23
+  Enabled: true
+Naming/BlockForwarding: # new in 1.24
+  Enabled: true
+Security/IoMethods: # new in 1.22
+  Enabled: true
+Style/FileRead: # new in 1.24
+  Enabled: true
+Style/FileWrite: # new in 1.24
+  Enabled: true
+Style/InPatternThen: # new in 1.16
+  Enabled: true
+Style/MapToHash: # new in 1.24
+  Enabled: true
+Style/MultilineInPatternThen: # new in 1.16
+  Enabled: true
+Style/NumberedParameters: # new in 1.22
+  Enabled: true
+Style/NumberedParametersLimit: # new in 1.22
+  Enabled: true
+Style/OpenStructUse: # new in 1.23
+  Enabled: true
+Style/QuotedSymbols: # new in 1.16
+  Enabled: true
+Style/RedundantSelfAssignmentBranch: # new in 1.19
+  Enabled: true
+Style/SelectByRegexp: # new in 1.22
+  Enabled: true
+Style/StringChars: # new in 1.12
+  Enabled: true
+RSpec/BeEq: # new in 2.9.0
+  Enabled: true
+RSpec/BeNil: # new in 2.9.0
+  Enabled: true
+RSpec/ExcessiveDocstringSpacing: # new in 2.5
+  Enabled: true
+RSpec/IdenticalEqualityAssertion: # new in 2.4
+  Enabled: true
+RSpec/SubjectDeclaration: # new in 2.5
+  Enabled: true
+RSpec/FactoryBot/SyntaxMethods: # new in 2.7
+  Enabled: true
+RSpec/Rails/AvoidSetupHook: # new in 2.4
+  Enabled: true
+
+Lint/RefinementImportMethods: # new in 1.27
+  Enabled: true
+Security/CompoundHash: # new in 1.28
+  Enabled: true
+Style/EnvHome: # new in 1.29
+  Enabled: true
+Style/FetchEnvVar: # new in 1.28
+  Enabled: true
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+Style/ObjectThen: # new in 1.28
+  Enabled: true
+Style/RedundantInitialize: # new in 1.27
+  Enabled: true
+RSpec/ChangeByZero: # new in 2.11.0
+  Enabled: true
+RSpec/VerifiedDoubleReference: # new in 2.10.0
+  Enabled: true

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-04-26 18:43:37 UTC using RuboCop version 1.11.0.
+# on 2022-02-28 21:11:02 UTC using RuboCop version 1.25.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -48,7 +48,8 @@ Metrics/PerceivedComplexity:
   Max: 15
 
 # Offense count: 1
-# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# CheckDefinitionPathHierarchyRoots: lib, spec, test, src
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
 Naming/FileName:
   Exclude:
@@ -65,12 +66,18 @@ Naming/PredicateName:
     - 'spec/**/*'
     - 'lib/assembly-objectfile/object_fileable.rb'
 
-# Offense count: 9
-# Configuration parameters: Max.
-RSpec/ExampleLength:
+# Offense count: 1
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
   Exclude:
     - 'spec/content_metadata_spec.rb'
 
+# Offense count: 32
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 34
+
 # Offense count: 2
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
@@ -85,10 +92,14 @@ RSpec/InstanceVariable:
   Exclude:
     - 'spec/object_file_spec.rb'
 
-# Offense count: 40
+# Offense count: 41
 RSpec/MultipleExpectations:
   Max: 29
 
+# Offense count: 20
+RSpec/NestedGroups:
+  Max: 4
+
 # Offense count: 2
 RSpec/RepeatedDescription:
   Exclude:
@@ -99,7 +110,7 @@ RSpec/RepeatedExample:
   Exclude:
     - 'spec/object_file_spec.rb'
 
-# Offense count: 8
+# Offense count: 5
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
     - 'spec/content_metadata_spec.rb'
@@ -110,9 +121,9 @@ Style/CommentedKeyword:
   Exclude:
     - 'lib/assembly-objectfile/content_metadata.rb'
 
-# Offense count: 122
+# Offense count: 123
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Layout/LineLength:
   Max: 277

data/Gemfile

@@ -4,3 +4,5 @@ source 'http://rubygems.org'
 
 # Specify your gem's dependencies in .gemspec
 gemspec
+
+gem 'byebug'

data/README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://travis-ci.com/sul-dlss/assembly-objectfile.svg?branch=main)](https://travis-ci.com/sul-dlss/assembly-objectfile)
+[![CircleCI](https://circleci.com/gh/sul-dlss/assembly-objectfile/tree/main.svg?style=svg)](https://circleci.com/gh/sul-dlss/assembly-objectfile/tree/main)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/2310962acce78d78e76c/test_coverage)](https://codeclimate.com/github/sul-dlss/assembly-objectfile/test_coverage)
 [![Maintainability](https://api.codeclimate.com/v1/badges/2310962acce78d78e76c/maintainability)](https://codeclimate.com/github/sul-dlss/assembly-objectfile/maintainability)
 [![Gem Version](https://badge.fury.io/rb/assembly-objectfile.svg)](https://badge.fury.io/rb/assembly-objectfile)

data/assembly-objectfile.gemspec

@@ -13,6 +13,7 @@ Gem::Specification.new do |s|
   s.summary     = 'Ruby immplementation of file services needed to prepare objects to be accessioned in SULAIR digital library'
   s.description = 'Get exif data, file sizes and more.'
   s.license     = 'ALv2'
+  s.metadata['rubygems_mfa_required'] = 'true'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- spec/*`.split("\n")
@@ -20,7 +21,7 @@ Gem::Specification.new do |s|
   s.executables   = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
   s.require_paths = ['lib']
 
-  s.required_ruby_version = '~> 2.5'
+  s.required_ruby_version = '>= 3.0'
 
   s.add_dependency 'activesupport', '>= 5.2.0'
   s.add_dependency 'deprecation'
@@ -33,7 +34,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'json'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec', '~> 3.0'
-  s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'rubocop', '~> 1.25'
   s.add_development_dependency 'rubocop-rspec'
-  s.add_development_dependency 'simplecov', '~> 0.17.0' # CodeClimate cannot use SimpleCov >= 0.18.0 for generating test coverage
+  s.add_development_dependency 'simplecov'
 end

data/lib/assembly-objectfile/content_metadata/file.rb

@@ -35,7 +35,7 @@ module Assembly
         @style = style
       end
 
-      delegate :sha1, :md5, :provider_md5, :provider_sha1, :mimetype, :filesize, :image?, to: :file
+      delegate :sha1, :md5, :provider_md5, :provider_sha1, :mimetype, :filesize, :image?, :valid_image?, to: :file
 
       def file_id(common_path:, flatten_folder_structure:)
         # set file id attribute, first check the relative_path parameter on the object, and if it is set, just use that

data/lib/assembly-objectfile/content_metadata/nokogiri_builder.rb

@@ -31,19 +31,19 @@ module Assembly
                 resource_label = fileset.label_from_file(default: default_label)
 
                 xml.label(resource_label) unless resource_label.empty?
-                fileset.files.each do |obj| # iterate over all the files in a resource
-                  xml_file_params = { id: obj.file_id(common_path: common_path, flatten_folder_structure: config.flatten_folder_structure) }
-                  xml_file_params.merge!(obj.file_attributes(config.file_attributes)) if config.add_file_attributes
-                  xml_file_params.merge!(mimetype: obj.mimetype, size: obj.filesize) if config.add_exif
+                fileset.files.each do |cm_file| # iterate over all the files in a resource
+                  xml_file_params = { id: cm_file.file_id(common_path: common_path, flatten_folder_structure: config.flatten_folder_structure) }
+                  xml_file_params.merge!(cm_file.file_attributes(config.file_attributes)) if config.add_file_attributes
+                  xml_file_params.merge!(mimetype: cm_file.mimetype, size: cm_file.filesize) if config.add_exif
 
                   xml.file(xml_file_params) do
                     if config.add_exif # add exif info if the user requested it
-                      xml.checksum(obj.sha1, type: 'sha1')
-                      xml.checksum(obj.md5, type: 'md5')
-                      xml.imageData(obj.image_data) if obj.image? # add image data for an image
-                    elsif obj.provider_md5 || obj.provider_sha1 # if we did not add exif info, see if there are user supplied checksums to add
-                      xml.checksum(obj.provider_sha1, type: 'sha1') if obj.provider_sha1
-                      xml.checksum(obj.provider_md5, type: 'md5') if obj.provider_md5
+                      xml.checksum(cm_file.sha1, type: 'sha1')
+                      xml.checksum(cm_file.md5, type: 'md5')
+                      xml.imageData(cm_file.image_data) if cm_file.valid_image? # add image data for an image
+                    elsif cm_file.provider_md5 || cm_file.provider_sha1 # if we did not add exif info, see if there are user supplied checksums to add
+                      xml.checksum(cm_file.provider_sha1, type: 'sha1') if cm_file.provider_sha1
+                      xml.checksum(cm_file.provider_md5, type: 'md5') if cm_file.provider_md5
                     end
                   end
                 end

data/lib/assembly-objectfile/object_fileable.rb

@@ -91,8 +91,6 @@ module Assembly
       @exif ||= begin
         check_for_file
         MiniExiftool.new(path, replace_invalid_chars: '?')
-      rescue StandardError
-        nil
       end
     end
 
@@ -176,8 +174,7 @@ module Assembly
       @exif_mimetype ||= begin
         check_for_file
         prefer_exif = !Assembly::TRUSTED_MIMETYPES.include?(file_mimetype) # if it's not a "trusted" mimetype and there is exif data; get the mimetype from the exif
-        exif.mimetype if
-exif&.mimetype && prefer_exif
+        exif.mimetype if exif&.mimetype && prefer_exif
       end
     end
 
@@ -272,7 +269,7 @@ exif&.mimetype && prefer_exif
 
     # private method to check for file existence before operating on it
     def check_for_file
-      raise "input file #{path} does not exist" unless file_exists?
+      raise "input file #{path} does not exist or is a directory" unless file_exists?
     end
   end
 end

data/lib/assembly-objectfile/version.rb

@@ -3,7 +3,7 @@
 # Main Assembly namespace
 module Assembly
   class ObjectFile
-    # Project version number
-    VERSION = '1.10.3'
+    # Gem version
+    VERSION = '1.13.0'
   end
 end

data/spec/content_metadata_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Assembly::ContentMetadata do
     let(:xml) { Nokogiri::XML(result) }
 
     context 'when style=simple_image' do
-      context 'when using a single tif and jp2' do
+      context 'when using a single tif and jp2 with add_exif: true' do
         it 'generates valid content metadata with exif, adding file attributes' do
           objects = [Assembly::ObjectFile.new(TEST_TIF_INPUT_FILE), Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE)]
           result = described_class.create_content_metadata(druid: TEST_DRUID, add_exif: true, add_file_attributes: true, objects: objects)
@@ -44,46 +44,8 @@ RSpec.describe Assembly::ContentMetadata do
           expect(xml.xpath('//resource/file/imageData')[1].attributes['width'].value).to eq('100')
           expect(xml.xpath('//resource/file/imageData')[1].attributes['height'].value).to eq('100')
         end
-      end
 
-      context 'when using a single tif and jp2' do
-        it 'generates valid content metadata with no exif adding specific file attributes for 2 objects, and defaults for 1 object' do
-          obj1 = Assembly::ObjectFile.new(TEST_TIF_INPUT_FILE)
-          obj2 = Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE)
-          obj3 = Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE2)
-          obj1.file_attributes = { publish: 'no', preserve: 'no', shelve: 'no' }
-          obj2.file_attributes = { publish: 'yes', preserve: 'yes', shelve: 'yes' }
-          objects = [obj1, obj2, obj3]
-          result = described_class.create_content_metadata(druid: TEST_DRUID, add_exif: false, add_file_attributes: true, objects: objects)
-          expect(result.class).to be String
-          xml = Nokogiri::XML(result)
-          expect(xml.errors.size).to eq 0
-          expect(xml.xpath('//contentMetadata')[0].attributes['type'].value).to eq('image')
-          expect(xml.xpath('//resource').length).to eq 3
-          expect(xml.xpath('//resource/file').length).to eq 3
-          expect(xml.xpath('//resource/file/checksum').length).to eq 0
-          expect(xml.xpath('//resource/file/imageData').length).to eq 0
-          expect(xml.xpath('//label').length).to eq 3
-          expect(xml.xpath('//label')[0].text).to match(/Image 1/)
-          expect(xml.xpath('//label')[1].text).to match(/Image 2/)
-          expect(xml.xpath('//label')[2].text).to match(/Image 3/)
-          expect(xml.xpath('//resource')[0].attributes['type'].value).to eq('image')
-          expect(xml.xpath('//resource')[1].attributes['type'].value).to eq('image')
-          expect(xml.xpath('//resource')[2].attributes['type'].value).to eq('image')
-          expect(xml.xpath('//resource/file')[0].attributes['publish'].value).to eq('no') # specificially set in object
-          expect(xml.xpath('//resource/file')[0].attributes['preserve'].value).to eq('no') # specificially set in object
-          expect(xml.xpath('//resource/file')[0].attributes['shelve'].value).to eq('no') # specificially set in object
-          expect(xml.xpath('//resource/file')[1].attributes['publish'].value).to eq('yes') # specificially set in object
-          expect(xml.xpath('//resource/file')[1].attributes['preserve'].value).to eq('yes') # specificially set in object
-          expect(xml.xpath('//resource/file')[1].attributes['shelve'].value).to eq('yes')  # specificially set in object
-          expect(xml.xpath('//resource/file')[2].attributes['publish'].value).to eq('yes') # defaults by mimetype
-          expect(xml.xpath('//resource/file')[2].attributes['preserve'].value).to eq('no') # defaults by mimetype
-          expect(xml.xpath('//resource/file')[2].attributes['shelve'].value).to eq('yes') # defaults by mimetype
-        end
-      end
-
-      context 'when using a single tif and jp2' do
-        it 'generates valid content metadata with exif, overriding file labels' do
+        it 'generates valid content metadata, overriding file labels' do
           objects = [Assembly::ObjectFile.new(TEST_TIF_INPUT_FILE, label: 'Sample tif label!'), Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE, label: 'Sample jp2 label!')]
           result = described_class.create_content_metadata(druid: TEST_DRUID, add_exif: true, add_file_attributes: true, objects: objects)
           expect(result.class).to be String
@@ -119,6 +81,42 @@ RSpec.describe Assembly::ContentMetadata do
         end
       end
 
+      context 'when using a single tif and jp2 with add_exif: false' do
+        it 'generates valid content metadata adding specific file attributes for 2 objects, and defaults for 1 object' do
+          obj1 = Assembly::ObjectFile.new(TEST_TIF_INPUT_FILE)
+          obj2 = Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE)
+          obj3 = Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE2)
+          obj1.file_attributes = { publish: 'no', preserve: 'no', shelve: 'no' }
+          obj2.file_attributes = { publish: 'yes', preserve: 'yes', shelve: 'yes' }
+          objects = [obj1, obj2, obj3]
+          result = described_class.create_content_metadata(druid: TEST_DRUID, add_exif: false, add_file_attributes: true, objects: objects)
+          expect(result.class).to be String
+          xml = Nokogiri::XML(result)
+          expect(xml.errors.size).to eq 0
+          expect(xml.xpath('//contentMetadata')[0].attributes['type'].value).to eq('image')
+          expect(xml.xpath('//resource').length).to eq 3
+          expect(xml.xpath('//resource/file').length).to eq 3
+          expect(xml.xpath('//resource/file/checksum').length).to eq 0
+          expect(xml.xpath('//resource/file/imageData').length).to eq 0
+          expect(xml.xpath('//label').length).to eq 3
+          expect(xml.xpath('//label')[0].text).to match(/Image 1/)
+          expect(xml.xpath('//label')[1].text).to match(/Image 2/)
+          expect(xml.xpath('//label')[2].text).to match(/Image 3/)
+          expect(xml.xpath('//resource')[0].attributes['type'].value).to eq('image')
+          expect(xml.xpath('//resource')[1].attributes['type'].value).to eq('image')
+          expect(xml.xpath('//resource')[2].attributes['type'].value).to eq('image')
+          expect(xml.xpath('//resource/file')[0].attributes['publish'].value).to eq('no') # specificially set in object
+          expect(xml.xpath('//resource/file')[0].attributes['preserve'].value).to eq('no') # specificially set in object
+          expect(xml.xpath('//resource/file')[0].attributes['shelve'].value).to eq('no') # specificially set in object
+          expect(xml.xpath('//resource/file')[1].attributes['publish'].value).to eq('yes') # specificially set in object
+          expect(xml.xpath('//resource/file')[1].attributes['preserve'].value).to eq('yes') # specificially set in object
+          expect(xml.xpath('//resource/file')[1].attributes['shelve'].value).to eq('yes')  # specificially set in object
+          expect(xml.xpath('//resource/file')[2].attributes['publish'].value).to eq('yes') # defaults by mimetype
+          expect(xml.xpath('//resource/file')[2].attributes['preserve'].value).to eq('no') # defaults by mimetype
+          expect(xml.xpath('//resource/file')[2].attributes['shelve'].value).to eq('yes') # defaults by mimetype
+        end
+      end
+
       context 'when using a single tif and jp2' do
         it 'generates valid content metadata with exif, overriding file labels for one, and skipping auto labels for the others or for where the label is set but is blank' do
           objects = [Assembly::ObjectFile.new(TEST_TIF_INPUT_FILE, label: 'Sample tif label!'), Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE), Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE, label: '')]
@@ -331,6 +329,26 @@ RSpec.describe Assembly::ContentMetadata do
           end
         end
       end
+
+      context 'when using a single svg with add_exif: true' do
+        subject(:result) { described_class.create_content_metadata(druid: TEST_DRUID, add_exif: true, auto_labels: false, add_file_attributes: true, objects: objects) }
+
+        let(:objects) { [Assembly::ObjectFile.new(TEST_SVG_INPUT_FILE)] }
+
+        it 'generates no imageData node' do
+          xml = Nokogiri::XML(result)
+          expect(xml.errors.size).to eq 0
+          expect(xml.xpath('//contentMetadata')[0].attributes['type'].value).to eq('image')
+          expect(xml.xpath('//resource/file').length).to eq 1
+          expect(xml.xpath('//resource/file')[0]['mimetype']).to eq 'image/svg+xml'
+          expect(xml.xpath('//resource/file')[0]['publish']).to eq('no')
+          expect(xml.xpath('//resource/file')[0]['preserve']).to eq('yes')
+          expect(xml.xpath('//resource/file')[0]['shelve']).to eq('no')
+          expect(xml.xpath("//resource[@sequence='1']/file").length).to eq 1
+          expect(xml.xpath('//imageData')).not_to be_present
+          expect(xml.xpath('//resource')[0].attributes['type'].value).to eq('image')
+        end
+      end
     end
 
     context 'when style=webarchive-seed' do

data/spec/object_file_spec.rb

@@ -4,10 +4,10 @@ require 'spec_helper'
 
 describe Assembly::ObjectFile do
   it 'does not run if no input file is passed in' do
-    @ai = described_class.new('')
-    expect { @ai.filesize }.to raise_error(RuntimeError, 'input file  does not exist')
-    expect { @ai.sha1 }.to raise_error(RuntimeError, 'input file  does not exist')
-    expect { @ai.md5 }.to raise_error(RuntimeError, 'input file  does not exist')
+    object_file = described_class.new('')
+    expect { object_file.filesize }.to raise_error(RuntimeError, 'input file  does not exist or is a directory')
+    expect { object_file.sha1 }.to raise_error(RuntimeError, 'input file  does not exist or is a directory')
+    expect { object_file.md5 }.to raise_error(RuntimeError, 'input file  does not exist or is a directory')
   end
 
   it 'returns the common directory of a set of filenames passed into it, where the common part does not terminate on a directory' do
@@ -20,191 +20,191 @@ describe Assembly::ObjectFile do
 
   it 'tells us if an input file is an image' do
     expect(File.exist?(TEST_TIF_INPUT_FILE)).to be true
-    @ai = described_class.new(TEST_TIF_INPUT_FILE)
-    expect(@ai.image?).to eq(true)
-    expect(@ai.exif).not_to be nil
-    expect(@ai.mimetype).to eq('image/tiff')
-    expect(@ai.file_mimetype).to eq('image/tiff')
-    expect(@ai.extension_mimetype).to eq('image/tiff')
-    expect(@ai.exif_mimetype).to eq('image/tiff')
-    expect(@ai.object_type).to eq(:image)
-    expect(@ai.valid_image?).to eq(true)
-    expect(@ai.jp2able?).to eq(true)
+    object_file = described_class.new(TEST_TIF_INPUT_FILE)
+    expect(object_file.image?).to be(true)
+    expect(object_file.exif).not_to be_nil
+    expect(object_file.mimetype).to eq('image/tiff')
+    expect(object_file.file_mimetype).to eq('image/tiff')
+    expect(object_file.extension_mimetype).to eq('image/tiff')
+    expect(object_file.exif_mimetype).to eq('image/tiff')
+    expect(object_file.object_type).to eq(:image)
+    expect(object_file.valid_image?).to be(true)
+    expect(object_file.jp2able?).to be(true)
   end
 
   it 'tells us information about the input file' do
-    @ai = described_class.new(TEST_TIF_INPUT_FILE)
-    expect(@ai.filename).to eq('test.tif')
-    expect(@ai.ext).to eq('.tif')
-    expect(@ai.filename_without_ext).to eq('test')
-    expect(@ai.dirname).to eq(File.dirname(TEST_TIF_INPUT_FILE))
+    object_file = described_class.new(TEST_TIF_INPUT_FILE)
+    expect(object_file.filename).to eq('test.tif')
+    expect(object_file.ext).to eq('.tif')
+    expect(object_file.filename_without_ext).to eq('test')
+    expect(object_file.dirname).to eq(File.dirname(TEST_TIF_INPUT_FILE))
   end
 
   it 'sets the correct mimetype of plain/text for .txt files' do
-    @ai = described_class.new(TEST_RES1_TEXT)
-    expect(@ai.mimetype).to eq('text/plain')
+    object_file = described_class.new(TEST_RES1_TEXT)
+    expect(object_file.mimetype).to eq('text/plain')
   end
 
   it 'sets the correct mimetype of plain/text for .xml files' do
-    @ai = described_class.new(TEST_RES1_TEXT)
-    expect(@ai.mimetype).to eq('text/plain')
+    object_file = described_class.new(TEST_RES1_TEXT)
+    expect(object_file.mimetype).to eq('text/plain')
   end
 
   it 'sets the correct mimetype of plain/text for .obj 3d files' do
-    @ai = described_class.new(TEST_OBJ_FILE)
-    expect(@ai.mimetype).to eq('text/plain')
+    object_file = described_class.new(TEST_OBJ_FILE)
+    expect(object_file.mimetype).to eq('text/plain')
   end
 
   it 'sets a mimetype of application/x-tgif for .obj 3d files if we prefer the mimetype extension gem over unix file system command' do
-    @ai = described_class.new(TEST_OBJ_FILE, mime_type_order: %i[extension file exif])
-    expect(@ai.mimetype).to eq('application/x-tgif')
+    object_file = described_class.new(TEST_OBJ_FILE, mime_type_order: %i[extension file exif])
+    expect(object_file.mimetype).to eq('application/x-tgif')
   end
 
   it 'ignores invald mimetype generation methods and still sets a mimetype of application/x-tgif for .obj 3d files if we prefer the mimetype extension gem over unix file system command' do
-    @ai = described_class.new(TEST_OBJ_FILE, mime_type_order: %i[bogus extension file])
-    expect(@ai.mimetype).to eq('application/x-tgif')
+    object_file = described_class.new(TEST_OBJ_FILE, mime_type_order: %i[bogus extension file])
+    expect(object_file.mimetype).to eq('application/x-tgif')
   end
 
   it 'sets the correct mimetype of plain/text for .ply 3d files' do
-    @ai = described_class.new(TEST_PLY_FILE)
-    expect(@ai.mimetype).to eq('text/plain')
+    object_file = described_class.new(TEST_PLY_FILE)
+    expect(object_file.mimetype).to eq('text/plain')
   end
 
   it 'overrides the mimetype generators and uses the manual mapping to set the correct mimetype of application/json for a .json file' do
-    @ai = described_class.new(TEST_JSON_FILE)
-    expect(@ai.exif_mimetype).to be_nil # exif returns nil
-    expect(@ai.file_mimetype).to eq('text/plain') # unix file system command returns plain text
-    expect(@ai.mimetype).to eq('application/json') # but our configured mapping overrides both and returns application/json
+    object_file = described_class.new(TEST_JSON_FILE)
+    expect(object_file.exif_mimetype).to be_nil # exif returns nil
+    expect(object_file.file_mimetype).to eq('text/plain') # unix file system command returns plain text
+    expect(object_file.mimetype).to eq('application/json') # but our configured mapping overrides both and returns application/json
   end
 
   it 'sets the correct mimetype of image/tiff for .tif files' do
-    @ai = described_class.new(TEST_TIF_INPUT_FILE)
-    expect(@ai.mimetype).to eq('image/tiff')
+    object_file = described_class.new(TEST_TIF_INPUT_FILE)
+    expect(object_file.mimetype).to eq('image/tiff')
   end
 
   it 'sets the correct mimetype of image/jp2 for .jp2 files' do
-    @ai = described_class.new(TEST_JP2_INPUT_FILE)
-    expect(@ai.mimetype).to eq('image/jp2')
+    object_file = described_class.new(TEST_JP2_INPUT_FILE)
+    expect(object_file.mimetype).to eq('image/jp2')
   end
 
   it 'sets the correct mimetype of application/pdf for .pdf files' do
-    @ai = described_class.new(TEST_RES1_PDF)
-    expect(@ai.mimetype).to eq('application/pdf')
+    object_file = described_class.new(TEST_RES1_PDF)
+    expect(object_file.mimetype).to eq('application/pdf')
   end
 
   it 'gives us the mimetype of a file even if the exif information is damaged' do
-    @ai = described_class.new(TEST_FILE_NO_EXIF)
-    expect(@ai.filename).to eq('file_with_no_exif.xml')
-    expect(@ai.ext).to eq('.xml')
-    expect(['text/html', 'application/xml'].include?(@ai.mimetype)).to be true # we could get either of these mimetypes depending on the OS
+    object_file = described_class.new(TEST_FILE_NO_EXIF)
+    expect(object_file.filename).to eq('file_with_no_exif.xml')
+    expect(object_file.ext).to eq('.xml')
+    expect(['text/html', 'application/xml'].include?(object_file.mimetype)).to be true # we could get either of these mimetypes depending on the OS
   end
 
   it 'gives us the DPG base name for a file' do
     test_file = File.join(TEST_INPUT_DIR, 'oo000oo0001_00_001.tif')
-    @ai = described_class.new(test_file)
-    expect(@ai.dpg_basename).to eq('oo000oo0001_001')
+    object_file = described_class.new(test_file)
+    expect(object_file.dpg_basename).to eq('oo000oo0001_001')
   end
 
   it 'gives us the DPG subfolder name for a file' do
     test_file = File.join(TEST_INPUT_DIR, 'oo000oo0001_05_001.tif')
-    @ai = described_class.new(test_file)
-    expect(@ai.dpg_folder).to eq('05')
+    object_file = described_class.new(test_file)
+    expect(object_file.dpg_folder).to eq('05')
   end
 
   it 'tells us that a jp2 file is not jp2able but does have a color profile' do
     expect(File.exist?(TEST_JP2_INPUT_FILE)).to be true
-    @ai = described_class.new(TEST_JP2_INPUT_FILE)
-    expect(@ai.image?).to eq(true)
-    expect(@ai.object_type).to eq(:image)
-    expect(@ai.valid_image?).to eq(true)
-    expect(@ai.jp2able?).to eq(false)
-    expect(@ai.has_color_profile?).to eq(true)
+    object_file = described_class.new(TEST_JP2_INPUT_FILE)
+    expect(object_file.image?).to be(true)
+    expect(object_file.object_type).to eq(:image)
+    expect(object_file.valid_image?).to be(true)
+    expect(object_file.jp2able?).to be(false)
+    expect(object_file.has_color_profile?).to be(true)
   end
 
   it 'tells us that a tiff file is jp2able and has a color profile' do
     expect(File.exist?(TEST_RES1_TIF1)).to be true
-    @ai = described_class.new(TEST_RES1_TIF1)
-    expect(@ai.image?).to eq(true)
-    expect(@ai.object_type).to eq(:image)
-    expect(@ai.valid_image?).to eq(true)
-    expect(@ai.jp2able?).to eq(true)
-    expect(@ai.has_color_profile?).to eq(true)
+    object_file = described_class.new(TEST_RES1_TIF1)
+    expect(object_file.image?).to be(true)
+    expect(object_file.object_type).to eq(:image)
+    expect(object_file.valid_image?).to be(true)
+    expect(object_file.jp2able?).to be(true)
+    expect(object_file.has_color_profile?).to be(true)
   end
 
   it 'tells us that a tiff file is not jp2able and is not valid since it has no profile' do
     expect(File.exist?(TEST_TIFF_NO_COLOR_FILE)).to be true
-    @ai = described_class.new(TEST_TIFF_NO_COLOR_FILE)
-    expect(@ai.image?).to eq(true)
-    expect(@ai.object_type).to eq(:image)
-    expect(@ai.valid_image?).to eq(true)
-    expect(@ai.jp2able?).to eq(true)
-    expect(@ai.has_color_profile?).to eq(false)
+    object_file = described_class.new(TEST_TIFF_NO_COLOR_FILE)
+    expect(object_file.image?).to be(true)
+    expect(object_file.object_type).to eq(:image)
+    expect(object_file.valid_image?).to be(true)
+    expect(object_file.jp2able?).to be(true)
+    expect(object_file.has_color_profile?).to be(false)
   end
 
   it 'computes checksums for an image file' do
     expect(File.exist?(TEST_TIF_INPUT_FILE)).to be true
-    @ai = described_class.new(TEST_TIF_INPUT_FILE)
-    expect(@ai.md5).to eq('a2400500acf21e43f5440d93be894101')
-    expect(@ai.sha1).to eq('8d11fab63089a24c8b17063d29a4b0eac359fb41')
+    object_file = described_class.new(TEST_TIF_INPUT_FILE)
+    expect(object_file.md5).to eq('a2400500acf21e43f5440d93be894101')
+    expect(object_file.sha1).to eq('8d11fab63089a24c8b17063d29a4b0eac359fb41')
   end
 
   it 'indicates that the file is not found when a valid directory is supplied instead of a file or when an invalid file path is specified' do
     path = Assembly::PATH_TO_GEM
-    @ai = described_class.new(path)
+    object_file = described_class.new(path)
     expect(File.exist?(path)).to be true
     expect(File.directory?(path)).to be true
-    expect(@ai.file_exists?).to be false
+    expect(object_file.file_exists?).to be false
 
     path = File.join(Assembly::PATH_TO_GEM, 'bogus.txt')
-    @ai = described_class.new(path)
+    object_file = described_class.new(path)
     expect(File.exist?(path)).to be false
     expect(File.directory?(path)).to be false
-    expect(@ai.file_exists?).to be false
+    expect(object_file.file_exists?).to be false
   end
 
   it 'sets attributes correctly when initializing' do
-    @ai = described_class.new('/some/file.txt')
-    expect(@ai.path).to eq('/some/file.txt')
-    expect(@ai.label).to be_nil
-    expect(@ai.file_attributes).to be_nil
-    expect(@ai.provider_sha1).to be_nil
-    expect(@ai.provider_md5).to be_nil
-    expect(@ai.relative_path).to be_nil
-
-    @ai = described_class.new('/some/file.txt', label: 'some label', file_attributes: { 'shelve' => 'yes', 'publish' => 'yes', 'preserve' => 'no' }, relative_path: '/tmp')
-    expect(@ai.path).to eq('/some/file.txt')
-    expect(@ai.label).to eq('some label')
-    expect(@ai.file_attributes).to eq('shelve' => 'yes', 'publish' => 'yes', 'preserve' => 'no')
-    expect(@ai.provider_sha1).to be_nil
-    expect(@ai.provider_md5).to be_nil
-    expect(@ai.relative_path).to eq('/tmp')
+    object_file = described_class.new('/some/file.txt')
+    expect(object_file.path).to eq('/some/file.txt')
+    expect(object_file.label).to be_nil
+    expect(object_file.file_attributes).to be_nil
+    expect(object_file.provider_sha1).to be_nil
+    expect(object_file.provider_md5).to be_nil
+    expect(object_file.relative_path).to be_nil
+
+    object_file = described_class.new('/some/file.txt', label: 'some label', file_attributes: { 'shelve' => 'yes', 'publish' => 'yes', 'preserve' => 'no' }, relative_path: '/tmp')
+    expect(object_file.path).to eq('/some/file.txt')
+    expect(object_file.label).to eq('some label')
+    expect(object_file.file_attributes).to eq('shelve' => 'yes', 'publish' => 'yes', 'preserve' => 'no')
+    expect(object_file.provider_sha1).to be_nil
+    expect(object_file.provider_md5).to be_nil
+    expect(object_file.relative_path).to eq('/tmp')
   end
 
   it 'sets md5_provider attribute' do
-    ai = described_class.new('/some/file.txt', provider_md5: 'XYZ')
-    expect(ai.provider_md5).to eq('XYZ')
+    object_file = described_class.new('/some/file.txt', provider_md5: 'XYZ')
+    expect(object_file.provider_md5).to eq('XYZ')
   end
 
   it 'tells us if an input file is not an image' do
     non_image_file = File.join(Assembly::PATH_TO_GEM, 'spec/object_file_spec.rb')
     expect(File.exist?(non_image_file)).to be true
-    @ai = described_class.new(non_image_file)
-    expect(@ai.image?).to eq(false)
-    expect(@ai.object_type).not_to eq(:image)
-    expect(@ai.valid_image?).to eq(false)
+    object_file = described_class.new(non_image_file)
+    expect(object_file.image?).to be(false)
+    expect(object_file.object_type).not_to eq(:image)
+    expect(object_file.valid_image?).to be(false)
 
     non_image_file = File.join(Assembly::PATH_TO_GEM, 'spec/test_data/input/file_with_no_exif.xml')
     expect(File.exist?(non_image_file)).to be true
-    @ai = described_class.new(non_image_file)
-    expect(@ai.image?).to eq(false)
-    expect(@ai.object_type).not_to eq(:image)
-    expect(@ai.valid_image?).to eq(false)
+    object_file = described_class.new(non_image_file)
+    expect(object_file.image?).to be(false)
+    expect(object_file.object_type).not_to eq(:image)
+    expect(object_file.valid_image?).to be(false)
   end
 
   it 'tells us the size of an input file' do
     expect(File.exist?(TEST_TIF_INPUT_FILE)).to be true
-    @ai = described_class.new(TEST_TIF_INPUT_FILE)
-    expect(@ai.filesize).to eq(63_542)
+    object_file = described_class.new(TEST_TIF_INPUT_FILE)
+    expect(object_file.filesize).to eq(63_542)
   end
 
   it 'tells us the mimetype and encoding of an input file' do
@@ -214,4 +214,9 @@ describe Assembly::ObjectFile do
     expect(@ai.file_mimetype).to eq('image/tiff')
     expect(@ai.encoding).to eq('binary')
   end
+
+  it 'raises MiniExiftool::Error if exiftool raises one' do
+    object_file = described_class.new('spec/test_data/empty.txt')
+    expect { object_file.exif }.to raise_error(MiniExiftool::Error)
+  end
 end

data/spec/spec_helper.rb

@@ -3,8 +3,8 @@
 require 'simplecov'
 SimpleCov.start
 
-bootfile = File.expand_path("#{File.dirname(__FILE__)}/../config/boot")
-require bootfile
+require File.expand_path("#{File.dirname(__FILE__)}/../config/boot")
+require 'byebug'
 
 RSpec.configure do |config|
   config.order = 'random'
@@ -18,6 +18,7 @@ TEST_TIF_INPUT_FILE2  = File.join(TEST_INPUT_DIR, 'test2.tif')
 TEST_JPEG_INPUT_FILE  = File.join(TEST_INPUT_DIR, 'test.jpg')
 TEST_JP2_INPUT_FILE = File.join(TEST_INPUT_DIR, 'test.jp2')
 TEST_JP2_INPUT_FILE2 = File.join(TEST_INPUT_DIR, 'test2.jp2')
+TEST_SVG_INPUT_FILE  = File.join(TEST_INPUT_DIR, 'test.svg')
 TEST_JP2_OUTPUT_FILE = File.join(TEST_OUTPUT_DIR, 'test.jp2')
 TEST_PDF_FILE = File.join(TEST_INPUT_DIR, 'test.pdf')
 

data/spec/test_data/input/test.svg

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg width="507.3" height="508.2" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" overflow="hidden"><defs><clipPath id="clip0"><rect x="2361" y="213" width="507" height="508"/></clipPath></defs><g clip-path="url(#clip0)" transform="translate(-2361 -213)"><path d="M2361 467C2361 326.72 2474.5 213 2614.5 213 2754.5 213 2868 326.72 2868 467 2868 607.28 2754.5 721 2614.5 721 2474.5 721 2361 607.28 2361 467Z" fill="#BF9000" fill-rule="evenodd"/></g></svg>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: assembly-objectfile
 version: !ruby/object:Gem::Version
-  version: 1.10.3
+  version: 1.13.0
 platform: ruby
 authors:
 - Peter Mangiafico
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-04-26 00:00:00.000000000 Z
+date: 2022-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -157,16 +157,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.25'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.25'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -185,16 +185,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: '0'
 description: Get exif data, file sizes and more.
 email:
 - pmangiafico@stanford.edu
@@ -202,13 +202,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/pull_request_template.md"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".rvmrc.example"
-- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -233,6 +233,7 @@ files:
 - spec/content_metadata_spec.rb
 - spec/object_file_spec.rb
 - spec/spec_helper.rb
+- spec/test_data/empty.txt
 - spec/test_data/input/.empty
 - spec/test_data/input/file_with_no_exif.xml
 - spec/test_data/input/oo000oo0001/00/oo000oo0001_00_001.tif
@@ -265,6 +266,7 @@ files:
 - spec/test_data/input/test.jp2
 - spec/test_data/input/test.json
 - spec/test_data/input/test.pdf
+- spec/test_data/input/test.svg
 - spec/test_data/input/test.tif
 - spec/test_data/input/test2.jp2
 - spec/test_data/input/test2.tif
@@ -272,23 +274,24 @@ files:
 homepage: https://github.com/sul-dlss/assembly-objectfile
 licenses:
 - ALv2
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.16
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Ruby immplementation of file services needed to prepare objects to be accessioned
@@ -297,6 +300,7 @@ test_files:
 - spec/content_metadata_spec.rb
 - spec/object_file_spec.rb
 - spec/spec_helper.rb
+- spec/test_data/empty.txt
 - spec/test_data/input/.empty
 - spec/test_data/input/file_with_no_exif.xml
 - spec/test_data/input/oo000oo0001/00/oo000oo0001_00_001.tif
@@ -329,6 +333,7 @@ test_files:
 - spec/test_data/input/test.jp2
 - spec/test_data/input/test.json
 - spec/test_data/input/test.pdf
+- spec/test_data/input/test.svg
 - spec/test_data/input/test.tif
 - spec/test_data/input/test2.jp2
 - spec/test_data/input/test2.tif

data/.travis.yml

@@ -1,20 +0,0 @@
-language: ruby
-rvm:
-  - 2.5.7
-  - 2.6.5
-addons:
-  apt:
-    packages:
-      - libimage-exiftool-perl
-before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-script:
-  - bundle exec rubocop
-  - bundle exec rake
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-
-notifications:
-  email: false