aspera-cli 4.6.0 → 4.7.0

data/lib/aspera/cli/plugins/config.rb

@@ -1,16 +1,19 @@
+# frozen_string_literal: true
 require 'aspera/cli/basic_auth_plugin'
 require 'aspera/cli/extended_value'
+require 'aspera/cli/version'
 require 'aspera/fasp/installation'
 require 'aspera/fasp/parameters'
-require 'aspera/open_application'
-require 'aspera/aoc'
+require 'aspera/fasp/transfer_spec'
+require 'aspera/fasp/error_info'
 require 'aspera/proxy_auto_config'
-require 'aspera/uri_reader'
-require 'aspera/rest'
+require 'aspera/open_application'
 require 'aspera/persistency_action_once'
 require 'aspera/id_generator'
 require 'aspera/keychain/encrypted_hash'
 require 'aspera/keychain/macos_security'
+require 'aspera/aoc'
+require 'aspera/rest'
 require 'xmlsimple'
 require 'base64'
 require 'net/smtp'
@@ -32,7 +35,7 @@ module Aspera
         CONF_PRESET_VERSION='version'
         CONF_PRESET_DEFAULT='default'
         CONF_PRESET_GLOBAL='global_common_defaults'
-        CONF_PRESET_SECRETS='default_secrets'
+        CONF_PRESET_SECRETS='default_secrets' # pragma: allowlist secret
         CONF_PLUGIN_SYM = :config # Plugins::Config.name.split('::').last.downcase.to_sym
         CONF_GLOBAL_SYM = :config
         # old tool name
@@ -54,19 +57,19 @@ module Aspera
         DEMO='demo'
         DEMO_SERVER_PRESET='demoserver'
         AOC_PATH_API_CLIENTS='admin/api-clients'
-        EMAIL_TEST_TEMPLATE=<<END_OF_TEMPLATE
-From: <%=from_name%> <<%=from_email%>>
-To: <<%=to%>>
-Subject: Amelia email test
+        EMAIL_TEST_TEMPLATE=<<~END_OF_TEMPLATE
+          From: <%=from_name%> <<%=from_email%>>
+          To: <<%=to%>>
+          Subject: Amelia email test
 
-It worked !
-END_OF_TEMPLATE
+          It worked !
+        END_OF_TEMPLATE
         # special extended values
-        EXTV_INCLUDE_PRESETS='incps'
-        EXTV_PRESET='preset'
+        EXTV_INCLUDE_PRESETS=:incps
+        EXTV_PRESET=:preset
         PRESET_DIG_SEPARATOR='.'
         DEFAULT_CHECK_NEW_VERSION_DAYS=7
-        DEFAULT_PRIV_KEY_FILENAME='aspera_aoc_key'
+        DEFAULT_PRIV_KEY_FILENAME='aspera_aoc_key' # pragma: allowlist secret
         DEFAULT_PRIVKEY_LENGTH=4096
         private_constant :DEFAULT_CONFIG_FILENAME,:CONF_PRESET_CONFIG,:CONF_PRESET_VERSION,:CONF_PRESET_DEFAULT,
         :CONF_PRESET_GLOBAL,:PROGRAM_NAME_V1,:PROGRAM_NAME_V2,:DEFAULT_REDIRECT,:ASPERA_PLUGINS_FOLDERNAME,
@@ -74,93 +77,103 @@ END_OF_TEMPLATE
         :TRANSFER_SDK_ARCHIVE_URL,:AOC_PATH_API_CLIENTS,:DEMO_SERVER_PRESET,:EMAIL_TEST_TEMPLATE,:EXTV_INCLUDE_PRESETS,
         :EXTV_PRESET,:DEFAULT_CHECK_NEW_VERSION_DAYS,:DEFAULT_PRIV_KEY_FILENAME,:SERVER_COMMAND,:CONF_PRESET_SECRETS,
         :PRESET_DIG_SEPARATOR
-        def option_preset; nil; end
-
-        def option_preset=(value)
-          case value
-          when String
-            self.options.add_option_preset(preset_by_name(value))
-          when Hash
-            self.options.add_option_preset(value)
-          else
-            raise 'Preset definition must be a String for name, or Hash for value'
-          end
-          nil
-        end
-
-        def initialize(env,tool_name,help_url,version,main_folder)
+        def initialize(env,params)
+          raise 'env and params must be Hash' unless env.is_a?(Hash) && params.is_a?(Hash)
+          raise 'missing param' unless [:name,:help,:version,:gem].sort.eql?(params.keys.sort)
           super(env)
+          @info=params
+          @main_folder=default_app_main_folder
           @plugins={}
           @plugin_lookup_folders=[]
           @use_plugin_defaults=true
           @config_presets=nil
           @connect_versions=nil
           @vault=nil
-          @program_version=version
-          @tool_name=tool_name
-          @help_url=help_url
-          @main_folder=main_folder
           @conf_file_default=File.join(@main_folder,DEFAULT_CONFIG_FILENAME)
           @option_config_file=@conf_file_default
-          Log.log.debug("#{tool_name} folder: #{@main_folder}")
+          @pac_exec=nil
+          Log.log.debug("#{@info[:name]} folder: #{@main_folder}")
           # set folder for FASP SDK
           add_plugin_lookup_folder(self.class.gem_plugins_folder)
           add_plugin_lookup_folder(File.join(@main_folder,ASPERA_PLUGINS_FOLDERNAME))
           # do file parameter first
-          self.options.set_obj_attr(:config_file,self,:option_config_file)
-          self.options.add_opt_simple(:config_file,"read parameters from file in YAML format, current=#{@option_config_file}")
-          self.options.parse_options!
+          options.set_obj_attr(:config_file,self,:option_config_file)
+          options.add_opt_simple(:config_file,"read parameters from file in YAML format, current=#{@option_config_file}")
+          options.parse_options!
           # read correct file
           read_config_file
           # add preset handler (needed for smtp)
           ExtendedValue.instance.set_handler(EXTV_PRESET,:reader,lambda{|v|preset_by_name(v)})
           ExtendedValue.instance.set_handler(EXTV_INCLUDE_PRESETS,:decoder,lambda{|v|expanded_with_preset_includes(v)})
           # load defaults before it can be overriden
-          self.add_plugin_default_preset(CONF_GLOBAL_SYM)
-          self.options.parse_options!
-          self.options.set_obj_attr(:ascp_path,self,:option_ascp_path)
-          self.options.set_obj_attr(:use_product,self,:option_use_product)
-          self.options.set_obj_attr(:preset,self,:option_preset)
-          self.options.set_obj_attr(:plugin_folder,self,:option_plugin_folder)
-          self.options.add_opt_switch(:no_default,'-N','do not load default configuration for plugin') { @use_plugin_defaults=false }
-          self.options.add_opt_boolean(:override,'Wizard: override existing value')
-          self.options.add_opt_boolean(:use_generic_client,'Wizard: AoC: use global or org specific jwt client id')
-          self.options.add_opt_boolean(:default,'Wizard: set as default configuration for specified plugin (also: update)')
-          self.options.add_opt_boolean(:test_mode,'Wizard: skip private key check step')
-          self.options.add_opt_simple(:preset,'-PVALUE','load the named option preset from current config file')
-          self.options.add_opt_simple(:pkeypath,'Wizard: path to private key for JWT')
-          self.options.add_opt_simple(:ascp_path,'path to ascp')
-          self.options.add_opt_simple(:use_product,'use ascp from specified product')
-          self.options.add_opt_simple(:smtp,'smtp configuration (extended value: hash)')
-          self.options.add_opt_simple(:fpac,'proxy auto configuration URL')
-          self.options.add_opt_simple(:secret,'default secret')
-          self.options.add_opt_simple(:secrets,'secret vault')
-          self.options.add_opt_simple(:sdk_url,'URL to get SDK')
-          self.options.add_opt_simple(:sdk_folder,'SDK folder path')
-          self.options.add_opt_simple(:notif_to,'email recipient for notification of transfers')
-          self.options.add_opt_simple(:notif_template,'email ERB template for notification of transfers')
-          self.options.add_opt_simple(:version_check_days,Integer,'period in days to check new version (zero to disable)')
-          self.options.add_opt_simple(:plugin_folder,'folder where to find additional plugins')
-          self.options.set_option(:use_generic_client,true)
-          self.options.set_option(:test_mode,false)
-          self.options.set_option(:default,true)
-          self.options.set_option(:version_check_days,DEFAULT_CHECK_NEW_VERSION_DAYS)
-          self.options.set_option(:sdk_url,TRANSFER_SDK_ARCHIVE_URL)
-          self.options.set_option(:sdk_folder,File.join(@main_folder,'sdk'))
-          self.options.set_option(:override,:no)
-          self.options.parse_options!
-          Fasp::Installation.instance.folder=self.options.get_option(:sdk_folder,:mandatory)
+          add_plugin_default_preset(CONF_GLOBAL_SYM)
+          options.parse_options!
+          options.set_obj_attr(:ascp_path,Fasp::Installation.instance,:ascp_path)
+          options.set_obj_attr(:sdk_folder,Fasp::Installation.instance,:sdk_folder)
+          options.set_obj_attr(:use_product,self,:option_use_product)
+          options.set_obj_attr(:preset,self,:option_preset)
+          options.set_obj_attr(:plugin_folder,self,:option_plugin_folder)
+          options.add_opt_switch(:no_default,'-N','do not load default configuration for plugin') { @use_plugin_defaults=false }
+          options.add_opt_boolean(:override,'Wizard: override existing value')
+          options.add_opt_boolean(:use_generic_client,'Wizard: AoC: use global or org specific jwt client id')
+          options.add_opt_boolean(:default,'Wizard: set as default configuration for specified plugin (also: update)')
+          options.add_opt_boolean(:test_mode,'Wizard: skip private key check step')
+          options.add_opt_simple(:preset,'-PVALUE','load the named option preset from current config file')
+          options.add_opt_simple(:pkeypath,'Wizard: path to private key for JWT')
+          options.add_opt_simple(:ascp_path,'path to ascp')
+          options.add_opt_simple(:use_product,'use ascp from specified product')
+          options.add_opt_simple(:smtp,'smtp configuration (extended value: hash)')
+          options.add_opt_simple(:fpac,'proxy auto configuration script')
+          options.add_opt_simple(:secret,'default secret')
+          options.add_opt_simple(:secrets,'secret vault')
+          options.add_opt_simple(:sdk_url,'URL to get SDK')
+          options.add_opt_simple(:sdk_folder,'SDK folder path')
+          options.add_opt_simple(:notif_to,'email recipient for notification of transfers')
+          options.add_opt_simple(:notif_template,'email ERB template for notification of transfers')
+          options.add_opt_simple(:version_check_days,Integer,'period in days to check new version (zero to disable)')
+          options.add_opt_simple(:plugin_folder,'folder where to find additional plugins')
+          options.set_option(:use_generic_client,true)
+          options.set_option(:test_mode,false)
+          options.set_option(:default,true)
+          options.set_option(:version_check_days,DEFAULT_CHECK_NEW_VERSION_DAYS)
+          options.set_option(:sdk_url,TRANSFER_SDK_ARCHIVE_URL)
+          options.set_option(:sdk_folder,File.join(@main_folder,'sdk'))
+          options.set_option(:override,:no)
+          options.parse_options!
+          pac_script=options.get_option(:fpac,:optional)
+          # create PAC executor
+          @pac_exec=Aspera::ProxyAutoConfig.new(pac_script).register_uri_generic unless pac_script.nil?
+        end
+
+        # env var name to override the app's main folder
+        # default main folder is $HOME/<vendor main app folder>/<program name>
+        def conf_dir_env_var
+          return "#{@info[:name]}_home".upcase
+        end
+
+        def default_app_main_folder
+          # find out application main folder
+          app_folder=ENV[conf_dir_env_var]
+          # if env var undefined or empty
+          if app_folder.nil? || app_folder.empty?
+            user_home_folder=Dir.home
+            raise CliError,"Home folder does not exist: #{user_home_folder}. Check your user environment or use #{conf_dir_env_var}." unless Dir.exist?(user_home_folder)
+            app_folder=File.join(user_home_folder,ASPERA_HOME_FOLDER_NAME,@info[:name])
+          end
+          return app_folder
         end
 
         def check_gem_version
-          this_gem_name=File.basename(File.dirname(self.class.gem_root)).gsub(/-[0-9].*$/,'')
           latest_version=begin
-            Rest.new(base_url: 'https://rubygems.org/api/v1').read("versions/#{this_gem_name}/latest.json")[:data]['version']
-          rescue
+            Rest.new(base_url: 'https://rubygems.org/api/v1').read("versions/#{@info[:gem]}/latest.json")[:data]['version']
+          rescue StandardError
             Log.log.warn('Could not retrieve latest gem version on rubygems.')
             '0'
           end
-          return {name: this_gem_name, current: Aspera::Cli::VERSION, latest: latest_version, need_update: Gem::Version.new(Aspera::Cli::VERSION) < Gem::Version.new(latest_version)}
+          if Gem::Version.new(Environment.ruby_version) < Gem::Version.new(RUBY_FUTURE_MINIMUM_VERSION)
+            Log.log.warn("Note that a future version will require Ruby version #{RUBY_FUTURE_MINIMUM_VERSION} at minimum, you are using #{Environment.ruby_version}")
+          end
+          return {name: @info[:gem], current: Aspera::Cli::VERSION, latest: latest_version, need_update: Gem::Version.new(Aspera::Cli::VERSION) < Gem::Version.new(latest_version)}
         end
 
         def periodic_check_newer_gem_version
@@ -168,30 +181,29 @@ END_OF_TEMPLATE
           delay_days=options.get_option(:version_check_days,:mandatory)
           Log.log.info("check days: #{delay_days}")
           # check only if not zero day
-          if !delay_days.eql?(0)
-            # get last date from persistency
-            last_check_array=[]
-            check_date_persist=PersistencyActionOnce.new(
-            manager: persistency,
-            data:    last_check_array,
-            id:      'version_last_check')
-            # get persisted date or nil
-            last_check_date = begin
-              Date.strptime(last_check_array.first, '%Y/%m/%d')
-            rescue
-              nil
-            end
-            current_date=Date.today
-            Log.log.debug("days elapsed: #{last_check_date.is_a?(Date) ? current_date - last_check_date : last_check_date.class.name}")
-            if last_check_date.nil? or (current_date - last_check_date) > delay_days
-              last_check_array[0]=current_date.strftime('%Y/%m/%d')
-              check_date_persist.save
-              check_data=check_gem_version
-              if check_data[:need_update]
-                Log.log.warn("A new version is available: #{check_data[:latest]}. You have #{check_data[:current]}. Upgrade with: gem update #{check_data[:name]}")
-              end
-            end
+          return if delay_days.eql?(0)
+          # get last date from persistency
+          last_check_array=[]
+          check_date_persist=PersistencyActionOnce.new(
+          manager: persistency,
+          data:    last_check_array,
+          id:      'version_last_check')
+          # get persisted date or nil
+          current_date=Date.today
+          last_check_days = begin
+            current_date-Date.strptime(last_check_array.first, '%Y/%m/%d')
+          rescue StandardError
+            # negative value will force check
+            -1
           end
+          Log.log.debug("days elapsed: #{last_check_days}")
+          return if last_check_days < delay_days
+          # generate timestamp
+          last_check_array[0]=current_date.strftime('%Y/%m/%d')
+          check_date_persist.save
+          # compare this version and the one on internet
+          check_data=check_gem_version
+          Log.log.warn("A new version is available: #{check_data[:latest]}. You have #{check_data[:current]}. Upgrade with: gem update #{check_data[:name]}") if check_data[:need_update]
         end
 
         # retrieve structure from cloud (CDN) with all versions available
@@ -218,9 +230,10 @@ END_OF_TEMPLATE
         def add_plugin_default_preset(plugin_name_sym)
           default_config_name=get_plugin_default_config_name(plugin_name_sym)
           Log.log.debug("add_plugin_default_preset:#{plugin_name_sym}:#{default_config_name}")
-          self.options.add_option_preset(preset_by_name(default_config_name),:unshift) unless default_config_name.nil?
+          options.add_option_preset(preset_by_name(default_config_name),:unshift) unless default_config_name.nil?
           return nil
         end
+
         private
 
         def generate_rsa_private_key(private_key_path,length)
@@ -231,32 +244,40 @@ END_OF_TEMPLATE
           nil
         end
 
-        # folder containing plugins in the gem's main folder
-        def self.gem_plugins_folder
-          File.dirname(File.expand_path(__FILE__))
-        end
+        class << self
+          # folder containing plugins in the gem's main folder
+          def gem_plugins_folder
+            File.dirname(File.expand_path(__FILE__))
+          end
 
-        # find the root folder of gem where this class is
-        # go up as many times as englobing modules (not counting class, as it is a file)
-        def self.gem_root
-          File.expand_path(Module.nesting[1].to_s.gsub('::','/').gsub(%r([^/]+),'..'),File.dirname(__FILE__))
-        end
+          # name of englobin module
+          # @return "Aspera::Cli::Plugins"
+          def module_full_name
+            return Module.nesting[2].to_s
+          end
 
-        # instanciate a plugin
-        # plugins must be Capitalized
-        def self.plugin_class(plugin_name_sym)
-          # Module.nesting[2] is Aspera::Cli
-          return Object::const_get("#{Module.nesting[2].to_s}::Plugins::#{plugin_name_sym.to_s.capitalize}")
-        end
+          # @return main folder where code is, i.e. .../lib
+          # go up as many times as englobing modules (not counting class, as it is a file)
+          def gem_src_root
+            File.expand_path(module_full_name.gsub('::','/').gsub(%r{[^/]+},'..'),gem_plugins_folder)
+          end
+
+          # instanciate a plugin
+          # plugins must be Capitalized
+          def plugin_class(plugin_name_sym)
+            # Module.nesting[2] is Aspera::Cli::Plugins
+            return Object.const_get("#{module_full_name}::#{plugin_name_sym.to_s.capitalize}")
+          end
 
-        def self.flatten_all_config(t)
-          r=[]
-          t.each do |k,v|
-            v.each do |kk,vv|
-              r.push({'config'=>k,'parameter'=>kk,'value'=>vv})
+          def flatten_all_config(t)
+            r=[]
+            t.each do |k,v|
+              v.each do |kk,vv|
+                r.push({'config'=>k,'parameter'=>kk,'value'=>vv})
+              end
             end
+            return r
           end
-          return r
         end
 
         # set parameter and value in global config
@@ -281,8 +302,7 @@ END_OF_TEMPLATE
 
         # $HOME/.aspera/`program_name`
         attr_reader :main_folder
-        attr_reader :gem_url
-        attr_reader :plugins
+        attr_reader :gem_url, :plugins
         attr_accessor :option_config_file
 
         # @return the hash from name (also expands possible includes)
@@ -299,8 +319,8 @@ END_OF_TEMPLATE
             raise CliError,"no such config preset: #{include_path}" if nil?
           end
           case current
-          when Hash;return expanded_with_preset_includes(current,include_path)
-          when String; return ExtendedValue.instance.evaluate(current)
+          when Hash then return expanded_with_preset_includes(current,include_path)
+          when String then return ExtendedValue.instance.evaluate(current)
           else return current
           end
         end
@@ -316,7 +336,7 @@ END_OF_TEMPLATE
             memory.delete(EXTV_INCLUDE_PRESETS)
             hash_val={}
             raise "#{EXTV_INCLUDE_PRESETS} must be an Array" unless includes.is_a?(Array)
-            raise "#{EXTV_INCLUDE_PRESETS} must contain names" unless includes.map{|i|i.class}.uniq.eql?([String])
+            raise "#{EXTV_INCLUDE_PRESETS} must contain names" unless includes.map(&:class).uniq.eql?([String])
             includes.each do |preset_name|
               hash_val.merge!(preset_by_name(preset_name,include_path))
             end
@@ -325,26 +345,18 @@ END_OF_TEMPLATE
           return hash_val
         end
 
-        def option_ascp_path=(new_value)
-          Fasp::Installation.instance.ascp_path=new_value
-        end
-
-        def option_ascp_path
-          Fasp::Installation.instance.path(:ascp)
-        end
-
         def option_use_product=(value)
           Fasp::Installation.instance.use_ascp_from_product(value)
         end
 
         def option_use_product
-          'write-only value'
+          'write-only option, see value of ascp_path'
         end
 
         def option_plugin_folder=(value)
           case value
-          when String; add_plugin_lookup_folder(value)
-          when Array; value.each{|f|add_plugin_lookup_folder(f)}
+          when String then add_plugin_lookup_folder(value)
+          when Array then value.each{|f|add_plugin_lookup_folder(f)}
           else raise "folder shall be Array or String, not #{value.class}"
           end
         end
@@ -353,6 +365,19 @@ END_OF_TEMPLATE
           return @plugin_lookup_folders
         end
 
+        def option_preset; 'write-only option'; end
+
+        def option_preset=(value)
+          case value
+          when String
+            options.add_option_preset(preset_by_name(value))
+          when Hash
+            options.add_option_preset(value)
+          else
+            raise 'Preset definition must be a String for name, or Hash for value'
+          end
+        end
+
         def convert_preset_path(old_name,new_name,files_to_copy)
           old_subpath=File.join('',ASPERA_HOME_FOLDER_NAME,old_name,'')
           new_subpath=File.join('',ASPERA_HOME_FOLDER_NAME,new_name,'')
@@ -361,7 +386,7 @@ END_OF_TEMPLATE
             preset.values.select{|v|v.is_a?(String) and v.include?(old_subpath)}.each do |value|
               old_val=value.clone
               included_path=File.expand_path(old_val.gsub(/^@file:/,''))
-              files_to_copy.push(included_path) unless files_to_copy.include?(included_path) or !File.exist?(included_path)
+              files_to_copy.push(included_path) unless files_to_copy.include?(included_path) || !File.exist?(included_path)
               value.gsub!(old_subpath,new_subpath)
               Log.log.warn("Converted config value: #{old_val} -> #{value}")
             end
@@ -369,11 +394,11 @@ END_OF_TEMPLATE
         end
 
         def convert_preset_plugin_name(old_name,new_name)
-          if @config_presets[CONF_PRESET_DEFAULT].is_a?(Hash) and @config_presets[CONF_PRESET_DEFAULT].has_key?(old_name)
-            @config_presets[CONF_PRESET_DEFAULT][new_name]=@config_presets[CONF_PRESET_DEFAULT][old_name]
-            @config_presets[CONF_PRESET_DEFAULT].delete(old_name)
-            Log.log.warn("Converted plugin default: #{old_name} -> #{new_name}")
-          end
+          default_preset=@config_presets[CONF_PRESET_DEFAULT]
+          return unless default_preset.is_a?(Hash) && default_preset.has_key?(old_name)
+          default_preset[new_name]=default_preset[old_name]
+          default_preset.delete(old_name)
+          Log.log.warn("Converted plugin default: #{old_name} -> #{new_name}")
         end
 
         # read config file and validate format
@@ -390,11 +415,11 @@ END_OF_TEMPLATE
             # find first existing file (or nil)
             conf_file_to_load=search_files.select{|f| File.exist?(f)}.first
             # require save if old version of file
-            save_required=!@option_config_file.eql?(conf_file_to_load)
+            save_required= !@option_config_file.eql?(conf_file_to_load)
             # if no file found, create default config
             if conf_file_to_load.nil?
               Log.log.warn("No config file found. Creating empty configuration file: #{@option_config_file}")
-              @config_presets={CONF_PRESET_CONFIG=>{CONF_PRESET_VERSION=>@program_version}}
+              @config_presets={CONF_PRESET_CONFIG=>{CONF_PRESET_VERSION=>@info[:version]}}
             else
               Log.log.debug("loading #{@option_config_file}")
               @config_presets=YAML.load_file(conf_file_to_load)
@@ -431,14 +456,15 @@ END_OF_TEMPLATE
             config_tested_version='1.0'
             if Gem::Version.new(version) <= Gem::Version.new(config_tested_version)
               convert_preset_plugin_name(AOC_COMMAND_V2,AOC_COMMAND_V3)
-              convert_preset_path(PROGRAM_NAME_V2,@tool_name,files_to_copy)
+              convert_preset_path(PROGRAM_NAME_V2,@info[:name],files_to_copy)
               version=@config_presets[CONF_PRESET_CONFIG][CONF_PRESET_VERSION]=config_tested_version
               save_required=true
             end
+            Log.log.debug("conf version: #{version}")
             # Place new compatibility code here
             if save_required
               Log.log.warn('Saving automatic conversion.')
-              @config_presets[CONF_PRESET_CONFIG][CONF_PRESET_VERSION]=@program_version
+              @config_presets[CONF_PRESET_CONFIG][CONF_PRESET_VERSION]=@info[:version]
               save_presets_to_config_file
               Log.log.warn('Copying referenced files')
               files_to_copy.each do |file|
@@ -449,9 +475,9 @@ END_OF_TEMPLATE
           rescue Psych::SyntaxError => e
             Log.log.error('YAML error in config file')
             raise e
-          rescue => e
+          rescue StandardError => e
             Log.log.debug("-> #{e}")
-            new_name="#{@option_config_file}.pre#{@program_version}.manual_conversion_needed"
+            new_name="#{@option_config_file}.pre#{@info[:version]}.manual_conversion_needed"
             File.rename(@option_config_file,new_name)
             Log.log.warn("Renamed config file to #{new_name}.")
             Log.log.warn('Manual Conversion is required. Next time, a new empty file will be created.')
@@ -462,12 +488,11 @@ END_OF_TEMPLATE
         # find plugins in defined paths
         def add_plugins_from_lookup_folders
           @plugin_lookup_folders.each do |folder|
-            if File.directory?(folder)
-              #TODO: add gem root to load path ? and require short folder ?
-              #$LOAD_PATH.push(folder) if i[:add_path]
-              Dir.entries(folder).select{|file|file.end_with?(RUBY_FILE_EXT)}.each do |source|
-                add_plugin_info(File.join(folder,source))
-              end
+            next unless File.directory?(folder)
+            #TODO: add gem root to load path ? and require short folder ?
+            #$LOAD_PATH.push(folder) if i[:add_path]
+            Dir.entries(folder).select{|file|file.end_with?(RUBY_FILE_EXT)}.each do |source|
+              add_plugin_info(File.join(folder,source))
             end
           end
         end
@@ -489,36 +514,42 @@ END_OF_TEMPLATE
 
         def identify_plugin_for_url(url)
           plugins.each do |plugin_name_sym,plugin_info|
+            # no detection for internal plugin
             next if plugin_name_sym.eql?(CONF_PLUGIN_SYM)
+            # load plugin class
             require plugin_info[:require_stanza]
             c=self.class.plugin_class(plugin_name_sym)
-            if c.respond_to?(:detect)
-              current_url=url
-              begin
-                res=c.send(:detect,current_url)
-                return res.merge(product: plugin_name_sym, url: current_url) unless res.nil?
-              rescue
-              end
+            next unless c.respond_to?(:detect)
+            current_url=url
+            detection_info=nil
+            # first try : direct
+            begin
+              detection_info=c.detect(current_url)
+            rescue StandardError => e
+              Log.log.debug("Cannot detect #{plugin_name_sym} : #{e.message}")
+            end
+            # second try : is there a redirect ?
+            if detection_info.nil?
               begin
-                # is there a redirect ?
-                result=Rest.new({:base_url=>url}).call({operation: 'GET',subpath: '',redirect_max: 1})
-                current_url=result[:http].uri.to_s
-                # check if redirect
-                if ! url.eql?(current_url)
-                  res=c.send(:detect,current_url)
-                  return res.merge(product: plugin_name_sym, url: current_url) unless res.nil?
+                # TODO: check if redirect ?
+                new_url=Rest.new(base_url: url).call(operation: 'GET',subpath: '',redirect_max: 1)[:http].uri.to_s
+                unless url.eql?(new_url)
+                  detection_info=c.detect(new_url)
+                  current_url=new_url
                 end
-              rescue
+              rescue StandardError => e
+                Log.log.debug("Cannot detect #{plugin_name_sym} : #{e.message}")
               end
             end
-          end
+            return detection_info.merge(product: plugin_name_sym, url: current_url) unless detection_info.nil?
+          end # loop
           raise "No known application found at #{url}"
         end
 
         def execute_connect_action
-          command=self.options.get_next_command([:list,:info,:version])
+          command=options.get_next_command([:list,:info,:version])
           if [:info,:version].include?(command)
-            connect_id=self.options.get_next_argument('id or title')
+            connect_id=options.get_next_argument('id or title')
             one_res=connect_versions.select{|i|i['id'].eql?(connect_id) || i['title'].eql?(connect_id)}.first
             raise CliNoSuchId.new(:connect,connect_id) if one_res.nil?
           end
@@ -530,24 +561,24 @@ END_OF_TEMPLATE
             return {type: :single_object, data: one_res}
           when :version # shows files used
             all_links=one_res['links']
-            command=self.options.get_next_command([:list,:download,:open])
+            command=options.get_next_command([:list,:download,:open])
             if [:download,:open].include?(command)
-              link_title=self.options.get_next_argument('title or rel')
+              link_title=options.get_next_argument('title or rel')
               one_link=all_links.select {|i| i['title'].eql?(link_title) or i['rel'].eql?(link_title)}.first
-              raise "no such value" if one_link.nil?
+              raise 'no such value' if one_link.nil?
             end
             case command
             when :list # shows files used
               return {type: :object_list, data: all_links}
-            when :download #
-              folder_dest=self.transfer.destination_folder('receive')
+            when :download
+              folder_dest=transfer.destination_folder(Fasp::TransferSpec::DIRECTION_RECEIVE)
               #folder_dest=self.options.get_next_argument('destination folder')
               api_connect_cdn=Rest.new({base_url: CONNECT_WEB_URL})
               fileurl = one_link['href']
               filename=fileurl.gsub(%r{.*/},'')
               api_connect_cdn.call({operation: 'GET',subpath: fileurl,save_to_file: File.join(folder_dest,filename)})
               return Main.result_status("Downloaded: #{filename}")
-            when :open #
+            when :open
               OpenApplication.instance.uri(one_link['href'])
               return Main.result_status("Opened: #{one_link['href']}")
             end
@@ -555,12 +586,12 @@ END_OF_TEMPLATE
         end
 
         def execute_action_ascp
-          command=self.options.get_next_command([:connect,:use,:show,:products,:info,:install,:spec])
+          command=options.get_next_command([:connect,:use,:show,:products,:info,:install,:spec,:errors])
           case command
           when :connect
             return execute_connect_action
           when :use
-            ascp_path=self.options.get_next_argument('path to ascp')
+            ascp_path=options.get_next_argument('path to ascp')
             ascp_version=Fasp::Installation.instance.get_ascp_version(ascp_path)
             self.format.display_status("ascp version: #{ascp_version}")
             preset_name=set_global_default(:ascp_path,ascp_path)
@@ -568,46 +599,51 @@ END_OF_TEMPLATE
           when :show # shows files used
             return {type: :status, data: Fasp::Installation.instance.path(:ascp)}
           when :info # shows files used
-            data=Fasp::Installation::FILES.inject({}) do |m,v|
+            data=Fasp::Installation::FILES.each_with_object({}) do |v,m|
               m[v.to_s]=Fasp::Installation.instance.path(v) rescue 'Not Found'
-              m
             end
             # read PATHs from ascp directly, and pvcl modules as well
-            Open3.popen3(Fasp::Installation.instance.path(:ascp),'-DDL-') do |stdin, stdout, stderr, thread|
+            Open3.popen3(Fasp::Installation.instance.path(:ascp),'-DDL-') do |_stdin, _stdout, stderr, thread|
               last_line=''
-              while line=stderr.gets do
+              while (line=stderr.gets)
                 line.chomp!
                 last_line=line
                 case line
-                when %r{^DBG Path ([^ ]+) (dir|file) +: (.*)$};data[$1]=$3
-                when %r{^DBG Added module group:"([^"]+)" name:"([^"]+)", version:"([^"]+)" interface:"([^"]+)"$};data[$2]=$4
-                when %r{^DBG License result \(/license/(\S+)\): (.+)$};data[$1]=$2
-                when %r{^LOG (.+) version ([0-9.]+)$};data['product_name']=$1;data['product_version']=$2
-                when %r{^LOG Initializing FASP version ([^,]+),};data['ascp_version']=$1
+                when %r{^DBG Path ([^ ]+) (dir|file) +: (.*)$} then data[Regexp.last_match(1)]=Regexp.last_match(3)
+                when %r{^DBG Added module group:"([^"]+)" name:"([^"]+)", version:"([^"]+)" interface:"([^"]+)"$} then data[Regexp.last_match(2)]=Regexp.last_match(4)
+                when %r{^DBG License result \(/license/(\S+)\): (.+)$} then data[Regexp.last_match(1)]=Regexp.last_match(2)
+                when %r{^LOG (.+) version ([0-9.]+)$} then data['product_name']=Regexp.last_match(1);data['product_version']=Regexp.last_match(2)
+                when %r{^LOG Initializing FASP version ([^,]+),} then data['ascp_version']=Regexp.last_match(1)
                 end
               end
-              if !thread.value.exitstatus.eql?(1) and !data.has_key?('root')
+              if !thread.value.exitstatus.eql?(1) && !data.has_key?('root')
                 raise last_line
               end
             end
             data['keypass']=Fasp::Installation.instance.bypass_pass
             return {type: :single_object, data: data}
           when :products
-            command=self.options.get_next_command([:list,:use])
+            command=options.get_next_command([:list,:use])
             case command
             when :list
               return {type: :object_list, data: Fasp::Installation.instance.installed_products, fields: ['name','app_root']}
             when :use
-              default_product=self.options.get_next_argument('product name')
+              default_product=options.get_next_argument('product name')
               Fasp::Installation.instance.use_ascp_from_product(default_product)
               preset_name=set_global_default(:ascp_path,Fasp::Installation.instance.path(:ascp))
               return Main.result_status("Saved to default global preset #{preset_name}")
             end
           when :install
-            v=Fasp::Installation.instance.install_sdk(self.options.get_option(:sdk_url,:mandatory))
+            v=Fasp::Installation.instance.install_sdk(options.get_option(:sdk_url,:mandatory))
             return Main.result_status("Installed version #{v}")
           when :spec
-            return {type: :object_list, data: Fasp::Parameters.man_table, fields: ['name','type',Fasp::Parameters::SUPPORTED_AGENTS_SHORT.map{|i|i.to_s},'description'].flatten}
+            return {type: :object_list, data: Fasp::Parameters.man_table, fields: ['name','type',Fasp::Parameters::SUPPORTED_AGENTS_SHORT.map(&:to_s),'description'].flatten}
+          when :errors
+            error_data=[]
+            Fasp::ERROR_INFO.each_pair do |code,prop|
+              error_data.push(code: code, mnemonic: prop[:c], retry: prop[:r], info: prop[:a])
+            end
+            return {type: :object_list, data: error_data}
           end
           raise "unexpected case: #{command}"
         end
@@ -621,10 +657,10 @@ END_OF_TEMPLATE
         PRESET_ALL_ACTIONS=[PRESET_GBL_ACTIONS,PRESET_INSTANCE_ACTIONS].flatten.freeze
 
         def execute_file_action(action,config_name)
-          action=self.options.get_next_command(PRESET_ALL_ACTIONS) if action.nil?
-          config_name=instance_identifier() if config_name.nil? and PRESET_INSTANCE_ACTIONS.include?(action)
+          action=options.get_next_command(PRESET_ALL_ACTIONS) if action.nil?
+          config_name=instance_identifier() if config_name.nil? && PRESET_INSTANCE_ACTIONS.include?(action)
           # those operations require existing option
-          raise "no such preset: #{config_name}" if PRESET_EXST_ACTIONS.include?(action) and !@config_presets.has_key?(config_name)
+          raise "no such preset: #{config_name}" if PRESET_EXST_ACTIONS.include?(action) && !@config_presets.has_key?(config_name)
           selected_preset=@config_presets[config_name]
           case action
           when :list
@@ -639,21 +675,21 @@ END_OF_TEMPLATE
             save_presets_to_config_file
             return Main.result_status("Deleted: #{config_name}")
           when :get
-            param_name=self.options.get_next_argument('parameter name')
+            param_name=options.get_next_argument('parameter name')
             value=selected_preset[param_name]
             raise "no such option in preset #{config_name} : #{param_name}" if value.nil?
             case value
-            when Numeric,String; return {type: :text, data: ExtendedValue.instance.evaluate(value.to_s)}
+            when Numeric,String then return {type: :text, data: ExtendedValue.instance.evaluate(value.to_s)}
             end
             return {type: :single_object, data: value}
           when :unset
-            param_name=self.options.get_next_argument('parameter name')
+            param_name=options.get_next_argument('parameter name')
             selected_preset.delete(param_name)
             save_presets_to_config_file
             return Main.result_status("Removed: #{config_name}: #{param_name}")
           when :set
-            param_name=self.options.get_next_argument('parameter name')
-            param_value=self.options.get_next_argument('parameter value')
+            param_name=options.get_next_argument('parameter name')
+            param_value=options.get_next_argument('parameter value')
             if !@config_presets.has_key?(config_name)
               Log.log.debug("no such config name: #{config_name}, initializing")
               selected_preset=@config_presets[config_name]={}
@@ -665,7 +701,7 @@ END_OF_TEMPLATE
             save_presets_to_config_file
             return Main.result_status("Updated: #{config_name}: #{param_name} <- #{param_value}")
           when :initialize
-            config_value=self.options.get_next_argument('extended value (Hash)')
+            config_value=options.get_next_argument('extended value (Hash)')
             if @config_presets.has_key?(config_name)
               Log.log.warn("configuration already exists: #{config_name}, overwriting")
             end
@@ -674,7 +710,7 @@ END_OF_TEMPLATE
             return Main.result_status("Modified: #{@option_config_file}")
           when :update
             #  get unprocessed options
-            theopts=self.options.get_options_table
+            theopts=options.get_options_table
             Log.log.debug("opts=#{theopts}")
             @config_presets[config_name]||={}
             @config_presets[config_name].merge!(theopts)
@@ -683,10 +719,10 @@ END_OF_TEMPLATE
             save_presets_to_config_file
             return Main.result_status("Updated: #{config_name}")
           when :ask
-            self.options.ask_missing_mandatory=:yes
+            options.ask_missing_mandatory=:yes
             @config_presets[config_name]||={}
-            self.options.get_next_argument('option names',:multiple).each do |optionname|
-              option_value=self.options.get_interactive(:option,optionname)
+            options.get_next_argument('option names',:multiple).each do |optionname|
+              option_value=options.get_interactive(:option,optionname)
               @config_presets[config_name][optionname]=option_value
             end
             save_presets_to_config_file
@@ -694,95 +730,98 @@ END_OF_TEMPLATE
           end
         end
 
-        ACTIONS=[PRESET_GBL_ACTIONS,:id,:preset,:open,:documentation,:genkey,:gem_path,:plugin,:flush_tokens,:echo,:wizard,:export_to_cli,:detect,:coffee,:ascp,:email_test,:smtp_settings,:proxy_check,:folder,:file,:check_update,:initdemo,:vault].flatten.freeze
+        ACTIONS=[PRESET_GBL_ACTIONS,:id,:preset,:open,:documentation,:genkey,:gem,:plugin,:flush_tokens,:echo,:wizard,:export_to_cli,:detect,:coffee,:ascp,:email_test,
+                 :smtp_settings,:proxy_check,:folder,:file,:check_update,:initdemo,:vault].flatten.freeze
 
         # "config" plugin
         def execute_action
-          action=self.options.get_next_command(ACTIONS)
+          action=options.get_next_command(ACTIONS)
           case action
           when *PRESET_GBL_ACTIONS # older syntax
             return execute_file_action(action,nil)
           when :id # older syntax
-            return execute_file_action(nil,self.options.get_next_argument('config name'))
+            return execute_file_action(nil,options.get_next_argument('config name'))
           when :preset # newer syntax
             return execute_file_action(nil,nil)
           when :open
-            OpenApplication.instance.uri("#{@option_config_file}") #file://
+            OpenApplication.instance.uri(@option_config_file.to_s) #file://
             return Main.result_nothing
           when :documentation
             section=options.get_next_argument('private key file path',:single,:optional)
             section='#'+section unless section.nil?
-            OpenApplication.instance.uri("#{@help_url}#{section}")
+            OpenApplication.instance.uri("#{@info[:help]}#{section}")
             return Main.result_nothing
           when :genkey # generate new rsa key
-            private_key_path=self.options.get_next_argument('private key file path')
+            private_key_path=options.get_next_argument('private key file path')
             generate_rsa_private_key(private_key_path,DEFAULT_PRIVKEY_LENGTH)
             return Main.result_status('Generated key: '+private_key_path)
           when :echo # display the content of a value given on command line
-            result={type: :other_struct, data: self.options.get_next_argument('value')}
+            result={type: :other_struct, data: options.get_next_argument('value')}
             # special for csv
-            result[:type]=:object_list if result[:data].is_a?(Array) and result[:data].first.is_a?(Hash)
+            result[:type]=:object_list if result[:data].is_a?(Array) && result[:data].first.is_a?(Hash)
             return result
           when :flush_tokens
             deleted_files=Oauth.flush_tokens
             return {type: :value_list, data: deleted_files, name: 'file'}
           when :plugin
-            case self.options.get_next_command([:list,:create])
+            case options.get_next_command([:list,:create])
             when :list
-              return {type: :object_list, data: @plugins.keys.map { |i| { 'plugin' => i.to_s, 'path' => @plugins[i][:source] } } , fields: ['plugin','path']}
+              return {type: :object_list, data: @plugins.keys.map { |i| { 'plugin' => i.to_s, 'path' => @plugins[i][:source] } }, fields: ['plugin','path']}
             when :create
               plugin_name=options.get_next_argument('name',:single,:mandatory).downcase
               plugin_folder=options.get_next_argument('folder',:single,:optional) || File.join(@main_folder,ASPERA_PLUGINS_FOLDERNAME)
               plugin_file=File.join(plugin_folder,"#{plugin_name}.rb")
-              content=<<_EOF_
-require 'aspera/cli/plugin'
-module Aspera
-  module Cli
-    module Plugins
-      class #{plugin_name.capitalize} < Plugin
-        ACTIONS=[]
-        def execute_action; return Main.result_status("You called plugin #{plugin_name}"); end
-      end # #{plugin_name.capitalize}
-    end # Plugins
-  end # Cli
-end # Aspera
-_EOF_
+              content=<<~END_OF_PLUGIN_CODE
+                require 'aspera/cli/plugin'
+                module Aspera
+                  module Cli
+                    module Plugins
+                      class #{plugin_name.capitalize} < Plugin
+                        ACTIONS=[]
+                        def execute_action; return Main.result_status('You called plugin #{plugin_name}'); end
+                      end # #{plugin_name.capitalize}
+                    end # Plugins
+                  end # Cli
+                end # Aspera
+              END_OF_PLUGIN_CODE
               File.write(plugin_file,content)
               return Main.result_status("Created #{plugin_file}")
             end
           when :wizard
             # interactive mode
-            self.options.ask_missing_mandatory=true
+            options.ask_missing_mandatory=true
             # register url option
             BasicAuthPlugin.new(@agents.merge(skip_option_header: true))
             # get from option, or ask
-            instance_url=self.options.get_option(:url,:mandatory)
+            instance_url=options.get_option(:url,:mandatory)
             # allow user to tell the preset name
-            preset_name=self.options.get_option(:id,:optional)
-            appli=identify_plugin_for_url(instance_url)
-            plugin_name="<replace per app>"
-            test_args="<replace per app>"
-            case appli[:product]
+            preset_name=options.get_option(:id,:optional)
+            # allow user to specify type of application
+            application=options.get_option(:value,:optional)
+            application=application.nil? ? identify_plugin_for_url(instance_url)[:product] : application.to_sym
+            plugin_name='<replace per app>'
+            test_args='<replace per app>'
+            case application
             when :aoc
               self.format.display_status('Detected: Aspera on Cloud'.bold)
               plugin_name=AOC_COMMAND_CURRENT
-              organization,instance_domain=AoC.parse_url(instance_url)
+              organization=AoC.parse_url(instance_url).first
               # if not defined by user, generate name
-              preset_name=[appli[:product],organization].join('_') if preset_name.nil?
+              preset_name=[application,organization].join('_') if preset_name.nil?
               self.format.display_status("Preparing preset: #{preset_name}")
               # init defaults if necessary
               @config_presets[CONF_PRESET_DEFAULT]||={}
-              option_override=self.options.get_option(:override,:mandatory)
-              option_default=self.options.get_option(:default,:mandatory)
+              option_override=options.get_option(:override,:mandatory)
+              option_default=options.get_option(:default,:mandatory)
               Log.log.error("override=#{option_override} -> #{option_override.class}")
-              raise CliError,"A default configuration already exists for plugin '#{plugin_name}' (use --override=yes or --default=no)" if !option_override and option_default and @config_presets[CONF_PRESET_DEFAULT].has_key?(plugin_name)
-              raise CliError,"Preset already exists: #{preset_name}  (use --override=yes or --id=<name>)" if !option_override and @config_presets.has_key?(preset_name)
+              raise CliError,"A default configuration already exists for plugin '#{plugin_name}' (use --override=yes or --default=no)" if !option_override && option_default && @config_presets[CONF_PRESET_DEFAULT].has_key?(plugin_name)
+              raise CliError,"Preset already exists: #{preset_name}  (use --override=yes or --id=<name>)" if !option_override && @config_presets.has_key?(preset_name)
               # lets see if path to priv key is provided
-              private_key_path=self.options.get_option(:pkeypath,:optional)
+              private_key_path=options.get_option(:pkeypath,:optional)
               # give a chance to provide
               if private_key_path.nil?
                 self.format.display_status('Please provide path to your private RSA key, or empty to generate one:')
-                private_key_path=self.options.get_option(:pkeypath,:mandatory).to_s
+                private_key_path=options.get_option(:pkeypath,:mandatory).to_s
               end
               # else generate path
               if private_key_path.empty?
@@ -800,74 +839,73 @@ _EOF_
               # declare command line options for AoC
               require 'aspera/cli/plugins/aoc'
               # make username mandatory for jwt, this triggers interactive input
-              self.options.get_option(:username,:mandatory)
+              options.get_option(:username,:mandatory)
               # instanciate AoC plugin, so that command line options are known
-              files_plugin=self.class.plugin_class(plugin_name).new(@agents.merge({skip_basic_auth_options: true, private_key_path: private_key_path}))
-              aoc_api=files_plugin.get_api
+              aoc_api=self.class.plugin_class(plugin_name).new(@agents.merge({skip_basic_auth_options: true, private_key_path: private_key_path})).aoc_api
               auto_set_pub_key=false
               auto_set_jwt=false
               use_browser_authentication=false
-              if self.options.get_option(:use_generic_client)
+              if options.get_option(:use_generic_client)
                 self.format.display_status('Using global client_id.')
                 self.format.display_status('Please Login to your Aspera on Cloud instance.'.red)
                 self.format.display_status('Navigate to your "Account Settings"'.red)
                 self.format.display_status('Check or update the value of "Public Key" to be:'.red.blink)
-                self.format.display_status("#{pub_key_pem}")
-                if ! self.options.get_option(:test_mode)
+                self.format.display_status(pub_key_pem.to_s)
+                if !options.get_option(:test_mode)
                   self.format.display_status('Once updated or validated, press enter.')
                   OpenApplication.instance.uri(instance_url)
-                  STDIN.gets
+                  $stdin.gets
                 end
               else
                 self.format.display_status('Using organization specific client_id.')
-                if self.options.get_option(:client_id,:optional).nil? or self.options.get_option(:client_secret,:optional).nil?
+                if options.get_option(:client_id,:optional).nil? || options.get_option(:client_secret,:optional).nil?
                   self.format.display_status('Please login to your Aspera on Cloud instance.'.red)
                   self.format.display_status('Go to: Apps->Admin->Organization->Integrations')
                   self.format.display_status('Create or check if there is an existing integration named:')
-                  self.format.display_status("- name: #{@tool_name}")
+                  self.format.display_status("- name: #{@info[:name]}")
                   self.format.display_status("- redirect uri: #{DEFAULT_REDIRECT}")
                   self.format.display_status('- origin: localhost')
                   self.format.display_status('Once created or identified,')
                   self.format.display_status('Please enter:'.red)
                 end
                 OpenApplication.instance.uri("#{instance_url}/#{AOC_PATH_API_CLIENTS}")
-                self.options.get_option(:client_id,:mandatory)
-                self.options.get_option(:client_secret,:mandatory)
+                options.get_option(:client_id,:mandatory)
+                options.get_option(:client_secret,:mandatory)
                 use_browser_authentication=true
               end
               if use_browser_authentication
                 self.format.display_status('We will use web authentication to bootstrap.')
                 auto_set_pub_key=true
                 auto_set_jwt=true
-                @api_aoc.oauth.params[:auth]=:web
-                @api_aoc.oauth.params[:redirect_uri]=DEFAULT_REDIRECT
-                @api_aoc.oauth.params[:scope]=AoC::SCOPE_FILES_ADMIN
+                aoc_api.oauth.params[:crtype]=:web
+                aoc_api.oauth.params[:web][:redirect_uri]=DEFAULT_REDIRECT
+                aoc_api.oauth.params[:scope]=AoC::SCOPE_FILES_ADMIN
               end
               myself=aoc_api.read('self')[:data]
               if auto_set_pub_key
-                raise CliError,'Public key is already set in profile (use --override=yes)'  unless myself['public_key'].empty? or option_override
+                raise CliError,'Public key is already set in profile (use --override=yes)' unless myself['public_key'].empty? || option_override
                 self.format.display_status('Updating profile with new key')
                 aoc_api.update("users/#{myself['id']}",{'public_key'=>pub_key_pem})
               end
               if auto_set_jwt
                 self.format.display_status('Enabling JWT for client')
-                aoc_api.update("clients/#{self.options.get_option(:client_id)}",{'jwt_grant_enabled'=>true,'explicit_authorization_required'=>false})
+                aoc_api.update("clients/#{options.get_option(:client_id)}",{'jwt_grant_enabled'=>true,'explicit_authorization_required'=>false})
               end
               self.format.display_status("Creating new config preset: #{preset_name}")
               @config_presets[preset_name]={
-                :url.to_s           =>self.options.get_option(:url),
+                :url.to_s           =>options.get_option(:url),
                 :username.to_s      =>myself['email'],
                 :auth.to_s          =>:jwt.to_s,
-                :private_key.to_s   =>'@file:'+private_key_path,
+                :private_key.to_s   =>'@file:'+private_key_path
               }
               # set only if non nil
               [:client_id,:client_secret].each do |s|
-                o=self.options.get_option(s)
+                o=options.get_option(s)
                 @config_presets[preset_name][s.to_s] = o unless o.nil?
               end
               test_args="#{plugin_name} user profile show"
             else
-              raise CliBadArgument,"Supports only: aoc. Detected: #{appli}"
+              raise CliBadArgument,"Supports only: aoc. Detected: #{application}"
             end # product
             if option_default
               self.format.display_status("Setting config preset as default for #{plugin_name}")
@@ -877,29 +915,29 @@ _EOF_
             end
             self.format.display_status('Saving config file.')
             save_presets_to_config_file
-            return Main.result_status("Done.\nYou can test with:\n#{@tool_name} #{test_args}")
+            return Main.result_status("Done.\nYou can test with:\n#{@info[:name]} #{test_args}")
           when :export_to_cli
             self.format.display_status('Exporting: Aspera on Cloud')
             require 'aspera/cli/plugins/aoc'
             # need url / username
             add_plugin_default_preset(AOC_COMMAND_V3.to_sym)
             # instanciate AoC plugin
-            files_plugin=self.class.plugin_class(AOC_COMMAND_CURRENT).new(@agents) # TODO: is this line needed ?
-            url=self.options.get_option(:url,:mandatory)
+            self.class.plugin_class(AOC_COMMAND_CURRENT).new(@agents) # TODO: is this line needed ? get options ?
+            url=options.get_option(:url,:mandatory)
             cli_conf_file=Fasp::Installation.instance.cli_conf_file
             data=JSON.parse(File.read(cli_conf_file))
             organization,instance_domain=AoC.parse_url(url)
             key_basename='org_'+organization+'.pem'
             key_file=File.join(File.dirname(File.dirname(cli_conf_file)),'etc',key_basename)
-            File.write(key_file,self.options.get_option(:private_key,:mandatory))
+            File.write(key_file,options.get_option(:private_key,:mandatory))
             new_conf={
               'organization'       => organization,
               'hostname'           => [organization,instance_domain].join('.'),
               'privateKeyFilename' => key_basename,
-              'username'           => self.options.get_option(:username,:mandatory)
+              'username'           => options.get_option(:username,:mandatory)
             }
-            new_conf['clientId']=self.options.get_option(:client_id,:optional)
-            new_conf['clientSecret']=self.options.get_option(:client_secret,:optional)
+            new_conf['clientId']=options.get_option(:client_id,:optional)
+            new_conf['clientSecret']=options.get_option(:client_secret,:optional)
             if new_conf['clientId'].nil?
               new_conf['clientId'],new_conf['clientSecret']=AoC.get_client_info()
             end
@@ -916,14 +954,18 @@ _EOF_
           when :detect
             # need url / username
             BasicAuthPlugin.new(@agents)
-            return Main.result_status("Found: #{identify_plugin_for_url(self.options.get_option(:url,:mandatory))}")
+            return {type: :single_object, data: identify_plugin_for_url(options.get_option(:url,:mandatory))}
           when :coffee
             OpenApplication.instance.uri('https://enjoyjava.com/wp-content/uploads/2018/01/How-to-make-strong-coffee.jpg')
             return Main.result_nothing
           when :ascp
             execute_action_ascp
-          when :gem_path
-            return Main.result_status(self.class.gem_root)
+          when :gem
+            case options.get_next_command([:path,:version,:name])
+            when :path then return Main.result_status(self.class.gem_src_root)
+            when :version then return Main.result_status(Aspera::Cli::VERSION)
+            when :name then return Main.result_status(@info[:gem])
+            end
           when :folder
             return Main.result_status(@main_folder)
           when :file
@@ -934,9 +976,10 @@ _EOF_
           when :smtp_settings
             return {type: :single_object, data: email_settings}
           when :proxy_check
-            pac_url=self.options.get_option(:fpac,:mandatory)
-            server_url=self.options.get_next_argument('server url')
-            return Main.result_status(Aspera::ProxyAutoConfig.new(UriReader.read(pac_url)).get_proxy(server_url))
+            # ensure fpac was provided
+            options.get_option(:fpac,:mandatory)
+            server_url=options.get_next_argument('server url')
+            return Main.result_status(@pac_exec.find_proxy_for_url(server_url))
           when :check_update
             return {type: :single_object, data: check_gem_version}
           when :initdemo
@@ -944,7 +987,8 @@ _EOF_
               Log.log.warn("Demo server preset already present: #{DEMO_SERVER_PRESET}")
             else
               Log.log.info("Creating Demo server preset: #{DEMO_SERVER_PRESET}")
-              @config_presets[DEMO_SERVER_PRESET]={'url'=>'ssh://'+DEMO+'.asperasoft.com:33001','username'=>AOC_COMMAND_V2,'ssAP'.downcase.reverse+'drow'.reverse=>DEMO+AOC_COMMAND_V2}
+              @config_presets[DEMO_SERVER_PRESET]=
+{'url'=>'ssh://'+DEMO+'.asperasoft.com:33001','username'=>AOC_COMMAND_V2,'ssAP'.downcase.reverse+'drow'.reverse=>DEMO+AOC_COMMAND_V2}
             end
             @config_presets[CONF_PRESET_DEFAULT]||={}
             if @config_presets[CONF_PRESET_DEFAULT].has_key?(SERVER_COMMAND)
@@ -957,13 +1001,13 @@ _EOF_
             save_presets_to_config_file
             return Main.result_status('Done')
           when :vault
-            command=self.options.get_next_command([:init,:list,:get,:set,:delete])
+            command=options.get_next_command([:init,:list,:get,:set,:delete])
             case command
             when :init
-              type=self.options.get_option(:value,:optional)
+              type=options.get_option(:value,:optional)
               case type
               when 'config',NilClass
-                raise "default secrets already exists" if @config_presets.has_key?(CONF_PRESET_SECRETS)
+                raise 'default secrets already exists' if @config_presets.has_key?(CONF_PRESET_SECRETS)
                 @config_presets[CONF_PRESET_SECRETS]={}
                 set_global_default(:secrets,"@preset:#{CONF_PRESET_SECRETS}")
               else raise 'no such vault type'
@@ -974,26 +1018,26 @@ _EOF_
             when :set
               # register url option
               BasicAuthPlugin.new(@agents.merge(skip_option_header: true))
-              username=self.options.get_option(:username,:mandatory)
-              url=self.options.get_option(:url,:mandatory)
-              description=self.options.get_option(:value,:optional)
-              secret=self.options.get_next_argument('secret')
+              username=options.get_option(:username,:mandatory)
+              url=options.get_option(:url,:mandatory)
+              description=options.get_option(:value,:optional)
+              secret=options.get_next_argument('secret')
               vault.set(username: username, url: url, description: description, secret: secret)
               save_presets_to_config_file if vault.is_a?(Keychain::EncryptedHash)
               return Main.result_status('Done')
             when :get
               # register url option
               BasicAuthPlugin.new(@agents.merge(skip_option_header: true))
-              username=self.options.get_option(:username,:mandatory)
-              url=self.options.get_option(:url,:optional)
+              username=options.get_option(:username,:mandatory)
+              url=options.get_option(:url,:optional)
               result=vault.get(username: username, url: url)
               return {type: :single_object, data: result}
             when :delete
               # register url option
               BasicAuthPlugin.new(@agents.merge(skip_option_header: true))
-              username=self.options.get_option(:username,:mandatory)
-              url=self.options.get_option(:url,:optional)
-              result=vault.delete(username: username, url: url)
+              username=options.get_option(:username,:mandatory)
+              url=options.get_option(:url,:optional)
+              vault.delete(username: username, url: url)
               return Main.result_status('Done')
             end
           else raise 'INTERNAL ERROR: wrong case'
@@ -1002,9 +1046,9 @@ _EOF_
 
         # @return email server setting with defaults if not defined
         def email_settings
-          smtp=self.options.get_option(:smtp,:mandatory)
+          smtp=options.get_option(:smtp,:mandatory)
           # change string keys into symbol keys
-          smtp=smtp.keys.inject({}){|m,v|m[v.to_sym]=smtp[v];m}
+          smtp=smtp.keys.each_with_object({}){|v,m|m[v.to_sym]=smtp[v];}
           # defaults
           smtp[:tls]||=true
           smtp[:port]||=smtp[:tls]?587:25
@@ -1034,7 +1078,7 @@ _EOF_
             raise "Missing email parameter: #{n}" unless vars.has_key?(n)
           end
           start_options=[mail_conf[:domain]]
-          start_options.push(mail_conf[:username],mail_conf[:password],:login) if mail_conf.has_key?(:username) and mail_conf.has_key?(:password)
+          start_options.push(mail_conf[:username],mail_conf[:password],:login) if mail_conf.has_key?(:username) && mail_conf.has_key?(:password)
           # create a binding with only variables defined in vars
           template_binding=empty_binding
           # add variables to binding
@@ -1047,8 +1091,8 @@ _EOF_
           Log.dump(:msg_with_headers,msg_with_headers)
           smtp = Net::SMTP.new(mail_conf[:server], mail_conf[:port])
           smtp.enable_starttls if mail_conf[:tls]
-          smtp.start(*start_options) do |smtp|
-            smtp.send_message(msg_with_headers, vars[:from_email], vars[:to])
+          smtp.start(*start_options) do |smtp_session|
+            smtp_session.send_message(msg_with_headers, vars[:from_email], vars[:to])
           end
         end
 
@@ -1062,16 +1106,16 @@ _EOF_
         # returns [String] name if config_presets has default
         # returns nil if there is no config or bypass default params
         def get_plugin_default_config_name(plugin_sym)
-          raise "internal error: config_presets shall be defined" if @config_presets.nil?
+          raise 'internal error: config_presets shall be defined' if @config_presets.nil?
           if !@use_plugin_defaults
             Log.log.debug('skip default config')
             return nil
           end
-          if @config_presets.has_key?(CONF_PRESET_DEFAULT) and
+          if @config_presets.has_key?(CONF_PRESET_DEFAULT) &&
           @config_presets[CONF_PRESET_DEFAULT].has_key?(plugin_sym.to_s)
             default_config_name=@config_presets[CONF_PRESET_DEFAULT][plugin_sym.to_s]
             if !@config_presets.has_key?(default_config_name)
-              Log.log.error("Default config name [#{default_config_name}] specified for plugin [#{plugin_sym.to_s}], but it does not exist in config file.\nPlease fix the issue: either create preset with one parameter (#{@tool_name} config id #{default_config_name} init @json:'{}') or remove default (#{@tool_name} config id default remove #{plugin_sym.to_s}).")
+              Log.log.error("Default config name [#{default_config_name}] specified for plugin [#{plugin_sym}], but it does not exist in config file.\nPlease fix the issue: either create preset with one parameter (#{@info[:name]} config id #{default_config_name} init @json:'{}') or remove default (#{@info[:name]} config id default remove #{plugin_sym}).")
             end
             raise CliError,"Config name [#{default_config_name}] must be a hash, check config file." if !@config_presets[default_config_name].is_a?(Hash)
             return default_config_name
@@ -1081,7 +1125,7 @@ _EOF_
 
         def vault
           if @vault.nil?
-            vault_info=self.options.get_option(:secrets,:optional)
+            vault_info=options.get_option(:secrets,:optional)
             case vault_info
             when Hash
               @vault=Keychain::EncryptedHash.new(vault_info)
@@ -1091,8 +1135,8 @@ _EOF_
               when Environment::OS_X
                 @vault=Keychain::MacosSecurity.new(name)
               when Environment::OS_WINDOWS,Environment::OS_LINUX,Environment::OS_AIX
-                raise "not implemented"
-              else raise "Error"
+                raise 'not implemented'
+              else raise 'Error'
               end
             when NilClass
               # keep nil
@@ -1100,18 +1144,18 @@ _EOF_
               raise CliBadArgument,'secrets shall be Hash'
             end
           end
-          raise "No vault defined" if @vault.nil?
+          raise 'No vault defined' if @vault.nil?
           @vault
         end
 
         def get_secret(options)
-          raise "options shall be Hash" unless options.is_a?(Hash)
-          raise "options shall have username" unless options.has_key?(:username)
+          raise 'options shall be Hash' unless options.is_a?(Hash)
+          raise 'options shall have username' unless options.has_key?(:username)
           secret=self.options.get_option(:secret,:optional)
           if secret.nil?
             secret=vault.get(options) rescue nil
             # mandatory by default
-            raise "please provide secret for #{options[:username]}" if secret.nil? and ( options[:mandatory].nil? or options[:mandatory] )
+            raise "please provide secret for #{options[:username]}" if secret.nil? && (options[:mandatory].nil? || options[:mandatory])
           end
           return secret
         end