aspera-cli 4.26.1 → 4.26.2

data/lib/aspera/cli/{main.rb → runner.rb}

@@ -1,14 +1,16 @@
 # frozen_string_literal: true
 
+require 'aspera/cli/context'
 require 'aspera/cli/manager'
 require 'aspera/cli/formatter'
+require 'aspera/cli/plugins/factory'
 require 'aspera/cli/plugins/config'
 require 'aspera/cli/extended_value'
-require 'aspera/cli/plugins/factory'
 require 'aspera/cli/transfer_agent'
 require 'aspera/cli/version'
 require 'aspera/cli/info'
 require 'aspera/cli/hints'
+require 'aspera/cli/result'
 require 'aspera/secret_hider'
 require 'aspera/log'
 require 'aspera/assert'
@@ -19,55 +21,8 @@ require 'openssl'
 
 module Aspera
   module Cli
-    # Global objects shared with plugins
-    class Context
-      # @type [Array<Symbol>]
-      MEMBERS = %i[options transfer config formatter persistency man_header].freeze
-      # @!attribute [rw] options
-      #   @return [Manager] the command line options manager
-      # @!attribute [rw] transfer
-      #   @return [TransferAgent] the transfer agent, used by transfer plugins
-      # @!attribute [rw] config
-      #   @return [Plugins::Config] the configuration plugin, used by plugins to get configuration values and presets
-      # @!attribute [rw] formatter
-      #   @return [Formatter] the formatter, used by plugins to display results and messages
-      # @!attribute [rw] persistency
-      #   @return [Object] # whatever the type is
-      # @!attribute [rw] man_header
-      #   @return [Boolean] whether to display the manual header in plugin help
-      attr_accessor(*MEMBERS)
-
-      # Initialize all members to nil, so that they are defined and can be validated later
-      # @return [nil]
-      def initialize
-        MEMBERS.each{ |i| instance_variable_set(:"@#{i}", nil)}
-      end
-
-      # Validate that all members are set, raise exception if not
-      # @raise [Aspera::AssertionError] if any member is not set
-      # @return [nil]
-      def validate
-        MEMBERS.each do |i|
-          Aspera.assert(instance_variable_defined?(:"@#{i}"))
-          Aspera.assert(!instance_variable_get(:"@#{i}").nil?)
-        end
-      end
-
-      # Check if the context is in manual-only mode
-      # @return [Boolean] true if in manual-only mode
-      def only_manual?
-        transfer.eql?(:only_manual)
-      end
-
-      # Set the context to manual-only mode
-      # @return [Symbol] :only_manual
-      def only_manual!
-        @transfer = :only_manual
-      end
-    end
-
     # The main CLI class
-    class Main
+    class Runner
       # Plugins store transfer result using this key and use result_transfer_multiple()
       STATUS_FIELD = 'status'
       COMMAND_CONFIG = :config
@@ -79,46 +34,19 @@ module Aspera
       private_constant :COMMAND_CONFIG, :COMMAND_HELP, :SCALAR_TYPES, :USER_INTERFACES
 
       class << self
-        # Create a special result type (only used internally here)
-        # @param special_sym [Symbol] the special result type
-        # @return [Hash] result hash with type :special
-        def result_special(special_sym); {type: :special, data: special_sym}; end
-
-        # Expect some list, but nothing to display
-        # @return [Hash] result hash for empty list
-        def result_empty; result_special(:empty); end
-
-        # Nothing expected
-        # @return [Hash] result hash for nothing
-        def result_nothing; result_special(:nothing); end
-
-        # Result is some status, such as "complete", "deleted"...
-        # @param status [String] The status
-        # @return [Hash] result hash with type :status
-        def result_status(status); return {type: :status, data: status}; end
-
-        # Text result coming from command result
-        # @param data [String, Integer, Symbol] the text data to display
-        # @return [Hash] result hash with type :text
-        def result_text(data); return {type: :text, data: data}; end
-
-        # Create a success result
-        # @return [Hash] result hash with status 'complete'
-        def result_success; return result_status('complete'); end
-
         # Process statuses of finished transfer sessions
         # @param statuses [Array] array of transfer session statuses
         # @raise [Symbol] exception if there is one error
-        # @return [Hash] empty status result if all transfers succeeded
+        # @return [Result] empty status result if all transfers succeeded
         def result_transfer(statuses)
           worst = TransferAgent.session_status(statuses)
           raise worst unless worst.eql?(:success)
-          return Main.result_nothing
+          return Result::Nothing.new
         end
 
         # Used when one command executes several transfer jobs (each job being possibly multi session)
         # @param status_table [Array] [{STATUS_FIELD=>[status array],...},...]
-        # @return a status object suitable as command result
+        # @return [Result] a status object suitable as command result
         # Each element has a key STATUS_FIELD which contains the result of possibly multiple sessions
         def result_transfer_multiple(status_table)
           global_status = :success
@@ -129,62 +57,7 @@ module Aspera
             item[STATUS_FIELD] = item[STATUS_FIELD].join(',')
           end
           raise global_status unless global_status.eql?(:success)
-          return result_object_list(status_table)
-        end
-
-        # Display image for that URL or directly blob
-        # @param url_or_blob [String] URL or blob to display as image
-        # @return [Hash] result hash with type :image
-        def result_image(url_or_blob)
-          return {type: :image, data: url_or_blob}
-        end
-
-        # A single object, must be Hash
-        # @param data [Hash] the object data
-        # @param fields [Array<String>, nil] optional list of fields to display
-        # @return [Hash] result hash with type :single_object
-        def result_single_object(data, fields: nil)
-          return {type: :single_object, data: data, fields: fields}
-        end
-
-        # An Array of Hash
-        # @param data [Array<Hash>] array of objects
-        # @param fields [Array<String>, nil] optional list of fields to display
-        # @param total [Integer, nil] optional total count
-        # @return [Hash] result hash with type :object_list
-        def result_object_list(data, fields: nil, total: nil)
-          return {type: :object_list, data: data, fields: fields, total: total}
-        end
-
-        # A list of values
-        # @param data [Array] The list of values
-        # @param name [String] The name of the list (used for display)
-        # @return [Hash] result hash with type :value_list
-        def result_value_list(data, name: 'id')
-          Aspera.assert_type(data, Array)
-          Aspera.assert_type(name, String)
-          return {type: :value_list, data: data, name: name}
-        end
-
-        # Determines type of result based on data
-        # @param data [Object] the data to analyze and format
-        # @return [Hash] result hash with appropriate type based on data
-        def result_auto(data)
-          case data
-          when NilClass
-            return result_special(:null)
-          when Hash
-            return result_single_object(data)
-          when Array
-            all_types = data.map(&:class).uniq
-            return result_object_list(data) if all_types.eql?([Hash])
-            unsupported_types = all_types - SCALAR_TYPES
-            return result_value_list(data, name: 'list') if unsupported_types.empty?
-            Aspera.error_unexpected_value(unsupported_types){'list item types'}
-          when *SCALAR_TYPES
-            return result_text(data)
-          else Aspera.error_unexpected_value(data.class.name){'result type'}
-          end
+          return Result::ObjectList.new(status_table)
         end
       end
 
@@ -196,14 +69,13 @@ module Aspera
         Log.dump(:argv, @argv, level: :trace2)
         @option_help = false
         @option_show_config = false
-        @bash_completion = false
         @context = Context.new
       end
 
       # This is the main function called by initial script just after constructor
       # Processes command line arguments, executes commands, and handles exceptions
       # @return [nil]
-      def process_command_line
+      def run
         # Catch exception information , if any
         exception_info = nil
         # False if command shall not be executed (e.g. --show-config)
@@ -215,7 +87,6 @@ module Aspera
           Plugins::Factory.instance.add_plugins_from_lookup_folders
           # Help requested without command ? (plugins must be known here)
           show_usage if @option_help && @context.options.command_or_arg_empty?
-          generate_bash_completion if @bash_completion
           @context.config.periodic_check_newer_gem_version
           command_sym =
             if @option_show_config && @context.options.command_or_arg_empty?
@@ -240,7 +111,7 @@ module Aspera
           # Help requested for current plugin
           show_usage(all: false) if @option_help
           if @option_show_config
-            @context.formatter.display_results(type: :single_object, data: @context.options.known_options(only_defined: true).stringify_keys)
+            @context.formatter.display_results(Result::SingleObject.new(@context.options.known_options(only_defined: true).stringify_keys))
             execute_command = false
           end
           # Locking for single execution (only after "per plugin" option, in case lock port is there)
@@ -263,7 +134,7 @@ module Aspera
             at_exit{File.delete(pid_file)}
           end
           # Execute and display (if not exclusive execution)
-          @context.formatter.display_results(**command_plugin.execute_action) if execute_command
+          @context.formatter.display_results(command_plugin.execute_action) if execute_command
           # Save config file if command modified it
           @context.config.save_config_file_if_needed
           # Finish
@@ -271,7 +142,7 @@ module Aspera
         rescue Net::SSH::AuthenticationFailed => e; exception_info = {e: e, t: 'SSH', security: true}
         rescue OpenSSL::SSL::SSLError => e;         exception_info = {e: e, t: 'SSL'}
         rescue Cli::BadArgument => e;               exception_info = {e: e, t: 'Argument', usage: true}
-        rescue Cli::MissingArgument => e;           exception_info = {e: e, t: 'Missing', usage: true}
+        rescue Cli::MissingArgument => e;           exception_info = {e: e, t: 'Missing'}
         rescue Cli::BadIdentifier => e;             exception_info = {e: e, t: 'Identifier'}
         rescue Cli::SchemaRequest => e;             exception_info = {e: e, t: 'Schema'}
         rescue Cli::Error => e;                     exception_info = {e: e, t: 'Tool', usage: true}
@@ -299,7 +170,7 @@ module Aspera
               Log.log.warn{'Sorry, no schema provided yet. Please refer to the manual or API.'}
             else
               builder = Schema::Documentation.new(TerminalFormatter, Schema::Registry.instance.reader(schema_path)).build
-              @context.formatter.display_results(**Main.result_object_list(builder.rows, fields: builder.columns))
+              @context.formatter.display_results(Result::ObjectList.new(builder.rows, fields: builder.columns))
             end
           end
         end
@@ -371,7 +242,7 @@ module Aspera
         @context.config = Plugins::Config.new(context: @context)
         @context.man_header = true
         # Data persistency is set in config
-        Aspera.assert(@context.persistency){'missing persistency object'}
+        Aspera.assert(@context.persistency, 'missing persistency object')
         # The TransferAgent plugin may use the @preset parser
         @context.transfer = TransferAgent.new(@context.options, @context.config)
         # Add commands for config plugin after all options have been added
@@ -422,7 +293,6 @@ module Aspera
       def declare_global_options
         Log.log.debug('declare_global_options')
         @context.options.declare(:help, 'Show this message', allowed: Allowed::TYPES_NONE, short: 'h'){@option_help = true}
-        @context.options.declare(:bash_comp, 'Generate bash completion for command', allowed: Allowed::TYPES_NONE){@bash_completion = true}
         @context.options.declare(:show_config, 'Display parameters used for the provided action', allowed: Allowed::TYPES_NONE){@option_show_config = true}
         @context.options.declare(:version, 'Display version', allowed: Allowed::TYPES_NONE, short: 'v'){@context.formatter.display_message(:data, Cli::VERSION); Process.exit(0)} # rubocop:disable Style/Semicolon
         @context.options.declare(
@@ -464,17 +334,6 @@ module Aspera
         command_plugin = Plugins::Factory.instance.create(plugin_name_sym, context: @context)
         return command_plugin
       end
-
-      # Generate bash completion suggestions
-      # @return [nil]
-      def generate_bash_completion
-        if @context.options.get_next_argument('', multiple: true, mandatory: false).nil?
-          Plugins::Factory.instance.plugin_list.each{ |p| puts p}
-        else
-          Log.log.warn('only first level completion so far')
-        end
-        Process.exit(0)
-      end
     end
   end
 end

data/lib/aspera/cli/sync_actions.rb

@@ -15,7 +15,8 @@ module Aspera
         %w[Syncd Error Confl Pconf] +
         (23..24).map{ |i| "P(#{i})"}).freeze
       class << self
-        def declare_options(_options)
+        def declare_options(options)
+          options.declare(:sql, 'SQL suffix appended to sqlite3 queries for admin subcommands (e.g. WHERE clause)')
         end
       end
 
@@ -33,7 +34,7 @@ module Aspera
         if sync_info.key?('sessions') || sync_info.key?('instance')
           # `args`
           sync_info['sessions'] ||= [{}]
-          Aspera.assert(sync_info['sessions'].length == 1){'Only one session is supported'}
+          Aspera.assert(sync_info['sessions'].length == 1, 'Only one session is supported')
           session = sync_info['sessions'].first
           dir_key = path_is_remote ? 'remote_dir' : 'local_dir'
           raise "Parameter #{dir_key} shall not be in sync_info" if session.key?(dir_key)
@@ -94,31 +95,34 @@ module Aspera
       end
 
       def execute_sync_admin
-        command2 = options.get_next_command(%i[status find meta counters file_info overview])
+        command2 = options.get_next_command(%i[status find meta counters file_info overview query])
         require 'aspera/sync/database' unless command2.eql?(:status)
+        sql_suffix = options.get_option(:sql)
         case command2
         when :status
-          return Main.result_single_object(Sync::Operations.admin_status(async_info_from_args))
+          return Result::SingleObject.new(Sync::Operations.admin_status(async_info_from_args))
         when :find
           folder = options.get_next_argument('path')
           dbs = Sync::Operations.list_db_files(folder)
-          return Main.result_object_list(dbs.keys.map{ |n| {name: n, path: dbs[n]}})
+          return Result::ObjectList.new(dbs.keys.map{ |n| {name: n, path: dbs[n]}})
         when :meta, :counters
-          return Main.result_single_object(db_from_args.send(command2))
+          return Result::SingleObject.new(db_from_args.send(command2, sql_suffix))
         when :file_info
-          result = db_from_args.send(command2)
+          result = db_from_args.file_info(sql_suffix)
           result.each do |r|
             r['sstate'] = SyncActions::STATE_STR[r['state']] if r['state']
           end
-          return Main.result_object_list(
+          return Result::ObjectList.new(
             result,
             fields: %w[sstate record_id f_meta_path message]
           )
         when :overview
-          return Main.result_object_list(
+          return Result::ObjectList.new(
             db_from_args.overview,
             fields: %w[table name type]
           )
+        when :query
+          return Result.auto(db_from_args.execute(options.get_option(:sql, mandatory: true)))
         else Aspera.error_unexpected_value(command2)
         end
       end
@@ -131,7 +135,7 @@ module Aspera
         case command
         when *Sync::Operations::DIRECTIONS
           Sync::Operations.start(async_info_from_args(direction: command), transfer.user_transfer_spec, &block)
-          return Main.result_success
+          return Result::Success.new
         when :admin
           return execute_sync_admin
         else Aspera.error_unexpected_value(command)

data/lib/aspera/cli/terminal_formatter.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require 'aspera/environment'
+require 'aspera/formatter_interface'
+require 'aspera/markdown'
+require 'aspera/assert'
+
+module Aspera
+  module Cli
+    # Terminal formatter with ANSI colors and Unicode support
+    # @see FormatterInterface
+    # @see MarkdownFormatter (in build/lib/doc_helper.rb)
+    module TerminalFormatter
+      HINT = 'HINT:'.bg_green.gray.blink.freeze
+      include FormatterInterface
+
+      # Format boolean with colored symbol (✓/✗ or Y/ )
+      def tick(yes)
+        result =
+          if Environment.terminal_supports_unicode?
+            yes ? "\u2713" : "\u2717"
+          else
+            yes ? 'Y' : ' '
+          end
+        return result.green if yes
+        return result.red
+      end
+
+      # Format special values with colors (dim for empty, reverse for others)
+      def special_format(what)
+        result = "<#{what}>"
+        return %w[null empty].any?{ |s| what.include?(s)} ? result.dim : result.reverse_color
+      end
+
+      # Prepare table row for terminal display (word wrap arrays)
+      def check_row(row)
+        row.each_key do |k|
+          row[k] = row[k].map{ |i| WordWrap.ww(i.to_s, 120).chomp}.join("\n") if row[k].is_a?(Array)
+        end
+      end
+
+      # Convert Markdown to terminal format (**bold** -> blue, `code` -> bold)
+      # @param match [MatchData, String]
+      def markdown_text(match)
+        if match.is_a?(String)
+          match = Markdown::FORMATS.match(match)
+          Aspera.assert(match, 'markdown text does not match any known format')
+        end
+        Aspera.assert_type(match, MatchData)
+        if match[:entity]
+          Aspera.assert_values(match[:entity], %w[bsol])
+          '\\'
+        elsif match[:bold]
+          match[:bold].to_s.blue
+        elsif match[:code]
+          match[:code].to_s.bold
+        else
+          Aspera.error_unexpected_value(match.to_s)
+        end
+      end
+
+      module_function :tick, :special_format, :check_row, :markdown_text
+    end
+  end
+end

data/lib/aspera/cli/transfer_progress.rb

@@ -43,13 +43,13 @@ module Aspera
         case type
         when :sessions_init
           # Give opportunity to show progress of initialization with multiple status
-          Aspera.assert(session_id.nil?)
+          Aspera.assert(session_id.nil?, 'session_id must be nil for :sessions_init event')
           Aspera.assert_type(info, String)
           # Initialization of progress bar
           @title = info
         when :session_start
           Aspera.assert_type(session_id, String)
-          Aspera.assert(info.nil?)
+          Aspera.assert(info.nil?, 'info must be nil for :session_start event')
           raise "Session #{session_id} already started" if @sessions[session_id]
           @sessions[session_id] = {
             job_size: 0, # Total size of transfer (pre-calc)
@@ -60,7 +60,7 @@ module Aspera
           @title = nil
         when :session_size
           Aspera.assert_type(session_id, String)
-          Aspera.assert(!info.nil?)
+          Aspera.assert(!info.nil?, 'info must not be nil for :session_size event')
           Aspera.assert_type(@sessions[session_id], Hash)
           @sessions[session_id][:job_size] = info.to_i
           sessions_total = total(:job_size)
@@ -76,12 +76,12 @@ module Aspera
           end
         when :session_end
           Aspera.assert_type(session_id, String)
-          Aspera.assert(info.nil?)
+          Aspera.assert(info.nil?, 'info must be nil for :session_end event')
           # A session may be too short and finish before it has been started
           @sessions[session_id][:running] = false if @sessions[session_id].is_a?(Hash)
         when :end
-          Aspera.assert(session_id.nil?)
-          Aspera.assert(info.nil?)
+          Aspera.assert(session_id.nil?, 'session_id must be nil for :end event')
+          Aspera.assert(info.nil?, 'info must be nil for :end event')
           @progress_bar.finish
         else Aspera.error_unexpected_value(type){'event type'}
         end

data/lib/aspera/cli/version.rb

@@ -4,6 +4,6 @@ module Aspera
   module Cli
     # For beta add extension : .beta1
     # For dev version add extension : .pre
-    VERSION = '4.26.1'
+    VERSION = '4.26.2'
   end
 end

data/lib/aspera/cli/wizard.rb

@@ -80,7 +80,7 @@ module Aspera
         end
         RestParameters.instance.spinner_cb.call(action: :success)
         raise "No known application found at #{app_url}" if found_apps.empty?
-        Aspera.assert(found_apps.all?{ |a| a.keys.all?(Symbol)})
+        Aspera.assert(found_apps.all?{ |a| a.keys.all?(Symbol)}, 'all app info keys must be symbols')
         return found_apps
       end
 
@@ -128,7 +128,8 @@ module Aspera
           apps.first
         else
           formatter.display_status('Multiple applications detected, please select from:')
-          formatter.display_results(type: :object_list, data: apps, fields: %w[product url version])
+          require 'aspera/cli/result'
+          formatter.display_results(Result::ObjectList.new(apps, fields: %w[product url version]))
           answer = options.prompt_user_input_in_list('product', apps.map{ |a| a[:product]})
           apps.find{ |a| a[:product].eql?(answer)}
         end
@@ -140,9 +141,7 @@ module Aspera
         options.add_option_preset({url: wiz_url}, 'wizard')
         # Instantiate plugin: command line options will be known, e.g. private_key, and wizard can be called
         plugin_instance = Plugins::Factory.instance.plugin_class(identification[:product]).new(context: @parent.context)
-        Aspera.assert(plugin_instance.respond_to?(:wizard), type: Cli::BadArgument) do
-          "Detected: #{identification[:product]}, but this application has no wizard"
-        end
+        Aspera.assert(plugin_instance.respond_to?(:wizard), type: Cli::BadArgument){"Detected: #{identification[:product]}, but this application has no wizard"}
         # Call the wizard
         wizard_result = plugin_instance.wizard(self, wiz_url)
         Log.log.debug{"wizard result: #{wizard_result}"}
@@ -166,7 +165,7 @@ module Aspera
         test_args = "-P#{wiz_preset_name} #{test_args}" unless option_default
         # TODO: actually test the command
         test_cmd = "#{Info::CMD_NAME} #{identification[:product]} #{test_args}"
-        return Main.result_status("You can test with:\n#{test_cmd.red}")
+        return Result::Status.new("You can test with:\n#{test_cmd.red}")
       end
     end
   end

data/lib/aspera/command_line_builder.rb

@@ -66,7 +66,7 @@ module Aspera
           Aspera.assert(node.key?('type') || node.key?('enum')){"Missing type for #{name} in #{schema.current.dig('description').current}"}
           Aspera.assert(node['type'].eql?('boolean')){"switch must be bool: #{name}"} if node['x-cli-switch'] && !node['x-cli-special']
           node['x-cli-option'] = "--#{name.to_s.tr('_', '-')}" if node['x-cli-option'].eql?(true) || (node['x-cli-switch'].eql?(true) && !node.key?('x-cli-option'))
-          Aspera.assert(DIRECT_PROPERTIES.any?{ |i| node.key?(i)}, type: :warn){name} if ascp && supported_by_agent(:direct, node)
+          Aspera.assert(DIRECT_PROPERTIES.any?{ |i| node.key?(i)}, name, type: :warn) if ascp && supported_by_agent(:direct, node)
           node.freeze
         end
         schema

data/lib/aspera/data_repository.rb

@@ -6,6 +6,10 @@ require 'openssl'
 
 module Aspera
   # a simple binary data repository
+  #
+  # @!method self.instance
+  #   Returns the singleton instance of DataRepository
+  #   @return [DataRepository] the singleton instance
   class DataRepository
     include Singleton
 

data/lib/aspera/dot_container.rb

@@ -39,7 +39,7 @@ module Aspera
       # @param container [Hash, Array]
       # @param index     [String, Integer]
       def array_requires_integer_index!(container, index)
-        Aspera.assert(container.is_a?(Hash) || index.is_a?(Integer)){'Using String index when Integer index used previously'}
+        Aspera.assert(container.is_a?(Hash) || index.is_a?(Integer), 'Using String index when Integer index used previously')
       end
 
       # Create a new `Hash` or `Array` depending on type of `key`

data/lib/aspera/environment.rb

@@ -13,6 +13,10 @@ require 'shellwords'
 
 module Aspera
   # detect OS, architecture, and specific stuff
+  #
+  # @!method self.instance
+  #   Returns the singleton instance of Environment
+  #   @return [Environment] the singleton instance
   class Environment
     include Singleton
 
@@ -111,7 +115,7 @@ module Aspera
       # @raise [RuntimeError] If `:exception` is `true` and the process fails in `:capture` mode.
       def secure_execute(*cmd, mode: :execute, **kwargs)
         cmd = cmd.map(&:to_s)
-        Aspera.assert(cmd.size.positive?, type: ArgumentError){'executable must be present'}
+        Aspera.assert(cmd.size.positive?, 'executable must be present', type: ArgumentError)
         Aspera.assert_values(mode, PROCESS_MODES, type: ArgumentError){'mode'}
         Log.log.debug do
           parts = [mode.to_s, 'command:']
@@ -153,7 +157,7 @@ module Aspera
       # @param mode [Integer] the file mode (permissions)
       # @yieldreturn [String] The content to write to the file
       def write_file_restricted(path, force: false, mode: nil)
-        Aspera.assert(block_given?, type: Aspera::InternalError)
+        Aspera.assert(block_given?, 'block required for write_file_restricted', type: Aspera::InternalError)
         if force || !File.exist?(path)
           # Windows may give error
           File.unlink(path) rescue nil
@@ -192,10 +196,24 @@ module Aspera
       end
 
       # @return true if we can display Unicode characters
+      # Uses Encoding.locale_charmap for OS-independent detection.
+      # Falls back to locale env vars for systems where charmap is not available.
       # https://www.gnu.org/software/libc/manual/html_node/Locale-Categories.html
       # https://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html
       def terminal_supports_unicode?
-        terminal? && I18N_VARS.any?{ |var| ENV[var]&.include?('UTF-8')}
+        return false unless terminal?
+        locale_charmap_utf8? || I18N_VARS.any?{ |var| ENV[var]&.include?('UTF-8')}
+      end
+
+      private
+
+      # @return true if the locale charmap resolves to UTF-8
+      # Unix: nl_langinfo(CODESET) returns "UTF-8"
+      # Windows: GetACP returns "CP65001" which Encoding.find resolves as UTF-8
+      def locale_charmap_utf8?
+        Encoding.find(Encoding.locale_charmap) == Encoding::UTF_8
+      rescue ArgumentError
+        false
       end
     end
     attr_accessor :url_method, :file_illegal_characters
@@ -266,6 +284,7 @@ module Aspera
       return unless @os.eql?(OS_WINDOWS) && ENV.key?('USERPROFILE') && Dir.exist?(ENV.fetch('USERPROFILE', nil))
       ENV['HOME'] = ENV.fetch('USERPROFILE', nil)
       Log.log.debug{"Windows: set HOME to USERPROFILE: #{Dir.home}"}
+      nil
     end
 
     def graphical?

data/lib/aspera/faspex_gw.rb

@@ -68,7 +68,7 @@ module Aspera
       case request.path
       when '/aspera/faspex/send'
         begin
-          Aspera.assert(!request.body.nil?){'payload missing'}
+          Aspera.assert(!request.body.nil?, 'payload missing')
           faspex_pkg_parameters = JSON.parse(request.body)
           Log.log.debug{"faspex pkg create parameters=#{faspex_pkg_parameters}"}
           # compare string, as class is not yet known here

data/lib/aspera/json_rpc.rb

@@ -36,15 +36,16 @@ module Aspera
         id:      @request_id += 1
       })
       Aspera.assert_type(data, Hash){'response'}
-      Aspera.assert(data['jsonrpc'] == JSON_RPC_VERSION){'bad version in response'}
-      Aspera.assert(data.key?('id')){'missing id in response'}
-      Aspera.assert(!(data.key?('error') && data.key?('result'))){'both error and response'}
+      Aspera.assert(data['jsonrpc'] == JSON_RPC_VERSION, 'bad version in response')
+      Aspera.assert(data.key?('id'), 'missing id in response')
+      Aspera.assert(!(data.key?('error') && data.key?('result')), 'both error and response')
       Aspera.assert(
         !data.key?('error') ||
         data['error'].is_a?(Hash) &&
         data['error']['code'].is_a?(Integer) &&
-        data['error']['message'].is_a?(String)
-      ){'bad error response'}
+        data['error']['message'].is_a?(String),
+        'bad error response'
+      )
       return data['result']
     end
   end

data/lib/aspera/keychain/base.rb

@@ -11,7 +11,7 @@ module Aspera
         options.each_pair do |k, v|
           Aspera.assert_type(v, String){k.to_s}
         end
-        Aspera.assert(options.key?(:label)){'label is required'}
+        Aspera.assert(options.key?(:label), 'label is required')
       end
     end
   end

data/lib/aspera/keychain/encrypted_hash.rb

@@ -28,7 +28,7 @@ module Aspera
           vault_file = File.read(@path)
           if vault_file.start_with?('---')
             vault_info = YAML.parse(vault_file).to_ruby
-            Aspera.assert(vault_info.keys.sort == FILE_KEYS){'Invalid vault file'}
+            Aspera.assert(vault_info.keys.sort == FILE_KEYS, 'Invalid vault file')
             @cipher_name = vault_info['cipher']
             vault_encrypted_data = vault_info['data']
           else

data/lib/aspera/keychain/factory.rb

@@ -20,7 +20,7 @@ module Aspera
           when 'file'
             info[:file] = name || 'vault.bin'
             info[:file] = File.join(folder, info[:file]) unless File.absolute_path?(info[:file])
-            Aspera.assert(!password.nil?){'please provide password'}
+            Aspera.assert(!password.nil?, 'please provide password')
             info[:password] = password
             # this module requires compilation, so it is optional
             require 'aspera/keychain/encrypted_hash'