aspera-cli 4.25.5 → 4.25.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a886cb3a02f285c84728b216f1cd906b8440db041a8240ed09ed1969d81ec6c3
-  data.tar.gz: a05a7d9fc94a5d748c52d659426a18cf567a9e303231c86d1ec2312abc3465ae
+  metadata.gz: 8e8b3ed2906ef470b3617e60b438089f57c5b3d0e1770649e2ba1a64d413d32d
+  data.tar.gz: e09b6b5d455c77ea355ba617577b82a1c51e60afab2e8431e62dcf8d9e7785c6
 SHA512:
-  metadata.gz: 87988d7b4252134e772c7c5420e59471cfb89355627cb3bf49fe6f5cf19382644856dfee3494adb3db2a879fc42b77f5754f8fee995eae8ca45229fc68ccd769
-  data.tar.gz: ace70306ca85a12b17d12dcf146f280d313dcbef491576c265a5a20f70199d1c03ef3834cc62de30b20949f2cfdea39821b09b232c8bd826709f5622c7f631c3
+  metadata.gz: eb3f5becd29ffc54c7746868a47b3e8841cde1566abb0b5ea97d9c4bb7768f9f85c4cf96cbd3e52b6a1724f4be0eb817ea03282a4070e5cf32a9d06fb6a3aab5
+  data.tar.gz: f8f03f1a45d50b92e01d39f734bdebebf94e1640c695751a3122106797d9c4d223e544050cd854cb026daa736589440666d5ccd2453b50c9a39a6df5fadccc8e

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 <!-- markdownlint-configure-file { "no-duplicate-heading": { "siblings_only": true } } -->
 
+## 4.25.6
+
+Released: 2026-04-08
+
+### Issues Fixed
+
+* `node`: #253 fix `node transfer list` infinite loop with `once_only`.
+
 ## 4.25.5
 
 Released: 2026-03-25
@@ -14,9 +22,7 @@ Released: 2026-03-25
 
 * `config`: Fixed `preset update` with dot-path options.
 * `sync`: #251 in `admin` command: Fixed database path on Windows: Use `~private-asp` instead of `.private-asp`.
-* `httpgw`: #252 HTTPGW transfer showed success even in case of error code `403`. Now raises error with message.
-
-### Breaking Changes
+* `httpgw`: #252 HTTPGW transfer showed success even when error code `403` was returned. Now raises error with message.
 
 ## 4.25.4
 
@@ -115,7 +121,7 @@ Released: 2026-01-21
 ### Issues Fixed
 
 * `aoc`: Restored command `admin workspace shared_folder :id list` which was since 4.11.0.
-* `direct`: When using `ascp4` do not set env var: `ASPERA_TEST_REDIS_DISABLE`, else it fails with: `Failed to initialize application`.
+* `direct`: When using `ascp4`, do not set env var: `ASPERA_TEST_REDIS_DISABLE`, else it fails with: `Failed to initialize application`.
 * `shares`: Properly detect using `/node_api/ping` endpoint instead of `/app`.
 
 ### Breaking Changes
@@ -194,7 +200,7 @@ Released: 2025-09-30
 * `console`: Removed options `filter_from` and `filter_to`. Use standard option `query` instead.
 * `sync`: Removed option `sync_info`. Replaced with positional parameters. Streamlined command line interface. Applies to all plugins with `sync` command.
 * `async`: Removed option `sync_name`. Replaced with percent selector `%name:`.
-* `aoc`: `files download` using gen4 API do not require anymore to provide the containing folder in first position, and then only file names. Now, directly provide the path to all files.
+* `aoc`: `files download` using gen4 API no longer requires providing the containing folder in first position, and then only file names. Now, directly provide the path to all files.
 * `logger`: Log is simplified, date is removed by default. Use `--log_format=standard` to revert to standard Ruby logger. See option `log_format` for details.
 
 ## 4.23.0
@@ -208,7 +214,7 @@ Released: 2025-08-11
 
 ### Issues Fixed
 
-* `server`: #209: missing home folder for transfer user shall not cause an error.
+* `server`: #209: a missing home folder for the transfer user shall not cause an error.
 * `direct`: #205: `kill` blocks `cmd` on Windows.
 
 ### Breaking Changes
@@ -924,7 +930,7 @@ Released: 2021-02-03
 
 ## 0.11.2
 
-* Fixes on multi-session: Progress bat and transfer spec param for "direct".
+* Fixes on multi-session: Progress bar and transfer spec param for `direct`.
 
 ## 0.11.1
 
@@ -995,7 +1001,7 @@ Released: 2021-02-03
 
 ## 0.10.6
 
-* FaspManager: Transfer spec `authentication` no more needed for local transfer to use Aspera public keys. public keys will be used if there is a token and no key or password is provided.
+* FaspManager: Transfer spec `authentication` is no longer needed for local transfer to use Aspera public keys. Public keys will be used if there is a token and no key or password is provided.
 * Gem version requirements made more open.
 
 ## 0.10.5

data/CONTRIBUTING.md

@@ -114,6 +114,8 @@ The following environment variables and macros control specific build behaviors:
 | `ENABLE_COVERAGE`           | set/unset  | Enables test coverage analysis when defined.                 |
 | `SIGNING_KEY`               | File path  | Path to the signing key used for building the gem file.      |
 | `SIGNING_KEY_PEM`           | PEM Value  | The PEM content of the signing key.                          |
+| `DRY_RUN`                   | `1`        | Simulates execution without performing actual operations (git, gh commands). |
+| `DEBUG`                     | `1`        | Shows stack trace on errors during documentation generation. |
 
 These values can be set as standard environment variables or passed directly to the `rake` command.
 
@@ -156,7 +158,7 @@ tlmgr install fvextra selnolig lualatex-math
 rake doc:check_links
 ```
 
-- Debug the generation process: `ASPERA_CLI_DOC_DEBUG=debug`.
+- Debug the generation process: `DEBUG=1`.
 
 - Build the documentation:
 
@@ -254,6 +256,13 @@ bundle exec rake container:test
 bundle exec rake doc:check_links
 ```
 
+- **Check release procedure**:
+
+```shell
+bundle exec rake release:run DRY_RUN=1
+git restore lib/aspera/cli/version.rb CHANGELOG.md docs/README.md
+```
+
 ### Automated Release Process
 
 Releases are managed through the GitHub Actions UI via the **New Release on GitHub** workflow (`.github/workflows/release.yml`).
@@ -313,4 +322,4 @@ This triggers the `.github/workflows/deploy.yml` action to publish to RubyGems.
   - [rest-client](https://github.com/rest-client/rest-client)
   - [oauth2](https://github.com/oauth-xx/oauth2)
 - Integrate `thor` <http://whatisthor.com/> or another standard Ruby CLI framework.
-- Explore [Traveling Ruby](https://github.com/phusion/traveling-ruby) for distribution.
+- Explore [Traveling Ruby](https://github.com/phusion/traveling-ruby) for distribution, or [truby Traveling Ruby](https://github.com/trubygems/traveling-ruby).

data/lib/aspera/api/node.rb

@@ -530,32 +530,45 @@ module Aspera
         Aspera.assert_type(query, Hash, NilClass){'query'}
         Aspera.assert(!call_args.key?(:query))
         query = {} if query.nil?
-        query[:iteration_token] = iteration[0] unless iteration.nil?
+        query[:iteration_token] = iteration[0] unless iteration.nil? || iteration[0].nil?
         max = query.delete(RestList::MAX_ITEMS)
+        # Return empty list immediately if max is 0
+        return [] if max&.zero?
         item_list = []
         loop do
           data, http = read(subpath, query, **call_args, ret: :both)
           Aspera.assert_type(data, Array){"Expected data to be an Array, got: #{data.class}"}
           # no data
           break if data.empty?
-          # get next iteration token from link
-          next_iteration_token = nil
-          link_info = http['Link']
-          unless link_info.nil?
-            m = link_info.match(/<([^>]+)>/)
-            Aspera.assert(m){"Cannot parse iteration in Link: #{link_info}"}
-            next_iteration_token = Rest.query_to_h(URI.parse(m[1]).query)['iteration_token']
-          end
-          # same as last iteration: stop
-          break if next_iteration_token&.eql?(query[:iteration_token])
-          query[:iteration_token] = next_iteration_token
           item_list.concat(data)
+          # Check if we reached the max limit
           if max&.<=(item_list.length)
             item_list = item_list.slice(0, max)
             break
           end
+          # Update progress spinner
+          RestParameters.instance.spinner_cb.call(item_list.length)
+          # Parse Link header according to RFC 8288 to extract next iteration token
+          next_url = Rest.parse_link_header(http['Link'], rel: 'next')
+          next_iteration_token = nil
+          if next_url
+            begin
+              parsed_uri = URI.parse(next_url)
+              query_params = Rest.query_to_h(parsed_uri.query) if parsed_uri.query
+              next_iteration_token = query_params['iteration_token'] if query_params
+            rescue URI::InvalidURIError => e
+              Log.log.warn{"Invalid URI in Link header: #{next_url} - #{e.message}"}
+            end
+          end
+          # Stop if no next token
           break if next_iteration_token.nil?
+          # Stop if same token as current (infinite loop protection)
+          break if next_iteration_token.eql?(query[:iteration_token])
+          # Update token for next iteration
+          query[:iteration_token] = next_iteration_token
         end
+        # Signal completion
+        RestParameters.instance.spinner_cb.call(action: :success)
         # save iteration token if needed
         iteration[0] = query[:iteration_token] unless iteration.nil?
         item_list

data/lib/aspera/ascp/installation.rb

@@ -178,33 +178,32 @@ module Aspera
       # Folder, PVCL, version, license information
       def ascp_info_from_log
         data = {}
+        _, stderr, status = Environment.secure_execute(path(:ascp), '-DDL-', mode: :capture, exception: false)
         # read PATHs from ascp directly, and pvcl modules as well
-        Open3.popen3(path(:ascp), '-DDL-') do |_stdin, _stdout, stderr, thread|
-          last_line = ''
-          while (line = stderr.gets)
-            line.chomp!
-            # skip lines that may have accents
-            next unless line.valid_encoding?
-            last_line = line
-            case line
-            when /^DBG Path ([^ ]+) (dir|file) +: (.*)$/
-              data[Regexp.last_match(1)] = Regexp.last_match(3)
-            when /^DBG Added module group:"(?<module>[^"]+)" name:"(?<scheme>[^"]+)", version:"(?<version>[^"]+)" interface:"(?<interface>[^"]+)"$/
-              c = Regexp.last_match.named_captures.symbolize_keys
-              data[c[:interface]] ||= {}
-              data[c[:interface]][c[:module]] ||= []
-              data[c[:interface]][c[:module]].push("#{c[:scheme]} v#{c[:version]}")
-            when %r{^DBG License result \(/license/(\S+)\): (.+)$}
-              data[Regexp.last_match(1)] = Regexp.last_match(2)
-            when /^LOG (.+) version ([0-9.]+)$/
-              data['product_name'] = Regexp.last_match(1)
-              data['product_version'] = Regexp.last_match(2)
-            when /^LOG Initializing FASP version ([^,]+),/
-              data['ascp_version'] = Regexp.last_match(1)
-            end
+        last_line = ''
+        stderr.lines do |line|
+          line.chomp!
+          # Skip lines that may have accents
+          next unless line.valid_encoding?
+          last_line = line
+          case line
+          when /^DBG Path ([^ ]+) (dir|file) +: (.*)$/
+            data[Regexp.last_match(1)] = Regexp.last_match(3)
+          when /^DBG Added module group:"(?<module>[^"]+)" name:"(?<scheme>[^"]+)", version:"(?<version>[^"]+)" interface:"(?<interface>[^"]+)"$/
+            c = Regexp.last_match.named_captures.symbolize_keys
+            data[c[:interface]] ||= {}
+            data[c[:interface]][c[:module]] ||= []
+            data[c[:interface]][c[:module]].push("#{c[:scheme]} v#{c[:version]}")
+          when %r{^DBG License result \(/license/(\S+)\): (.+)$}
+            data[Regexp.last_match(1)] = Regexp.last_match(2)
+          when /^LOG (.+) version ([0-9.]+)$/
+            data['product_name'] = Regexp.last_match(1)
+            data['product_version'] = Regexp.last_match(2)
+          when /^LOG Initializing FASP version ([^,]+),/
+            data['ascp_version'] = Regexp.last_match(1)
           end
-          raise last_line if !thread.value.exitstatus.eql?(1) && !data.key?('root')
         end
+        raise last_line if !status.exitstatus.eql?(1) && !data.key?('root')
         return data
       end
 

data/lib/aspera/cli/plugins/server.rb

@@ -32,7 +32,7 @@ module Aspera
 
         class LocalExecutor
           def execute(ascmd_path, input:)
-            return Environment.secure_execute(ascmd_path, mode: :capture, stdin_data: input, binmode: true, exception: false)
+            Environment.secure_execute(ascmd_path, mode: :capture, stdin_data: input, binmode: true, exception: false).first
           end
         end
 

data/lib/aspera/cli/version.rb

@@ -4,6 +4,6 @@ module Aspera
   module Cli
     # For beta add extension : .beta1
     # For dev version add extension : .pre
-    VERSION = '4.25.5'
+    VERSION = '4.25.6'
   end
 end

data/lib/aspera/environment.rb

@@ -84,22 +84,31 @@ module Aspera
         "'#{str.gsub("'", %q('\'\''))}'"
       end
 
-      # Execute a process securely without shell.
+      # Executes a command without invoking a shell.
       #
-      # Execution `mode` can be:
-      # - :execute    -> Kernel.system, return nil
-      # - :background -> Process.spawn, return pid
-      # - :capture    -> Open3.capture3, return stdout
+      # The command is provided as an array to avoid shell interpolation and
+      # ensure safer execution.
       #
-      # @param cmd [Array<String>] Executable and arguments (mapped "to_s")
-      # @param mode [:execute,:background,:capture] Execution mode
-      # @param kwargs [Hash] Additional arguments to underlying method
-      # @option kwargs [Hash] :env Environment variables
-      # @option kwargs [Boolean] :exception for :capture mode, raise error if process fails
-      # @option kwargs [Boolean] :close_others for :background mode
-      # @return [nil] for :execute mode
-      # @return [Integer] pid for :background mode
-      # @return [String] stdout for :capture mode
+      # @param cmd [Array<#to_s>] The executable and its arguments.
+      # @param mode [:execute, :background, :capture] The execution strategy:
+      #   - `:execute`    Uses {Kernel.system}. Returns `true`, `false`, or `nil`.
+      #   - `:background` Uses {Process.spawn}. Returns the spawned process PID.
+      #   - `:capture`    Uses {Open3.capture3}. Returns captured output and status.
+      #
+      # @param kwargs [Hash] Additional options forwarded to the underlying call.
+      #
+      # @option kwargs [Hash{String => String}] :env Environment variables to set for the process.
+      # @option kwargs [Boolean] :exception (false) When `true` in `:capture` mode,
+      #   raises an error if the command exits with a non-zero status.
+      # @option kwargs [Boolean] :close_others (true) When `true` in `:background` mode,
+      #   closes all other file descriptors in the child process.
+      #
+      # @return [Boolean, nil] For `:execute` mode (`true`, `false`, or `nil`).
+      # @return [Integer] For `:background` mode (process ID).
+      # @return [Array(String, String, Process::Status)] For `:capture` mode
+      #   (`stdout`, `stderr`, `status`).
+      #
+      # @raise [RuntimeError] If `:exception` is `true` and the process fails in `:capture` mode.
       def secure_execute(*cmd, mode: :execute, **kwargs)
         cmd = cmd.map(&:to_s)
         Aspera.assert(cmd.size.positive?, type: ArgumentError){'executable must be present'}
@@ -128,11 +137,12 @@ module Aspera
           # https://docs.ruby-lang.org/en/master/Process.html#module-Process-label-Execution+Options
           argv = [kwargs.delete(:env)].compact + cmd
           exception = kwargs.delete(:exception){true}
-          stdout, stderr, status = Open3.capture3(*argv, **kwargs)
-          Log.log.debug{"status=#{status}, stderr=#{stderr}"}
-          Log.log.trace1{"stdout=#{stdout}"}
-          raise "Process failed: #{status.exitstatus} (#{stderr})" if exception && !status.success?
-          stdout
+          result = Open3.capture3(*argv, **kwargs)
+          Log.dump(:stdout, result[0], level: :trace1)
+          Log.dump(:stderr, result[1], level: :trace1)
+          Log.dump(:status, result[2])
+          raise "Process failed: #{result[2].exitstatus} (#{result[1]})" if exception && !result[2].success?
+          result
         else Aspera.error_unreachable_line
         end
       end

data/lib/aspera/keychain/macos_security.rb

@@ -57,7 +57,7 @@ module Aspera
               command_args.push(v.shellescape) unless v.empty?
             end
             command_args.push(last_opt) unless last_opt.nil?
-            return Environment.secure_execute(*command_args, mode: :capture)
+            Environment.secure_execute(*command_args, mode: :capture).first
           end
 
           def key_chains(output)

data/lib/aspera/preview/utils.rb

@@ -51,11 +51,11 @@ module Aspera
           Environment.secure_execute(command_sym.to_s, *command_args.map(&:to_s), out: File::NULL, err: File::NULL)
         end
 
-        # Execute external command and capture output
+        # Execute external command and get stdout
         # @return [String]
         def external_capture(command_sym, command_args)
           Aspera.assert_values(command_sym, EXTERNAL_TOOLS){'command'}
-          return Environment.secure_execute(command_sym.to_s, *command_args.map(&:to_s), mode: :capture)
+          Environment.secure_execute(command_sym.to_s, *command_args.map(&:to_s), mode: :capture).first
         end
 
         def ffmpeg(gl_p: FFMPEG_DEFAULT_PARAMS, in_p: [], in_f:, out_p: [], out_f:)

data/lib/aspera/rest.rb

@@ -150,6 +150,37 @@ module Aspera
         end
       end
 
+      # Parse Link header according to RFC 8288 to extract a specific relation
+      # @param link_header [String, nil] The Link header value
+      # @param rel [String] The relation to look for (default: 'next')
+      # @return [String, nil] The URL of the link with the specified relation, or nil
+      def parse_link_header(link_header, rel: 'next')
+        return if link_header.nil? || link_header.empty?
+        # RFC 8288: Link header format is: <URI>; param1=value1; param2=value2, <URI2>; ...
+        # We look for the link with the specified rel
+        link_header.split(',').each do |link_part|
+          link_part = link_part.strip
+          # Extract URL between < and >
+          url_match = link_part.match(/<([^>]+)>/)
+          next unless url_match
+          url = url_match[1]
+          # Extract parameters after the URL
+          params_str = link_part[url_match.end(0)..-1]
+          # Check if this link has the specified rel (with or without quotes, case insensitive)
+          next unless /;\s*rel\s*=\s*"?#{Regexp.escape(rel)}"?/i.match?(params_str)
+          return url
+        end
+        # Fallback: if no rel found and looking for 'next', try the first link (backward compatibility)
+        if rel.eql?('next')
+          first_link = link_header.split(',').first&.strip
+          if first_link
+            url_match = first_link.match(/<([^>]+)>/)
+            return url_match[1] if url_match
+          end
+        end
+        nil
+      end
+
       # Start a HTTP/S session, also used for web sockets
       # @param base_url [String] Base url of HTTP/S session
       # @return [Net::HTTP] A started HTTP session

data/lib/aspera/sync/operations.rb

@@ -197,7 +197,7 @@ module Aspera
               raise Error, 'Missing either local_db_dir or local_dir'
             end
           end
-          stdout = Environment.secure_execute(*arguments, mode: :capture)
+          stdout = Environment.secure_execute(*arguments, mode: :capture).first
           return parse_status(stdout)
         end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aspera-cli
 version: !ruby/object:Gem::Version
-  version: 4.25.5
+  version: 4.25.6
 platform: ruby
 authors:
 - Laurent Martin