aspera-cli 4.25.0.pre → 4.25.0

data/lib/aspera/agent/direct.rb

@@ -186,20 +186,21 @@ module Aspera
         Log.log.debug('fasp local shutdown')
       end
 
+      # @param id [String] Transfer session identifier
       # @return [Array] list of sessions for a job
-      def sessions_by_job(job_id)
-        @sessions.select{ |session| session[:job_id].eql?(job_id)}
+      def sessions_by_job(id)
+        @sessions.select{ |session| session[:job_id].eql?(id)}
       end
 
       # Send command to management port of command (used in `asession).
       # Examples:
       # {'type'=>'START','source'=>_path_,'destination'=>_path_}
       # {'type'=>'DONE'}
-      # @param data [Hash]   Command on mgt port
-      # @param id   [String] Optional identifier or transfer session
+      # @param data [Hash]   Command on mgt port (snake case)
+      # @param id   [String] Optional identifier of transfer session
       def send_command(data, id: nil)
         Log.dump(:command, data)
-        sessions = id ? @sessions.select{ |session| session[:job_id].eql?(id)} : @sessions
+        sessions = id ? sessions_by_job(id) : @sessions
         if sessions.empty?
           Log.log.warn('No transfer session')
           return
@@ -251,11 +252,14 @@ module Aspera
         Aspera.assert_type(session, Hash)
         notify_progress(:sessions_init, info: 'starting')
         begin
+          # do not use
           capture_stderr = false
           stderr_r, stderr_w = nil
           spawn_args = {}
           command_pid = nil
-          command_arguments = []
+          # get location of command executable (ascp, async)
+          command_path = Ascp::Installation.instance.path(name)
+          command_arguments = [command_path]
           if @monitor
             # we use Socket directly, instead of TCPServer, as it gives access to lower level options
             socket_class = defined?(JRUBY_VERSION) ? ServerSocket : Socket
@@ -266,20 +270,18 @@ module Aspera
             mgt_server_socket.listen(1)
             # build arguments and add mgt port
             command_arguments = if name.eql?(:async)
-              ["--exclusive-mgmt-port=#{mgt_server_socket.local_address.ip_port}"]
+              [command_path, "--exclusive-mgmt-port=#{mgt_server_socket.local_address.ip_port}"]
             else
-              ['-M', mgt_server_socket.local_address.ip_port.to_s]
+              [command_path, '-M', mgt_server_socket.local_address.ip_port.to_s]
             end
           end
           command_arguments.concat(args)
           if capture_stderr
             # capture process stderr
             stderr_r, stderr_w = IO.pipe
-            spawn_args[err] = stderr_w
+            spawn_args[:err] = stderr_w
           end
-          # get location of command executable (ascp, async)
-          command_path = Ascp::Installation.instance.path(name)
-          command_pid = Environment.secure_spawn(env: env, exec: command_path, args: command_arguments, **spawn_args)
+          command_pid = Environment.secure_execute(*command_arguments, mode: :background, env: env, **spawn_args)
           # close here, but still used in other process (pipe)
           stderr_w&.close
           notify_progress(:sessions_init, info: "waiting for #{name} to start")

data/lib/aspera/agent/factory.rb

@@ -16,15 +16,18 @@ module Aspera
         Aspera::Agent.const_get(agent.to_s.capitalize).new(**options)
       end
 
-      # Discover available agents
-      # @return [Array] list of symbols of agents
-      def list
+      IGNORED_ITEMS = %i[factory base]
+      # Available agents: :long : Capitalized name string, :short : single character symbol
+      ALL =
         Dir.children(File.dirname(File.expand_path(__FILE__)))
           .select{ |file| file.end_with?(Environment::RB_EXT)}
           .map{ |file| File.basename(file, Environment::RB_EXT).to_sym}
-          .reject{ |item| IGNORED_ITEMS.include?(item)}
-      end
-      IGNORED_ITEMS = %i[factory base]
+          .reject{ |item| IGNORED_ITEMS.include?(item)}.each_with_object({}) do |agent_sym, hash|
+          hash[agent_sym] = {
+            long:  agent_sym.to_s.capitalize,
+            short: agent_sym.eql?(:direct) ? :a : agent_sym.to_s[0].to_sym
+          }.freeze
+        end.freeze
       private_constant :IGNORED_ITEMS
     end
   end

data/lib/aspera/agent/transferd.rb

@@ -21,10 +21,10 @@ module Aspera
 
       private_constant :LOCAL_SOCKET_ADDR, :PORT_SEP, :AUTO_LOCAL_TCP_PORT
 
-      # @param url   [String] URL of the transfer manager daemon
-      # @param start [Bool]   if false, expect that an external daemon is already running
-      # @param stop  [Bool]   if false, do not shutdown daemon on exit
-      # @param base  [Hash]   base class options
+      # @param url   [String]  URL of the transfer manager daemon
+      # @param start [Boolean] If `false`, expect that an external daemon is already running
+      # @param stop  [Boolean] If `false`, do not shutdown daemon on exit
+      # @param base  [Hash]    Base class options
       def initialize(
         url:   AUTO_LOCAL_TCP_PORT,
         start: true,
@@ -79,9 +79,9 @@ module Aspera
           log_stdout = "#{transferd_base_tmp}.out"
           log_stderr = "#{transferd_base_tmp}.err"
           File.write(conf_file, config.to_json)
-          @daemon_pid = Environment.secure_spawn(
-            exec: Ascp::Installation.instance.path(:transferd),
-            args: ['--config', conf_file],
+          @daemon_pid = Environment.secure_execute(
+            Ascp::Installation.instance.path(:transferd), '--config', conf_file,
+            mode: :background,
             out: log_stdout,
             err: log_stderr
           )
@@ -170,7 +170,7 @@ module Aspera
       def stop_daemon
         if !@daemon_pid.nil?
           Log.log.debug("Stopping daemon #{@daemon_pid}")
-          Process.kill(:INT, @daemon_pid)
+          Process.kill(:KILL, @daemon_pid)
           _, status = Process.wait2(@daemon_pid)
           Log.log.debug("daemon stopped #{status}")
           @daemon_pid = nil

data/lib/aspera/api/aoc.rb

@@ -33,7 +33,7 @@ module Aspera
       # types of events for shared folder creation
       # Node events: permission.created permission.modified permission.deleted
       PERMISSIONS_CREATED = ['permission.created'].freeze
-      # Special name when creating workspace shared folders
+      # Special user identifier when creating workspace shared folders
       ID_AK_ADMIN = 'ASPERA_ACCESS_KEY_ADMIN'
 
       private_constant :MAX_AOC_URL_REDIRECT,
@@ -48,11 +48,13 @@ module Aspera
         :ID_AK_ADMIN
 
       # various API scopes supported
-      SCOPE_FILES_SELF = 'self'
-      SCOPE_FILES_USER = 'user:all'
-      SCOPE_FILES_ADMIN = 'admin:all'
-      SCOPE_FILES_ADMIN_USER = 'admin-user:all'
-      SCOPE_FILES_ADMIN_USER_USER = "#{SCOPE_FILES_ADMIN_USER}+#{SCOPE_FILES_USER}"
+      module Scope
+        SELF = 'self'
+        USER = 'user:all'
+        ADMIN = 'admin:all'
+        ADMIN_USER = 'admin-user:all'
+        ADMIN_USER_USER = "#{ADMIN_USER}+#{USER}"
+      end
       FILES_APP = 'files'
       PACKAGES_APP = 'packages'
       API_V1 = 'api/v1'
@@ -227,10 +229,12 @@ module Aspera
         @workspace_info = nil
         @home_info = nil
         auth_params = {
-          type:          :oauth2,
-          client_id:     client_id,
-          client_secret: client_secret,
-          scope:         scope
+          type:   :oauth2,
+          params: {
+            client_id:     client_id,
+            client_secret: client_secret,
+            scope:         scope
+          }
         }
         # analyze type of url
         url_info = AoC.link_info(url)
@@ -256,20 +260,20 @@ module Aspera
           Aspera.assert(username, 'Missing mandatory option: username', type: ParameterError)
           auth_params[:private_key_obj] = OpenSSL::PKey::RSA.new(private_key, passphrase)
           auth_params[:payload] = {
-            iss: auth_params[:client_id], # issuer
+            iss: client_id, # issuer
             sub: username, # subject
             aud: JWT_AUDIENCE
           }
           # add jwt payload for global client id
-          auth_params[:payload][:org] = url_info[:organization] if GLOBAL_CLIENT_APPS.include?(auth_params[:client_id])
+          auth_params[:payload][:org] = url_info[:organization] if GLOBAL_CLIENT_APPS.include?(client_id)
           auth_params[:cache_ids] = [url_info[:organization]]
         when :url_json
-          auth_params[:url] = {grant_type: 'url_token'} # URL arguments
+          auth_params[:url] = {grant_type: 'url_token'} # Query arguments
           auth_params[:json] = {url_token: url_info[:token]} # JSON body
           # password protection of link
           auth_params[:json][:password] = password unless password.nil?
           # basic auth required for /token
-          auth_params[:auth] = {type: :basic, username: auth_params[:client_id], password: auth_params[:client_secret]}
+          auth_params[:auth] = {type: :basic, username: client_id, password: client_secret}
         else Aspera.error_unexpected_value(auth_params[:grant_method]){'auth, use one of: :web, :jwt'}
         end
         super(
@@ -386,11 +390,12 @@ module Aspera
         @home_info
       end
 
-      # @param node_id [String] identifier of node in AoC
-      # @param workspace_id [String] workspace identifier
-      # @param workspace_name [String] workspace name
-      # @param scope e.g. Node::SCOPE_USER, or nil (requires secret)
-      # @param package_info [Hash] created package information
+      # Return a Node API for given node id, in a given context (files, packages), for the given scope.
+      # @param node_id        [String] identifier of node in AoC
+      # @param workspace_id   [String,nil] workspace identifier
+      # @param workspace_name [String,nil] workspace name
+      # @param scope          [String,nil] e.g. Node::SCOPE_USER, or Node::SCOPE_ADMIN, or nil (requires secret)
+      # @param package_info   [Hash,nil] created package information
       # @returns [Node] a node API for access key
       def node_api_from(node_id:, workspace_id: nil, workspace_name: nil, scope: Node::SCOPE_USER, package_info: nil)
         Aspera.assert_type(node_id, String)
@@ -409,18 +414,22 @@ module Aspera
           app_info[:package_name] = package_info['name']
         end
         node_params = {base_url: node_info['url']}
-        # if secret is available
-        if scope.nil?
+        ak_secret = @secret_finder&.lookup_secret(url: node_info['url'], username: node_info['access_key'])
+        # If secret is available, or no scope, use basic auth
+        if scope.nil? || ak_secret
+          Aspera.assert(ak_secret, "Secret not found for access key #{node_info['access_key']}@#{node_info['url']}", type: Error)
           node_params[:auth] = {
             type:     :basic,
             username: node_info['access_key'],
-            password: @secret_finder&.lookup_secret(url: node_info['url'], username: node_info['access_key'], mandatory: true)
+            password: ak_secret
           }
         else
           # OAuth bearer token
           node_params[:auth] = auth_params.clone
-          node_params[:auth][:scope] = Node.token_scope(node_info['access_key'], scope)
-          # special header required for bearer token only
+          node_params[:auth][:params] ||= {}
+          node_params[:auth][:params][:scope] = Node.token_scope(node_info['access_key'], scope)
+          node_params[:auth][:params][:owner_access] = true if scope.eql?(Node::SCOPE_ADMIN)
+          # Special header required for bearer token only
           node_params[:headers] = {Node::HEADER_X_ASPERA_ACCESS_KEY => node_info['access_key']}
         end
         node_params[:app_info] = app_info

data/lib/aspera/api/ats.rb

@@ -5,6 +5,7 @@ require 'aspera/rest'
 
 module Aspera
   module Api
+    # ATS API without authentication
     class Ats < Aspera::Rest
       SERVICE_BASE_URL = 'https://ats.aspera.io'
       # currently supported clouds

data/lib/aspera/api/faspex.rb

@@ -34,7 +34,7 @@ module Aspera
         query: {
           response_type: :code,
           state:         @context,
-          client_id:     client_id,
+          client_id:     params[:client_id],
           redirect_uri:  @redirect_uri
         },
         exception: false,
@@ -46,7 +46,7 @@ module Aspera
       raise Error, info['action_message'] if info['action_message']
       Aspera.assert(info['code']){'Missing code in answer'}
       # Exchange code for token
-      return create_token_call(optional_scope_client_id.merge(
+      return create_token_call(base_params.merge(
         grant_type:   'authorization_code',
         code:         info['code'],
         redirect_uri: @redirect_uri
@@ -155,7 +155,9 @@ module Aspera
                 base_url:     "#{base_url}/#{PATH_AUTH}",
                 grant_method: :faspex_pub_link,
                 context:      encoded_context,
-                client_id:    config[:client_id],
+                params:       {
+                  client_id: config[:client_id]
+                },
                 redirect_uri: config[:redirect_uri]
               }
             }
@@ -177,7 +179,9 @@ module Aspera
                 type:         :oauth2,
                 base_url:     "#{url}/#{PATH_AUTH}",
                 grant_method: :web,
-                client_id:    client_id,
+                params:       {
+                  client_id: client_id
+                },
                 redirect_uri: redirect_uri
               }
             }
@@ -190,7 +194,9 @@ module Aspera
                 type:            :oauth2,
                 base_url:        "#{url}/#{PATH_AUTH}",
                 grant_method:    :jwt,
-                client_id:       client_id,
+                params:          {
+                  client_id: client_id
+                },
                 payload:         {
                   iss: client_id, # issuer
                   aud: client_id, # audience (this field is not clear...)

data/lib/aspera/ascmd.rb

@@ -89,7 +89,7 @@ module Aspera
     # Version 2 allows use of reverse proxy with multiple addresses.
     # @param [Symbol] one of OPERATIONS
     # @param [Array] parameters for "as" command
-    # @return result of command, type depends on command (bool, array, hash)
+    # @return [Boolean,Array,Hash] result of command, type depends on command
     def execute_single(action_sym, arguments, version: 1, host: nil)
       arguments = [] if arguments.nil?
       Log.log.debug{"execute_single:#{action_sym}:#{arguments}"}

data/lib/aspera/ascp/installation.rb

@@ -294,12 +294,12 @@ module Aspera
       end
 
       # Retrieves ascp binary for current system architecture from URL or file
-      # @param url      [String] URL to SDK archive, or SpecialValues::DEF
-      # @param folder   [String] Destination folder path
-      # @param backup   [Bool]   If destination folder exists, then rename
-      # @param with_exe [Bool]   If false, only retrieves files, but do not generate or restrict access
-      # @param &block   [Proc]   A lambda that receives a file path from archive and tells destination sub folder(end with /) or file, or nil to not extract
-      # @return ascp version (from execution)
+      # @param url      [String]  URL to SDK archive, or SpecialValues::DEF
+      # @param folder   [String]  Destination folder path
+      # @param backup   [Boolean] If destination folder exists, then rename
+      # @param with_exe [Boolean] If false, only retrieves files, but do not generate or restrict access
+      # @param &block   [Proc]    A lambda that receives a file path from archive and tells destination sub folder(end with /) or file, or nil to not extract
+      # @return [Array] name, ascp version (from execution), folder
       def install_sdk(url: nil, version: nil, folder: nil, backup: true, with_exe: true, &block)
         url = sdk_url_for_platform(version: version) if url.nil? || url.eql?('DEF')
         folder = Products::Transferd.sdk_directory if folder.nil?
@@ -348,7 +348,7 @@ module Aspera
         sdk_name = 'IBM Aspera Transfer SDK'
         sdk_version = transferd_version || sdk_ascp_version
         File.write(File.join(folder, Products::Other::INFO_META_FILE), "<product><name>#{sdk_name}</name><version>#{sdk_version}</version></product>")
-        return sdk_name, sdk_version
+        return sdk_name, sdk_version, folder
       end
 
       attr_accessor :transferd_urls

data/lib/aspera/ascp/management.rb

@@ -5,8 +5,12 @@ require 'aspera/assert'
 module Aspera
   module Ascp
     # processing of ascp management port events
+    # Reference: `mgmtmess.c`
     class Management
-      # from https://www.google.com/search?q=FASP+error+codes
+      # References:
+      # https://www.google.com/search?q=FASP+error+codes
+      # https://www.ibm.com/support/pages/error-code-reference-tables
+      # mgmtmess.c : as_mgmt_err_is_retryable
       # Note that the fact that an error is retry-able is not internally defined by protocol, it's client-side responsibility
       # rubocop:disable Layout/FirstHashElementLineBreak
       ERRORS = {
@@ -289,7 +293,7 @@ module Aspera
       # cspell: enable
 
       class << self
-        # translate native event name to snake case
+        # Translate native event name to snake case
         def field_native_to_snake(name)
           case name
           when 'Elapsedusec' then 'elapsed_usec'
@@ -298,7 +302,7 @@ module Aspera
           end
         end
 
-        # translate snake case event name to native
+        # Translate snake case event name to native
         # @param name [String] Field name
         def field_snake_to_native(name)
           field = name.delete('_')
@@ -320,7 +324,7 @@ module Aspera
         end
 
         # Build command to send on management port
-        # @param data [Hash] e.g. {'type'=>'START','source'=>_path_,'destination'=>_path_}
+        # @param data [Hash] keys are snake case: e.g. {'type'=>'START','source'=>_path_,'destination'=>_path_}
         # @return [String] frame to send on management port
         def command_to_stream(data)
           data
@@ -339,7 +343,7 @@ module Aspera
       end
       attr_reader :last_event
 
-      # process line of mgt port event
+      # Process line of mgt port event
       # @param line [String] line of mgt port event
       # @return [Hash] event hash or nil if event is not yet complete
       def process_line(line)

data/lib/aspera/assert.rb

@@ -31,7 +31,7 @@ module Aspera
     end
 
     # Assert that a condition is true, else raise exception
-    # @param assertion [Bool]       Must be true
+    # @param assertion [TrueClass, FalseClass]       Must be true
     # @param info      [String,nil] Fixed message in case assert fails, else use `block`
     # @param type      [Exception,Symbol] Exception to raise, or Symbol for Log.log
     # @param block     [Proc]       Produces a string that describes the problem for complex messages
@@ -78,7 +78,7 @@ module Aspera
     end
 
     # Assert that value is one of the given values
-    # @param value  [any]              Value to check
+    # @param value  [Object]           Value to check
     # @param values [Array]            Accepted values
     # @param type   [Exception,Symbol] Exception to raise, or Symbol for Log.log
     # @param block  [Proc]             Additional description in front of message
@@ -91,7 +91,7 @@ module Aspera
     end
 
     # The value is not one of the expected values
-    # @param value  [any]              The wrong value
+    # @param value  [Object]           The wrong value
     # @param type   [Exception,Symbol] Exception to raise, or Symbol for Log.log
     # @param block  [Proc]             Additional description in front of message
     def error_unexpected_value(value, type: InternalError)

data/lib/aspera/cli/extended_value.rb

@@ -64,6 +64,15 @@ module Aspera
         def assert_no_value(value, ext_type)
           Aspera.assert(value.empty?, type: BadArgument){"no value allowed for extended value type: #{ext_type}"}
         end
+
+        def read_stdin(mode)
+          case mode
+          when '' then $stdin.read
+          when 'bin' then $stdin.binmode.read
+          when 'chomp' then $stdin.chomp
+          else raise BadArgument, "`stdin` supports only: '', 'bin' or 'chomp'"
+          end
+        end
       end
 
       private
@@ -87,8 +96,7 @@ module Aspera
           re:     lambda{ |i| Regexp.new(i, Regexp::MULTILINE)},
           ruby:   lambda{ |i| Environment.secure_eval(i, __FILE__, __LINE__)},
           secret: lambda{ |i| prompt = i.empty? ? 'secret' : i; $stdin.getpass("#{prompt}> ")}, # rubocop:disable Style/Semicolon
-          stdin:  lambda{ |i| ExtendedValue.assert_no_value(i, :stdin); $stdin.read}, # rubocop:disable Style/Semicolon
-          stdbin: lambda{ |i| ExtendedValue.assert_no_value(i, :stdbin); $stdin.binmode.read}, # rubocop:disable Style/Semicolon
+          stdin:  lambda{ |i| ExtendedValue.read_stdin(i)},
           yaml:   lambda{ |i| YAML.load(i)},
           zlib:   lambda{ |i| Zlib::Inflate.inflate(i)},
           extend: lambda{ |i| ExtendedValue.instance.evaluate_extend(i)}

data/lib/aspera/cli/formatter.rb

@@ -8,6 +8,7 @@ require 'aspera/environment'
 require 'aspera/log'
 require 'aspera/assert'
 require 'aspera/markdown'
+require 'aspera/dot_container'
 require 'terminal-table'
 require 'tty-spinner'
 require 'yaml'
@@ -64,9 +65,10 @@ module Aspera
           end
         end
 
+        # Give Markdown String, or matched data, return formatted string for terminal
         # used by spec_doc
         # @param match [MatchData,String]
-        def markdown(match)
+        def markdown_text(match)
           if match.is_a?(String)
             match = Markdown::FORMATS.match(match)
             Aspera.assert(match)
@@ -84,11 +86,11 @@ module Aspera
           end
         end
 
-        # replace empty values with a readable version on terminal
-        def enhance_display_values_hash(input_hash)
-          stack = [input_hash]
-          until stack.empty?
-            current = stack.pop
+        # Replace special values with a readable version on terminal
+        def replace_specific_for_terminal(input_hash)
+          hash_to_process = [input_hash]
+          until hash_to_process.empty?
+            current = hash_to_process.pop
             current.each do |key, value|
               case value
               when NilClass
@@ -100,73 +102,24 @@ module Aspera
               when Array
                 if value.empty?
                   current[key] = special_format('empty list')
+                elsif value.all?(String)
+                  current[key] = value.join(',')
                 else
                   value.each do |item|
-                    stack.push(item) if item.is_a?(Hash)
+                    hash_to_process.push(item) if item.is_a?(Hash)
                   end
                 end
               when Hash
                 if value.empty?
                   current[key] = special_format('empty dict')
                 else
-                  stack.push(value)
+                  hash_to_process.push(value)
                 end
               end
             end
           end
         end
 
-        # Given a list of string, display that list in a single cell
-        def list_to_string(list)
-          list.join(',')
-        end
-
-        # Build new prefix
-        def add_prefix(prefix, key)
-          [prefix, key].compact.join('.')
-        end
-
-        # Add elements of enumerator to the stack, in reverse order
-        def add_elements(stack, prefix, enum)
-          enum.reverse_each do |key, value|
-            stack.push([add_prefix(prefix, key), value])
-          end
-        end
-
-        # Flatten a Hash into single level hash
-        def flatten_hash(input)
-          Aspera.assert_type(input, Hash)
-          return input if input.empty?
-          flat = {}
-          # tail (pop,push) contains the next element to display
-          stack = [[nil, input]]
-          until stack.empty?
-            prefix, current = stack.pop
-            # empty things will be displayed as such
-            if current.respond_to?(:empty?) && current.empty?
-              flat[prefix] = current
-              next
-            end
-            case current
-            when Hash
-              add_elements(stack, prefix, current)
-            when Array
-              if current.none?{ |i| i.is_a?(Array) || i.is_a?(Hash)}
-                flat[prefix] = list_to_string(current.map(&:to_s))
-              elsif current.all?{ |i| i.is_a?(Hash) && i.keys == ['name']}
-                flat[prefix] = list_to_string(current.map{ |i| i['name']})
-              elsif current.all?{ |i| i.is_a?(Hash) && i.keys.sort == %w[name value]}
-                add_elements(stack, prefix, current.each_with_object({}){ |i, h| h[i['name']] = i['value']})
-              else
-                add_elements(stack, prefix, current.each_with_index.map{ |v, i| [i, v]})
-              end
-            else
-              flat[prefix] = current
-            end
-          end
-          flat
-        end
-
         def all_but(list)
           list = [list] unless list.is_a?(Array)
           return list.map{ |i| "#{FIELDS_LESS}#{i}"}.unshift(SpecialValues::ALL)
@@ -356,13 +309,13 @@ module Aspera
             if data.empty?
               display_message(:data, self.class.special_format('empty dict'))
             else
-              data = self.class.flatten_hash(data) if @options[:flat_hash]
+              data = DotContainer.new(data).to_dotted if @options[:flat_hash]
               display_table([data], compute_fields([data], fields), single: true)
             end
           when :object_list
             # :object_list is an Array of Hash, where key=column name
             Aspera.assert_array_all(data, Hash){'result'}
-            data = data.map{ |obj| self.class.flatten_hash(obj)} if @options[:flat_hash]
+            data = data.map{ |obj| DotContainer.new(obj).to_dotted} if @options[:flat_hash]
             display_table(data, compute_fields(data, fields), single: type.eql?(:single_object))
           when :value_list
             # :value_list is a simple array of values, name of column provided in `name`
@@ -474,7 +427,7 @@ module Aspera
           return
         end
         filter_columns_on_select(object_array)
-        object_array.each{ |i| self.class.enhance_display_values_hash(i)}
+        object_array.each{ |i| self.class.replace_specific_for_terminal(i)}
         # if table has only one element, and only one field, display the value
         if object_array.length == 1 && fields.length == 1
           Log.log.debug("display_table: single element, field: #{fields.first}")