aspera-cli 4.2.0 → 4.4.0

data/lib/aspera/cli/plugins/aoc.rb

@@ -5,6 +5,7 @@ require 'aspera/cli/transfer_agent'
 require 'aspera/aoc'
 require 'aspera/node'
 require 'aspera/persistency_action_once'
+require 'aspera/id_generator'
 require 'securerandom'
 require 'resolv'
 require 'date'
@@ -39,7 +40,6 @@ module Aspera
           self.options.add_opt_simple(:new_user_option,'new user creation option')
           self.options.add_opt_simple(:from_folder,'share to share source folder')
           self.options.add_opt_simple(:scope,'OAuth scope for AoC API calls')
-          self.options.add_opt_simple(:notify,'notify users that file was received')
           self.options.add_opt_boolean(:bulk,'bulk operation')
           self.options.add_opt_boolean(:default_ports,'use standard FASP ports or get from node api')
           self.options.set_option(:bulk,:no)
@@ -83,19 +83,29 @@ module Aspera
           return self.transfer.start(*@api_aoc.tr_spec(app,direction,node_file,ts_add))
         end
 
-        NODE4_COMMANDS=[ :browse, :find, :mkdir, :rename, :delete, :upload, :download, :transfer, :http_node_download, :v3, :file, :bearer_token_node ]
+        NODE4_COMMANDS=[ :browse, :find, :mkdir, :rename, :delete, :upload, :download, :transfer, :http_node_download, :v3, :file, :bearer_token_node, :node_info ]
 
         def execute_node_gen4_command(command_repo,top_node_file)
           case command_repo
           when :bearer_token_node
             thepath=self.options.get_next_argument('path')
             node_file = @api_aoc.resolve_node_file(top_node_file,thepath)
-            node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER, use_secret: false)
             return Main.result_status(node_api.oauth_token)
+          when :node_info
+            thepath=self.options.get_next_argument('path')
+            node_file = @api_aoc.resolve_node_file(top_node_file,thepath)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER, use_secret: false)
+            return {:type=>:single_object,:data=>{
+              url: node_file[:node_info]['url'],
+              username: node_file[:node_info]['access_key'],
+              password: node_api.oauth_token,
+              root_id: node_file[:file_id]
+              }}
           when :browse
             thepath=self.options.get_next_argument('path')
             node_file = @api_aoc.resolve_node_file(top_node_file,thepath)
-            node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
             file_info = node_api.read("files/#{node_file[:file_id]}")[:data]
             if file_info['type'].eql?('folder')
               result=node_api.read("files/#{node_file[:file_id]}/files",self.options.get_option(:value,:optional))
@@ -115,14 +125,14 @@ module Aspera
             containing_folder_path = thepath.split(AoC::PATH_SEPARATOR)
             new_folder=containing_folder_path.pop
             node_file = @api_aoc.resolve_node_file(top_node_file,containing_folder_path.join(AoC::PATH_SEPARATOR))
-            node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
             result=node_api.create("files/#{node_file[:file_id]}/files",{:name=>new_folder,:type=>:folder})[:data]
             return Main.result_status("created: #{result['name']} (id=#{result['id']})")
           when :rename
             thepath=self.options.get_next_argument('source path')
             newname=self.options.get_next_argument('new name')
             node_file = @api_aoc.resolve_node_file(top_node_file,thepath)
-            node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
             result=node_api.update("files/#{node_file[:file_id]}",{:name=>newname})[:data]
             return Main.result_status("renamed #{thepath} to #{newname}")
           when :delete
@@ -130,7 +140,7 @@ module Aspera
             return do_bulk_operation(thepath,'deleted','path') do |l_path|
               raise "expecting String (path), got #{l_path.class.name} (#{l_path})" unless l_path.is_a?(String)
               node_file = @api_aoc.resolve_node_file(top_node_file,l_path)
-              node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+              node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
               result=node_api.delete("files/#{node_file[:file_id]}")[:data]
               {'path'=>l_path}
             end
@@ -153,7 +163,7 @@ module Aspera
             client_node_file = @api_aoc.resolve_node_file(client_home_node_file,client_folder)
             server_node_file = @api_aoc.resolve_node_file(server_home_node_file,server_folder)
             # force node as transfer agent
-            @agents[:transfer].set_agent_instance(Fasp::Node.new(@api_aoc.get_node_api(client_node_file[:node_info],AoC::SCOPE_NODE_USER)))
+            @agents[:transfer].set_agent_instance(Fasp::Node.new(@api_aoc.get_node_api(client_node_file[:node_info],scope: AoC::SCOPE_NODE_USER)))
             # additional node to node TS info
             add_ts={
               'remote_access_key'   => server_node_file[:node_info]['access_key'],
@@ -191,14 +201,14 @@ module Aspera
             raise CliBadArgument,'one file at a time only in HTTP mode' if source_paths.length > 1
             file_name = source_paths.first['source']
             node_file = @api_aoc.resolve_node_file(top_node_file,File.join(source_folder,file_name))
-            node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
             node_api.call({:operation=>'GET',:subpath=>"files/#{node_file[:file_id]}/content",:save_to_file=>File.join(self.transfer.destination_folder('receive'),file_name)})
             return Main.result_status("downloaded: #{file_name}")
           when :v3
-            # Note: other "common" actions are unauthorized with user scope
+            # Note: other common actions are unauthorized with user scope
             command_legacy=self.options.get_next_command(Node::SIMPLE_ACTIONS)
             # TODO: shall we support all methods here ? what if there is a link ?
-            node_api=@api_aoc.get_node_api(top_node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(top_node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
             return Node.new(@agents.merge(skip_basic_auth_options: true, node_api: node_api)).execute_action(command_legacy)
           when :file
             file_path=self.options.get_option(:path,:optional)
@@ -207,21 +217,21 @@ module Aspera
             else
               {node_info: top_node_file[:node_info],file_id: self.options.get_option(:id,:mandatory)}
             end
-            node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+            node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
             command_node_file=self.options.get_next_command([:show,:permission,:modify])
             case command_node_file
             when :show
               items=node_api.read("files/#{node_file[:file_id]}")[:data]
               return {:type=>:single_object,:data=>items}
             when :modify
-              update_param=self.options.get_next_argument("update data (Hash)")
+              update_param=self.options.get_next_argument('update data (Hash)')
               res=node_api.update("files/#{node_file[:file_id]}",update_param)[:data]
               return {:type=>:single_object,:data=>res}
             when :permission
               command_perm=self.options.get_next_command([:list,:create])
               case command_perm
               when :list
-                # generic options : TODO: as arg ?
+                # generic options : TODO: as arg ? option_url_query
                 list_options||={'include'=>['[]','access_level','permission_count']}
                 # special value: ALL will show all permissions
                 if !VAL_ALL.eql?(node_file[:file_id])
@@ -229,11 +239,10 @@ module Aspera
                   list_options['file_id']=node_file[:file_id]
                   list_options['inherited']||=false
                 end
-                #option_url_query
                 items=node_api.read('permissions',list_options)[:data]
                 return {:type=>:object_list,:data=>items}
               when :create
-                #create_param=self.options.get_next_argument("creation data (Hash)")
+                #create_param=self.options.get_next_argument('creation data (Hash)')
                 set_workspace_info
                 access_id="ASPERA_ACCESS_KEY_ADMIN_WS_#{@workspace_id}"
                 node_file[:node_info]
@@ -256,14 +265,14 @@ module Aspera
                 return {:type=>:single_object,:data=>item}
               else raise "internal error:shall not reach here (#{command_perm})"
               end
-              raise "internal error:shall not reach here"
+              raise 'internal error:shall not reach here'
             else raise "internal error:shall not reach here (#{command_node_file})"
             end
-            raise "internal error:shall not reach here"
+            raise 'internal error:shall not reach here'
           when :permissions
 
           end # command_repo
-          raise "ERR"
+          raise 'ERR'
         end # execute_node_gen4_command
 
         # build constructor option list for AoC based on options of CLI
@@ -294,15 +303,15 @@ module Aspera
 
           ws_name=self.options.get_option(:workspace,:optional)
           if ws_name.nil?
-            Log.log.debug("using default workspace".green)
+            Log.log.debug('using default workspace'.green)
             if @default_workspace_id.eql?(nil)
-              raise CliError,"no default workspace defined for user, please specify workspace"
+              raise CliError,'no default workspace defined for user, please specify workspace'
             end
             # get default workspace
             @workspace_id=@default_workspace_id
           else
             # lookup another workspace
-            wss=@api_aoc.read("workspaces",{'q'=>ws_name})[:data]
+            wss=@api_aoc.read('workspaces',{'q'=>ws_name})[:data]
             wss=wss.select { |i| i['name'].eql?(ws_name) }
             case wss.length
             when 0
@@ -310,14 +319,14 @@ module Aspera
             when 1
               @workspace_id=wss.first['id']
             else
-              raise "unexpected case"
+              raise 'unexpected case'
             end
           end
           @workspace_data=@api_aoc.read("workspaces/#{@workspace_id}")[:data]
           Log.log.debug("workspace_id=#{@workspace_id},@workspace_data=#{@workspace_data}".red)
 
           @workspace_name||=@workspace_data['name']
-          Log.log.info("current workspace is "+@workspace_name.red)
+          Log.log.info('current workspace is '+@workspace_name.red)
 
           # display workspace
           self.format.display_status("Current Workspace: #{@workspace_name.red}#{@workspace_id == @default_workspace_id ? ' (default)' : ''}")
@@ -333,7 +342,7 @@ module Aspera
           end
           home_node_id||=@workspace_data['home_node_id']||@workspace_data['node_id']
           home_file_id||=@workspace_data['home_file_id']
-          raise "node_id must be defined" if home_node_id.to_s.empty?
+          raise 'node_id must be defined' if home_node_id.to_s.empty?
           @home_node_file={
             node_info: @api_aoc.read("nodes/#{home_node_id}")[:data],
             file_id: home_file_id
@@ -345,7 +354,7 @@ module Aspera
 
         def do_bulk_operation(ids_or_one,success_msg,id_result='id',&do_action)
           ids_or_one=[ids_or_one] unless self.options.get_option(:bulk)
-          raise "expecting Array" unless ids_or_one.is_a?(Array)
+          raise 'expecting Array' unless ids_or_one.is_a?(Array)
           result_list=[]
           ids_or_one.each do |id|
             one={id_result=>id}
@@ -401,7 +410,8 @@ module Aspera
 
         # private
         def option_url_query(default)
-          query=self.options.get_option(:query,:optional)||default
+          query=self.options.get_option(:query,:optional)
+          query=default if query.nil?
           Log.log.debug("Query=#{query}".bg_red)
           begin
             # check it is suitable
@@ -418,6 +428,37 @@ module Aspera
           end
         end
 
+        # Call @api_aoc.read with same parameters, but use paging if necessary to get all results
+        def read_with_paging(resource_class_path,base_query)
+          raise "Query must be Hash" unless base_query.is_a?(Hash)
+          # set default large page if user does not specify own parameters. AoC Caps to 1000 anyway
+          base_query['per_page']=1000 unless base_query.has_key?('per_page')
+          max_items=base_query[MAX_ITEMS]
+          base_query.delete(MAX_ITEMS)
+          max_pages=base_query[MAX_PAGES]
+          base_query.delete(MAX_PAGES)
+          item_list=[]
+          total_count=nil
+          current_page=base_query['page']
+          current_page=1 if current_page.nil?
+          page_count=0
+          loop do
+            query=base_query.clone
+            query['page']=current_page
+            result=@api_aoc.read(resource_class_path,query)
+            total_count=result[:http]['X-Total-Count']
+            page_count+=1
+            current_page+=1
+            add_items=result[:data]
+            break if add_items.empty?
+            # append new items to full list
+            item_list += add_items
+            break if !max_pages.nil? and page_count > max_pages
+            break if !max_items.nil? and item_list.count > max_items
+          end
+          return item_list,total_count
+        end
+
         def execute_admin_action
           @api_aoc.oauth.params[:scope]=AoC::SCOPE_FILES_ADMIN
           command_admin=self.options.get_next_command([ :ats, :resource, :usage_reports, :analytics, :subscription, :auth_providers ])
@@ -507,18 +548,18 @@ module Aspera
               when 'organizations'; c_user_info['organization_id']
               when 'users'; c_user_info['id']
               when 'nodes'; c_user_info['id']
-              else raise "organizations or users for option --name"
+              else raise 'organizations or users for option --name'
               end
               #
               filter=self.options.get_option(:query,:optional) || {}
-              raise "query must be Hash" unless filter.is_a?(Hash)
+              raise 'query must be Hash' unless filter.is_a?(Hash)
               filter['limit']||=100
               if self.options.get_option(:once_only,:mandatory)
                 saved_date=[]
                 startdate_persistency=PersistencyActionOnce.new(
                 manager: @agents[:persistency],
                 data: saved_date,
-                ids:  ['aoc_ana_date',self.options.get_option(:url,:mandatory),@workspace_name].push(filter_resource,filter_id))
+                ids: IdGenerator.from_list(['aoc_ana_date',self.options.get_option(:url,:mandatory),@workspace_name].push(filter_resource,filter_id)))
                 start_datetime=saved_date.first
                 stop_datetime=Time.now.utc.strftime('%FT%T.%LZ')
                 #Log.log().error("start: #{start_datetime}")
@@ -527,30 +568,23 @@ module Aspera
                 filter['start_time'] = start_datetime unless start_datetime.nil?
                 filter['stop_time'] = stop_datetime
               end
-              notification=self.options.get_option(:notify,:optional)
               events=analytics_api.read("#{filter_resource}/#{filter_id}/#{event_type}",option_url_query(filter))[:data][event_type]
               startdate_persistency.save unless startdate_persistency.nil?
-              if !notification.nil?
-                require 'erb'
-                events.each do |transfer|
-                  email_to_send={}
-                  notification.each do |k,v|
-                    email_to_send[k.to_sym]=ERB.new(v).result(binding)
-                  end
-                  Log.log().error("send email:   #{email_to_send}")
-                  self.config.send_email(email_to_send)
+              if !self.options.get_option(:notif_to,:optional).nil?
+                events.each do |tr_event|
+                  self.config.send_email_template({ev: tr_event})
                 end
               end
               return {:type=>:object_list,:data=>events}
             end
           when :resource
-            resource_type=self.options.get_next_argument('resource',[:self,:organization,:user,:group,:client,:contact,:dropbox,:node,:operation,:package,:saml_configuration, :workspace, :dropbox_membership,:short_link,:workspace_membership,:apps_new,:client_registration_token,:client_access_key,:kms_profile])
+            resource_type=self.options.get_next_argument('resource',[:self,:organization,:user,:group,:client,:contact,:dropbox,:node,:operation,:package,:saml_configuration, :workspace, :dropbox_membership,:short_link,:workspace_membership,:application,:client_registration_token,:client_access_key,:kms_profile])
             # get path on API
             resource_class_path=case resource_type
             when :self,:organization
-              "#{resource_type}"
-            when :apps_new
-              "admin/#{resource_type}"
+              resource_type
+            when :application
+              'admin/apps_new'
             when :dropbox
               resource_type.to_s+'es'
             when :client_registration_token,:client_access_key
@@ -579,13 +613,13 @@ module Aspera
                 res_id=@home_node_file[:node_info]['id']
               end
               if !res_name.nil?
-                Log.log.warn("name overrides id") unless res_id.nil?
+                Log.log.warn('name overrides id') unless res_id.nil?
                 matching=@api_aoc.read(resource_class_path,{:q=>res_name})[:data]
-                raise CliError,"no resource match name" if matching.empty?
+                raise CliError,'no resource match name' if matching.empty?
                 raise CliError,"several resources match name (#{matching.join(',')})" unless matching.length.eql?(1)
                 res_id=matching.first['id']
               end
-              raise CliBadArgument,"provide either id or name" if res_id.nil?
+              raise CliBadArgument,'provide either id or name' if res_id.nil?
               resource_instance_path="#{resource_class_path}/#{res_id}"
             end
             resource_instance_path=resource_class_path if singleton_object
@@ -595,26 +629,29 @@ module Aspera
               id_result='token' if resource_class_path.eql?('admin/client_registration_tokens')
               # TODO: report inconsistency: creation url is !=, and does not return id.
               resource_class_path='admin/client_registration/token' if resource_class_path.eql?('admin/client_registration_tokens')
-              list_or_one=self.options.get_next_argument("creation data (Hash)")
+              list_or_one=self.options.get_next_argument('creation data (Hash)')
               return do_bulk_operation(list_or_one,'created',id_result)do|params|
-                raise "expecting Hash" unless params.is_a?(Hash)
+                raise 'expecting Hash' unless params.is_a?(Hash)
                 @api_aoc.create(resource_class_path,params)[:data]
               end
             when :list
-              default_fields=['id','name']
-              list_query=nil
+              default_fields=['id']
+              default_query={}
               case resource_type
-              when :node; default_fields.push('host','access_key')
+              when :application; default_query={:organization_apps=>true};default_fields.push('app_type','app_name','available','direct_authorizations_allowed','workspace_authorizations_allowed')
+              when :client,:client_access_key,:dropbox,:group,:package,:saml_configuration,:workspace; default_fields.push('name')
+              when :client_registration_token; default_fields.push('value','data.client_subject_scopes','created_at')
+              when :contact; default_fields=['email','name','source_id','source_type']
+              when :node; default_fields.push('name','host','access_key')
               when :operation; default_fields=nil
-              when :contact; default_fields=["email","name","source_id","source_type"]
-              when :apps_new; list_query={:organization_apps=>true};default_fields=['app_type','available']
-              when :client_registration_token; default_fields=['id','value','data.client_subject_scopes','created_at']
+              when :short_link; default_fields.push('short_url','data.url_token_data.purpose')
+              when :user; default_fields.push('name','email')
               end
-              result=@api_aoc.read(resource_class_path,option_url_query(list_query))
-              count_msg="Items: #{result[:data].length}/#{result[:http]['X-Total-Count']}"
-              count_msg=count_msg.bg_red unless result[:data].length.eql?(result[:http]['X-Total-Count'].to_i)
+              item_list,total_count=read_with_paging(resource_class_path,option_url_query(default_query))
+              count_msg="Items: #{item_list.length}/#{total_count}"
+              count_msg=count_msg.bg_red unless item_list.length.eql?(total_count.to_i)
               self.format.display_status(count_msg)
-              return {:type=>:object_list,:data=>result[:data],:fields=>default_fields}
+              return {:type=>:object_list,:data=>item_list,:fields=>default_fields}
             when :show
               object=@api_aoc.read(resource_instance_path)[:data]
               fields=object.keys.select{|k|!k.eql?('certificate')}
@@ -644,8 +681,8 @@ module Aspera
             when :shared_folders
               read_params = case resource_type
               when :workspace;{'access_id'=>"ASPERA_ACCESS_KEY_ADMIN_WS_#{res_id}",'access_type'=>'user'}
-              when :node;{'include'=>['[]','access_level','permission_count'],'created_by_id'=>"ASPERA_ACCESS_KEY_ADMIN"}
-              else raise "error"
+              when :node;{'include'=>['[]','access_level','permission_count'],'created_by_id'=>'ASPERA_ACCESS_KEY_ADMIN'}
+              else raise 'error'
               end
               res_data=@api_aoc.read("#{resource_class_path}/#{res_id}/permissions",read_params)[:data]
               fields=case resource_type
@@ -661,7 +698,7 @@ module Aspera
               res_data=@api_aoc.read(resource_instance_path)[:data]
               node_file = @api_aoc.resolve_node_file({node_info: res_data, file_id: ak_data['root_file_id']},folder_path)
 
-              #node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+              #node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
               #file_info = node_api.read("files/#{node_file[:file_id]}")[:data]
 
               access_id="ASPERA_ACCESS_KEY_ADMIN_WS_#{@workspace_id}"
@@ -685,7 +722,7 @@ module Aspera
               create_data.deep_merge!(user_create_data)
               Log.dump(:data,create_data)
               raise :ERROR
-            else raise "unknown command"
+            else raise 'unknown command'
             end
           when :usage_reports
             return {:type=>:object_list,:data=>@api_aoc.read('usage_reports',{:workspace_id=>@workspace_id})[:data]}
@@ -716,7 +753,7 @@ module Aspera
             when :workspaces
               return {:type=>:object_list,:data=>@api_aoc.read('workspaces')[:data],:fields=>['id','name']}
               #              when :settings
-              #                return {:type=>:object_list,:data=>@api_aoc.read("client_settings/")[:data]}
+              #                return {:type=>:object_list,:data=>@api_aoc.read('client_settings/')[:data]}
             when :shared_inboxes
               query=option_url_query(nil)
               if query.nil?
@@ -761,7 +798,7 @@ module Aspera
               resolve_package_recipients(package_creation,'recipients')
               resolve_package_recipients(package_creation,'bcc_recipients')
 
-              #  create a new package with one file
+              #  create a new package container
               package_info=@api_aoc.create('packages',package_creation)[:data]
 
               #  get node information for the node on which package must be created
@@ -772,7 +809,7 @@ module Aspera
 
               # execute transfer
               node_file = {node_info: node_info, file_id: package_info['contents_file_id']}
-              # raise esception if at least one error
+              # raise exception if at least one error
               Main.result_transfer(transfer_start(AoC::PACKAGES_APP,'send',node_file,AoC.package_tags(package_info,'upload')))
               # return all info on package
               return { :type=>:single_object, :data =>package_info}
@@ -789,7 +826,7 @@ module Aspera
                 skip_ids_persistency=PersistencyActionOnce.new(
                 manager: @agents[:persistency],
                 data: skip_ids_data,
-                ids:  ['aoc_recv',self.options.get_option(:url,:mandatory),@workspace_id].push(*@persist_ids))
+                id: IdGenerator.from_list(['aoc_recv',self.options.get_option(:url,:mandatory),@workspace_id].push(*@persist_ids)))
               end
               if ids_to_download.eql?(VAL_ALL)
                 # get list of packages in inbox
@@ -810,21 +847,23 @@ module Aspera
                 add_ts={'paths'=>[{'source'=>'.'}]}
                 node_file = {node_info: node_info, file_id: package_info['contents_file_id']}
                 statuses=transfer_start(AoC::PACKAGES_APP,'receive',node_file,AoC.package_tags(package_info,'download').merge(add_ts))
-                result_transfer.push({'package'=>package_id,'status'=>statuses.map{|i|i.to_s}.join(',')})
+                result_transfer.push({'package'=>package_id,Main::STATUS_FIELD=>statuses})
                 # update skip list only if all transfer sessions completed
                 if TransferAgent.session_status(statuses).eql?(:success)
                   skip_ids_data.push(package_id)
                   skip_ids_persistency.save unless skip_ids_persistency.nil?
                 end
               end
-              return {:type=>:object_list,:data=>result_transfer}
+              return Main.result_transfer_multiple(result_transfer)
             when :show
               package_id=self.options.get_next_argument('package ID')
               package_info=@api_aoc.read("packages/#{package_id}")[:data]
               return { :type=>:single_object, :data =>package_info }
             when :list
-              # list all packages ('page'=>1,'per_page'=>10,)'sort'=>'-sent_at',
-              packages=@api_aoc.read('packages',{'archived'=>false,'exclude_dropbox_packages'=>true,'has_content'=>true,'received'=>true,'workspace_id'=>@workspace_id})[:data]
+              query=option_url_query({'archived'=>false,'exclude_dropbox_packages'=>true,'has_content'=>true,'received'=>true})
+              raise 'option must be Hash' unless query.is_a?(Hash)
+              query['workspace_id']||=@workspace_id
+              packages=@api_aoc.read('packages',query)[:data]
               return {:type=>:object_list,:data=>packages,:fields=>['id','name','bytes_transferred']}
             when :delete
               list_or_one=self.options.get_option(:id,:mandatory)
@@ -883,7 +922,7 @@ module Aspera
               end
               result=self.entity_action(@api_aoc,'short_links',nil,:id,'self')
               if result[:data].is_a?(Hash) and result[:data].has_key?('created_at') and result[:data]['resource_type'].eql?('UrlToken')
-                node_api=@api_aoc.get_node_api(node_file[:node_info],AoC::SCOPE_NODE_USER)
+                node_api=@api_aoc.get_node_api(node_file[:node_info],scope: AoC::SCOPE_NODE_USER)
                 # TODO: access level as arg
                 access_levels=Aspera::Node::ACCESS_LEVELS #['delete','list','mkdir','preview','read','rename','write']
                 perm_data={
@@ -907,9 +946,9 @@ module Aspera
               end
               return result
             end # files command
-            throw "Error: shall not reach this line"
+            throw 'Error: shall not reach this line'
           when :automation
-            Log.log.warn("BETA: work under progress")
+            Log.log.warn('BETA: work under progress')
             # automation api is not in the same place
             automation_rest_params=@api_aoc.params.clone
             automation_rest_params[:base_url].gsub!('/api/','/automation/')
@@ -932,9 +971,9 @@ module Aspera
                 wf_command=self.options.get_next_command([:list,:create,:show])
                 wf_id=self.options.get_option(:id,:mandatory)
                 step=automation_api.create('steps',{'workflow_id'=>wf_id})[:data]
-                automation_api.update("workflows/#{wf_id}",{'step_order'=>[step["id"]]})
-                action=automation_api.create('actions',{'step_id'=>step["id"],'type'=>'manual'})[:data]
-                automation_api.update("steps/#{step["id"]}",{'action_order'=>[action["id"]]})
+                automation_api.update("workflows/#{wf_id}",{'step_order'=>[step['id']]})
+                action=automation_api.create('actions',{'step_id'=>step['id'],'type'=>'manual'})[:data]
+                automation_api.update("steps/#{step['id']}",{'action_order'=>[action['id']]})
                 wf=automation_api.read("workflows/#{wf_id}")[:data]
                 return {:type=>:single_object,:data=>wf}
               end
@@ -950,7 +989,7 @@ module Aspera
           else
             raise "internal error: #{command}"
           end # action
-          raise RuntimeError, "internal error: command shall return"
+          raise RuntimeError, 'internal error: command shall return'
         end
 
         private :c_user_info,:aoc_params,:set_workspace_info,:set_home_node_file,:do_bulk_operation,:resolve_package_recipients,:option_url_query,:assert_public_link_types,:execute_admin_action