aspera-cli 4.15.0 → 4.17.0

data/lib/aspera/cli/plugins/preview.rb

@@ -7,18 +7,20 @@ require 'aspera/preview/options'
 require 'aspera/preview/utils'
 require 'aspera/preview/file_types'
 require 'aspera/preview/terminal'
-require 'aspera/fasp/transfer_spec'
+require 'aspera/transfer/spec'
 require 'aspera/persistency_action_once'
-require 'aspera/node'
+require 'aspera/api/node'
 require 'aspera/hash_ext'
 require 'aspera/timer_limiter'
 require 'aspera/id_generator'
+require 'aspera/log'
+require 'aspera/assert'
 require 'securerandom'
 
 module Aspera
   module Cli
     module Plugins
-      class Preview < Aspera::Cli::BasicAuthPlugin
+      class Preview < Cli::BasicAuthPlugin
         # special tag to identify transfers related to generator
         PREV_GEN_TAG = 'preview_generator'
         # defined by node API: suffix for folder containing previews
@@ -47,8 +49,8 @@ module Aspera
         attr_accessor :option_previews_folder
         attr_accessor :option_folder_reset_cache, :option_skip_folders, :option_overwrite, :option_file_access
 
-        def initialize(env)
-          super(env)
+        def initialize(**env)
+          super
           @skip_types = []
           @default_transfer_spec = nil
           # by default generate all supported formats (clone, as altered by options)
@@ -94,7 +96,7 @@ module Aspera
           end
 
           options.parse_options!
-          raise 'skip_folder shall be an Array, use @json:[...]' unless @option_skip_folders.is_a?(Array)
+          Aspera.assert_type(@option_skip_folders, Array){'skip_folder'}
           @tmp_folder = File.join(options.get_option(:temp_folder, mandatory: true), "#{TMP_DIR_PREFIX}.#{SecureRandom.uuid}")
           FileUtils.mkdir_p(@tmp_folder)
           Log.log.debug{"tmpdir: #{@tmp_folder}"}
@@ -104,7 +106,7 @@ module Aspera
           @skip_types = []
           value.split(',').each do |v|
             s = v.to_sym
-            raise "not supported: #{v}" unless Aspera::Preview::FileTypes::CONVERSION_TYPES.include?(s)
+            Aspera.assert_values(s, Aspera::Preview::FileTypes::CONVERSION_TYPES){'skip_types'}
             @skip_types.push(s)
           end
         end
@@ -126,7 +128,7 @@ module Aspera
         def get_folder_entries(file_id, request_args=nil)
           headers = {'Accept' => 'application/json'}
           headers['X-Aspera-Cache-Control'] = 'no-cache' if @option_folder_reset_cache.eql?(:header)
-          return @api_node.call({operation: 'GET', subpath: "files/#{file_id}/files", headers: headers, url_params: request_args})[:data]
+          return @api_node.call(operation: 'GET', subpath: "files/#{file_id}/files", headers: headers, url_params: request_args)[:data]
           # return @api_node.read("files/#{file_id}/files",request_args)[:data]
         end
 
@@ -151,11 +153,11 @@ module Aspera
           end
           return if events.empty?
           events.each do |event|
-            if event['data']['direction'].eql?(Fasp::TransferSpec::DIRECTION_RECEIVE) &&
+            if event['data']['direction'].eql?(Transfer::Spec::DIRECTION_RECEIVE) &&
                 event['data']['status'].eql?('completed') &&
                 event['data']['error_code'].eql?(0) &&
-                event['data'].dig('tags', Fasp::TransferSpec::TAG_RESERVED, PREV_GEN_TAG).nil?
-              folder_id = event.dig('data', 'tags', Fasp::TransferSpec::TAG_RESERVED, 'node', 'file_id')
+                event['data'].dig('tags', Transfer::Spec::TAG_RESERVED, PREV_GEN_TAG).nil?
+              folder_id = event.dig('data', 'tags', Transfer::Spec::TAG_RESERVED, 'node', 'file_id')
               folder_id ||= event.dig('data', 'file_id')
               if !folder_id.nil?
                 folder_entry = @api_node.read("files/#{folder_id}")[:data] rescue nil
@@ -189,7 +191,7 @@ module Aspera
             if event.dig('data', 'type').eql?('file')
               file_entry = @api_node.read("files/#{event['data']['id']}")[:data] rescue nil
               if !file_entry.nil? &&
-                  @option_skip_folders.select{|d|file_entry['path'].start_with?(d)}.empty?
+                  @option_skip_folders.none?{|d|file_entry['path'].start_with?(d)}
                 file_entry['parent_file_id'] = event['data']['parent_file_id']
                 if event['types'].include?('file.deleted')
                   Log.log.error('TODO'.red)
@@ -211,10 +213,10 @@ module Aspera
         end
 
         def do_transfer(direction, folder_id, source_filename, destination='/')
-          raise 'Internal ERROR' if destination.nil? && direction.eql?(Fasp::TransferSpec::DIRECTION_RECEIVE)
+          Aspera.assert(!(destination.nil? && direction.eql?(Transfer::Spec::DIRECTION_RECEIVE)))
           t_spec = @api_node.transfer_spec_gen4(folder_id, direction, {
             'paths' => [{'source' => source_filename}],
-            'tags'  => {Fasp::TransferSpec::TAG_RESERVED => {PREV_GEN_TAG => true}}
+            'tags'  => {Transfer::Spec::TAG_RESERVED => {PREV_GEN_TAG => true}}
           })
           # force destination, need to set this in transfer agent else it gets overwritten, not do: t_spec['destination_root']=destination
           transfer.option_transfer_spec_deep_merge({'destination_root' => destination})
@@ -316,7 +318,7 @@ module Aspera
           if @access_remote
             raise 'missing parent_file_id in entry' if entry['parent_file_id'].nil?
             #  download original file to temp folder
-            do_transfer(Fasp::TransferSpec::DIRECTION_RECEIVE, entry['parent_file_id'], entry['name'], @tmp_folder)
+            do_transfer(Transfer::Spec::DIRECTION_RECEIVE, entry['parent_file_id'], entry['name'], @tmp_folder)
           end
           Log.log.info{"source: #{entry['id']}: #{entry['path']}"}
           gen_infos.each do |gen_info|
@@ -324,7 +326,7 @@ module Aspera
           end
           if @access_remote
             # upload
-            do_transfer(Fasp::TransferSpec::DIRECTION_SEND, @previews_folder_entry['id'], local_entry_preview_dir)
+            do_transfer(Transfer::Spec::DIRECTION_SEND, @previews_folder_entry['id'], local_entry_preview_dir)
             # cleanup after upload
             FileUtils.rm_rf(local_entry_preview_dir)
             File.delete(File.join(@tmp_folder, entry['name']))
@@ -401,8 +403,8 @@ module Aspera
           command = options.get_next_command(ACTIONS)
           unless %i[check test show].include?(command)
             # this will use node api
-            @api_node = Aspera::Node.new(params: basic_auth_params)
-            @transfer_server_address = URI.parse(@api_node.params[:base_url]).host
+            @api_node = Api::Node.new(**basic_auth_params)
+            @transfer_server_address = URI.parse(@api_node.base_url).host
             # get current access key
             @access_key_self = @api_node.read('access_keys/self')[:data]
             # TODO: check events is activated here:
@@ -420,13 +422,13 @@ module Aspera
               raise Cli::Error, "Folder #{@option_previews_folder} does not exist on node. " \
                 'Please create it in the storage root, or specify an alternate name.' if @previews_folder_entry.nil?
             else
-              raise 'only local storage allowed in this mode' unless @access_key_self['storage']['type'].eql?('local')
+              Aspera.assert(@access_key_self['storage']['type'].eql?('local')){'only local storage allowed in this mode'}
               @local_storage_root = @access_key_self['storage']['path']
               # TODO: option to override @local_storage_root='xxx'
               @local_storage_root = @local_storage_root[PVCL_LOCAL_STORAGE.length..-1] if @local_storage_root.start_with?(PVCL_LOCAL_STORAGE)
               # TODO: windows could have "C:" ?
-              raise "not local storage: #{@local_storage_root}" unless @local_storage_root.start_with?('/')
-              raise Cli::Error, "Local storage root folder #{@local_storage_root} does not exist." unless File.directory?(@local_storage_root)
+              Aspera.assert(@local_storage_root.start_with?('/')){"not local storage: #{@local_storage_root}"}
+              Aspera.assert(File.directory?(@local_storage_root), exception_class: Cli::Error){"Local storage root folder #{@local_storage_root} does not exist."}
               @local_preview_folder = File.join(@local_storage_root, @option_previews_folder)
               raise Cli::Error, "Folder #{@local_preview_folder} does not exist locally. " \
                 'Please create it, or specify an alternate name.' unless File.directory?(@local_preview_folder)
@@ -435,7 +437,7 @@ module Aspera
               Log.log.debug{"marker file: #{marker_file}"}
               if File.exist?(marker_file)
                 ak = File.read(marker_file).chomp
-                raise "mismatch access key in #{marker_file}: contains #{ak}, using #{@access_key_self['id']}" unless @access_key_self['id'].eql?(ak)
+                Aspera.assert(@access_key_self['id'].eql?(ak)){"mismatch access key in #{marker_file}: contains #{ak}, using #{@access_key_self['id']}"}
               else
                 File.write(marker_file, @access_key_self['id'])
               end
@@ -459,15 +461,15 @@ module Aspera
               else
                 @api_node.read("files/#{scan_id}")[:data]
               end
-            @filter_block = Aspera::Node.file_matcher_from_argument(options)
+            @filter_block = Api::Node.file_matcher_from_argument(options)
             scan_folder_files(folder_info, scan_path)
             return Main.result_status('scan finished')
           when :events, :trevents
-            @filter_block = Aspera::Node.file_matcher_from_argument(options)
+            @filter_block = Api::Node.file_matcher_from_argument(options)
             iteration_persistency = nil
             if options.get_option(:once_only, mandatory: true)
               iteration_persistency = PersistencyActionOnce.new(
-                manager: @agents[:persistency],
+                manager: persistency,
                 data:    [],
                 id:      IdGenerator.from_list([
                   'preview_iteration',
@@ -477,7 +479,7 @@ module Aspera
                 ]))
             end
             # call processing method specified by command line command
-            send("process_#{command}", iteration_persistency)
+            send(:"process_#{command}", iteration_persistency)
             return Main.result_status("#{command} finished")
           when :check
             return Main.result_status('Tools validated')
@@ -499,8 +501,8 @@ module Aspera
         ensure
           Log.log.debug{"cleaning up temp folder #{@tmp_folder}"}
           FileUtils.rm_rf(@tmp_folder)
-        end # execute_action
-      end # Preview
-    end # Plugins
-  end # Cli
-end # Aspera
+        end
+      end
+    end
+  end
+end

data/lib/aspera/cli/plugins/server.rb

@@ -3,10 +3,12 @@
 # cspell:ignore ascmd zmode zuid zgid fasping
 require 'aspera/cli/basic_auth_plugin'
 require 'aspera/cli/sync_actions'
-require 'aspera/fasp/transfer_spec'
+require 'aspera/transfer/spec'
 require 'aspera/ascmd'
 require 'aspera/ssh'
 require 'aspera/nagios'
+require 'aspera/log'
+require 'aspera/assert'
 require 'tempfile'
 require 'open3'
 
@@ -14,7 +16,7 @@ module Aspera
   module Cli
     module Plugins
       # implement basic remote access with FASP/SSH
-      class Server < Aspera::Cli::BasicAuthPlugin
+      class Server < Cli::BasicAuthPlugin
         include SyncActions
         SSH_SCHEME = 'ssh'
         LOCAL_SCHEME = 'local'
@@ -51,27 +53,27 @@ module Aspera
               [address_or_url]
             else
               [
-                "ssh://#{address_or_url}:33001",
-                "ssh://#{address_or_url}:22"
+                "#{SSH_SCHEME}://#{address_or_url}:33001",
+                "#{SSH_SCHEME}://#{address_or_url}:22"
               ]
               # wss not practical as it requires a token
             end
-
+            error = nil
             urls.each do |base_url|
               server_uri = URI.parse(base_url)
               Log.log.debug{"URI=#{server_uri}, host=#{server_uri.hostname}, port=#{server_uri.port}, scheme=#{server_uri.scheme}"}
               next unless server_uri.scheme.eql?(SSH_SCHEME)
-              begin
-                socket = TCPSocket.new(server_uri.hostname, server_uri.port)
-                socket.puts('SSH-2.0-Ascli_0.0')
-                version = socket.gets.chomp
-                if version.match?(/^SSH-2.0-/)
-                  return {version: version.gsub(/^SSH-2.0-/, ''), url: base_url}
-                end
-              rescue StandardError => e
-                Log.log.debug{"detect error: #{e}"}
+              socket = TCPSocket.new(server_uri.hostname, server_uri.port)
+              socket.puts('SSH-2.0-Ascli_0.0')
+              version = socket.gets.chomp
+              if version.match?(/^SSH-2.0-/)
+                return {version: version.gsub(/^SSH-2.0-/, ''), url: base_url}
               end
+            rescue StandardError => e
+              error = e
+              Log.log.debug{"detect error: #{e}"}
             end
+            raise error if error
             return nil
           end
 
@@ -88,8 +90,8 @@ module Aspera
           end
         end
 
-        def initialize(env)
-          super(env)
+        def initialize(**env)
+          super
           options.declare(:ssh_keys, 'SSH key path list (Array or single)')
           options.declare(:passphrase, 'SSH private key passphrase')
           options.declare(:ssh_options, 'SSH options', types: Hash, default: {})
@@ -125,14 +127,14 @@ module Aspera
           if !server_uri.scheme.eql?(SSH_SCHEME)
             Log.log.warn('URL scheme is https but no token was provided in transfer spec.')
             Log.log.warn("If you want to access the server, not using WSS for session, then use a URL with scheme \"#{SSH_SCHEME}\" and proper SSH port")
-            assumed_url = "#{SSH_SCHEME}://#{server_transfer_spec['remote_host']}:#{Aspera::Fasp::TransferSpec::SSH_PORT}"
+            assumed_url = "#{SSH_SCHEME}://#{server_transfer_spec['remote_host']}:#{Transfer::Spec::SSH_PORT}"
             Log.log.warn{"Assuming proper URL is: #{assumed_url}"}
             server_uri = URI.parse(assumed_url)
           end
           # Scheme is SSH
           if options.get_option(:username).nil?
-            options.set_option(:username, Aspera::Fasp::TransferSpec::ACCESS_KEY_TRANSFER_USER)
-            Log.log.info{"No username provided: Assuming default transfer user: #{Aspera::Fasp::TransferSpec::ACCESS_KEY_TRANSFER_USER}"}
+            options.set_option(:username, Transfer::Spec::ACCESS_KEY_TRANSFER_USER)
+            Log.log.info{"No username provided: Assuming default transfer user: #{Transfer::Spec::ACCESS_KEY_TRANSFER_USER}"}
           end
           server_transfer_spec['remote_user'] = options.get_option(:username, mandatory: true)
           if !server_uri.port.nil?
@@ -148,16 +150,15 @@ module Aspera
           end
           ssh_key_list = options.get_option(:ssh_keys)
           if !ssh_key_list.nil?
-            raise 'Expecting single value or array for ssh_keys' unless ssh_key_list.is_a?(Array) || ssh_key_list.is_a?(String)
             ssh_key_list = [ssh_key_list] if ssh_key_list.is_a?(String)
+            Aspera.assert_type(ssh_key_list, Array){'ssh_keys'}
+            Aspera.assert(ssh_key_list.all?(String))
             ssh_key_list.map!{|p|File.expand_path(p)}
             Log.log.debug{"SSH keys=#{ssh_key_list}"}
             if !ssh_key_list.empty?
               @ssh_opts[:keys] = ssh_key_list
-              server_transfer_spec['EX_ssh_key_paths'] = ssh_key_list
-              ssh_key_list.each do |k|
-                Log.log.warn{"No such key file: #{k}"} unless File.exist?(k)
-              end
+              server_transfer_spec['ssh_private_key'] = File.read(ssh_key_list.first)
+              Log.log.warn{'Using only first SSH key for transfers'} unless ssh_key_list.length.eql?(1)
               cred_set = true
             end
           end
@@ -175,7 +176,7 @@ module Aspera
         def execute_transfer(command, transfer_spec)
           case command
           when :upload, :download
-            Fasp::TransferSpec.action_to_direction(transfer_spec, command)
+            Transfer::Spec.action_to_direction(transfer_spec, command)
             return Main.result_transfer(transfer.start(transfer_spec))
           when :sync
             # lets ignore the arguments provided by execute_sync_action, we just give the transfer spec
@@ -186,7 +187,7 @@ module Aspera
         # actions without ascmd
         BASE_ACTIONS = %i[health].concat(TRANSFER_COMMANDS).freeze
         # all actions
-        ACTIONS = [BASE_ACTIONS, Aspera::AsCmd::OPERATIONS, ASCMD_ALIASES.keys].flatten.freeze
+        ACTIONS = [BASE_ACTIONS, AsCmd::OPERATIONS, ASCMD_ALIASES.keys].flatten.freeze
 
         def execute_action
           server_transfer_spec = options_to_base_transfer_spec
@@ -225,16 +226,16 @@ module Aspera
               else
                 nagios.add_critical('transfer', statuses.reject{|i|i.eql?(:success)}.first.to_s)
               end
-            else raise 'ERROR'
+            else Aspera.error_unexpected_value(command_nagios)
             end
             return nagios.result
           when *TRANSFER_COMMANDS
             return execute_transfer(command, server_transfer_spec)
-          when *Aspera::AsCmd::OPERATIONS
+          when *AsCmd::OPERATIONS
             command_arguments = options.get_next_argument('ascmd command arguments', expected: :multiple, mandatory: false)
-            ascmd = Aspera::AsCmd.new(ascmd_executor)
+            ascmd = AsCmd.new(ascmd_executor)
             begin
-              result = ascmd.send(:execute_single, command, command_arguments)
+              result = ascmd.execute_single(command, command_arguments)
               case command
               when :mkdir, :mv, :cp, :rm
                 return Main.result_success
@@ -245,10 +246,10 @@ module Aspera
               when :du, :md5sum, :info
                 return {type: :single_object, data: result.stringify_keys}
               end
-            rescue Aspera::AsCmd::Error => e
+            rescue AsCmd::Error => e
               raise Cli::BadArgument, e.extended_message
             end
-          else raise 'internal error: unexpected action'
+          else Aspera.error_unreachable_line
           end
         end # execute_action
       end # Server

data/lib/aspera/cli/plugins/shares.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 require 'aspera/cli/plugins/node'
-
+require 'aspera/assert'
 module Aspera
   module Cli
     module Plugins
       # Plugin for Aspera Shares v1
-      class Shares < Aspera::Cli::BasicAuthPlugin
+      class Shares < Cli::BasicAuthPlugin
         API_BASE = 'node_api'
         class << self
           def detect(address_or_url)
@@ -24,7 +24,7 @@ module Aspera
             end
             return nil unless found
             version = 'unknown'
-            test_page = api.call({ operation: 'GET', subpath: 'login' })
+            test_page = api.call(operation: 'GET', subpath: 'login')
             if (m = test_page[:http].body.match(/\(v(1\..*)\)/))
               version = m[1]
             end
@@ -47,10 +47,8 @@ module Aspera
           end
         end
 
-        def initialize(env)
-          super(env)
-          options.declare(:type, 'Type of user/group for operations', values: %i[any local ldap saml], default: :any)
-          options.parse_options!
+        def initialize(**env)
+          super
         end
 
         SAML_IMPORT_MANDATORY = %w[id name_id].freeze
@@ -81,66 +79,74 @@ module Aspera
           when :repository, :files
             api_shares_node = basic_auth_api(API_BASE)
             repo_command = options.get_next_command(Node::COMMANDS_SHARES)
-            return Node.new(@agents, api: api_shares_node).execute_action(repo_command)
+            return Node.new(**init_params, api: api_shares_node).execute_action(repo_command)
           when :admin
             api_shares_admin = basic_auth_api('api/v1')
-            admin_command = options.get_next_command(%i[user group share node].freeze)
+            admin_command = options.get_next_command(%i[node share transfer_settings user group].freeze)
             case admin_command
             when :node
               return entity_action(api_shares_admin, 'data/nodes')
+            when :share
+              share_command = options.get_next_command(%i[user_permissions group_permissions].concat(Plugin::ALL_OPS))
+              case share_command
+              when *Plugin::ALL_OPS
+                return entity_command(share_command, api_shares_admin, 'data/shares')
+                # return {type: :object_list, data: all_shares, fields: %w[id name status status_message]}
+              when :user_permissions, :group_permissions
+                share_id = instance_identifier
+                return entity_action(api_shares_admin, "data/shares/#{share_id}/#{share_command}")
+              end
+            when :transfer_settings
+              xfer_settings_command = options.get_next_command(%i[show modify])
+              return entity_command(xfer_settings_command, api_shares_admin, 'data/transfer_settings', is_singleton: true)
             when :user, :group
               entity_type = admin_command
-              entities_location = options.get_option(:type, mandatory: true)
-              entities_path = "data/#{entities_location}_#{entity_type}s"
+              entities_location = options.get_next_command(%i[all local ldap saml])
+              entities_prefix = entities_location.eql?(:all) ? '' : "#{entities_location}_"
+              entities_path = "data/#{entities_prefix}#{entity_type}s"
               entity_action = nil
               case entities_location
-              when :any
-                entities_path = "data/#{entity_type}s"
+              when :all
                 entity_action = %i[list show delete]
                 entity_action.concat(USR_GRP_SETTINGS)
                 entity_action.push(:users) if entity_type.eql?(:group)
                 entity_action.freeze
               when :local
-                entity_action = %i[list show create modify delete].freeze
+                entity_action = %i[list show delete create modify]
+                entity_action.push(:users) if entity_type.eql?(:group)
+                entity_action.freeze
               when :ldap
                 entity_action = %i[add].freeze
               when :saml
                 entity_action = %i[import].freeze
               end
               entity_verb = options.get_next_command(entity_action)
-              # entity_path = "#{entities_path}/#{instance_identifier}" if %i[app_authorizations share_permissions].include?(entity_verb)
               case entity_verb
-              when *Plugin::ALL_OPS
+              when *Plugin::ALL_OPS # list, show, delete, create, modify
                 display_fields = entity_type.eql?(:user) ? %w[id username first_name last_name email] : nil
-                display_fields.push(:directory_user) if entity_type.eql?(:user) && entities_location.eql?(:any)
+                display_fields.push(:directory_user) if entity_type.eql?(:user) && entities_location.eql?(:all)
                 return entity_command(entity_verb, api_shares_admin, entities_path, display_fields: display_fields)
-              when :import
+              when *USR_GRP_SETTINGS # transfer_settings, app_authorizations, share_permissions
+                group_id = instance_identifier
+                entities_path = "#{entities_path}/#{group_id}/#{entity_verb}"
+                return entity_action(api_shares_admin, entities_path, is_singleton: !entity_verb.eql?(:share_permissions))
+              when :import # saml
                 return do_bulk_operation(command: entity_verb, descr: 'user information') do |entity_parameters|
                   entity_parameters = entity_parameters.transform_keys{|k|k.gsub(/\s+/, '_').downcase}
-                  raise 'expecting Hash' unless entity_parameters.is_a?(Hash)
+                  Aspera.assert_type(entity_parameters, Hash)
                   SAML_IMPORT_MANDATORY.each{|p|raise "missing mandatory field: #{p}" if entity_parameters[p].nil?}
                   entity_parameters.each_key do |p|
                     raise "unsupported field: #{p}, use: #{SAML_IMPORT_ALLOWED.join(',')}" unless SAML_IMPORT_ALLOWED.include?(p)
                   end
                   api_shares_admin.create("#{entities_path}/import", entity_parameters)[:data]
                 end
-              when :add
+              when :add # ldap
                 return do_bulk_operation(command: entity_verb, descr: "#{entity_type} name", values: String) do |entity_name|
                   api_shares_admin.create(entities_path, {entity_type=>entity_name})[:data]
                 end
-              when *USR_GRP_SETTINGS
-                group_id = instance_identifier
-                entities_path = "#{entities_path}/#{group_id}/#{entity_verb}"
-                return entity_action(api_shares_admin, entities_path, is_singleton: !entity_verb.eql?(:share_permissions))
-              end
-            when :share
-              share_command = options.get_next_command(%i[user_permissions group_permissions].concat(Plugin::ALL_OPS))
-              case share_command
-              when *Plugin::ALL_OPS
-                return entity_command(share_command, api_shares_admin, 'data/shares')
-                # return {type: :object_list, data: all_shares, fields: %w[id name status status_message]}
-              when :user_permissions, :group_permissions
-                return entity_action(api_shares_admin, "data/shares/#{instance_identifier}/#{share_command}")
+              when :users # group
+                return entity_action(api_shares_admin, "#{entities_path}/#{instance_identifier}/#{entities_prefix}users")
+              else Aspera.error_unexpected_value(entity_verb)
               end
             end
           end

data/lib/aspera/cli/sync_actions.rb

@@ -1,13 +1,14 @@
 # frozen_string_literal: true
 
-require 'aspera/sync'
+require 'aspera/transfer/sync'
+require 'aspera/assert'
 
 module Aspera
   module Cli
     # Module for sync actions
     module SyncActions
       SIMPLE_ARGUMENTS_SYNC = {
-        direction:  Aspera::Sync::DIRECTIONS,
+        direction:  Transfer::Sync::DIRECTIONS,
         local_dir:  String,
         remote_dir: String
       }.stringify_keys.freeze
@@ -19,8 +20,7 @@ module Aspera
       end
 
       def execute_sync_action(&block)
-        # options = Aspera::Cli::Manager.new
-        raise 'Internal Error: No block given' unless block
+        Aspera.assert(block){'No block given'}
         command = options.get_next_command(%i[start admin])
         # try to get 3 arguments as simple arguments
         case command
@@ -45,13 +45,13 @@ module Aspera
               :sync_info,
               mandatory: false,
               default: {'sessions' => [{'name' => File.basename(simple_session_args['local_dir'])}]})
-            raise "sync_info shall be a Hash with key 'sessions' with Array of Hash: #{async_params}" unless async_params.is_a?(Hash) &&
-              async_params['sessions']&.is_a?(Array) &&
-              async_params['sessions'].first.is_a?(Hash)
+            Aspera.assert_type(async_params, Hash){'sync_info'}
+            Aspera.assert_type(async_params['sessions'], Array){'sync_info[sessions]'}
+            Aspera.assert_type(async_params['sessions'].first, Hash){'sync_info[sessions][0]'}
             async_params['sessions'].first.merge!(simple_session_args)
           end
           Log.log.debug{Log.dump('async_params', async_params)}
-          Aspera::Sync.start(async_params, &block)
+          Transfer::Sync.start(async_params, &block)
           return Main.result_success
         when :admin
           command2 = options.get_next_command([:status])
@@ -59,7 +59,7 @@ module Aspera
           when :status
             sync_session_name = options.get_next_argument('name of sync session', mandatory: false, type: String)
             async_params = options.get_option(:sync_info, mandatory: true)
-            return {type: :single_object, data: Aspera::Sync.admin_status(async_params, sync_session_name)}
+            return {type: :single_object, data: Transfer::Sync.admin_status(async_params, sync_session_name)}
           end # command2
         end # command
       end # execute_action