aspera-cli 4.0.0.pre3 → 4.2.1

data/lib/aspera/cli/plugins/server.rb

@@ -62,7 +62,7 @@ module Aspera
           end.select{|i|!i.nil?}
         end
 
-        ACTIONS=[:nagios,:nodeadmin,:userdata,:configurator,:ctl,:download,:upload,:browse,:delete,:rename].concat(Aspera::AsCmd::OPERATIONS)
+        ACTIONS=[:health,:nodeadmin,:userdata,:configurator,:ctl,:download,:upload,:browse,:delete,:rename].concat(Aspera::AsCmd::OPERATIONS)
 
         def execute_action
           server_uri=URI.parse(self.options.get_option(:url,:mandatory))
@@ -93,12 +93,14 @@ module Aspera
               ssh_keys=[ssh_keys] if ssh_keys.is_a?(String)
               ssh_keys.map!{|p|File.expand_path(p)}
               Log.log.debug("ssh keys=#{ssh_keys}")
-              ssh_options[:keys]=ssh_keys
-              server_transfer_spec['EX_ssh_key_paths']=ssh_keys
-              ssh_keys.each do |k|
-                Log.log.warn("no such key file: #{k}") unless File.exist?(k)
+              if !ssh_keys.empty?
+                ssh_options[:keys]=ssh_keys
+                server_transfer_spec['EX_ssh_key_paths']=ssh_keys
+                ssh_keys.each do |k|
+                  Log.log.warn("no such key file: #{k}") unless File.exist?(k)
+                end
+                cred_set=true
               end
-              cred_set=true
             end
             raise 'either password or key must be provided' if !cred_set
             shell_executor=Ssh.new(server_transfer_spec['remote_host'],server_transfer_spec['remote_user'],ssh_options)
@@ -114,9 +116,9 @@ module Aspera
           command=:rm if command.eql?(:delete)
           command=:mv if command.eql?(:rename)
           case command
-          when :nagios
+          when :health
             nagios=Nagios.new
-            command_nagios=self.options.get_next_command([ :app_services, :transfer ])
+            command_nagios=self.options.get_next_command([ :app_services, :transfer, :asctlstatus ])
             case command_nagios
             when :app_services
               # will not work with aspshell, requires Linux/bash
@@ -145,6 +147,19 @@ module Aspera
               else
                 nagios.add_critical('transfer',statuses.select{|i|!i.eql?(:success)}.first.to_s)
               end
+            when :asctlstatus
+              realcmd='asctl'
+              prefix=self.options.get_option(:cmd_prefix,:optional)
+              realcmd="#{prefix}#{realcmd} all:status" unless prefix.nil?
+              result=shell_executor.execute(realcmd.split(' '))
+              data=asctl_parse(result)
+              data.each do |i|
+                if i['state'].eql?('running')
+                  nagios.add_ok(i['process'],i['state'])
+                else
+                  nagios.add_critical(i['process'],i['state'])
+                end
+              end
             else raise "ERROR"
             end
             return nagios.result

data/lib/aspera/cli/transfer_agent.rb

@@ -10,7 +10,7 @@ module Aspera
   module Cli
     # The Transfer agent is a common interface to start a transfer using
     # one of the supported transfer agents
-    # provides CLI options to select one of the transfer agents (fasp client)
+    # provides CLI options to select one of the transfer agents (FASP/ascp client)
     class TransferAgent
       # special value for --sources : read file list from arguments
       FILE_LIST_FROM_ARGS='@args'
@@ -22,7 +22,7 @@ module Aspera
         @opt_mgr=cli_objects[:options]
         @config=cli_objects[:config]
         # transfer spec overrides provided on command line
-        @transfer_spec_cmdline={}
+        @transfer_spec_cmdline={"create_dir"=>true}
         # the currently selected transfer agent
         @agent=nil
         @progress_listener=Listener::ProgressMulti.new
@@ -45,6 +45,7 @@ module Aspera
 
       def option_transfer_spec; @transfer_spec_cmdline; end
 
+      # multiple option are merged
       def option_transfer_spec=(value); @transfer_spec_cmdline.merge!(value); end
 
       def option_transfer_spec_deep_merge(ts); @transfer_spec_cmdline.deep_merge!(ts); end
@@ -75,7 +76,7 @@ module Aspera
         when :connect
           new_agent=Fasp::Connect.new
         when :node
-          # way for code to setup alternate node api in avance
+          # way for code to setup alternate node api in advance
           # support: @preset:<name>
           # support extended values
           node_config=@opt_mgr.get_option(:transfer_info,:optional)
@@ -118,7 +119,7 @@ module Aspera
           aoc_config[:private_key]=ExtendedValue.instance.evaluate(aoc_config[:private_key])
           new_agent=Fasp::Aoc.new(aoc_config)
         else
-          raise "INTERNAL ERROR"
+          raise "Unexpected transfer agent type: #{agent_type}"
         end
         set_agent_instance(new_agent)
         return nil
@@ -178,9 +179,9 @@ module Aspera
           # when providing a list, just specify source
           @transfer_paths=file_list.map{|i|{'source'=>i}}
         when :pair
-          raise CliBadArgument,"whe using pair, provide even number of paths: #{file_list.length}" unless file_list.length.even?
+          raise CliBadArgument,"When using pair, provide an even number of paths: #{file_list.length}" unless file_list.length.even?
           @transfer_paths=file_list.each_slice(2).to_a.map{|s,d|{'source'=>s,'destination'=>d}}
-        else raise "ERROR"
+        else raise "Unsupported src_type"
         end
         Log.log.debug("paths=#{@transfer_paths}")
         return @transfer_paths

data/lib/aspera/cli/version.rb

@@ -1,5 +1,5 @@
 module Aspera
   module Cli
-    VERSION = "4.0.0.pre3"
+    VERSION = "4.2.1"
   end
 end

data/lib/aspera/cos_node.rb

@@ -5,46 +5,51 @@ require 'xmlsimple'
 module Aspera
   class CosNode < Rest
     attr_reader :add_ts
-    def initialize(bucket_name,storage_endpoint,instance_id,api_key,auth_url='https://iam.cloud.ibm.com/identity')
+    IBM_CLOUD_TOKEN_URL='https://iam.cloud.ibm.com/identity'
+    def initialize(bucket_name,storage_endpoint,instance_id,api_key,auth_url=IBM_CLOUD_TOKEN_URL)
+      @auth_url=auth_url
+      @api_key=api_key
       s3_api=Aspera::Rest.new({
-        :base_url => storage_endpoint,
-        :not_auth_codes => ['401','403'],
-        :headers  => {'ibm-service-instance-id' => instance_id},
-        :auth     => {
-        :type       => :oauth2,
-        :base_url   => auth_url,
-        :grant      => :ibm_apikey,
-        :api_key    => api_key
+        :base_url       => storage_endpoint,
+        :not_auth_codes => ['401','403'], # error codes when not authorized
+        :headers        => {'ibm-service-instance-id' => instance_id},
+        :auth           => {
+        :type      => :oauth2,
+        :base_url  => @auth_url,
+        :grant     => :ibm_apikey,
+        :api_key   => @api_key
         }})
       # read FASP connection information for bucket
       xml_result_text=s3_api.call({:operation=>'GET',:subpath=>bucket_name,:headers=>{'Accept'=>'application/xml'},:url_params=>{'faspConnectionInfo'=>nil}})[:http].body
       ats_info=XmlSimple.xml_in(xml_result_text, {'ForceArray' => false})
       Aspera::Log.dump('ats_info',ats_info)
-      # get delegated token
-      delegated_oauth=Oauth.new({
-        :type       => :oauth2,
-        :base_url   => auth_url,
-        :grant      => :delegated_refresh,
-        :api_key    => api_key,
-        :token_field=> 'delegated_refresh_token'
-      })
-      # to be placed in rest call header and in transfer tags
-      aspera_storage_credentials={
-        'type'  => 'token',
-        'token' => {'delegated_refresh_token'=>delegated_oauth.get_authorization().gsub(/^Bearer /,'')}
-      }
-      # transfer spec addition
-      @add_ts={'tags'=>{'aspera'=>{'node'=>{'storage_credentials'=>aspera_storage_credentials}}}}
-      # set a general addon to transfer spec
-      # here we choose to use the add_request_param
-      #self.transfer.option_transfer_spec_deep_merge(@add_ts)
       super({
         :base_url => ats_info['ATSEndpoint'],
-        :headers  => {'X-Aspera-Storage-Credentials'=>JSON.generate(aspera_storage_credentials)},
         :auth     => {
         :type     => :basic,
         :username => ats_info['AccessKey']['Id'],
         :password => ats_info['AccessKey']['Secret']}})
+      # prepare transfer spec addition
+      @add_ts={'tags'=>{'aspera'=>{'node'=>{'storage_credentials'=>{
+        'type'  => 'token',
+        'token' => {'delegated_refresh_token'=>nil}
+        }}}}}
+      generate_token
+    end
+
+    # potentially call this if delegated token is expired
+    def generate_token
+      # OAuth API to get delegated token
+      delegated_oauth=Oauth.new({
+        :type       => :oauth2,
+        :base_url   => @auth_url,
+        :grant      => :delegated_refresh,
+        :api_key    => @api_key,
+        :token_field=> 'delegated_refresh_token'
+      })
+      # get delagated token to be placed in rest call header and in transfer tags
+      @add_ts['tags']['aspera']['node']['storage_credentials']['token']['delegated_refresh_token']=delegated_oauth.get_authorization().gsub(/^Bearer /,'')
+      @params[:headers]={'X-Aspera-Storage-Credentials'=>JSON.generate(@add_ts['tags']['aspera']['node']['storage_credentials'])}
     end
   end
 end

data/lib/aspera/environment.rb

@@ -2,7 +2,7 @@ require 'aspera/log'
 require 'rbconfig'
 
 module Aspera
-  # a simple binary data repository
+  # detect OS, architecture, and OS specific stuff
   class Environment
     OS_WINDOWS = :windows
     OS_X = :osx
@@ -53,7 +53,7 @@ module Aspera
       return ''
     end
 
-    # on Windows, the env var %USERPROFILE% provides the path to user's home more reliably then %HOMEDRIVE%%HOMEPATH%
+    # on Windows, the env var %USERPROFILE% provides the path to user's home more reliably than %HOMEDRIVE%%HOMEPATH%
     def self.fix_home
       if os.eql?(OS_WINDOWS)
         if ENV.has_key?('USERPROFILE') and Dir.exist?(ENV['USERPROFILE'])

data/lib/aspera/fasp/connect.rb

@@ -12,7 +12,9 @@ module Aspera
       private_constant :MAX_CONNECT_START_RETRY,:SLEEP_SEC_BETWEEN_RETRY
       def initialize
         super
-        @connect_app_id=SecureRandom.uuid
+        @connect_settings={
+          'app_id' => SecureRandom.uuid
+        }
         # TODO: start here and create monitor
       end
 
@@ -32,46 +34,51 @@ module Aspera
             OpenApplication.uri_graphical('https://downloads.asperasoft.com/connect2/')
             raise StandardError,'Connect is not installed'
           end
-          sleep SLEEP_SEC_BETWEEN_RETRY
+          sleep(SLEEP_SEC_BETWEEN_RETRY)
           retry
         end
         if transfer_spec['direction'] == 'send'
           Log.log.warn("Connect requires upload selection using GUI, ignoring #{transfer_spec['paths']}".red)
           transfer_spec.delete('paths')
-          resdata=@connect_api.create('windows/select-open-file-dialog/',{'title'=>'Select Files','suggestedName'=>'','allowMultipleSelection'=>true,'allowedFileTypes'=>'','aspera_connect_settings'=>{'app_id'=>@connect_app_id}})[:data]
+          resdata=@connect_api.create('windows/select-open-file-dialog/',{'aspera_connect_settings'=>@connect_settings,'title'=>'Select Files','suggestedName'=>'','allowMultipleSelection'=>true,'allowedFileTypes'=>''})[:data]
           transfer_spec['paths']=resdata['dataTransfer']['files'].map { |i| {'source'=>i['name']}}
         end
         @request_id=SecureRandom.uuid
         # if there is a token, we ask connect client to use well known ssh private keys
         # instead of asking password
         transfer_spec['authentication']='token' if transfer_spec.has_key?('token')
+        connect_settings=
         connect_transfer_args={
-          'transfer_specs'=>[{
-          'transfer_spec'=>transfer_spec,
-          'aspera_connect_settings'=>{
-          'allow_dialogs'=>true,
-          'app_id'=>@connect_app_id,
-          'request_id'=>@request_id
-          }}]}
+          'aspera_connect_settings'=>@connect_settings.merge({
+          'request_id'               =>@request_id,
+          'allow_dialogs'            =>true,
+          }),
+          'transfer_specs'         =>[{
+          'transfer_spec'            =>transfer_spec,
+          }]}
         # asynchronous anyway
-        @connect_api.create('transfers/start',connect_transfer_args)
+        res=@connect_api.create('transfers/start',connect_transfer_args)[:data]
+        @xfer_id=res['transfer_specs'].first['transfer_spec']['tags']['aspera']['xfer_id']
       end
 
       def wait_for_transfers_completion
-        connect_activity_args={'aspera_connect_settings'=>{'app_id'=>@connect_app_id}}
+        connect_activity_args={'aspera_connect_settings'=>@connect_settings}
         started=false
         spinner=nil
         loop do
-          result=@connect_api.create('transfers/activity',connect_activity_args)[:data]
-          if result['transfers']
-            trdata=result['transfers'].select{|i| i['aspera_connect_settings'] and i['aspera_connect_settings']['request_id'].eql?(@request_id)}.first
-            raise 'problem with connect, please kill it' unless trdata
+          tr_info=@connect_api.create("transfers/info/#{@xfer_id}",connect_activity_args)[:data]
+          if tr_info['transfer_info'].is_a?(Hash)
+            trdata=tr_info['transfer_info']
+            if trdata.nil?
+              Log.log.warn("no session in Connect")
+              break
+            end
             # TODO: get session id
             case trdata['status']
             when 'completed'
-              notify_listeners('emulated',{Manager::LISTENER_SESSION_ID_B=>@connect_app_id,'Type'=>'DONE'})
+              notify_end(@connect_settings['app_id'])
               break
-            when 'initiating'
+            when 'initiating','queued'
               if spinner.nil?
                 spinner = TTY::Spinner.new('[:spinner] :title', format: :classic)
                 spinner.start
@@ -81,13 +88,13 @@ module Aspera
             when 'running'
               #puts "running: sessions:#{trdata['sessions'].length}, #{trdata['sessions'].map{|i| i['bytes_transferred']}.join(',')}"
               if !started and trdata['bytes_expected'] != 0
-                notify_listeners('emulated',{Manager::LISTENER_SESSION_ID_B=>@connect_app_id,'Type'=>'NOTIFICATION','PreTransferBytes'=>trdata['bytes_expected']})
+                notify_begin(@connect_settings['app_id'],trdata['bytes_expected'])
                 started=true
               else
-                notify_listeners('emulated',{Manager::LISTENER_SESSION_ID_B=>@connect_app_id,'Type'=>'STATS','Bytescont'=>trdata['bytes_written']})
+                notify_progress(@connect_settings['app_id'],trdata['bytes_written'])
               end
             else
-              raise Fasp::Error.new("#{trdata['status']}: #{trdata['error_desc']}")
+              raise Fasp::Error.new("unknown status: #{trdata['status']}: #{trdata['error_desc']}")
             end
           end
           sleep 1

data/lib/aspera/fasp/http_gw.rb

@@ -2,12 +2,147 @@
 require 'aspera/fasp/manager'
 require 'aspera/log'
 require 'aspera/rest'
+require 'websocket-client-simple'
+require 'securerandom'
+require 'openssl'
+require 'base64'
+require 'json'
+require 'uri'
 
 # ref: https://api.ibm.com/explorer/catalog/aspera/product/ibm-aspera/api/http-gateway-api/doc/guides-toc
 module Aspera
   module Fasp
     # executes a local "ascp", connects mgt port, equivalent of "Fasp Manager"
     class HttpGW < Manager
+      # message returned by HTTP GW in case of success
+      OK_MESSAGE='end upload'
+      # refresh rate for progress
+      UPLOAD_REFRESH_SEC=0.5
+      private_constant :OK_MESSAGE,:UPLOAD_REFRESH_SEC
+      # send message on http gw web socket
+      def ws_send(ws,type,data)
+        ws.send(JSON.generate({type => data}))
+      end
+
+      def upload(transfer_spec)
+        # precalculate size
+        total_size=0
+        # currently, files are sent flat
+        source_path=[]
+        transfer_spec['paths'].each do |item|
+          filepath=item['source']
+          item['source']=item['destination']=File.basename(filepath)
+          total_size+=item['file_size']=File.size(filepath)
+          source_path.push(filepath)
+        end
+        session_id=SecureRandom.uuid
+        ws=::WebSocket::Client::Simple::Client.new
+        error=nil
+        received=0
+        ws.on :message do |msg|
+          Log.log.info("ws: message: #{msg.data}")
+          message=msg.data
+          if message.eql?(OK_MESSAGE)
+            received+=1
+          else
+            message.chomp!
+            if message[0].eql?('"') and message[-1].eql?('"')
+              error=JSON.parse(Base64.strict_decode64(message.chomp[1..-2]))['message']
+            else
+              error="expecting quotes in [#{message}]"
+            end
+          end
+        end
+        ws.on :error do |e|
+          error=e
+        end
+        ws.on :open do
+          Log.log.info("ws: open")
+        end
+        ws.on :close do
+          Log.log.info("ws: close")
+        end
+        # open web socket to end point
+        ws.connect("#{@gw_api.params[:base_url]}/upload")
+        while !ws.open? and error.nil? do
+          Log.log.info("ws: wait")
+          sleep(0.2)
+        end
+        notify_begin(session_id,total_size)
+        ws_send(ws,:transfer_spec,transfer_spec)
+        # current file index
+        filenum=0
+        # aggregate size sent
+        sent_bytes=0
+        # last progress event
+        lastevent=Time.now-1
+        transfer_spec['paths'].each do |item|
+          # TODO: on destination write same path?
+          destination_path=item['source']
+          # TODO: get mime type?
+          file_mime_type=''
+          total=item['file_size']
+          # compute total number of slices
+          numslices=1+(total-1)/@upload_chunksize
+          # current slice index
+          slicenum=0
+          File.open(source_path[filenum]) do |file|
+            while !file.eof? do
+              data=file.read(@upload_chunksize)
+              slice_data={
+                name: destination_path,
+                type: file_mime_type,
+                size: total,
+                data: Base64.strict_encode64(data),
+                slice: slicenum,
+                total_slices: numslices,
+                fileIndex: filenum
+              }
+              ws_send(ws,:slice_upload, slice_data)
+              sent_bytes+=data.length
+              currenttime=Time.now
+              if (currenttime-lastevent)>UPLOAD_REFRESH_SEC
+                notify_progress(session_id,sent_bytes)
+                lastevent=currenttime
+              end
+              slicenum+=1
+              raise error unless error.nil?
+            end
+          end
+          filenum+=1
+        end
+        ws.close
+        notify_end(session_id)
+      end
+
+      def download(transfer_spec)
+        transfer_spec['zip_required']||=false
+        transfer_spec['source_root']||='/'
+        # is normally provided by application, like package name
+        if !transfer_spec.has_key?('download_name')
+          # by default it is the name of first file
+          dname=File.basename(transfer_spec['paths'].first['source'])
+          # we remove extension
+          dname=dname.gsub(/\.@gw_api.*$/,'')
+          # ands add indication of number of files if there is more than one
+          if transfer_spec['paths'].length > 1
+            dname=dname+" #{transfer_spec['paths'].length} Files"
+          end
+          transfer_spec['download_name']=dname
+        end
+        creation=@gw_api.create('download',{'transfer_spec'=>transfer_spec})[:data]
+        transfer_uuid=creation['url'].split('/').last
+        if transfer_spec['zip_required'] or transfer_spec['paths'].length > 1
+          # it is a zip file if zip is required or there is more than 1 file
+          file_dest=transfer_spec['download_name']+'.zip'
+        else
+          # it is a plain file if we don't require zip and there is only one file
+          file_dest=File.basename(transfer_spec['paths'].first['source'])
+        end
+        file_dest=File.join(transfer_spec['destination_root'],file_dest)
+        @gw_api.call({:operation=>'GET',:subpath=>"download/#{transfer_uuid}",:save_to_file=>file_dest})
+      end
+
       # start FASP transfer based on transfer spec (hash table)
       # note that it is asynchronous
       # HTTP download only supports file list
@@ -15,37 +150,13 @@ module Aspera
         raise "GW URL must be set" unless !@gw_api.nil?
         raise "option: must be hash (or nil)" unless options.is_a?(Hash)
         raise "paths: must be Array" unless transfer_spec['paths'].is_a?(Array)
+        raise "on token based transfer is supported in GW" unless transfer_spec['token'].is_a?(String)
+        transfer_spec['authentication']||='token'
         case transfer_spec['direction']
         when 'send'
-          # this is a websocket
-          raise "error, not implemented"
+          upload(transfer_spec)
         when 'receive'
-          transfer_spec['zip_required']||=false
-          transfer_spec['authentication']||='token'
-          transfer_spec['source_root']||='/'
-          # is normally provided by application, like package name
-          if !transfer_spec.has_key?('download_name')
-            # by default it is the name of first file
-            dname=File.basename(transfer_spec['paths'].first['source'])
-            # we remove extension
-            dname=dname.gsub(/\.@gw_api.*$/,'')
-            # ands add indication of number of files if there is more than one
-            if transfer_spec['paths'].length > 1
-              dname=dname+" #{transfer_spec['paths'].length} Files"
-            end
-            transfer_spec['download_name']=dname
-          end
-          creation=@gw_api.create('download',{'transfer_spec'=>transfer_spec})[:data]
-          transfer_uuid=creation['url'].split('/').last
-          if transfer_spec['zip_required'] or transfer_spec['paths'].length > 1
-            # it is a zip file if zip is required or there is more than 1 file
-            file_dest=transfer_spec['download_name']+'.zip'
-          else
-            # it is a plain file if we don't require zip and there is only one file
-            file_dest=File.basename(transfer_spec['paths'].first['source'])
-          end
-          file_dest=File.join(transfer_spec['destination_root'],file_dest)
-          @gw_api.call({:operation=>'GET',:subpath=>"download/#{transfer_uuid}",:save_to_file=>file_dest})
+          download(transfer_spec)
         else
           raise "error"
         end
@@ -74,6 +185,7 @@ module Aspera
         @gw_api=Rest.new({:base_url => params[:url]})
         api_info = @gw_api.read('info')[:data]
         Log.log.info("#{api_info}")
+        @upload_chunksize=128000 # TODO: configurable ?
       end
 
     end # LocalHttp