aspector 0.10.0 → 0.10.1

data/VERSION

@@ -1 +1 @@
-0.10.0
+0.10.1

data/aspector.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "aspector"
-  s.version = "0.10.0"
+  s.version = "0.10.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Guoliang Cao"]
-  s.date = "2012-03-19"
+  s.date = "2012-03-20"
   s.description = ""
   s.email = "gcao99@gmail.com"
   s.extra_rdoc_files = [
@@ -35,6 +35,7 @@ Gem::Specification.new do |s|
     "examples/aspector_example.rb",
     "examples/cache_aspect.rb",
     "examples/exception_handler.rb",
+    "examples/implicit_method_option_test.rb",
     "examples/logging_aspect.rb",
     "examples/retry_aspect.rb",
     "lib/aspector.rb",

data/examples/implicit_method_option_test.rb

@@ -0,0 +1,31 @@
+class A
+  def test
+    puts 'test'
+  end
+end
+
+##############################
+
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+
+require 'aspector'
+
+class ImplicitMethodOptionTest < Aspector::Base
+  # Apply advice to options[:method] and options[:methods] if no target method is given
+  # before options[:method], options[:methods] do
+  before do
+    puts 'before'
+  end
+end
+
+# ImplicitMethodOptionTest.apply A, :method => 'test'
+ImplicitMethodOptionTest.apply "A#test"
+
+##############################
+
+A.new.test
+
+# Expected output:
+# before
+# test
+

data/lib/aspector/base.rb

@@ -155,7 +155,7 @@ module Aspector
     end
 
     def aop_get_context
-      return @aop_target if @aop_target.is_a?(Module) and not @aop_options[:eigen_class]
+      return @aop_target if @aop_target.is_a?(Module) and not @aop_options[:class_methods]
 
       class << @aop_target
         self
@@ -189,7 +189,7 @@ module Aspector
     end
 
     def aop_add_method_hooks
-      if @aop_options[:eigen_class]
+      if @aop_options[:class_methods]
         return unless @aop_target.is_a?(Module)
 
         eigen_class = class << @aop_target; self; end

data/lib/aspector/base_class_methods.rb

@@ -31,6 +31,19 @@ module Aspector
       alias :default_options :aop_default_options
 
       def aop_apply target, options = {}
+        # Handle 'Klass#method' and 'Klass.method' shortcut
+        if target.is_a? String
+          if target.index('.')
+            target, method = target.split('.')
+            target = Object.const_get target
+            options.merge! :method => method, :class_methods => true
+          else
+            target, method = target.split('#')
+            target = Object.const_get target
+            options.merge! :method => method
+          end
+        end
+
         aspect_instance = new(target, options)
         aspect_instance.send :aop_apply
         aspect_instance
@@ -100,6 +113,8 @@ module Aspector
 
         with_method = methods.pop unless block_given?
 
+        methods << aop_options[:method] << aop_options[:methods] if methods.empty?
+
         Aspector::Advice.new(self,
                              meta_data.advice_type,
                              Aspector::MethodMatcher.new(*methods),

data/spec/functional/aspect_on_eigen_class_spec.rb

@@ -14,7 +14,7 @@ describe "Aspector for eigen class" do
       end
     end
 
-    aspector(klass, :eigen_class => true) do
+    aspector(klass, :class_methods => true) do
       before :test do value << "do_before" end
 
       after  :test do |result|
@@ -43,7 +43,7 @@ describe "Aspector for eigen class" do
       end
     end
 
-    aspector(klass, :eigen_class => true) do
+    aspector(klass, :class_methods => true) do
       before :test do value << "do_before" end
 
       after  :test do |result|

data/spec/unit/before_spec.rb

@@ -77,5 +77,57 @@ describe "Before advices" do
     obj.value.should == %w"do_this(test) test"
   end
 
+  it "implicit method option" do
+    ImplicitMethodOptionTest = create_test_class do
+      def do_this
+        value << "do_this"
+      end
+    end
+
+    aspector "ImplicitMethodOptionTest#test" do
+      before :do_this
+    end
+
+    o = ImplicitMethodOptionTest.new
+    o.test
+    o.value.should == %w"do_this test"
+  end
+
+  it "implicit methods option" do
+    klass = create_test_class do
+      def do_this
+        value << "do_this"
+      end
+    end
+
+    aspector klass, :methods => [:test] do
+      before :do_this
+    end
+
+    o = ImplicitMethodOptionTest.new
+    o.test
+    o.value.should == %w"do_this test"
+  end
+
+  it "klass.method shortcut" do
+    module KlassMethodTest
+      def self.value
+        @value ||= []
+      end
+
+      def self.test
+        value << "test"
+      end
+    end
+
+    aspector "KlassMethodTest.test" do
+      before do
+        value << "before"
+      end
+    end
+
+    KlassMethodTest.test.should == %w"before test"
+  end
+
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aspector
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-19 00:00:00.000000000 Z
+date: 2012-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -213,6 +213,7 @@ files:
 - examples/aspector_example.rb
 - examples/cache_aspect.rb
 - examples/exception_handler.rb
+- examples/implicit_method_option_test.rb
 - examples/logging_aspect.rb
 - examples/retry_aspect.rb
 - lib/aspector.rb
@@ -263,7 +264,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2602659987837807092
+      hash: 3014402332352836990
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: