aspecto-opentelemetry 0.1.7 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 170a65edd49c074b4b4f4b6c387fca2fd09783966e134b595b7d8bc2f05d79f0
-  data.tar.gz: dafa464e48a08da3aaf868059843852db9974d7d8eda765356d2c91f631c081b
+  metadata.gz: a0943b7b3f5688ebe24ae7f8bb45836d082697786ba1ea649e0ed947836f13d2
+  data.tar.gz: f9572d70ddeb8419648e78a2edf3b90094e2bb6658701556b01ed5a353b18f3f
 SHA512:
-  metadata.gz: f4730136d9f1f4e1ca13003cbe9ce0eb4f70b66802526c119b99343697e115c3bd7d1fee92005bf03e0010260d35c0a9e07bbdd9fc7a43a1126904a619f48023
-  data.tar.gz: f11b3ff7ab8da4f02b343d49bf8bf49ee79c341dd6170680e64a4d6346e2be57d530e911ed5a2f3ab1b656b8cf06246ed1586d99373a83984f5a0577ade17278
+  metadata.gz: 2181743694a6cefbde9138ddbf3dfbcb57a0b95787cf2cbda35f418d05bf6755a40f495bba32a22a0f5184fa83ef3789a63617b1d6eaadf0dcff36623c0a99ec
+  data.tar.gz: 9c6d4cfe66c894c6c9a82c04080d8e9653502c9bf97b82149a30522f82c1e5f5f7b2621257cbf7481baa19d776e499663df17d28bb8007940582da0bb716d909

data/README.md

@@ -19,8 +19,6 @@ Or, if you use [bundler](https://bundler.io), include aspecto-opentelemetry in y
 
 ### Rails Applications
 
-#### Configuration in Code
-
 Add this code to a new file `aspecto.rb` under `config/initializers/`:
 
 ```rb
@@ -34,26 +32,8 @@ Aspecto::OpenTelemetry::configure do |c|
 end
 ```
 
-#### Configuration via Environment Variables
-
-In your Gemfile:
-
-```
-gem 'aspecto-opentelemetry', require: 'aspecto/auto_instrument'
-```
-
-And set environment variables:
-
-```
-OTEL_SERVICE_NAME=<YOUR_SERVICE_NAME>
-ASPECTO_AUTH=<YOUR_ASPECTO_TOKEN>
-# ASPECTO_SAMPLING_RATIO=1.0 # [optional]: defaults to 1.0, use aspecto app to configure remotely
-```
-
 ### Ruby Applications
 
-#### Configuration in Code
-
 Add this code after your require other gems:
 
 ```rb
@@ -67,23 +47,6 @@ Aspecto::OpenTelemetry::configure do |c|
 end
 ```
 
-#### Configuration via Environment Variables
-
-Add this require statement after your require other gems:
-
-```rb
-require 'aspecto/auto_instrument'
-```
-
-And set environment variables:
-
-```
-OTEL_SERVICE_NAME=<YOUR_SERVICE_NAME>
-ASPECTO_AUTH=<YOUR_ASPECTO_TOKEN>
-# ASPECTO_ENV=<CURRENT_ENVIRONMENT> # [optional]: automatically detected for rails and sinatra
-# ASPECTO_SAMPLING_RATIO=1.0 # [optional]: defaults to 1.0, use aspecto app to configure remotely
-```
-
 ### Shutdown
 
 Call this function when your application shuts down

data/RELEASE.md

@@ -0,0 +1,4 @@
+# Release steps
+1. Increment VERSION in [`version.rb`](./lib/aspecto/opentelemetry/version.rb)
+1. Create and merge Pull Request into `master`
+1. Run `Publish` Github action on `master` branch 🚀

data/lib/aspecto/opentelemetry/config/remote_config.rb

@@ -16,6 +16,8 @@ module Aspecto
         def initialize(aspecto_auth, service_name, env, fallback_sampler)
           @service_name = service_name
           @env = env
+          @error_reported = false
+          @got_remote_config = false
           @fallback_sampler = fallback_sampler
           aspecto_config_host = ENV.fetch("ASPECTO_CONFIG_HOST", "https://config.aspecto.io")
           @aspecto_config_url = URI("#{aspecto_config_host}/config/#{aspecto_auth}")
@@ -27,7 +29,10 @@ module Aspecto
             update_config
           end
 
-          ::OpenTelemetry.logger.info "[Aspecto] SDK client initialized"
+          ::OpenTelemetry.logger.info "[Aspecto] initialized remote config polling"
+        rescue StandardError => e
+          ::OpenTelemetry.logger.error "[Aspecto] failed to initialize remote config polling"
+          ::OpenTelemetry.logger.error e
         end
 
         def shutdown
@@ -50,7 +55,7 @@ module Aspecto
           @http_client.verify_mode = OpenSSL::SSL::VERIFY_PEER
         end
 
-        def update_config # rubocop:disable Metrics/AbcSize
+        def update_config
           ::OpenTelemetry::Common::Utilities.untraced do
             request = Net::HTTP::Get.new(@aspecto_config_url.path)
             request["If-None-Match"] = @latest_config_etag unless @latest_config_etag.nil?
@@ -60,7 +65,7 @@ module Aspecto
             return if response_code == 304
 
             if response_code >= 400
-              ::OpenTelemetry.logger.error("[Aspecto] error when trying to get remote config. will try again in #{@remote_config_poll_frequency}")
+              log_config_error "failed to get remote config with http response #{response_code}."
               return
             end
 
@@ -68,13 +73,14 @@ module Aspecto
             handle_new_config JSON.parse(response.body) if response_code < 300
           end
         rescue StandardError => e
-          ::OpenTelemetry.logger.error "[Aspecto] updating remote config failed. using previous remote config"
-          ::OpenTelemetry.logger.debug e
+          log_config_error "updating remote config failed with exception.", e
         end
 
         def handle_new_config(config)
-          ::OpenTelemetry.logger.info("[Aspecto] successfully received remote configuration")
           update_sampler config["samplingRules"]
+          @error_reported = false
+          @got_remote_config = true
+          ::OpenTelemetry.logger.info("[Aspecto] successfully updated remote configuration")
         end
 
         def update_sampler(sampler_config)
@@ -84,6 +90,16 @@ module Aspecto
           # updating the sampler should be thread safe as it's an atomic setter on a global value
           ::OpenTelemetry.tracer_provider.sampler = message_process_sampler
         end
+
+        def log_config_error(msg, err = nil)
+          return if @error_reported # report every issue only once
+
+          retry_msg = "will try again until success every #{@remote_config_poll_frequency}."
+          previous_config_msg = @got_remote_config ? "using previous remote config" : "no previous config is avialable"
+          ::OpenTelemetry.logger.info("[Aspecto]: #{msg} #{retry_msg} #{previous_config_msg}")
+          ::OpenTelemetry.logger.info(err) if err
+          @error_reported = true
+        end
       end
     end
   end

data/lib/aspecto/opentelemetry/sampler/message_process_sampler.rb

@@ -29,7 +29,7 @@ module Aspecto
         private
 
         def should_sample_processing(parent_context, links, name, attributes)
-          return if links.length.zero?
+          return if !links || links.length.zero?
 
           decision = link_decision(links[0])
 

data/lib/aspecto/opentelemetry/version.rb

@@ -2,6 +2,6 @@
 
 module Aspecto
   module OpenTelemetry
-    VERSION = "0.1.7"
+    VERSION = "0.1.10"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aspecto-opentelemetry
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.10
 platform: ruby
 authors:
 - Aspecto
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-01-03 00:00:00.000000000 Z
+date: 2022-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aspecto-opentelemetry-instrumentation-aws_sdk
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.8
+        version: 0.4.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.8
+        version: 0.4.5
 - !ruby/object:Gem::Dependency
   name: opentelemetry-exporter-otlp
   requirement: !ruby/object:Gem::Requirement
@@ -190,6 +190,7 @@ files:
 - Gemfile
 - LICENSE
 - README.md
+- RELEASE.md
 - Rakefile
 - lib/aspecto/auto_instrument.rb
 - lib/aspecto/opentelemetry.rb