aslakhellesoy-cucumber 0.3.0 → 0.3.0.1

data/spec/cucumber/parser/feature_parser_spec.rb

@@ -48,6 +48,14 @@ Feature: hi
           [:feature, nil, "", 
             [:comment, "# Hello\n\n# World\n"]]
         end
+        
+        it "should not consume comments as part of a multiline name" do
+          parse("Feature: hi\n Scenario: test\n\n#hello\n Scenario: another").to_sexp.should ==
+            [:feature, nil, "Feature: hi", 
+             [:scenario, 2, "Scenario:", "test"], 
+             [:scenario, 5, "Scenario:", "another", 
+              [:comment, "#hello\n "]]]
+        end
       end
 
       describe "Tags" do
@@ -59,6 +67,14 @@ Feature: hi
             [:tag, "world"]]
         end
 
+        it "should not take the tags as part of a multiline name feature element" do
+          parse("Feature: hi\n Scenario: test\n\n@hello Scenario: another").to_sexp.should ==
+          [:feature, nil, "Feature: hi",
+           [:scenario, 2, "Scenario:", "test"], 
+           [:scenario, 4, "Scenario:", "another", 
+             [:tag, "hello"]]]
+        end
+
         it "should parse a file with tags on a scenario" do
           parse(%{# FC
   @ft
@@ -90,6 +106,18 @@ Feature: hi
             [:background, 2, "Background:",
               [:step, 3, "Given", "I am a step"]]]
         end
+        
+        it "should allow multiline names" do
+          parse(%{Feature: Hi
+Background: It is my ambition to say 
+            in ten sentences
+            what others say 
+            in a whole book.
+Given I am a step}).to_sexp.should ==
+          [:feature, nil, "Feature: Hi",
+            [:background, 2, "Background:", "It is my ambition to say\nin ten sentences\nwhat others say\nin a whole book.",
+              [:step, 6, "Given", "I am a step"]]]
+        end
       end
 
       describe "Scenarios" do
@@ -146,6 +174,21 @@ Given I have a string
               [:step_invocation, 3, "Given", "I have a string",
                 [:py_string, "hello\nworld"]]]]
         end
+        
+        it "should allow multiline names" do
+          parse(%{Feature: Hi
+Scenario: It is my ambition to say 
+          in ten sentences
+          what others say 
+          in a whole book.
+Given I am a step
+
+}).to_sexp.should ==
+          [:feature, nil, "Feature: Hi",
+            [:scenario, 2, "Scenario:", "It is my ambition to say\nin ten sentences\nwhat others say\nin a whole book.",
+              [:step_invocation, 6, "Given", "I am a step"]]]
+        end
+        
       end
 
       describe "Scenario Outlines" do
@@ -225,6 +268,42 @@ Examples:
                     [:cell, "5"],
                     [:cell, "6"]]]]]]
         end
+
+        it "should allow multiline names" do
+          parse(%{Feature: Hi
+Scenario Outline: It is my ambition to say 
+          in ten sentences
+          what others say 
+          in a whole book.
+Given I am a step
+
+}).to_sexp.should ==
+          [:feature, nil, "Feature: Hi",
+            [:scenario_outline, "Scenario Outline:", "It is my ambition to say\nin ten sentences\nwhat others say\nin a whole book.",
+              [:step, 6, "Given", "I am a step"]]]
+        end
+        
+        it "should allow Examples to have multiline names" do
+          parse(%{Feature: Hi
+Scenario Outline: name
+Given I am a step
+
+Examples: I'm a multiline name
+          and I'm ok
+|x|
+|5|
+
+}).to_sexp.should ==
+          [:feature, nil, "Feature: Hi",
+            [:scenario_outline, "Scenario Outline:", "name",
+              [:step, 3, "Given", "I am a step"],
+              [:examples, "Examples:", "I'm a multiline name\nand I'm ok",
+                [:table,
+                  [:row, 7,
+                    [:cell, "x"]],
+                  [:row, 8,
+                    [:cell, "5"]]]]]]
+        end
       end
 
       describe "Syntax" do

data/spec/cucumber/step_mother_spec.rb

@@ -86,16 +86,22 @@ spec/cucumber/step_mother_spec.rb:40:in `/Three cute (.*)/'
       end.should raise_error(Redundant)
     end
 
+    # http://railsforum.com/viewtopic.php?pid=93881
+    it "should not raise Redundant unless it's really redundant" do
+      @step_mother.Given(/^(.*) (.*) user named '(.*)'$/) {|a,b,c|}
+      @step_mother.Given(/^there is no (.*) user named '(.*)'$/) {|a,b|}
+    end
+
     it "should raise an error if the world is nil" do
       @step_mother.World do
       end
 
       begin
-        @step_mother.before_and_after(nil)
+        @step_mother.before_and_after(nil) {}
         raise "Should fail"
       rescue NilWorld => e
         e.message.should == "World procs should never return nil"
-        e.backtrace.should == ["spec/cucumber/step_mother_spec.rb:90:in `World'"]
+        e.backtrace.should == ["spec/cucumber/step_mother_spec.rb:96:in `World'"]
       end
     end
 
@@ -126,10 +132,11 @@ spec/cucumber/step_mother_spec.rb:40:in `/Three cute (.*)/'
       end.should raise_error(MultipleWorld, %{You can only pass a proc to #World once, but it's happening
 in 2 places:
 
-spec/cucumber/step_mother_spec.rb:123:in `World'
-spec/cucumber/step_mother_spec.rb:125:in `World'
+spec/cucumber/step_mother_spec.rb:129:in `World'
+spec/cucumber/step_mother_spec.rb:131:in `World'
 
-Use Ruby modules instead to extend your worlds. See the #World RDoc.
+Use Ruby modules instead to extend your worlds. See the Cucumber::StepMother#World RDoc
+or http://wiki.github.com/aslakhellesoy/cucumber/a-whole-new-world.
 
 })
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: aslakhellesoy-cucumber
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.3.0.1
 platform: ruby
 authors: 
 - "Aslak Helles\xC3\xB8y"
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-14 00:00:00 -07:00
+date: 2009-04-26 00:00:00 -07:00
 default_executable: cucumber
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -62,16 +62,6 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 2.1.2
     version: 
-- !ruby/object:Gem::Dependency 
-  name: hoe
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: 1.11.0
-    version: 
 description: Executable Feature scenarios
 email: 
 - aslak.hellesoy@gmail.com
@@ -154,6 +144,11 @@ files:
 - examples/i18n/fr/features/addition.feature
 - examples/i18n/fr/features/step_definitions/calculatrice_steps.rb
 - examples/i18n/fr/lib/calculatrice.rb
+- examples/i18n/hu/Rakefile
+- examples/i18n/hu/features/addition.feature
+- examples/i18n/hu/features/division.feature
+- examples/i18n/hu/features/step_definitons/calculator_steps.rb
+- examples/i18n/hu/lib/calculator.rb
 - examples/i18n/id/Rakefile
 - examples/i18n/id/features/addition.feature
 - examples/i18n/id/features/division.feature
@@ -178,6 +173,11 @@ files:
 - examples/i18n/lt/features/division.feature
 - examples/i18n/lt/features/step_definitons/calculator_steps.rb
 - examples/i18n/lt/lib/calculator.rb
+- examples/i18n/lv/Rakefile
+- examples/i18n/lv/features/addition.feature
+- examples/i18n/lv/features/division.feature
+- examples/i18n/lv/features/step_definitons/calculator_steps.rb
+- examples/i18n/lv/lib/calculator.rb
 - examples/i18n/no/Rakefile
 - examples/i18n/no/features/step_definitons/kalkulator_steps.rb
 - examples/i18n/no/features/summering.feature
@@ -246,6 +246,7 @@ files:
 - examples/self_test/features/call_undefined_step_from_step_def.feature
 - examples/self_test/features/failing_expectation.feature
 - examples/self_test/features/lots_of_undefined.feature
+- examples/self_test/features/multiline_name.feature
 - examples/self_test/features/outline_sample.feature
 - examples/self_test/features/sample.feature
 - examples/self_test/features/step_definitions/sample_steps.rb
@@ -277,6 +278,8 @@ files:
 - examples/tickets/features/248.feature
 - examples/tickets/features/270/back.feature
 - examples/tickets/features/270/back.steps.rb
+- examples/tickets/features/272/hooks.feature
+- examples/tickets/features/272/hooks_steps.rb
 - examples/tickets/features/279/py_string_indent.feature
 - examples/tickets/features/279/py_string_indent.steps.rb
 - examples/tickets/features/279/wrong.feature_
@@ -298,6 +301,7 @@ files:
 - features/cucumber_cli_diff_disabled.feature
 - features/cucumber_cli_outlines.feature
 - features/custom_formatter.feature
+- features/multiline_names.feature
 - features/rake_task.feature
 - features/report_called_undefined_steps.feature
 - features/snippet.feature
@@ -388,6 +392,7 @@ files:
 - rails_generators/feature/templates/feature.erb
 - rails_generators/feature/templates/steps.erb
 - spec/cucumber/ast/background_spec.rb
+- spec/cucumber/ast/feature_element_spec.rb
 - spec/cucumber/ast/feature_factory.rb
 - spec/cucumber/ast/feature_spec.rb
 - spec/cucumber/ast/py_string_spec.rb
@@ -408,7 +413,6 @@ files:
 - spec/cucumber/formatter/html/index.html
 - spec/cucumber/formatter/html/jquery-1.3.min.js
 - spec/cucumber/formatter/html/jquery.uitableedit.js
-- spec/cucumber/formatters/profile_formatter_spec.rb
 - spec/cucumber/parser/feature_parser_spec.rb
 - spec/cucumber/parser/table_parser_spec.rb
 - spec/cucumber/rails/stubs/mini_rails.rb

data/spec/cucumber/formatters/profile_formatter_spec.rb

@@ -1,198 +0,0 @@
-require File.dirname(__FILE__) + '/../../spec_helper'
-require 'cucumber/formatter/profile'
-
-module Cucumber
-  module Formatter
-    describe Progress do
-      attr_reader :io, :formatter
-
-      def mock_proc(stubs={})
-        stub(Proc, {:to_comment_line => '# steps/example_steps.rb:11'}.merge(stubs))
-      end
-
-      def mock_step(stubs={})
-        stub('step', {:keyword => 'Given',
-          :actual_keyword =>  'Given',
-          :format => 'test',
-          :row? => false,
-          :file => 'test.feature',
-          :line => 5,
-          :regexp_args_proc => [nil, nil, mock_proc]}.merge(stubs))
-      end
-
-      before(:each) do
-        ::Term::ANSIColor.coloring = false
-        @io = StringIO.new
-        step_mother = stub('step_mother')
-        @formatter = ProfileFormatter.new(step_mother, io)
-      end
-      
-      after(:each) do
-        ::Term::ANSIColor.coloring = true
-      end
-
-      xit "should print a heading" do
-        formatter.visit_features(nil)
-
-        io.string.should eql("Profiling enabled.\n")
-      end
-
-      xit "should record the current time when starting a new step" do
-        now = Time.now
-        Time.stub!(:now).and_return(now)
-        formatter.step_executing('should foo', nil, nil)
-
-        formatter.instance_variable_get("@step_time").should == now
-      end
-      
-      describe "grouping recorded passed steps" do
-
-        before(:each) do
-          now = Time.now
-          formatter.instance_variable_set("@step_time", now)
-          Time.stub!(:now).and_return(now, now)
-        end
-
-        xit "should group by regular expressions and actual keyword" do
-          step_1 = mock_step(:actual_keyword => 'Given')
-          step_2 = mock_step(:actual_keyword => 'Given')
-
-          formatter.step_passed(step_1, /nihon/, nil)
-          formatter.step_passed(step_2, /ichiban/, nil)
-
-          step_times = formatter.instance_variable_get("@step_times")
-
-          step_times.has_key?('Given /nihon/').should be_true
-          step_times.has_key?('Given /ichiban/').should be_true
-        end
-
-        xit "should use a previous step's keyword when recording row steps" do
-          step = mock_step(:actual_keyword => 'Given')
-          step_row = mock_step(:row? => true)
-
-          formatter.step_passed(step, /nihon/, [])
-          formatter.step_passed(step_row, /nihon/, [])
-
-          step_times = formatter.instance_variable_get("@step_times")
-          
-          step_times['Given /nihon/'].length.should == 2
-        end
-
-      end
-
-      xit "should correctly record a passed step" do
-        formatter.step_executing(nil, nil, nil)
-        formatter.step_passed(mock_step(:format => 'she doth teach the torches to burn bright', :actual_keyword => 'Given'), nil, nil)
-        formatter.dump
-
-        io.string.should include('Given she doth teach the torches to burn bright')
-      end
-
-      xit "should correctly record a passed step row" do
-        formatter.step_executing(nil, nil, nil)
-        formatter.step_passed(mock_step(:row? => true), /example/, ['fitty'])
-        formatter.dump
-
-        io.string.should include('fitty')
-      end
-
-      xit "should calculate the mean step execution time" do
-        now = Time.now
-        Time.stub!(:now).and_return(now, now+5, now, now+1)
-
-        2.times do
-          formatter.step_executing(mock_step, nil, nil)
-          formatter.step_passed(mock_step, nil, nil)
-        end
-
-        formatter.dump
-
-        io.string.should include('3.0000000')
-      end
-
-      xit "should display file and line comment for step invocation" do
-        step = mock_step(:format => 'test', :actual_keyword => 'Given', :file => 'test.feature', :line => 5)
-
-        formatter.step_executing(step, nil, nil)
-        formatter.step_passed(step, nil, nil)
-        formatter.dump
-
-        @io.string.should include("# test.feature:5")
-      end
-
-      xit "should display file and line comment for step definition" do
-        step = mock_step(:format => 'test', :actual_keyword => 'Given',
-                         :regexp_args_proc => [/test/, nil, mock_proc(:to_comment_line => '# steps/example_steps.rb:11')])
-
-        formatter.step_executing(step, nil, nil)
-        formatter.step_passed(step, nil, nil)
-        formatter.dump
-
-        @io.string.should include("# steps/example_steps.rb:11")
-      end
-
-      xit "should show the performance times of the step invocations for a step definition" do
-        now = Time.now
-        Time.stub!(:now).and_return(now, now+5, now, now+1)
-
-        step = mock_step(:format => 'step invocation', :actual_keyword => 'Given')
-
-        2.times do
-          formatter.step_executing(step, /example/, nil)
-          formatter.step_passed(step, /example/, nil)
-        end
-
-        formatter.dump
-
-        io.string.should include("3.0000000  Given /example/")
-        io.string.should include("5.0000000  Given step invocation")
-        io.string.should include("1.0000000  Given step invocation")
-      end
-      
-      xit "should sort the step invocations in descending order" do
-        now = Time.now
-        Time.stub!(:now).and_return(now, now+1, now, now+5)
-        
-        step = mock_step(:format => 'step invocation', :actual_keyword => 'Given')
-        
-        2.times do
-          formatter.step_executing(step, /example 1/, nil)
-          formatter.step_passed(step, /example 1/, nil)
-        end
-        
-        formatter.dump
-        io_string_lines = io.string.split("\n")
-        
-        io_string_lines.at(-2).should include('5.0000000')
-        io_string_lines.at(-1).should include('1.0000000')
-      end
-
-      xit "should print the top average 10 step results" do
-        formatter.instance_variable_set("@step_time", Time.now)
-
-        11.times do |test_number|
-          step_regexp = Regexp.new "unique_test_#{test_number}"
-          formatter.step_passed(mock_step(:format => 'test', :actual_keyword => 'Given',
-          :regexp_args_proc => [step_regexp, nil, mock_proc]), step_regexp, nil)
-        end
-
-        formatter.dump
-
-        io.string.scan(/unique_test_\d+/).length.should == 10
-      end
-
-      xit "should print the top 5 step invocations for step definition" do
-        formatter.instance_variable_set("@step_time", Time.now)
-   
-        10.times do |test_number|
-          formatter.step_passed(mock_step(:format => 'please invocate me', :actual_keyword => 'Given'), nil, nil)
-        end
-
-        formatter.dump
-
-        io.string.scan(/please invocate me/).length.should == 5
-      end
-
-    end
-  end
-end